The option -Wno-error=unused-but-set-variable is added to disable variable
'fp' set but not used in GCC. But, XCODE doesn't know this option. To make
XCODE pass build, -Wno-error=unknown-warning-option is added.
The warning unused-but-set-variable reports the code issue. It will report
to
Set macro for variable arguments, and remove the hard code definition
to avoid the potential duplicated definition.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c | 1 -
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1226
According to UEFI Spec, for ACPI Expanded Device Path,
when HIDSTR=empty, CIDSTR=empty, UID STR!=empty,
the ACPI Expanded Device Path node can be displayed as
AcpiExp(HID,CID,UIDSTR) format.
And if UID is 0 and UIDSTR is empty, then use
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1228
According to UEFI spec,for ACPI Expanded Device Path
when HID=PNP0A03 or CID=PNP0A03 and HID != PNP0A08,
the device path node can be displayed as: PciRoot(UID|UIDSTR)
When HID=PNP0A08 or CID=PNP0A08, the device path node can be
displayed
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1227
According to UEFI Spec, ACPI Expanded Device Path can be display
AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR)), but current code display
UID|UIDSTR before CID|CIDSTR.
This patch is to fix this issue.
Cc: Ruiyu Ni
Cc: Michael D Kinney
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1229
When converting DebugPort device path from text,
current code use VENDOR_DEFINED_MESSAGING_DEVICE_PATH structure
for Debug port device node.
typedef struct {
EFI_DEVICE_PATH_PROTOCOL Header;
EFI_GUID Guid;
UINT8
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225
According to UEFI spec, the string expression of UTF8 vendor
device node should be displayed as: VenUtf8(). Current code
display it as: VenUft8() by mistake when convert device
path node to text.
This commit is to fix this bug.
Cc: Ruiyu
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Monday, October 8, 2018 11:08 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Bi, Dandan ; Fu,
> Siyuan ; Wu, Jiaxin
> Subject: [edk2] [Patch]
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, October 8, 2018 11:03 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Fu, Siyuan
> ; Ye, Ting ; Bi, Dandan
> ; Wu, Jiaxin
> Subject: [Patch 0/2] Correct comments to align with the input parameter.
>
Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Monday, October 08, 2018 9:29 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Zeng, Star
>Subject: [patch] MdeModulePkg/HiiDB: Fix incorrect structure convention for
>checkbox
>
>REF:
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, October 2, 2018 6:14 PM
> To: Ni, Ruiyu ; Zhang, Chao B
> Cc: Zhang, Shenglei ; edk2-devel@lists.01.org;
> Kinney, Michael D
> Subject: Re: [edk2] [PATCH v3 00/16] Removed unused PCDs
>
> Ray, Chao,
>
> guys, you keep breaking
Laszlo:
We meet with this failure in GCC4.8 and GCC4.9, but not in GCC5. We don't
verify earlier version than GCC4.8.
GCC48 is the specific tool chain for GCC4.8. But, GCC49 is the general tool
chain that can be used with GCC4.9 or the above GCC version for LTO disable.
So, even if we
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Bi Dandan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
---
MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Bi Dandan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
---
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.c | 11 ++-
NetworkPkg/UefiPxeBcDxe/PxeBcMtftp.h | 5 -
2
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Carsey Jaben
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Bi Dandan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
---
ShellPkg/DynamicCommand/TftpDynamicCommand/Tftp.c | 2 ++
1 file changed, 2 insertions(+)
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1230
Cc: Carsey Jaben
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Bi Dandan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Jiaxin Wu (2):
NetworkPkg/UefiPxeBcDxe: Correct comments to align with the input
Hi all,
Sorry for that. Ray and Chao just helped me push the patches. It's my fault
about the mistake.
I'll prepare patches more carefully next time and make sure all things correct.
Best Regards,
Shenglei
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent:
Pilar:
The change is good. Could you also update INF and FDF spec for this usage? If
you don't know how to update INF and FDF spec, please submit BZ. I will provide
the spec patch.
Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: edk2-devel
Reviewed-by: David Wei
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
From: Steele, Kelly
Sent: Thursday, October 4, 2018 12:43 AM
To: edk2-devel@lists.01.org
Cc: Wei, David ; Guo, Mang
Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Cleanup build
scripts
>From
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, August 29, 2018 8:51 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/3] Update LZMA SDK version to the latest 18.05
Liming Gao (3):
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Monday, September 10, 2018 8:37 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2] Update BrotliCompress to the latest version 1.0.5
Because the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1224
When covert IFR binary to EFI_IFR_CHECKBOX structure,
Current code has following incorrect code logic:
IfrCheckBox = (EFI_IFR_CHECKBOX *) (IfrOpHdr + 1);
The correct one should be:
IfrCheckBox = (EFI_IFR_CHECKBOX *) IfrOpHdr;
This patch is
Hi Kelly,
Below comments should be removed. Other changes looks good to me.
Reviewed-by: David Wei
+
+//KES://
+//KES:// Dump MUX I2C registers
+//KES://
+//KES:MB3DumpMux ();
+
+ //
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
From: Steele, Kelly
Sent: Thursday, October 4,
Hi,
We planned to drop the support of BaseTools Python run from the freeze binary
in Windows OS
https://lists.01.org/pipermail/edk2-devel/2018-September/029436.html
Please run BaseTools Python from source in Windows. Here is the step wiki
Supreeth,
I have created the edk2-test repository with the
Readme.md, License.txt, and Contributions.txt files.
I have also created the "EDK II Test Maintainers"
team for developers that are maintainers of the test
infrastructure and test cases in this repository.
Best regards,
Mike
>
25 matches
Mail list logo
