[edk2] [PATCH V2 2/4] MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function

2018-10-25 Thread Star Zeng
V2: Add the missing "gBS->FreePool (Data);". REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new EhciInsertAsyncIntTransfer function from EhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J

[edk2] [PATCH V2 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-25 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, EhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address". EhcMonitorAsyncRequests

[edk2] [PATCH V2 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer

2018-10-25 Thread Star Zeng
V2: Thanks for Ray's feedback. Add the missing "FreePool (Data);". Remove the unnecessary indentation change. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Please refer to the log message of each commit for more details. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J Wang Cc: Jiewen Yao

[edk2] [PATCH V2 3/4] MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-25 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, XhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address". XhcMonitorAsyncRequests

[edk2] [PATCH V2 1/4] MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function

2018-10-25 Thread Star Zeng
V2: Add the missing "FreePool (Data);". Remove the unnecessary indentation change. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new XhciInsertAsyncIntTransfer function from XhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change.

Re: [edk2] [PATCH 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-25 Thread Ni, Ruiyu
On 10/25/2018 6:58 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, EhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address".

Re: [edk2] [PATCH 3/4] MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-25 Thread Ni, Ruiyu
On 10/25/2018 6:58 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, XhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address".

Re: [edk2] [Patch 0/2] Mtftp: Correct the total received and saved block number.

2018-10-25 Thread Ye, Ting
Series Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Thursday, October 25, 2018 4:56 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch 0/2] Mtftp: Correct the total received and saved block number. The block returned from

Re: [edk2] [PATCH 1/4] MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function

2018-10-25 Thread Zeng, Star
On 2018/10/26 12:57, Ni, Ruiyu wrote: On 10/25/2018 6:58 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new XhciInsertAsyncIntTransfer function from XhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change.

Re: [edk2] [PATCH 1/4] MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function

2018-10-25 Thread Zeng, Star
On 2018/10/26 12:57, Ni, Ruiyu wrote: On 10/25/2018 6:58 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new XhciInsertAsyncIntTransfer function from XhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change.

Re: [edk2] [PATCH 2/4] MdeModulePkg EhciDxe: Extract new EhciInsertAsyncIntTransfer function

2018-10-25 Thread Ni, Ruiyu
On 10/25/2018 6:58 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new EhciInsertAsyncIntTransfer function from EhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J

Re: [edk2] [PATCH 1/4] MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function

2018-10-25 Thread Ni, Ruiyu
On 10/25/2018 6:58 PM, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new XhciInsertAsyncIntTransfer function from XhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J

[edk2] [PATCH] MdeModulePkg/Core: fix an IA32 build failure

2018-10-25 Thread Jian J Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1277 The failure is caused by data type conversion between UINTN and UINT64, which is checked in at 63ebde8ef6d4ff497d054ccc010904ecd4441198. Cc: Star Zeng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch

2018-10-25 Thread Zeng, Star
Liming, I saw MdeModulePkg only builds MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf at EBC arch. You mean even the *unused* library INF files will be considered? Why? Sorry I am still confused. Thanks, Star -Original Message- From: Gao, Liming Sent: Friday,

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Support combo CPU feature style.

2018-10-25 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: Dong, Eric > Sent: Thursday, October 25, 2018 2:50 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Support combo CPU > feature style. > > Current code assume only

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

2018-10-25 Thread Gao, Liming
Star: This option is not the default option. To pass GCC build, GCC tool chain adds it. XCODE tool chain doesn't require it, it is not listed for XCODE. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, > Star > Sent:

Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch

2018-10-25 Thread Gao, Liming
Star: Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect PCD information from all INF files list in DSC/FDF. But before, only the used library INF files are considered. This change is to decide which PCD is really used, then generate the structure PCD value in the

Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch

2018-10-25 Thread Zeng, Star
On 2018/10/26 9:57, Liming Gao wrote: SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is defined in MdeModulePkg.dec for IA32 and X64 only. Could we explain more in the commit log about why this change is not needed before but required now? Thanks, Star

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

2018-10-25 Thread Zeng, Star
On 2018/10/26 10:33, Liming Gao wrote: This patch makes RegularExpressionDxe pass XCODE5 build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 1 file changed,

Re: [edk2] [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure

2018-10-25 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Friday, October 26, 2018 11:19 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure > > REF:

[edk2] [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure

2018-10-25 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1276 Fixed potentially uninitialized variable build failure caused by commit: b1cc6f672f3b924cdb190e5b92db3b47f46a8911 Test: Verified on internal platform and boots successfully. Cc: Jiewen Yao Cc: Desimone Nathaniel L Contributed-under:

Re: [edk2] [PATCH 1/1] BaseTools: Use VENDOR_DEVICE_PATH structure for Debug Port device path

2018-10-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, October 25, 2018 2:00 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH 1/1] BaseTools: Use VENDOR_DEVICE_PATH structure for Debug Port device

Re: [edk2] [PATCH 0/2] MdeModulePkg/UsbBusPei: validate HW data before using

2018-10-25 Thread Zeng, Star
Reviewed-by: Star Zeng As I know, you did Recovery test with USB disk for these patches. I think you can add the test information into the commit message of patches. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent:

Re: [edk2] [PATCH 1/1] BaseTools: Fix BPDG tool print traceback info issue

2018-10-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, October 25, 2018 1:51 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH 1/1] BaseTools: Fix BPDG tool print traceback info issue Fix BPDG tool

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

2018-10-25 Thread Liming Gao
This patch makes RegularExpressionDxe pass XCODE5 build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 1 file changed, 4 insertions(+) diff --git

Re: [edk2] [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update behaviors are atomic

2018-10-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Friday, October 12, 2018 7:26 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update > behaviors are atomic > > The main

[edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch

2018-10-25 Thread Liming Gao
SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is defined in MdeModulePkg.dec for IA32 and X64 only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- MdeModulePkg/MdeModulePkg.dsc | 2 ++ 1 file changed, 2

Re: [edk2] [PATCH] BaseTools:Not miss the full assign value of FixedAtBuild structure PCD

2018-10-25 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Zhao, ZhiqiangX Sent: Wednesday, October 24, 2018 9:01 PM To: edk2-devel@lists.01.org Cc: Zhao, ZhiqiangX ; Gao, Liming ; Zhu, Yonghong ; Feng, Bob C Subject: [PATCH] BaseTools:Not miss the full assign value of FixedAtBuild structure

Re: [edk2] [Patch] SecurityPkg/Include/Library/TcgStorageOpalLib.h: Update Pyrite spec revision.

2018-10-25 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Dong, Eric > Sent: Friday, October 26, 2018 9:15 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [Patch] SecurityPkg/Include/Library/TcgStorageOpalLib.h: Update > Pyrite spec revision. > > Pyrite 2.0

Re: [edk2] [PATCH v4 6/6] MdeModulePkg/Core: add freed-memory guard feature

2018-10-25 Thread Wang, Jian J
Sure. Thanks. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, October 26, 2018 9:19 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > ; Yao, Jiewen ; Laszlo Ersek > ; Zeng, Star > Subject: Re: [edk2] [PATCH v4 6/6]

Re: [edk2] [PATCH v4 5/6] MdeModulePkg/Core: prevent re-acquire GCD memory lock

2018-10-25 Thread Wang, Jian J
Sorry missing that one. I'll update it. Thanks for the comments. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, October 26, 2018 9:18 AM > To: Wang, Jian J ; edk2-devel boun...@lists.01.org>; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > ; Yao,

Re: [edk2] [PATCH v4 6/6] MdeModulePkg/Core: add freed-memory guard feature

2018-10-25 Thread Zeng, Star
On 2018/10/25 15:18, Jian J Wang wrote: v4 changes: a. replace hard-coded memory attributes with the value got from CoreGetMemorySpaceDescriptor() b. remove the enclosure of CoreAcquireGcdMemoryLock() and CoreReleaseGcdMemoryLock() around CoreAddRange() Freed-memory guard is used to

Re: [edk2] [PATCH v4 5/6] MdeModulePkg/Core: prevent re-acquire GCD memory lock

2018-10-25 Thread Zeng, Star
On 2018/10/25 15:20, Wang, Jian J wrote: Sorry, forgot to update commit message: This issue is hidden in current code but exposed by introduction of freed-memory guard feature due to the fact that the feature will turn all pool allocation to page allocation. The solution is moving the memory

Re: [edk2] [PATCH v4 0/6] Introduce freed-memory guard feature

2018-10-25 Thread Zeng, Star
On 2018/10/25 15:17, Jian J Wang wrote: v4 changes: Updated per comments from Star. Please refer to individual patch file for details (#2/5/6) Minor comments to patch 5 and 6, please see the individual feedback. With them addressed, Reviewed-by: Star Zeng to patch 1, 2, 5 and 6. And

[edk2] [Patch] SecurityPkg/Include/Library/TcgStorageOpalLib.h: Update Pyrite spec revision.

2018-10-25 Thread Eric Dong
Pyrite 2.0 spec has been published, update the spec link info for this file. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- SecurityPkg/Include/Library/TcgStorageOpalLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow issue.

2018-10-25 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Long Qin Sent: Wednesday, October 24, 2018 9:22 PM To: edk2-devel@lists.01.org Cc: Ye, Ting Subject: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow

Re: [edk2] [PATCH v4 4/6] UefiCpuPkg/CpuDxe: prevent recursive calling of InitializePageTablePool

2018-10-25 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wang, Jian J > Sent: Thursday, October 25, 2018 3:18 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; > Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Ni, > Ruiyu > Subject: [PATCH v4 4/6] UefiCpuPkg/CpuDxe: prevent

Re: [edk2] [PATCH v4 3/6] UefiCpuPkg/CpuDxe: consider freed-memory guard in non-stop mode

2018-10-25 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wang, Jian J > Sent: Thursday, October 25, 2018 3:18 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; > Zeng, Star ; Kinney, Michael D > ; Yao, Jiewen ; Ni, > Ruiyu > Subject: [PATCH v4 3/6] UefiCpuPkg/CpuDxe:

Re: [edk2] [Patch 1/2 V2] BaseTools: Add $(INC)-like support when compiling .nasm files

2018-10-25 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, October 25, 2018 8:05 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 1/2 V2] BaseTools: Add $(INC)-like

[edk2] [PATCH v2] CryptoPkg/BaseCryptLib: Fix potential integer overflow issue.

2018-10-25 Thread Long Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1275 The LookupFreeMemRegion() in RuntimeMemAllocate.c is used to look-up free memory region for runtime resource allocation, which was designed to support runtime authenticated variable service. The ReqPages in this function is the required

[edk2] [Patch 2/2 V2] BaseTools: Update nasm file build rule to support $(INC)

2018-10-25 Thread Yonghong Zhu
From: zhijufan Update the build rule to: "$(NASM)" -I${s_path}(+) $(NASM_INC)(+) $(NASM_FLAGS) -o $dst ${d_path}(+)${s_base}.iii Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Conf/build_rule.template | 2 +- 1

[edk2] [Patch 0/2 V2] Update .nasm to support $(INC)-like support

2018-10-25 Thread Yonghong Zhu
V2: 1. remove FileMacro variable 2. Make sure the NASM_INC file path have '\' in the end Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1085 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan zhijufan (2): BaseTools: Add

[edk2] [Patch 1/2 V2] BaseTools: Add $(INC)-like support when compiling .nasm files

2018-10-25 Thread Yonghong Zhu
From: zhijufan current edk2\BaseTools\Conf\build_rule.template, the compile of nasm source files does not have the $(INC) support. The '-I' option only includes the directory of the nasm source file (${s_path}(+)). Hence, it will be impossible for nasm files to include files outside of the nasm

Re: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when compiling .nasm files

2018-10-25 Thread Zhu, Yonghong
Yes, I agree. I will help to update a V2. Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, October 25, 2018 10:20 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when

Re: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when compiling .nasm files

2018-10-25 Thread Carsey, Jaben
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, October 25, 2018 12:38 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when > compiling

Re: [edk2] [Patch v3 6/6] BaseTools/GenFds: create and use new variable in FdfParser

2018-10-25 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Wednesday, October 24, 2018 1:29 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Zhu, Yonghong ; Gao, Liming Subject: [Patch v3 6/6] BaseTools/GenFds: create and use new variable in FdfParser replace lots of '}' and

Re: [edk2] [Patch] FDF spec: Add PI1.5 standalone SMM support in FDF file

2018-10-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, October 25, 2018 8:42 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Shaw, Kevin W ; > Cohen; Eugene > Subject: [Patch] FDF spec: Add PI1.5 standalone SMM support in FDF

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow issue.

2018-10-25 Thread Long, Qin
Thanks, Laszlo. From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 25, 2018 12:59 AM To: Long, Qin ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow issue. On 10/24/18 15:22, Long Qin wrote: > The

Re: [edk2] [PATCH 1/2] ShellPkg-Shell App: Provide fully-qualified path to shell scripts

2018-10-25 Thread Jim.Dailey
On Thursday, October 25, 2018 12:48 AM ruiyu...@intel.com wrote: >On 10/25/2018 12:35 AM, jim.dai...@dell.com wrote: >> Add a function to return the fully-qualified version of some path. >> >> ... >> +CHAR16* >> +EFIAPI >> +FullyQualifyPath( >> + IN OUTCHAR16 **Path >This API assumes

Re: [edk2] [PATCH v2 0/4] SdMmcOverride extension

2018-10-25 Thread Marcin Wojtas
Hi Hao, Were you able to find time for evaluating my patchset? Best regards, Marcin pt., 12 paź 2018 o 14:50 Marcin Wojtas napisał(a): > > pt., 12 paź 2018 o 14:48 Wu, Hao A napisał(a): > > > > > -Original Message- > > > From: Marcin Wojtas [mailto:m...@semihalf.com] > > > Sent:

[edk2] [Patch] FDF spec: Add PI1.5 standalone SMM support in FDF file

2018-10-25 Thread Yonghong Zhu
V2: Update it to MM_CORE_STANDALONE and MM_STANDALONE Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=551 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Cc: Cohen, Eugene Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH v2] BaseTools: Allow multiple PciDeviceId in Fdf OptionROM override

2018-10-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tomas Pilar (tpilar) Sent: Wednesday, October 24, 2018 7:43 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] BaseTools: Allow

Re: [edk2] [Patch v3 0/6] BaseTools/GenFds: cleanup GenFds

2018-10-25 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Wednesday, October 24, 2018 1:29 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch v3 0/6] BaseTools/GenFds: cleanup

[edk2] [PATCH 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-25 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, EhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address". EhcMonitorAsyncRequests

[edk2] [PATCH 1/4] MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function

2018-10-25 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Extract new XhciInsertAsyncIntTransfer function from XhcAsyncInterruptTransfer. It is code preparation for following patch, no essential functional change. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J Wang Cc: Jiewen Yao Contributed-under:

[edk2] [PATCH 0/4] Remove unnecessary Map/Unmap in XhciDxe/EhciDxe for AsyncInterruptTransfer

2018-10-25 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 Please refer to the log message of each commit for more details. Cc: Ruiyu Ni Cc: Hao Wu Cc: Jian J Wang Cc: Jiewen Yao Star Zeng (4): MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function MdeModulePkg EhciDxe:

[edk2] [PATCH 3/4] MdeModulePkg XhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-25 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, XhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address". XhcMonitorAsyncRequests

[edk2] [PATCH 0/2] MdeModulePkg/UsbBusPei: validate HW data before using

2018-10-25 Thread Ruiyu Ni
The patches sync the similar fixes to UsbBusDxe to UsbBusPei. Ruiyu Ni (2): MdeModulePkg/UsbBusPei: Fix out-of-bound read access to descriptors MdeModulePkg/UsbBusPei: Reject descriptor whose length is bad MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c | 93 +++-

[edk2] [PATCH 1/2] MdeModulePkg/UsbBusPei: Fix out-of-bound read access to descriptors

2018-10-25 Thread Ruiyu Ni
Today's implementation reads the Type/Length field in the USB descriptors data without checking whether the offset to read is beyond the data boundary. The patch fixes this issue by syncing the fix in commit 4c034bf62cbc1f3c5f4b5df25de97f0f528132b2 *MdeModulePkg/UsbBus: Fix out-of-bound read

[edk2] [PATCH 2/2] MdeModulePkg/UsbBusPei: Reject descriptor whose length is bad

2018-10-25 Thread Ruiyu Ni
Today's implementation doesn't check whether the length of descriptor is valid before using it. The patch fixes this issue by syncing the similar fix to UsbBusDxe. 70c3c2370a2aefe71cf0f6c1a1e063f7d74e1d79 *MdeModulePkg/UsbBus: Reject descriptor whose length is bad Additionally the patch also

[edk2] [Patch 1/2] MdeModulePke/Mtftp4Dxe: Correct the total received and saved block number.

2018-10-25 Thread Jiaxin Wu
The block returned from Mtftp4RemoveBlockNum is not the total received and saved block number if it works in passive (Slave) mode. The issue was exposed by the EMS test. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin ---

[edk2] [Patch 2/2] NetworkPkg/Mtftp6Dxe: Correct the total received and saved block number.

2018-10-25 Thread Jiaxin Wu
The block returned from Mtftp6RemoveBlockNum is not the total received and saved block number if it works in passive (Slave) mode. The issue was exposed by the EMS test. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin ---

[edk2] [Patch 0/2] Mtftp: Correct the total received and saved block number.

2018-10-25 Thread Jiaxin Wu
The block returned from Mtftp4RemoveBlockNum is not the total received and saved block number if it works in passive (Slave) mode. The issue was exposed by the EMS test. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin Jiaxin Wu (2):

[edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when compiling .nasm files

2018-10-25 Thread Yonghong Zhu
From: zhijufan current edk2\BaseTools\Conf\build_rule.template, the compile of nasm source files does not have the $(INC) support. The '-I' option only includes the directory of the nasm source file (${s_path}(+)). Hence, it will be impossible for nasm files to include files outside of the nasm

[edk2] [Patch 2/2] BaseTools: Update nasm file build rule to support $(INC)

2018-10-25 Thread Yonghong Zhu
From: zhijufan Update the build rule to: "$(NASM)" -I${s_path}(+) $(NASM_INC)(+) $(NASM_FLAGS) -o $dst ${d_path}(+)${s_base}.iii Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- BaseTools/Conf/build_rule.template | 2 +- 1

[edk2] [Patch 0/2] Update .nasm to support $(INC)-like support

2018-10-25 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1085 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan zhijufan (2): BaseTools: Add $(INC)-like support when compiling .nasm files BaseTools: Update nasm file build rule to

Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not override IDT

2018-10-25 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, October 23, 2018 5:34 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH v2] IntelFsp2Pkg: FSP should not override IDT > > REF:

[edk2] [PATCH v1 0/1] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-10-25 Thread Sughosh Ganu
Patch to update the memory attributes of the region where StandaloneMM drivers are loaded. Based on the review comments from Ard, this code has now been moved under StandaloneMmPkg directory. This patch needs to be applied on top of the following patch series - "ArmPkg related changes for

[edk2] [PATCH v1 1/1] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-10-25 Thread Sughosh Ganu
The StandaloneMM image executes in S-EL0 on reference Arm platforms and is deployed by the trusted firmware as BL32 image. Memory for the Standalone MM drivers is marked as RW+XN initially, allowing the drivers to be loaded into the memory. Once loaded, the memory attributes need to be changed to

[edk2] [PATCH v3 5/6] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-10-25 Thread Sughosh Ganu
From: Achin Gupta The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its architectural context including the initial translation tables for the S-EL1/EL0 translation regime. The MM environment will still request

[edk2] [PATCH v3 6/6] ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.

2018-10-25 Thread Sughosh Ganu
From: Achin Gupta This patch adds the definitions, sources, packages and library classes needed to compile and link MMU Library suitable for use in S-EL0. Currently, this is used only during the Standalone MM Core initialization and hence defined as MM_CORE_STANDALONE Module.

[edk2] [PATCH v3 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-10-25 Thread Sughosh Ganu
From: Achin Gupta PI v1.5 Specification Volume 4 defines Management Mode Core Interface and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a means of communicating between drivers outside of MM and MMI handlers inside of MM. This patch implements the EFI_MM_COMMUNICATION_PROTOCOL

[edk2] [PATCH v3 4/6] ArmPkg/Include: Add MM interface SVC return codes.

2018-10-25 Thread Sughosh Ganu
From: Achin Gupta This patch adds the Management Mode(MM) - Secure Partition Manager(SPM) SVC return codes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 7 +++ 1 file changed, 7 insertions(+) diff

[edk2] [PATCH v3 1/6] ArmPkg: Add PCDs needed for MM communication driver.

2018-10-25 Thread Sughosh Ganu
From: Achin Gupta This patch defines PCDs to describe the base address and size of communication buffer between normal world (uefi) and standalone MM environment in the secure world. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- ArmPkg/ArmPkg.dec | 3

[edk2] [PATCH v3 3/6] ArmPkg/Include: Fix the SPM version SVC ID

2018-10-25 Thread Sughosh Ganu
The MM_VERSION SMC call uses SMC32 calling convention. Fix the macro to reflect the correct value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH v3 0/6] ArmPkg related changes for StandaloneMM package

2018-10-25 Thread Sughosh Ganu
The following patch series adds support for Management Mode related changes for aarch64 based platforms. Changes since v2: Based on review comments from Ard, moved the memory attribute updation changes out of DebugPeCoffExtraActionLib into an extra action library added in StandaloneMM package.

Re: [edk2] [Patch] FDF Spec: Add the $(PCD) usage in the [FD] section

2018-10-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, October 22, 2018 3:49 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Shaw, Kevin W > ; Gao, Liming > Subject: [edk2] [Patch]

Re: [edk2] [Patch] BaseTools: Fix VPD PCD Sub-section display bug

2018-10-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, October 23, 2018 7:10 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix VPD PCD Sub-section display bug > >

Re: [edk2] [Patch] BaseTools: list .nasm include inc files as its dependency

2018-10-25 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, October 24, 2018 3:38 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] BaseTools: list .nasm include inc

Re: [edk2] [PATCH v4 5/6] MdeModulePkg/Core: prevent re-acquire GCD memory lock

2018-10-25 Thread Wang, Jian J
Sorry, forgot to update commit message: > This issue is hidden in current code but exposed by introduction > of freed-memory guard feature due to the fact that the feature > will turn all pool allocation to page allocation. > > The solution is moving the memory allocation in

[edk2] [PATCH v4 4/6] UefiCpuPkg/CpuDxe: prevent recursive calling of InitializePageTablePool

2018-10-25 Thread Jian J Wang
> v4 changes: none The freed-memory guard feature will cause an recursive calling of InitializePageTablePool(). This is due to a fact that AllocateAlignedPages() is used to allocate page table pool memory. This function will most likely call gBS->FreePages to free unaligned pages and then cause

[edk2] [PATCH v4 5/6] MdeModulePkg/Core: prevent re-acquire GCD memory lock

2018-10-25 Thread Jian J Wang
> v4 changes: > a. add more comments from Laszlo This issue is hidden in current code but exposed by introduction of freed-memory guard feature due to the fact that the feature will turn all pool allocation to page allocation. The solution is move the memory allocation in CoreGetMemorySpaceMap()

[edk2] [PATCH v4 6/6] MdeModulePkg/Core: add freed-memory guard feature

2018-10-25 Thread Jian J Wang
> v4 changes: > a. replace hard-coded memory attributes with the value got from >CoreGetMemorySpaceDescriptor() > b. remove the enclosure of CoreAcquireGcdMemoryLock() and >CoreReleaseGcdMemoryLock() around CoreAddRange() Freed-memory guard is used to detect UAF (Use-After-Free) memory

[edk2] [PATCH v4 3/6] UefiCpuPkg/CpuDxe: consider freed-memory guard in non-stop mode

2018-10-25 Thread Jian J Wang
> v4 changes: none Non-stop mode was introduced / explained in commit 8f2613628acf ("MdeModulePkg/MdeModulePkg.dec: add new settings for PCDs", 2018-08-30). The macro HEAP_GUARD_NONSTOP_MODE was added to CpuDxe in commit dcc026217fdc ("UefiCpuPkg/CpuDxe: implement non-stop mode for uefi",

[edk2] [PATCH v4 2/6] MdeModulePkg: introduce UEFI freed-memory guard bit in HeapGuard PCD

2018-10-25 Thread Jian J Wang
> v4 changes: > a. refine PCD description of PcdHeapGuardPropertyMask UAF (Use-After-Free) memory issue is kind of illegal access to memory which has been freed. It can be detected by a new freed-memory guard enforced onto freed memory. BIT4 of following PCD is used to enable the freed-memory

[edk2] [PATCH v4 1/6] MdeModulePkg: cleanup Heap Guard pool/page type PCD documentation

2018-10-25 Thread Jian J Wang
> v4 changes: none This cleanup is meant for avoiding misuse of newly introduced BIT4 (UAF detection) of PCD PcdHeapGuardPropertyMask, because it applies to all types of physical memory. In another words, PcdHeapGuardPoolType and PcdHeapGuardPageType don't have effect to the BIT4 of

[edk2] [PATCH v4 0/6] Introduce freed-memory guard feature

2018-10-25 Thread Jian J Wang
> v4 changes: > Updated per comments from Star. Please refer to individual patch > file for details (#2/5/6) Freed-memory guard is a new feauture used to detect UAF (Use-After-Free) memory issue. Tests: a. Feature basic unit/functionality test b. OVMF regression test Jian J Wang (6):

[edk2] [PATCH 1/1] SD : Continue setting up sd even if SD_HIGH_SPEED is not supported

2018-10-25 Thread tien . hock . loh
From: "Loh, Tien Hock" If SD doesn't support SD_HIGH_SPEED, function should still continue to setup SD to go into 4 bits more if it is supported. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Loh Tien Hock --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 20

[edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Support combo CPU feature style.

2018-10-25 Thread Eric Dong
Current code assume only one dependence (before or after) for one feature. Enhance code logic to support feature has two dependence (before and after) type. Cc: Ruiyu Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

Re: [edk2] [PATCH v3 6/6] MdeModulePkg/Core: add freed-memory guard feature

2018-10-25 Thread Wang, Jian J
Star, I think the CoreGetMemorySpaceDescriptor() can get the memory capabilities. So we can remove those hard-coded ones. In addition, since CoreAddRange() doesn't touch mGcdMemorySpaceMap, CoreAcquireGcdMemoryLock and CoreReleaseGcdMemoryLock are not necessary to protect CoreAddRange(). I'll

[edk2] [PATCH 1/1] BaseTools: Use VENDOR_DEVICE_PATH structure for Debug Port device path

2018-10-25 Thread Feng, YunhuaX
Copy code from Commit 9343d0a1cd09544686b14dba5b428d7bc811f6b9 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/C/DevicePath/DevicePath.c | 2 +- BaseTools/Source/C/DevicePath/DevicePathFromText.c |