Code looks good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Tuesday, October 30, 2018 2:31 PM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen
> Subject: [edk2] [P
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jeff Brasen
> Sent: Tuesday, October 30, 2018 2:31 PM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen
> Subject: [edk2] [PATCH 2/2] MdeModulePk
Please separate includes to each on their own line. PEP8 says no to multiples
on one line.
Not:
include random, string
But instead:
include string
include random
Also, if we only need sample from random, can we just use "from random import
sample"?
-Jaben
> -Original Messag
I have the same behavior as Leif describes (with probably the hypothesized
client).
When I reply, I get nothing but the mailing list in "to" (empty "cc").
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, October 25, 2018 8:05 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch 1/2 V2] BaseT
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, October 25, 2018 12:38 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when
> compiling .nas
Reviewed-by: Jaben Carsey
Ray?
I can push this one also if you don't see an issue.
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Wednesday, October 24, 2018 9:35 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jab
Looks good to me.
Ray?
Reviewed-by: Jaben Carsey
p.s. Ray if you agree you can RB and I will handle the push.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim.dai...@dell.com
> Sent: Wednesday, October 24, 2018 9:36 AM
>
replace lots of '}' and "}" with a shared new consistent variable.
Cc: Bob Feng
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 45 ++--
make functions for common error messages
refactor to use these functions
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 603 ++--
1 file changed, 303
1) initialize UiFvName via __init__ parameter. No change to default behavior.
2) initialize 3 empty lists in __init__. Curently not guarenteed initialized.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source
unused code/parameters/variables
6) add standard warnings and use them for common code
changes from v1:
1) do not shadow CapsuleFV.
2) rebase on master
changes from v2:
1) do not delete duplicate function calls.
2) add ".lower()" for GUID string comparison.
3) rebase on master
Jaben
Change lists and tuples used solely for "in" testing to sets.
These operations are not order dependent.
fixed some line length for PEP8 compliance on some.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTo
use MacroDict
4. GetFilePart calls into GetSectionData, otherwise doesn’t use MacroDict
Go to 1 and repeat forever.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 48 +++-
1 file changed
No effect on functionality, but sometimes first is spelled fisrt in below
patch.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Feng, Bob C
> Sent: Sunday, October 21, 2018 3:48 AM
> To: Zhao, ZhiqiangX ; edk2-devel@lists.01.org
> Cc: Gao
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> BobCF
> Sent: Friday, October 19, 2018 5:00 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTool: Filter out
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Friday, October 19, 2018 12:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix the bug that PcdValu
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Friday, October 19, 2018 12:21 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix the crash issue when D
Reviewed-by: Jaben Carsey
Note that you could change your first 2 lines (of the new content in both
places) to:
for Data in OverrideValues.values():
since you don't ever use the key later on...
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@l
I would like to know when a patch fixes a BZ. Subject/body I have less strong
opinion about.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> stephano
> Sent: Thursday, October 18, 2018 2:13 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2]
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Wednesday, October 17, 2018 6:04 PM
> To: Zhu, Yonghong ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch] BaseTools: Fix
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> BobCF
> Sent: Wednesday, October 17, 2018 10:43 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Remov
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zhaozh1x
> Sent: Wednesday, October 17, 2018 10:09 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH V2] BaseTools: Co
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, October 17, 2018 11:37 AM
> To: Zhao, ZhiqiangX
> Cc: edk2-devel@lists.01.org; Gao, Liming
> Subject: Re: [edk2] [PATCH] BaseTools: covert "unicode string" to
Propose to use a set not a list when the data is unordered and unique names of
functions.
With that: reviewed-by:Jaben.carsey
Sent from my iPad
> On Oct 16, 2018, at 7:25 PM, Yonghong Zhu wrote:
>
> From: Hess Chen
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by
Hess,
Thanks for the clarification. Makes sense!
I glanced at, but didn't read in detail the code... so.
Acked-by: Jaben Carsey
> -Original Message-
> From: Chen, Hesheng
> Sent: Monday, October 15, 2018 2:34 PM
> To: Carsey, Jaben ; Zhu, Yonghong
> ; edk2-devel@li
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 15, 2018 3:24 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Hesheng
> Subject: [edk2] [PATCH] BaseTools/EOT: Change to call a program instead of
> calling P
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 15, 2018 5:45 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Add
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 15, 2018 5:46 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix bugs use special char
this file is not imported/used.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Database.py | 120
1 file changed, 120 deletions(-)
diff --git a/BaseTools/Source/Python
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Sunday, October 07, 2018 6:42 PM
> To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf
> OptionROM
Seems good to me.
Any thoughts Ray?
Reviewed-by: Jaben Carsey
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Thursday, October 04, 2018 9:47 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [edk2] [
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Sunday, October 07, 2018 8:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ye, Ting ;
> Fu, Siyuan ; Wu, Jiaxin ; Bi
: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yeazel (Prime Air), Matt
> Sent: Friday, October 05, 2018 1:08 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] BaseTools: Add support for dots in paths
> Importance: High
>
> spl
Matthew,
Would os.path. (maybe splitext) be a better function than using the
string rsplit function? It just seems like we should use the python file path
manipulation functions instead of trying to trick the string manipulation
routines into the same behavior...
-Jaben
> -Origi
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, October 05, 2018 4:33 AM
> To: Carsey, Jaben ; Andrew Fish
>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment
> var
thing and should have been more aware. I would like to have a
community minimum amount of time before commits are done that we all agree to.
Something like 1 full day would be nice I think.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Be
Pushed.
c0b1f749ef1304810ed4ea58ded65b7f41d79d3e
> -Original Message-
> From: Carsey, Jaben
> Sent: Wednesday, October 03, 2018 11:15 AM
> To: 'jim.dai...@dell.com' ; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH] ShellPkg: Create a homefilesyst
Reviewed-by: Jaben Carsey
> -Original Message-
> From: jim.dai...@dell.com [mailto:jim.dai...@dell.com]
> Sent: Wednesday, October 03, 2018 9:02 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [edk2] [PATCH] ShellPkg: Create a homefile
> Cc: Carsey, Jaben ; Zeng, Star
>
> Subject: RE: [PATCH] ShellPkg ShellLib.h: Fix wrong parameter name for
> ShellOpenFileByName
> Importance: High
>
> Ray,
>
> Thanks.
>
> I did not check the detail. But at least, one of definition and implementation
> needs
replace lots of '}' and "}" with a shared new consistent variable.
Cc: Bob Feng
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 45 ++--
use MacroDict
4. GetFilePart calls into GetSectionData, otherwise doesn’t use MacroDict
Go to 1 and repeat forever.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 48 +++-
1 file changed
Change lists and tuples used solely for "in" testing to sets.
These operations are not order dependent.
fixed some line length for PEP8 compliance on some.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTo
every call to GetAprioriSection() is duplicated on the line below.
remove one of the calls.
Cc: Bob Feng
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 --
1 file changed
make functions for common error messages
refactor to use these functions
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 603 ++--
1 file changed, 303
unused code/parameters/variables
6) add standard warnings and use them for common code
changes from v1:
1) do not shadow CapsuleFV.
2) rebase on master
Jaben Carsey (7):
BaseTools/GenFds: cleanup GenFds
BaseTools/GenFds: change objects to sets
Basetools/GenFds: refactor class FV
BaseTools
1) initialize UiFvName via __init__ parameter. No change to default behavior.
2) initialize 3 empty lists in __init__. Curently not guarenteed initialized.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Tomas Pilar (tpilar)
> Sent: Wednesday, September 26, 2018 3:16 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2] Shell
I would prefer we just delete this.
Ray,
What do you think?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Tomas Pilar (tpilar)
> Sent: Tuesday, September 25, 2018 3:15 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] ShellPkg:
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhu, Yonghong
> Sent: Monday, September 24, 2018 11:23 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Zhu, Yonghong
>
> Subject: RE: [Patch] BaseTools: Fix the wrong reference _GetSkuId
make functions for common error messages
refactor to use these functions
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 603 ++--
1 file changed, 303
Change lists and tuples used solely for "in" testing to sets.
These operations are not order dependent.
fixed some line length for PEP8 compliance on some.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTo
use MacroDict
4. GetFilePart calls into GetSectionData, otherwise doesn’t use MacroDict
Go to 1 and repeat forever.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 48 +++-
1 file changed
replace lots of '}' and "}" with a shared new consistent variable.
Cc: Bob Feng
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 45 ++--
1) initialize UiFvName via __init__ parameter. No change to default behavior.
2) initialize 3 empty lists in __init__. Curently not guarenteed initialized.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source
unused code/parameters/variables
6) add standard warnings and use them for common code
Jaben Carsey (7):
BaseTools/GenFds: cleanup GenFds
BaseTools/GenFds: change objects to sets
Basetools/GenFds: refactor class FV
BaseTools/GenFds: remove MacroDict parameter
BaseTools/GenFds: refactor
every call to GetAprioriSection() is duplicated on the line below.
remove one of the calls.
Cc: Bob Feng
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 --
1 file changed
When the shell starts, it the prompt "shell>" or something like "fs0:>"... The
shell may not have a file system assigned yet so you cannot change directories
until you pick a file system.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> kris
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Wu, Jiaxin
> Sent: Sunday, September 16, 2018 10:44 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Carsey,
> Jaben ; Shao, Ming ; Wu,
> Jiaxin
> Subject: [Patch 3/5] ShellPkg/TftpDynamicCom
: Bob C Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
b/BaseTools/Source/Python
Reviewed-by: Jaben Carsey
Code looks good to me.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, September 12, 2018 6:22 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Zimmer, Vinc
Ard,
What happens when more than one emulators want to co-exist?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, September 12, 2018 7:57 AM
> To: Gao, Liming
> Cc: Ni, Ruiyu
Update the WorkspaceAutoGen class to use caching decorators and remove
the no longer needed private variables.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 69
callers from accessing "private" data and use the existing
properties
6) removed a circular dependency between APIs
v2:
fix error where class attribute M was accidentally removed.
Jaben Carsey (9):
BaseTools: Refactor PlatformAutoGen
BaseTools: AutoGen refactor WorkspaceAut
1) use decorators
2) also change some private functions to public when all callers are
external
3) change external callers to use functions instead of directly
accessing private data.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben
currently created for 3 different purposes and saved once.
this makes it created once and saved and then referenced.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py
FlexibleFieldName was never used not set.
DefinitionPosition (file and line number) are recalculated
and never used outside the function. remove the saving of the
data.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
use Common.caching and auto cache properties and functions of InfBuildData
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/InfBuildData.py | 840 +---
1 file
use function decorators
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenMake.py | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/BaseTools/Source
use decorators for property and automatic caching
remove circular dependency between some APIs
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 587
use decorators and auto cache those that were cached manually
remove properties never used
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py | 90 +---
1 file changed
1) use namedtuple instead of custom class when apropriate
2) rename collections.OrderedDict to OrderedDict since we import it already
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace
remove uncalled functions
remove extra blank lines
remove commented out code
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 56
1 file changed, 56
I have found a related issue. Please ignore this patch.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Thursday, September 06, 2018 11:31 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subj
Currently, Basetools only verifies Binary file list existance for default ARCH,
but it should verify for a specified ARCH the same.
Also, dont save the list to a unused variable.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
We have a BZ to remove the compatibility package... I’d call updating it
redundant and not worth your time.
Jaben
> On Sep 6, 2018, at 10:27 AM, Ard Biesheuvel wrote:
>
>> On 6 September 2018 at 18:53, Laszlo Ersek wrote:
>>> On 09/06/18 15:45, Ard Biesheuvel wrote:
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/Attribute.py | 28
1 file changed, 28 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds/Attribute.py
b/BaseTools
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 17 -
1 file changed, 17 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds
Update GenFdsGlobalVariable GetAlignment to support G.
replace use of local function in Region with updated shared function.
Cc: Yonghong Zhu
Cc: Liming Gao
Cc: Bob C Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds
But that is the line Leif wants to remove... the library from the components
section. Looks just like MdePkg to me... what is different?
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Andrew Fish
> Sent: Wednesday,
Aha. So that is very different from a non NULL library when listed in the
components section. The goal is to test compile the library but not use I
think. Is there any way to do that?
Jaben
On Sep 5, 2018, at 11:21 AM, Andrew Fish
mailto:af...@apple.com>> wrote:
On Sep 5, 2018, at
But a NULL lib listed in components section shouldn’t be linked in to
anything...
Unless is listed below with the shell INF also, it just test compiles it...
Or so I thought.
On Sep 5, 2018, at 11:04 AM, Andrew Fish
mailto:af...@apple.com>> wrote:
On Sep 5, 2018, at 10:30 AM, Carsey,
How does removing a lib from the components section affect the shell binary
output?
Is the asset at compile time?
Jaben
> On Sep 5, 2018, at 10:26 AM, Leif Lindholm wrote:
>
> Hi all,
>
> (This is partly a summary of discussions that have been held on IRC
> and offline,
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, September 05, 2018 12:21 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Carsey, Jaben
> ; Zhu, Yonghong
> Subject: [patch] BaseTools/PatchCheck.py: Fix error when run with
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Feng, Bob C
> Sent: Sunday, September 02, 2018 6:06 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Zhu, Yonghong
> ; Carsey, Jaben ;
> Feng, Bob C
> Subject: [Patch] BaseTools: Involve Dec default va
Should we move that to edk2-platforms and then it can use a UDK release instead
of adding dependencies to master?
Thanks
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Kinney, Michael D
> Sent: Thursday, August 30, 2
currently created for 3 different purposes and saved once.
this makes it created once and saved and then referenced.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py
use Common.caching and auto cache properties and functions of InfBuildData
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/InfBuildData.py | 842 +---
1 file
1) use decorators
2) also change some private functions to public when all callers are
external
3) change external callers to use functions instead of directly
accessing private data.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben
use function decorators
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/GenMake.py | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/BaseTools/Source
FlexibleFieldName was never used not set.
DefinitionPosition (file and line number) are recalculated
and never used outside the function. remove the saving of the
data.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
use decorators and auto cache those that were cached manually
remove properties never used
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Common/Misc.py | 90 +---
1 file changed
1) use namedtuple instead of custom class when apropriate
2) rename collections.OrderedDict to OrderedDict since we import it already
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace
use decorators for property and automatic caching
remove circular dependency between some APIs
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 587
Update the WorkspaceAutoGen class to use caching decorators and remove
the no longer needed private variables.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Bob Feng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 69
callers from accessing "private" data and use the existing
properties
6) removed a circular dependency between APIs
Jaben Carsey (9):
BaseTools: Refactor PlatformAutoGen
BaseTools: AutoGen refactor WorkspaceAutoGen class
BaseTools: AutoGen - refactor class properties
BaseTools
This error needs the information about which DEC files were searched.
Cc: Yonghong Zhu
Cc: Liming Gao
Cc: Lee Hamel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion
IsSupportedArch and IsBinaryModule return the same value under the same
curcimstances. Remove newer one with fewer callers and send them to the
other function.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools
Reverse the checking and only assign once to each variable.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 15 ---
1 file changed, 8 insertions(+), 7
This looks like a great change. Why not delete the bat file?
Reviewed-by Jaben Carsey:
Jaben
> On Aug 28, 2018, at 8:28 AM, Liming Gao wrote:
>
> From: Dongao Guo
>
> Add NmakeSubdirs.py to replace NmakeSubdirs.bat in VS Makefile. This script
> will
> invoke nmake
101 - 200 of 1061 matches
Mail list logo
