Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-18 Thread Zeng, Star
>; Pankaj Bansal <pankaj.ban...@nxp.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH] Fix not able to change serial attributes On 09/18/17 12:22, Zeng, Star wrote: > Thanks f

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-18 Thread Laszlo Ersek
On 09/18/17 12:22, Zeng, Star wrote: > Thanks for your good comments. :) > Since there is no clear description for the behavior of Reset() :(, I prone > to align the behavior with MdeModulePkg/Bus/Pci/PciSioSerialDxe/SerialIo.c > and IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/Serial.c, that

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-18 Thread Pankaj Bansal
<ler...@redhat.com>; Heyi Guo <heyi@linaro.org>; Pankaj Bansal <pankaj.ban...@nxp.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH] Fix not able to change serial attributes Thanks for your good co

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-18 Thread Zeng, Star
Bansal <pankaj.ban...@nxp.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com> Subject: Re: [edk2] [PATCH] Fix not able to change serial attributes On 09/16/17 03:21, Zeng, Star wrote: > Pankaj, > > Thanks for the contribution. > Could you help update the

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-16 Thread Laszlo Ersek
have to stay neutral on this patch. Hopefully it won't regress anything. Thanks, Laszlo > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Pankaj > Bansal > Sent: Friday, September 15, 2017 9:14 PM > To: edk2-devel@lists.01.

Re: [edk2] [PATCH] Fix not able to change serial attributes

2017-09-15 Thread Zeng, Star
Pankaj Bansal Sent: Friday, September 15, 2017 9:14 PM To: edk2-devel@lists.01.org Cc: Pankaj Bansal <pankaj.ban...@nxp.com> Subject: [edk2] [PATCH] Fix not able to change serial attributes Issue : When try to change serial attributes using sermode command, the default values a