Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-07 Thread Laszlo Ersek
, Star; Paolo Bonzini Cc: Andrew Fish; Justen, Jordan L; edk2-de...@ml01.01.org mailto:edk2-de...@ml01.01.org; Yao, Jiewen; Chen Fan; Fan, Jeff Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support + if (IsBspExecuteDisableEnabled ()) { +CopyMem ( + (VOID

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-07 Thread Laszlo Ersek
] [PATCH] MdeModulePkg DxeIpl: Add stack NX support + if (IsBspExecuteDisableEnabled ()) { +CopyMem ( + (VOID*) StartupCode-EnableExecuteDisble, (7) No need for the (VOID*) cast. With (VOID *) cast, I met build failure below. f:\svngit\edk2gitsvn\UefiCpuPkg\CpuDxe\ApStartup.c(412

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Zeng, Star
...@ml01.01.org; Yao, Jiewen; Chen Fan; Paolo Bonzini; Fan, Jeff Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support On 08/06/15 03:08, Zeng, Star wrote: I am working on that. One thing is strange that StartupAllAPs is working well with my qemu by OVMF and even real machine. I

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Laszlo Ersek
.org; Yao, Jiewen; Chen Fan; Paolo Bonzini; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support On 08/05/15 18:18, Andrew Fish wrote: On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/31/15 14:22, Star

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Zeng, Star
Subject: RE: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, Star Sent: Friday, August 7, 2015 9:28 AM To: Laszlo Ersek; Paolo Bonzini Cc: Justen, Jordan L; edk2-de

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Zeng, Star
Hi David, -Original Message- From: David Woodhouse [mailto:dw...@infradead.org] Sent: Thursday, August 6, 2015 8:11 PM To: Zeng, Star; edk2-de...@ml01.01.org Cc: Yao, Jiewen Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support On Fri, 2015-07-31 at 20:22 +0800

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-06 Thread Laszlo Ersek
Hi Star, On 08/06/15 11:44, Zeng, Star wrote: Hi Laszlo, Could you help take a try with the attached patch on your VM before I send it for formal review? I got your patch via your first (public) message as well -- not the one reflected by the list software, but on the direct route. So, I

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Laszlo Ersek
On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is FALSE by default. Cc: Jiewen Yao jiewen@intel.com

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Andrew Fish
On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com wrote: On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Laszlo Ersek
On 08/05/15 18:18, Andrew Fish wrote: On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-05 Thread Zeng, Star
; Paolo Bonzini; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support On 08/05/15 18:18, Andrew Fish wrote: On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/31/15 14:22, Star Zeng wrote: This feature

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support On 08/04/15 10:59, Zeng, Star wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 4:34 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini Subject: Re: [edk2

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
Star, On 07/31/15 14:22, Star Zeng wrote: This feature is added for UEFI spec that says Stack may be marked as non-executable in identity mapped page tables. A PCD PcdSetNxForStack is added to turn on/off this feature, and it is FALSE by default. diff --git a/MdeModulePkg/MdeModulePkg.dec

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Laszlo Ersek
On 08/04/15 10:59, Zeng, Star wrote: -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 4:34 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support

2015-08-04 Thread Zeng, Star
-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 4:34 PM To: Zeng, Star Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support Star, On 07/31/15 14:22, Star Zeng