Re: [edk2] [PATCH] edksetup.sh: Update help section regarding positional

2018-03-15 Thread Arvind Prasanna
Hi Leif: Thank you for your feedback. I concur with you that it is a bash side effect, desired or undesired :) . I ran into this issue with positional parameters and thought a small message would be helpful to users. I will no longer pursue this issue. Thanks, Arvind. On Wed, Mar 14, 2018 at

Re: [edk2] [PATCH] edksetup.sh: Update help section regarding positional

2018-03-14 Thread Leif Lindholm
Hi Arvind, On Sat, Mar 10, 2018 at 11:11:58AM -0500, Arvind Prasanna wrote: > It is possible to source edksetup.sh from another script. If the > calling/sourcing script has any positional parameters set, those are > incorrectly accounted for in edksetup.sh while sourcing it resulting in > the the

Re: [edk2] [PATCH] edksetup.sh: Update help section regarding positional

2018-03-12 Thread Arvind Prasanna
I am not sure why git send mail did not include my patch in the chain but here is my version 2: It is possible to source edksetup.sh from another script. If the calling/sourcing script has any positional parameters set, those are incorrectly accounted for in edksetup.sh while sourcing it resulting

Re: [edk2] [PATCH] edksetup.sh: Update help section regarding positional

2018-03-12 Thread Arvind Prasanna
Hi Liming Gao: Here is a simple example that highlights the issue: $ ls -l total 8 drwxrwxr-x 49 arvind arvind 4096 Mar 12 12:35 edk2 -rwxrwxr-x 1 arvind arvind 113 Mar 12 12:37 sourcing_script.sh $ cat sourcing_script.sh #!/bin/bash echo "I have been passed $# arguments" EDK2_PATH=${PWD}/..

Re: [edk2] [PATCH] edksetup.sh: Update help section regarding positional

2018-03-12 Thread Gao, Liming
Arvind: Could you give one example to explain this usage? -- Forwarded message -- From: Arvind Prasanna mailto:arvindprasa...@gmail.com>> Date: Sat, Mar 10, 2018 at 3:18 AM Subject: [PATCH] edksetup.sh: Update help section regarding positional To: edk2-devel@lists.01.org

[edk2] [PATCH] edksetup.sh: Update help section regarding positional

2018-03-10 Thread Arvind Prasanna
It is possible to source edksetup.sh from another script. If the calling/sourcing script has any positional parameters set, those are incorrectly accounted for in edksetup.sh while sourcing it resulting in the the help section always being shown. This patch updates the help section advising the use