Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-07 Thread Ard Biesheuvel
On 7 November 2018 at 16:00, Zeng, Star wrote: > On 2018/11/6 22:37, Zeng, Star wrote: >> >> On 2018/11/6 17:49, Ard Biesheuvel wrote: >>> >>> On 31 October 2018 at 05:38, Zeng, Star wrote: Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: > > > On Tue, Oct

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-07 Thread Zeng, Star
On 2018/11/6 22:37, Zeng, Star wrote: On 2018/11/6 17:49, Ard Biesheuvel wrote: On 31 October 2018 at 05:38, Zeng, Star wrote: Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: (add back the list) Oi! Go back on

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-06 Thread Zeng, Star
On 2018/11/6 17:49, Ard Biesheuvel wrote: On 31 October 2018 at 05:38, Zeng, Star wrote: Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: (add back the list) Oi! Go back on holiday! On 30 October 2018 at 09:07,

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-06 Thread Ard Biesheuvel
On 31 October 2018 at 05:38, Zeng, Star wrote: > Good feedback. > > On 2018/10/30 20:50, Leif Lindholm wrote: >> >> On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: >>> >>> (add back the list) >> >> >> Oi! Go back on holiday! >> >>> On 30 October 2018 at 09:07, Cohen, Eugene

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-11-01 Thread Leif Lindholm
On Thu, Nov 01, 2018 at 09:12:04AM +0800, Zeng, Star wrote: > > > I believe the performance data really depends on > > > 1. How many AsyncInterruptTransfer handlers (the number of USB keyboard > > > and/or USB bluetooth keyboard?) > > > 2. Data size (for flushing data from PCI controller specific

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-31 Thread Zeng, Star
On 2018/10/31 20:08, Leif Lindholm wrote: On Wed, Oct 31, 2018 at 12:38:43PM +0800, Zeng, Star wrote: Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: (add back the list) Oi! Go back on holiday! On 30 October 2018 at

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-31 Thread Leif Lindholm
On Wed, Oct 31, 2018 at 12:38:43PM +0800, Zeng, Star wrote: > Good feedback. > > On 2018/10/30 20:50, Leif Lindholm wrote: > > On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: > > > (add back the list) > > > > Oi! Go back on holiday! > > > > > On 30 October 2018 at 09:07, Cohen,

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-30 Thread Zeng, Star
Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: (add back the list) Oi! Go back on holiday! On 30 October 2018 at 09:07, Cohen, Eugene wrote: Has this patch been tested on a system that does not have coherent DMA?

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-30 Thread Leif Lindholm
On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: > (add back the list) Oi! Go back on holiday! > On 30 October 2018 at 09:07, Cohen, Eugene wrote: > > Has this patch been tested on a system that does not have coherent DMA? > > > > It's not clear that this change would actually be

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-30 Thread Ard Biesheuvel
e talking about here? Would it be possible to improve the IOMMU handling code instead? > > > From: edk2-devel On Behalf Of Star Zeng > Sent: Friday, October 26, 2018 7:41 AM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni ; Hao Wu ; Jiewen Yao > ; Star Zeng > Subject: [edk2] [PA

[edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-26 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274 In current code, EhcMonitorAsyncRequests (timer handler) will do unmap and map operations for AsyncIntTransfers to "Flush data from PCI controller specific address to mapped system memory address". EhcMonitorAsyncRequests