Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-23 Thread Ard Biesheuvel
On Sat, 23 Feb 2019 at 11:14, Marcin Wojtas wrote: > > Hi Laszlo, > > pt., 22 lut 2019 o 21:08 Laszlo Ersek napisał(a): > > > > On 02/22/19 20:21, Ard Biesheuvel wrote: > > > On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: > > >> > > >> Reviewed-by: Liming Gao > > >> > > > > > > Incremental

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-23 Thread Marcin Wojtas
Hi Laszlo, pt., 22 lut 2019 o 21:08 Laszlo Ersek napisał(a): > > On 02/22/19 20:21, Ard Biesheuvel wrote: > > On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: > >> > >> Reviewed-by: Liming Gao > >> > > > > Incremental builds are still broken for me, even with this patch. Is > > anyone else

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-22 Thread Laszlo Ersek
On 02/22/19 20:21, Ard Biesheuvel wrote: > On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: >> >> Reviewed-by: Liming Gao >> > > Incremental builds are still broken for me, even with this patch. Is > anyone else seeing the same? I am not; but I've been using Python3.4 for a while now (it is

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-22 Thread Ard Biesheuvel
On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Incremental builds are still broken for me, even with this patch. Is anyone else seeing the same? > >-Original Message- > >From: Feng, Bob C > >Sent: Wednesday, February 20, 2019 11:22 PM > >To:

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, February 20, 2019 11:22 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch V2] BaseTool: Fixed incremental rebuild issue. > >BZ:

[edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-20 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1540 This issue in introduced by commit d943b0c339fe3d35ffdf9f580ccb7a55915c6854 To convert bytes to string, we need to use bytes.decode() instead of using str(bytes). If the source file is not a txt file, ignore that file.