Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-26 Thread Guo Heyi
Hi Laszlo, Just a note that comment [6] has not been fully applied in my RFC v4, that I didn't touch the outer ALIGN_VALUE() yet. As you said, it is an independent issue and I think it can be fixed before or after my proposed change. I can do something after Ray comments on it. Regards, Heyi

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-24 Thread Guo Heyi
On Sat, Feb 24, 2018 at 04:30:42PM +0800, Ni, Ruiyu wrote: > On 2/24/2018 11:59 AM, Guo Heyi wrote: > >On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: > >>On 2/24/2018 9:51 AM, Guo Heyi wrote: > >>>On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: > Thanks for writing up

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-24 Thread Ni, Ruiyu
On 2/24/2018 11:59 AM, Guo Heyi wrote: On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: On 2/24/2018 9:51 AM, Guo Heyi wrote: On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: Thanks for writing up the details! Comments: On 02/23/18 09:53, Heyi Guo wrote: PCI address

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-24 Thread Ard Biesheuvel
On 24 February 2018 at 03:11, Ni, Ruiyu wrote: ... >>> (6) For all of these, I believe that we have to think about the corner >>> case when the Translation value is not a multiple of (Alignment + 1). >>> >>> "Alignment" comes from the PCI BAR in question, whereas Base comes

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Guo Heyi
On Sat, Feb 24, 2018 at 11:11:35AM +0800, Ni, Ruiyu wrote: > On 2/24/2018 9:51 AM, Guo Heyi wrote: > >On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: > >>Thanks for writing up the details! > >> > >>Comments: > >> > >>On 02/23/18 09:53, Heyi Guo wrote: > >>>PCI address translation is

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Ni, Ruiyu
On 2/24/2018 9:51 AM, Guo Heyi wrote: On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: Thanks for writing up the details! Comments: On 02/23/18 09:53, Heyi Guo wrote: PCI address translation is necessary for some non-x86 platforms. On such platforms, address value (denoted as

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Guo Heyi
On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: > Thanks for writing up the details! > > Comments: > > On 02/23/18 09:53, Heyi Guo wrote: > > PCI address translation is necessary for some non-x86 platforms. On > > such platforms, address value (denoted as "device address" or

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Guo Heyi
On Fri, Feb 23, 2018 at 04:05:17PM +0100, Laszlo Ersek wrote: > Thanks for writing up the details! > > Comments: > > On 02/23/18 09:53, Heyi Guo wrote: > > PCI address translation is necessary for some non-x86 platforms. On > > such platforms, address value (denoted as "device address" or

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Laszlo Ersek
On 02/23/18 16:17, Ard Biesheuvel wrote: > On 23 February 2018 at 15:05, Laszlo Ersek wrote: >> (3) In general, the comment style requires comments like this: >> >> // >> // Add empty comment lines both before and after. >> // >> > > Quite the opposite, in fact. Search

Re: [edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Ard Biesheuvel
On 23 February 2018 at 15:05, Laszlo Ersek wrote: > Thanks for writing up the details! > > Comments: > > On 02/23/18 09:53, Heyi Guo wrote: >> PCI address translation is necessary for some non-x86 platforms. On >> such platforms, address value (denoted as "device address" or

[edk2] [RFC v3 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

2018-02-23 Thread Heyi Guo
PCI address translation is necessary for some non-x86 platforms. On such platforms, address value (denoted as "device address" or "address in PCI view") set to PCI BAR registers in configuration space might be different from the address which is used by CPU to access the registers in memory BAR or