Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-28 Thread Steele, Kelly
I have built and verified that the firmware built for Quark still POSTs. QuarkPlatformPkg Reviewed-by: Kelly Steele QuarkSocPkg Reviewed-by: Kelly Steele > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: March

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-25 Thread Yao, Jiewen
;; Yao, Jiewen <jiewen@intel.com>; Zeng, Star > <star.z...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; > Fu, Siyuan <siyuan...@intel.com>; Fan, Jeff <jeff....@intel.com>; Agyeman, > Prince <prince.agye...@intel.com>; Steele, Kelly <

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-25 Thread Laszlo Ersek
On 03/24/16 11:36, Laszlo Ersek wrote: > This series removes unused but set variables from edk2, so that the > source builds after Ard's patch (the last one in this series) lets > -Wunused-but-set-variables take effect for GCC DEBUG builds. > > I used the following method for locating these

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 24, 2016 6:37 PM To: edk2-devel-01 Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Justen, Jordan L; Andrew Fish;

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Ni, Ruiyu
Good code clean-up. For OptionRomPkg and DuetPkg, Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Thursday, March 24, 2016 6:37 PM >To: edk2-devel-01 >Cc:

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Tian, Feng
MdeModulePkg series reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 24, 2016 6:37 PM To: edk2-devel-01 Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Justen,

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Gao, Liming
Laszlo: Reviewed-by: Liming Gao for the patches in EdkCompatibilityPkg. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 24, 2016 6:37 PM To: edk2-devel-01

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Laszlo Ersek
On 03/24/16 14:35, Ard Biesheuvel wrote: > On 24 March 2016 at 11:36, Laszlo Ersek wrote: >> Maintainers are invited to exert caution while reviewing the patches. >> Namely, in a few cases, the silencing is almost certainly wrong, and >> should be replaced with proper error

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Ard Biesheuvel
On 24 March 2016 at 11:36, Laszlo Ersek wrote: > This series removes unused but set variables from edk2, so that the > source builds after Ard's patch (the last one in this series) lets > -Wunused-but-set-variables take effect for GCC DEBUG builds. > > I used the following

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-24 Thread Zeng, Star
On 2016/3/24 18:36, Laszlo Ersek wrote: This series removes unused but set variables from edk2, so that the source builds after Ard's patch (the last one in this series) lets -Wunused-but-set-variables take effect for GCC DEBUG builds. I used the following method for locating these warnings: *