[edk2] [patch] MdeModulePkg/UsbKbDxe: don't assert when the key read is invalid

The GetKeyDescriptor() may return NULL when the KeyData is invalid. For such case, we should go to error handling path rather than assert Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian ---

[edk2] [PATCH] Initialize century of RTC CMOS.

Initialize century of RTC CMOS, in case that SetTime service does not set it. --- Vlv2TbltDevicePkg/PlatformDxe/Rtc.c | 16 1 file changed, 16 insertions(+) diff --git a/Vlv2TbltDevicePkg/PlatformDxe/Rtc.c b/Vlv2TbltDevicePkg/PlatformDxe/Rtc.c index caa042f..9415b7e 100644 ---

[edk2] [PATCH v3 5/9] ArmVirtPkg/VirtFdtDxe: remove unused PL011 DT node type

This type is not used in the code, so drop the definitions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[edk2] [PATCH v3 7/9] OvmfPkg/XenIoMmioLib: add missing MemoryAllocationLib dependency to INF

XenIoMmioLib depends on MemoryAllocationLib, and uses its header, but failed to declare the dependency in its INF. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf | 1 + 1 file

[edk2] [PATCH v3 8/9] ArmVirtPkg/ArmVirtXen: move from VirtFdtDxe to new XenioFdtDxe driver

Now that the only functionality that remains in VirtFdtDxe is enumerating the respective virtual I/O buses, it no longer makes sense to have a driver that is shared between Xen domU and QEMU. So move the Xen I/O DT node handling to a new driver, and update ArmVirtXen to switch to it.

[edk2] [PATCH v3 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no longer have to rely on VirtFdtDxe to execute first and set the PL031 base address in a dynamic PCD. The only driver which [transitively] depends on this PcdPL031RtcBase PCD is EmbeddedPkg/RealTimeClockRuntimeDxe, so this

[edk2] [PATCH v3 3/9] ArmVirtPkg/VirtFdtDxe: drop RTC handling

The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base address in a dynamic PCD, so drop the handling altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.inf | 3 --

[edk2] [PATCH v3 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

We no longer care when VirtFdtDxe executes, since the dependencies are now all resolved via protocols. So drop the A PRIORI declaration. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.fdf | 4

[edk2] [PATCH v3 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

This implements a library ArmVirtPL031FdtClientLib which is intended to be incorporated into RealTimeClockRuntimeDxe via NULL library class resolution. This allows us to make RealTimeClockRuntimeDxe depend on the FDT client protocol, and discover the PL031 base address from the device tree

[edk2] [PATCH v3 9/9] ArmVirtPkg/VirtFdtDxe: remove Xenio handling and rename to VirtioFdtDxe

Now that we have moved the handling of the xen,xen DT node to XenioFdtDxe, remove its handling from VirtFdtDxe. Since the only functionality that remains is handling the virtio,mmio DT node, rename VirtFdtDxe to VirtioFdtDxe to reflect that. Also update the platforms that use this driver.

[edk2] [PATCH v3 0/9] VirtFdtDxe refactoring and removal

This v3 now fully gets rid of the VirtFdtDxe kludge, by moving its functionality to its various clients that access PCDs or protocols supplied by it. Changes since v2: - dropped the patches implementing the protocol definition, the FdtClientDxe implementation and the handling of the GIC, PSCI,

Re: [edk2] [patch] MdeModulePkg/UsbKbDxe: don't assert when the key read is invalid

On 2016/4/13 15:13, Feng Tian wrote: The GetKeyDescriptor() may return NULL when the KeyData is invalid. For such case, we should go to error handling path rather than assert Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian

[edk2] [Patch 1/3] MdeModulePkg/Ps2KeyboardDxe: Use a different FILE_GUID

Change to use a different FILE_GUID to avoid using the same GUID as the module in IntelFrameworkModulePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu ---

[edk2] [Patch 0/3] Clean up after adding ISA device drivers in MdeModulePkg

Ruiyu Ni (3): MdeModulePkg/Ps2KeyboardDxe: Use a different FILE_GUID MdeModulePkg/Ps2MouseDxe: Use a different FILE_GUID MdeModulePkg/MdeModulePkg.uni: Add PS2 related PCD description .../Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf | 2 +-

[edk2] [Patch 3/3] MdeModulePkg/MdeModulePkg.uni: Add PS2 related PCD description

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu --- MdeModulePkg/MdeModulePkg.uni | 22 ++ 1 file changed, 22 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.uni

[edk2] [Patch 2/3] MdeModulePkg/Ps2MouseDxe: Use a different FILE_GUID

Change to use a different FILE_GUID to avoid using the same GUID as the module in IntelFrameworkModulePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu ---

Re: [edk2] [PATCH v2 3/3] MdeModulePkg: Update Guid/Protocol usages in INF files.

On 2016/4/13 14:33, Liming Gao wrote: V2: Update VariableSmm inf to align the change in VariableRuntimeDxe.inf. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Star Zeng

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Zhang, Chao B > Sent: Wednesday, April 13, 2016 4:29 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin; Zhang, Chao B > Subject: [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong

Re: [edk2] [PATCH v2] ShellPkg : Cache the environment variable into memory to enhance the performance.

Reviewed-by: Ruiyu Ni >-Original Message- >From: Qiu, Shumin >Sent: Wednesday, April 13, 2016 10:05 AM >To: edk2-devel@lists.01.org >Cc: Qiu, Shumin ; Ni, Ruiyu >Subject: [PATCH v2] ShellPkg : Cache the environment variable

[edk2] [PATCH v2] PerformancePkg: Make Dp print help information with -? flag in Shell.

Since Shell supports finding help information from resource section of application image. We enhance the Dp to add help information string. After the Dp are loaded in system the help string will be stored in resource section of the application image. Difference with previous patch: Keep

[edk2] [PATCH] SecurityPkg: AuthVariableLib & SecureBootConfigDxe: Fix SecureBootEnable & PK inconsistency issue

Revert previous fix in AuthVariable driver init which breaks SecureBootEnable original behavior. Add more error handling logic in SecureBootConfigDxe to prevent wrong display info when SecureBootEnable & PK inconsistency happens. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 2/2] ArmPlatformPkg/PL031RealTimeClockLib: remove local copy of gRT pointer

Since the only reason for keeping a local copy mRT of the gRT pointer is to be able to call GetVariable/SetVariable at runtime, use the UefiRuntimeLib helpers instead, so that we can drop mRT altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2] PerformancePkg: Make Dp print help information with -? flag in Shell.

On 2016/4/13 15:29, Qiu Shumin wrote: Since Shell supports finding help information from resource section of application image. We enhance the Dp to add help information string. After the Dp are loaded in system the help string will be stored in resource section of the application image.

[edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

In image verification, if image verified pass in DBT, still need to verify if it is blocked by any other cert/cert hash from DBX. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang ---

[edk2] [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

when enable Multiple workspace and there have other option(eg: -I) before $(WORKSPACE), handleWsMacro cannot return correct which cause the ArmVirtPkg build failure. example: [BuildOptions] *_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/ArmVirtPkg/Include Cc: Liming Gao

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

On 04/13/16 10:29, Zhang, Chao B wrote: > In image verification, if image verified pass in DBT, still need to verify if > it is blocked by any other cert/cert hash from DBX. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Chao Zhang > --- >

Re: [edk2] [PATCH] SecurityPkg: AuthVariableLib & SecureBootConfigDxe: Fix SecureBootEnable & PK inconsistency issue

On 04/13/16 09:33, Zhang, Chao B wrote: > Revert previous fix in AuthVariable driver init which breaks > SecureBootEnable original behavior. In this commit message, please identify the exact patch being undone, by git commit hash. Thanks Laszlo > Add more error handling logic in >

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

On 04/13/16 05:16, Jiaxin Wu wrote: > This patch is used to update ping command options to sync > with shell2.2 Spec. > Considering the backward compatible issue, the patch keeps > ‘-_s’ command option unchanged, only add the new option '-s' > and make the old option '-_s' function same as new

Re: [edk2] [PATCH] MdeModulePkg S3SaveStateDxe: Add protocol usage for gEfiLockBoxProtocolGuid

Reviewed-by: Qiu Shumin -Original Message- From: Zeng, Star Sent: Wednesday, April 13, 2016 2:31 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Tian, Feng Subject: [PATCH] MdeModulePkg S3SaveStateDxe: Add protocol usage for gEfiLockBoxProtocolGuid Cc: Shumin Qiu

Re: [edk2] [Patch 1/3] MdeModulePkg/Ps2KeyboardDxe: Use a different FILE_GUID

Reviewed-by: Qiu Shumin -Original Message- From: Ni, Ruiyu Sent: Wednesday, April 13, 2016 2:36 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch 1/3] MdeModulePkg/Ps2KeyboardDxe: Use a different FILE_GUID Change to use a different

Re: [edk2] [Patch 2/3] MdeModulePkg/Ps2MouseDxe: Use a different FILE_GUID

Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, April 13, 2016 2:36 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [edk2] [Patch 2/3]

Re: [edk2] [Patch 3/3] MdeModulePkg/MdeModulePkg.uni: Add PS2 related PCD description

Reviewed-by: Qiu Shumin -Original Message- From: Ni, Ruiyu Sent: Wednesday, April 13, 2016 2:36 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch 3/3] MdeModulePkg/MdeModulePkg.uni: Add PS2 related PCD description Contributed-under:

[edk2] [Patch] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

when $(WORKSPACE) is used in the DSC file [BuildOptions], enable the multiple workspace, the build options is not expand to use the correct path (it still use $(WORKSPACE), even though it is in a PACKAGES_PATH folder), which would cause build failure. Cc: Liming Gao

Re: [edk2] [Patch] MdeModulePkg/Ps2Mouse: Fix potential buffer overflow issue.

Reviewed-by: Qiu Shumin -Original Message- From: Ni, Ruiyu Sent: Wednesday, April 13, 2016 2:14 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch] MdeModulePkg/Ps2Mouse: Fix potential buffer overflow issue. Count is initially 1 but is

[edk2] [PATCH v2 3/3] MdeModulePkg: Update Guid/Protocol usages in INF files.

V2: Update VariableSmm inf to align the change in VariableRuntimeDxe.inf. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../Library/VarCheckUefiLib/VarCheckUefiLib.inf| 78

[edk2] [Patch] MdeModulePkg/Ps2Mouse: Fix potential buffer overflow issue.

Count is initially 1 but is assigned to 2 in case PS2_READ_DATA_BYTE. Though the state machine doesn't go back from PS2_READ_DATA_BYTE to PS2_READ_BYTE_ONE (not a true bug), force assign Count to 1 to avoid potential buffer overflow issue. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH] MdeModulePkg S3SaveStateDxe: Add protocol usage for gEfiLockBoxProtocolGuid

Cc: Shumin Qiu Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [edk2] [PATCH] ArmVirtPkg/RelocatableVirtHelper: use correct FindMemNode argument order

On 04/13/16 13:49, Ard Biesheuvel wrote: > Commit 03b6bed17ea6 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB > memory node retrieval in C") introduced a FindMemNode () C function > that takes pointers to system memory base and size as arguments, but the > calling code passes them in the wrong

Re: [edk2] [PATCH v3 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 04/13/16 10:02, Ard Biesheuvel wrote: > This implements a library ArmVirtPL031FdtClientLib which is intended to > be incorporated into RealTimeClockRuntimeDxe via NULL library class > resolution. This allows us to make RealTimeClockRuntimeDxe depend on the > FDT client protocol, and discover

Re: [edk2] [PATCH v3 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 10:02, Ard Biesheuvel wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively] depends on this PcdPL031RtcBase

Re: [edk2] [PATCH v3 3/9] ArmVirtPkg/VirtFdtDxe: drop RTC handling

On 04/13/16 10:02, Ard Biesheuvel wrote: > The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base > address in a dynamic PCD, so drop the handling altogether. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel >

Re: [edk2] [PATCH v3 5/9] ArmVirtPkg/VirtFdtDxe: remove unused PL011 DT node type

On 04/13/16 10:02, Ard Biesheuvel wrote: > This type is not used in the code, so drop the definitions. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 2 -- > 1 file changed, 2

Re: [edk2] [PATCH v3 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

On 04/13/16 10:02, Ard Biesheuvel wrote: > We no longer care when VirtFdtDxe executes, since the dependencies are now > all resolved via protocols. So drop the A PRIORI declaration. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 04/13/16 04:33, Dong, Eric wrote: >> On 05/04/16 03:10, Dong, Eric wrote: On a separate but related note: The ConfigHdr portion of Request and Response seems to contain absolutely zero information by the time it reaches EFI_HII_CONFIG_ACCESS_PROTOCOL. As far as I can tell, it is

[edk2] [PATCH] ArmVirtPkg/RelocatableVirtHelper: use correct FindMemNode argument order

Commit 03b6bed17ea6 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB memory node retrieval in C") introduced a FindMemNode () C function that takes pointers to system memory base and size as arguments, but the calling code passes them in the wrong order. Contributed-under: TianoCore Contribution

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 13/04/16 03:33, Dong, Eric wrote: Does the ConfigHdr have any meaning for EFI_HII_CONFIG_ACCESS_PROTOCOL, or is it just a pointless blob of noise? The GUID/NAME value in the ConfigHdr is get from the storage used in this driver. If one driver has more than one storage, the Guid + Name

[edk2] [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

Allow EfiVarStore to get from Hii Driver, and enhance code logic in MergeDefaultString function to get a full AltCfgResp. The logic in function MergeDefaultString after enhancement: (1) If there are no in AltCfgResp, merge the in DefaultAltCfgResp to AltCfgResp. (2) If there are in AltCfgResp,

Re: [edk2] [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Support EfiVarStore to get AltCfg from Driver

On 04/13/16 14:39, Dandan Bi wrote: > Allow EfiVarStore to get from Hii Driver, and enhance code logic > in MergeDefaultString function to get a full AltCfgResp. > The logic in function MergeDefaultString after enhancement: > (1) If there are no in AltCfgResp, merge the in > DefaultAltCfgResp

Re: [edk2] [PATCH v3 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

On 04/13/16 14:34, Laszlo Ersek wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> We no longer care when VirtFdtDxe executes, since the dependencies are now >> all resolved via protocols. So drop the A PRIORI declaration. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >>

Re: [edk2] [PATCH v3 7/9] OvmfPkg/XenIoMmioLib: add missing MemoryAllocationLib dependency to INF

On 04/13/16 10:02, Ard Biesheuvel wrote: > XenIoMmioLib depends on MemoryAllocationLib, and uses its header, but > failed to declare the dependency in its INF. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v3 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 13 April 2016 at 14:16, Laszlo Ersek wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> This implements a library ArmVirtPL031FdtClientLib which is intended to >> be incorporated into RealTimeClockRuntimeDxe via NULL library class >> resolution. This allows us to make

Re: [edk2] [PATCH v3 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 14:21, Laszlo Ersek wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic PCD. >>

Re: [edk2] [PATCH v4 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 04/13/16 16:32, Ard Biesheuvel wrote: > This implements a library ArmVirtPL031FdtClientLib which is intended to > be incorporated into RealTimeClockRuntimeDxe via NULL library class > resolution. This allows us to make RealTimeClockRuntimeDxe depend on the > FDT client protocol, and discover

Re: [edk2] [PATCH v4 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 13 April 2016 at 16:51, Laszlo Ersek wrote: > On 04/13/16 16:32, Ard Biesheuvel wrote: >> This implements a library ArmVirtPL031FdtClientLib which is intended to >> be incorporated into RealTimeClockRuntimeDxe via NULL library class >> resolution. This allows us to make

Re: [edk2] HII incompatibility between edk2 and iPXE?

> On Apr 13, 2016, at 3:51 AM, Michael Brown wrote: > > On 13/04/16 03:33, Dong, Eric wrote: > Does the ConfigHdr have any meaning for EFI_HII_CONFIG_ACCESS_PROTOCOL, > or is it just a pointless blob of noise? The GUID/NAME value in the ConfigHdr is get from

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:07, Ard Biesheuvel wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively] depends on this PcdPL031RtcBase

Re: [edk2] [PATCH] ArmVirtPkg/RelocatableVirtHelper: use correct FindMemNode argument order

On 13 April 2016 at 14:14, Laszlo Ersek wrote: > On 04/13/16 13:49, Ard Biesheuvel wrote: >> Commit 03b6bed17ea6 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB >> memory node retrieval in C") introduced a FindMemNode () C function >> that takes pointers to system memory base

Re: [edk2] [PATCH v3 9/9] ArmVirtPkg/VirtFdtDxe: remove Xenio handling and rename to VirtioFdtDxe

On 13 April 2016 at 16:18, Laszlo Ersek wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> Now that we have moved the handling of the xen,xen DT node to XenioFdtDxe, >> remove its handling from VirtFdtDxe. Since the only functionality that >> remains is handling the

[edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no longer have to rely on VirtFdtDxe to execute first and set the PL031 base address in a dynamic PCD. The only driver which [transitively] depends on this PcdPL031RtcBase PCD is EmbeddedPkg/RealTimeClockRuntimeDxe, so this

[edk2] [PATCH v4 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

We no longer care when VirtFdtDxe executes, since - the driver sets no dynamic PCDs any longer, and - the only remaining functionality centers on VirtioMmioInstallDevice() and XenIoMmioInstall() function calls and FDT configuration table installation. So drop the A PRIORI declaration.

[edk2] [PATCH v4 3/9] ArmVirtPkg/VirtFdtDxe: drop RTC handling

The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base address in a dynamic PCD, so drop the handling altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek ---

[edk2] [PATCH v4 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

This implements a library ArmVirtPL031FdtClientLib which is intended to be incorporated into RealTimeClockRuntimeDxe via NULL library class resolution. This allows us to make RealTimeClockRuntimeDxe depend on the FDT client protocol, and discover the PL031 base address from the device tree

[edk2] [PATCH v4 6/9] ArmVirtPkg/VirtFdtDxe: move FDT config table installation to FdtClientDxe

Now that FdtClientDxe is the core driver that takes ownership of the host supplied FDT, it makes sense to put it in charge of installing the FDT configuration table as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v4 8/9] ArmVirtPkg/ArmVirtXen: move from VirtFdtDxe to new XenioFdtDxe driver

Now that the only functionality that remains in VirtFdtDxe is enumerating the respective virtual I/O buses, it no longer makes sense to have a driver that is shared between Xen domU and QEMU. So move the Xen I/O DT node handling to a new driver, and update ArmVirtXen to switch to it.

[edk2] [PATCH v4 5/9] ArmVirtPkg/VirtFdtDxe: remove unused PL011 DT node type

This type is not used in the code, so drop the definitions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek --- ArmVirtPkg/VirtFdtDxe/VirtFdtDxe.c | 2 -- 1 file changed, 2

[edk2] [PATCH v4 0/9] VirtFdtDxe refactoring and removal

This v4 now fully gets rid of the VirtFdtDxe kludge, by moving its functionality to its various clients that access PCDs or protocols supplied by it. Changes since v3: - incorporated Laszlo's feedback (#1, #2, #4, #8, #9) - added Laszlo's R-b (#3, #4, #5, #6, #7, #8, #9) Changes since v2: -

Re: [edk2] [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Wednesday, April 13, 2016 5:48 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

Re: [edk2] [PATCH v3 4/9] ArmVirtPkg: get rid of A PRIORI DXE declarations for VirtFdtDxe

On 13 April 2016 at 14:34, Laszlo Ersek wrote: > On 04/13/16 10:02, Ard Biesheuvel wrote: >> We no longer care when VirtFdtDxe executes, since the dependencies are now >> all resolved via protocols. So drop the A PRIORI declaration. >> >> Contributed-under: TianoCore

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 17:07, Ard Biesheuvel wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively]

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:13, Ard Biesheuvel wrote: > On 13 April 2016 at 17:07, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic

Re: [edk2] [PATCH v3 8/9] ArmVirtPkg/ArmVirtXen: move from VirtFdtDxe to new XenioFdtDxe driver

On 04/13/16 10:02, Ard Biesheuvel wrote: > Now that the only functionality that remains in VirtFdtDxe is enumerating > the respective virtual I/O buses, it no longer makes sense to have a driver > that is shared between Xen domU and QEMU. So move the Xen I/O DT node > handling to a new driver, and

Re: [edk2] [PATCH] ArmVirtPkg/RelocatableVirtHelper: use correct FindMemNode argument order

On 04/13/16 15:27, Ard Biesheuvel wrote: > On 13 April 2016 at 14:14, Laszlo Ersek wrote: >> On 04/13/16 13:49, Ard Biesheuvel wrote: >>> Commit 03b6bed17ea6 ArmVirtPkg/XenRelocatablePlatformLib: rewrite DTB >>> memory node retrieval in C") introduced a FindMemNode () C

Re: [edk2] [PATCH v3 9/9] ArmVirtPkg/VirtFdtDxe: remove Xenio handling and rename to VirtioFdtDxe

On 04/13/16 10:02, Ard Biesheuvel wrote: > Now that we have moved the handling of the xen,xen DT node to XenioFdtDxe, > remove its handling from VirtFdtDxe. Since the only functionality that > remains is handling the virtio,mmio DT node, rename VirtFdtDxe to > VirtioFdtDxe to reflect that. Also

Re: [edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 16:54, Ard Biesheuvel wrote: > On 13 April 2016 at 16:53, Laszlo Ersek wrote: >> On 04/13/16 16:32, Ard Biesheuvel wrote: >>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>> longer have to rely on VirtFdtDxe to execute first and set

[edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no longer have to rely on VirtFdtDxe to execute first and set the PL031 base address in a dynamic PCD. The only driver which [transitively] depends on this PcdPL031RtcBase PCD is EmbeddedPkg/RealTimeClockRuntimeDxe, so this

Re: [edk2] [PATCH v3 1/9] ArmVirtPkg: implement ArmVirtPL031FdtClientLib

On 04/13/16 15:18, Ard Biesheuvel wrote: > On 13 April 2016 at 14:16, Laszlo Ersek wrote: >> On 04/13/16 10:02, Ard Biesheuvel wrote: >>> This implements a library ArmVirtPL031FdtClientLib which is intended to >>> be incorporated into RealTimeClockRuntimeDxe via NULL library

Re: [edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 16:32, Ard Biesheuvel wrote: > This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no > longer have to rely on VirtFdtDxe to execute first and set the PL031 base > address in a dynamic PCD. > > The only driver which [transitively] depends on this PcdPL031RtcBase

Re: [edk2] [PATCH v4 2/9] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 16:53, Laszlo Ersek wrote: > On 04/13/16 16:32, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic PCD. >>

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 17:20, Laszlo Ersek wrote: > On 04/13/16 17:13, Ard Biesheuvel wrote: >> On 13 April 2016 at 17:07, Ard Biesheuvel wrote: >>> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >>> longer have to rely on

[edk2] [Patch 0/2] BaseTools: Update tool to handle PE image with .code section only

rebase the image which only has .code section, but no other section, the tool return error. this patch fix this bug to support it. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu Yonghong Zhu (2):

[edk2] [Patch 1/2] BaseTools/GenFw: Update to handle PE image with .code section only

current GenFw rebase the image which only has .code section, but no other section, the tool return error. this patch fix this bug to support it. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch 2/2] BaseTools/VolInfo: Update to handle PE image with .code section only

rebase the image which only has .code section, but no other section, the tool return error. this patch fix this bug to support it. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

Hi David and Laszlo, This patch is not focused on the discussion about the multiple NICs existed case, just use to update the ping command option. So, please don't misunderstand. For the discussion in , If there are multiple NICs

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 13 April 2016 at 17:40, Laszlo Ersek wrote: > On 04/13/16 17:34, Ard Biesheuvel wrote: >> On 13 April 2016 at 17:29, Laszlo Ersek wrote: >>> On 04/13/16 17:17, Laszlo Ersek wrote: On 04/13/16 17:07, Ard Biesheuvel wrote: > This moves QEMU based

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

Patch looks good, but let's make sure to give Bhupesh some time to test. Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, April 13, 2016 3:30 AM > To: Wu, Jiaxin ; Bhupesh

Re: [edk2] [PATCH v2] PerformancePkg: Make Dp print help information with -? flag in Shell.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zeng, Star > Sent: Wednesday, April 13, 2016 1:07 AM > To: Qiu, Shumin ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:17, Laszlo Ersek wrote: > On 04/13/16 17:07, Ard Biesheuvel wrote: >> This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no >> longer have to rely on VirtFdtDxe to execute first and set the PL031 base >> address in a dynamic PCD. >> >> The only driver which

Re: [edk2] [PATCH v4a] ArmVirtPkg: move QEMU based platforms to ArmVirtPL031FdtClientLib

On 04/13/16 17:34, Ard Biesheuvel wrote: > On 13 April 2016 at 17:29, Laszlo Ersek wrote: >> On 04/13/16 17:17, Laszlo Ersek wrote: >>> On 04/13/16 17:07, Ard Biesheuvel wrote: This moves QEMU based platforms to ArmVirtPL031FdtClientLib, so that we no longer have to

Re: [edk2] HII incompatibility between edk2 and iPXE?

Michael: UEFI spec Chapter 31 Human Interface Infrastructure Overview and Chapter section 2 Design discussion and Chapter 33 HII Configuration Processing and Browser Protocol section 2 Configuration Strings gives the details on UEFI HII design and Configuration string format. One HII package

Re: [edk2] [PATCH v2] ShellPkg : Cache the environment variable into memory to enhance the performance.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, April 13, 2016 12:16 AM > To: Qiu, Shumin ; edk2-devel@lists.01.org > Subject: Re: [edk2]

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

On 04/12/2016 09:16 PM, Jiaxin Wu wrote: This patch is used to update ping command options to sync with shell2.2 Spec. Considering the backward compatible issue, the patch keeps ‘-_s’ command option unchanged, only add the new option '-s' and make the old option '-_s' function same as new one.

Re: [edk2] [patch 0/3] Fix some bugs found in EDKII SD/MMC stack

Hi Feng, For patch 2, please update the copyright header. Except that, the series looks good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Wednesday, April 13, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Wu,

[edk2] Tianocore Staging Process

You can find the final revision of the staging process is now live. https://github.com/tianocore/edk2-staging README.md is updated with the process description, supporting links are updated throughout the site. If you find something is off, don't hesitate to let me know.

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

Laszlo: There is no CVE number. The issue was exposed during internal code review. The code has been existing since 11/4/2014. Thanks & Best regards Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 13, 2016 6:22 PM To: Zhang,

[edk2] [PATCH v2] Ensure write-through behavior for NVMe devices

After further investigation of SCSI & NVMe specs, we found that: For SCSI devices, there is a 'DPOFUA' bit which is returned in the DEVICE-SPECIFIC PARAMETER field in response to a MODE SENSE command. This bit tells whether a SCSI device supports the DPO & FUA bits being set in the CDBs of SCSI

[edk2] [PATCH v2] MdeModulePkg NvmExpressDxe: Ensure write-through for NVMe write command

Set the Force Unit Access (FUA) bit in NVMe Write - Command Dword 12 to ensure write-through behavior. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c | 5 - 1 file changed, 4

Re: [edk2] [PATCH] SecurityPkg: AuthVariableLib & SecureBootConfigDxe: Fix SecureBootEnable & PK inconsistency issue

Laszlo: Thanks for your comment. I will update check-in log with commit hash of the patch undone. Thanks & Best regards Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, April 13, 2016 6:25 PM To: Zhang, Chao B Cc:

Re: [edk2] [PATCH v2] MdeModulePkg NvmExpressDxe: Ensure write-through for NVMe write command

Looks good to me Reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Thursday, April 14, 2016 9:14 AM To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH v2] MdeModulePkg NvmExpressDxe: Ensure