Re: [edk2] [PATCH 4/4] Vlv2TbltDevicePkg: Add RAW file type to Rule.Common.SEC.BINARY

2016-08-12 Thread Wei, David
Reviewed-by: David Wei Thanks, David Wei -Original Message- From: Gary Lin [mailto:g...@suse.com] Sent: Thursday, August 11, 2016 4:38 PM To: edk2-devel@lists.01.org Cc: Wei, David Subject: [PATCH 4/4] Vlv2TbltDevicePkg: Add RAW file type to Rule.Com

Re: [edk2] [PATCH 1/3] ArmPkg/CompilerIntrinsicsLib: replace memcpy and memset with C code

2016-08-12 Thread Ard Biesheuvel
On 12 August 2016 at 01:04, Andrew Fish wrote: > >> On Aug 11, 2016, at 2:50 PM, Cohen, Eugene wrote: >> Why does memcpy performance matter? In addition to the overall >>> memcpy stuff scattered around C code we have an instance that is >>> particularly sensitive to memcpy performance. For

Re: [edk2] IP4 Config Troubles with DHCP

2016-08-12 Thread Wu, Jiaxin
Eugene, I can reproduce the issue now. And root cause as below: #1. Set policy to DHCP. #2. If DHCP process is not complete yet, then run one App to invoke the UDP4 Configure with "UseDefaultAddress = TRUE" (loop to keep calling Udp4->Configure until Ip4Mode.IsConfigured changes to TRUE) #3.

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Get more accurate TSC Frequency

2016-08-12 Thread Paolo Bonzini
On 11/08/2016 04:37, Star Zeng wrote: > Minimize the code overhead between the two TSC reads by adding > new internal API to calculate TSC Frequency instead of reusing > MicroSecondDelay (). > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Paul A Lohr > Contributed-under: TianoCore Contributio

Re: [edk2] [PATCH] BaseTools/Source/C/GenFv/GenFvInternalLib.c

2016-08-12 Thread Gao, Liming
Duran: Reusing FvForceRebase flag is a good idea to resolve this issue. I agree your change. Reviewed-by: Liming Gao Thank Liming > -Original Message- > From: Leo Duran [mailto:leo.du...@amd.com] > Sent: Thursday, August 11, 2016 11:23 PM > To: edk2-devel@lists.01.org > Cc: Zhu, Yongho

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Get more accurate TSC Frequency

2016-08-12 Thread Zeng, Star
On 2016/8/12 16:31, Paolo Bonzini wrote: On 11/08/2016 04:37, Star Zeng wrote: Minimize the code overhead between the two TSC reads by adding new internal API to calculate TSC Frequency instead of reusing MicroSecondDelay (). Cc: Michael D Kinney Cc: Liming Gao Cc: Paul A Lohr Contributed-

Re: [edk2] DHCP Automatic Configure at Driver Connect

2016-08-12 Thread Cohen, Eugene
Jiaxin, > > The issue is not just a performance issue around DHCP timing. Even > > with a static IP address set the fact that the network interface comes > > "up" at each boot is problematic because our requirement is only to > > enable the network interface when directed to by an application. >

Re: [edk2] IP4 Config Troubles with DHCP

2016-08-12 Thread Cohen, Eugene
> Eugene, > > I can reproduce the issue now. And root cause as below: > > #1. Set policy to DHCP. > #2. If DHCP process is not complete yet, then run one App to invoke the > UDP4 Configure with "UseDefaultAddress = TRUE" (loop to keep calling > Udp4->Configure until Ip4Mode.IsConfigured changes t

Re: [edk2] Double or floating point on edk2 ?

2016-08-12 Thread Michael Zimmermann
sry for bringing up this ancient thread but I got a question about this: shouldn't soft-float be 100% safe because it's a software implementations and thus never throw exceptions? Thanks Michael On Tue, Dec 8, 2015 at 6:28 PM, Shubha Ramani wrote: > Thanks for your well-thought out and detailed

[edk2] [RFC] MdeModulePkg: ARM/AARCH64 requirements added to .dsc

2016-08-12 Thread Leif Lindholm
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- This is not a proposed change, but rather a demonstration: When trying to build HelloWorld standalone for ARM/AARCH64, with a command line like build -a AARCH64 -t GCC5 -p MdeModulePkg/MdeModulePkg.dsc \ -

Re: [edk2] [RFC] MdeModulePkg: ARM/AARCH64 requirements added to .dsc

2016-08-12 Thread Andrew Fish
> On Aug 12, 2016, at 10:11 AM, Leif Lindholm wrote: > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm > --- > > This is not a proposed change, but rather a demonstration: > When trying to build HelloWorld standalone for ARM/AARCH64, > with a command li

Re: [edk2] [PATCH] PcAtChipsetPkg AcpiTimerLib: Get more accurate TSC Frequency

2016-08-12 Thread Kinney, Michael D
Paolo, That is a good idea to find factors of ACPI_TIMER_FREQUENCY 3579545 Hz and find a value that is close to 100 uS for calibration. The pair you found 343 * 10436 = 3579548 Hz. If we look at frequencies lower and higher than ACPI_TIMER_FREQUENCY, the value 3579543 has many more factors and

[edk2] [MdeModulePkg][PeiCore] I seemed to have crashed the PEI Core by grabbing memory from PeiTemporaryRamBase?

2016-08-12 Thread Andrew Fish
I grabbed some memory between SEC and the PEI Core by adjusting SecCoreData-> PeiTemporaryRamBase and SecCoreData-> PeiTemporaryRamSize. When looking at the code I don't really understand the logic of the algorithm? So maybe I'm doing something wrong. This adjustment does not seem right to me?

Re: [edk2] [MdeModulePkg][PeiCore] I seemed to have crashed the PEI Core by grabbing memory from PeiTemporaryRamBase?

2016-08-12 Thread Marvin H?user
Hello Andrew, Unfortunately I cannot test anything right now and I don't have a whole lot of knowledge in this area, though I might have a hint for you. While PpiList is equal to the original TempRam base, the TempRam based passed to PEI is equal to the original TempRam base + the size of the P

[edk2] [PATCH v1 1/1] MdeModulePkg/PeiCore: Fix ConverSinglePpiPointer () typo.

2016-08-12 Thread Marvin Häuser
Rename ConverSinglePpiPointer () to ConvertSinglePpiPointer (). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- MdeModulePkg/Core/Pei/Ppi/Ppi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Core/Pei/Ppi/Ppi.c b/

[edk2] [MdeModulePkg/PeiCore] How is Data being NULL on entry ensured?

2016-08-12 Thread Marvin H?user
Dear list subscribers, I have just been looking around the PeiCore code and wondered, how it is ensured, that the third ("Data") argument of the entry point is NULL on the first run. EFI_PEI_CORE_ENTRY_POINT only has two arguments and hence most SEC implementations, including MdeModulePkg/SecCo

Re: [edk2] DHCP Automatic Configure at Driver Connect

2016-08-12 Thread Wu, Jiaxin
> Jiaxin, > > > > The issue is not just a performance issue around DHCP timing. Even > > > with a static IP address set the fact that the network interface > > > comes "up" at each boot is problematic because our requirement is > > > only to enable the network interface when directed to by an app

Re: [edk2] [MdeModulePkg/PeiCore] How is Data being NULL on entry ensured?

2016-08-12 Thread Andrew Fish
> On Aug 12, 2016, at 7:01 PM, Marvin H?user wrote: > > Dear list subscribers, > > I have just been looking around the PeiCore code and wondered, how it is > ensured, that the third ("Data") argument of the entry point is NULL on the > first run. > EFI_PEI_CORE_ENTRY_POINT only has two argume

Re: [edk2] [MdeModulePkg/PeiCore] How is Data being NULL on entry ensured?

2016-08-12 Thread Marvin H?user
Hey Andrew, Thank you very much! I suppose I was misguided by the ENTRY_POINT property being PeiCore in the build file. Regards, Marvin. > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Saturday, August 13, 2016 4:47 AM > To: Marvin H?user > Cc: edk2-devel@