Re: [edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-02 Thread Amit kumar
Thank you Michael and Andrew Regards Amit From: Kinney, Michael D Sent: Tuesday, May 2, 2017 10:33:45 PM To: Andrew Fish; Amit kumar; Kinney, Michael D Cc: edk2-devel@lists.01.org Subject: RE: [edk2] Accessing AVX/AVX2 instruction

[edk2] [PATCH] ArmVirtPkg: include XenPlatformHasAcpiDtDxe and PlatformHasAcpiDtDxe in the 32-bit builds too

2017-05-02 Thread Nerijus Baliūnas
Please see https://bugzilla.tianocore.org/show_bug.cgi?id=524 why it is needed. With this patch my arm uefi VM boots. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nerijus Baliūnas --- diff -ur edk2.git.orig/ArmVirtPkg/ArmVirtQemu.dsc

Re: [edk2] [PATCH 2/3] OvmfPkg: introduce FD_SIZE_4MB (mainly) for Windows HCK

2017-05-02 Thread Jordan Justen
On 2017-05-02 07:39:04, Laszlo Ersek wrote: > > I wouldn't mind if we made more room for the varstore in the 2MB build, > even at the expense of FVMAIN_COMPACT, if we also kept the current 2MB > build the default, so that the "new" (incompatible) 2MB build doesn't > come as a surprise to

[edk2] SMRAM sizes on large hosts

2017-05-02 Thread Laszlo Ersek
Hi All, in your experience, how much SMRAM do "big hosts" provide? (Machines that have, say, ~300 CPU cores.) With QEMU's Q35 board, which provides 8MB of SMRAM (TSEG), we're hitting various out-of-SMRAM conditions with OVMF at around 230-240 VCPUs. We'd like to go to a higher VCPU count than

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Duran, Leo
Hi Yao, Would it make sense to have a default protocol producer driver that provides pass-thru functionality? This way consumers of the protocol may add a dependency on it, ensuring that the protocol provider always run first. (In the SEV sample driver we run first because we added the driver

Re: [edk2] [PATCH 2/3] OvmfPkg: introduce FD_SIZE_4MB (mainly) for Windows HCK

2017-05-02 Thread Laszlo Ersek
On 05/02/17 20:22, Jordan Justen wrote: > On 2017-05-02 07:39:04, Laszlo Ersek wrote: >> >> I wouldn't mind if we made more room for the varstore in the 2MB build, >> even at the expense of FVMAIN_COMPACT, if we also kept the current 2MB >> build the default, so that the "new" (incompatible) 2MB

[edk2] Does edk2 supports RFC standards 3132?

2017-05-02 Thread Karunakar P
Hi all, Does edk2 supports RFC 3132? I can find DHCP RFCs supported info in Dhcp4Impl.h, it doesn't have RFC 3132. Does it mean edk2 don't support it yet? Do edk2 have plans to support it? /** @file EFI DHCP protocol implementation. RFCs supported are: RFC 2131: Dynamic Host

Re: [edk2] [PATCH 2/3] OvmfPkg: introduce FD_SIZE_4MB (mainly) for Windows HCK

2017-05-02 Thread Jordan Justen
On 2017-05-02 12:31:39, Laszlo Ersek wrote: > On 05/02/17 20:22, Jordan Justen wrote: > > On 2017-05-02 07:39:04, Laszlo Ersek wrote: > >> > >> I wouldn't mind if we made more room for the varstore in the 2MB build, > >> even at the expense of FVMAIN_COMPACT, if we also kept the current 2MB > >>

Re: [edk2] UDK2017 pre-release info now on wiki

2017-05-02 Thread Kinney, Michael D
Brian, Thanks for the summary of features in UDK 2017. I want to encourage everyone in the EDK II community to checkout the UDK2017 branch and test their platforms, drivers, applications, and operating systems. https://github.com/tianocore/edk2/tree/UDK2017 If you see issues, please enter

Re: [edk2] [PATCH 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

2017-05-02 Thread Ard Biesheuvel
Hello Jiewen, On 29 April 2017 at 14:48, Jiewen Yao wrote: > This protocol is to abstract DMA access from IOMMU. > 1) Intel "DMAR" ACPI table. > 2) AMD "IVRS" ACPI table > 3) ARM "IORT" ACPI table. > > There might be multiple IOMMU engines on one platform. > For example,

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Ard Biesheuvel
On 29 April 2017 at 14:48, Jiewen Yao wrote: > V4 == > Refine the EDKII_IOMMU_PROTOCOL. > > 1) Add AllocateBuffer/FreeBuffer/Map/Unmap() API. > They are similar to DmaLib in EmbeddedPkg and > similar to the previous BmDmaLib (by

Re: [edk2] [PATCH] CorebootModulePkg, EmulatorPkg, Vlv2TbltDevicePkg: .inf whitespace fixes

2017-05-02 Thread Wei, David
Only one comment: Please also update the year of copyright to 2017, such as changing "Copyright (c) 2006 - 2014" to "Copyright (c) 2006 - 2017". Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Leif Lindholm

[edk2] [RFC PATCH] ArmPkg: implement generic SMMU driver to remap DRAM for 32-bit PCI DMA

2017-05-02 Thread Ard Biesheuvel
This implements a driver that uses any SMMU compatible with the generic ARM SMMU architecture to remap the lowest 4 GB of DRAM in a way that makes it accessible to PCI masters that are only 32-bit DMA capable. Note that this driver goes a bit beyond what is strictly necessary to support 32-bit

[edk2] CFP: KVM Forum 2017

2017-05-02 Thread Paolo Bonzini
KVM Forum 2017: Call For Participation October 25-27, 2017 - Hilton Prague - Prague, Czech Republic (All submissions must be received before midnight June 15, 2017) =

[edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix memory leak

2017-05-02 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Signed-off-by: Chen A Chen Cc: Jaben Carsey --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +++- 1 file changed, 3

Re: [edk2] [PATCH 3/3] MdeModulePkg/PciBus: Add IOMMU support.

2017-05-02 Thread Ard Biesheuvel
On 29 April 2017 at 14:48, Jiewen Yao wrote: > If IOMMU protocol is installed, PciBus need call IOMMU > to set access attribute for the PCI device in Map/Ummap. > > Only after the access attribute is set, the PCI device can > access the DMA memory. > > Cc: Ruiyu Ni

Re: [edk2] [PATCH 3/3] MdeModulePkg/PciBus: Add IOMMU support.

2017-05-02 Thread Yao, Jiewen
Thank you. My mistake. It seems my test platform does not have such capability. It is fixed in V5. Thank you Yao Jiewen From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, May 2, 2017 6:04 PM To: Yao, Jiewen Cc: edk2-devel@lists.01.org; Ni, Ruiyu

Re: [edk2] [PATCH 1/3] MdeModulePkg/Include: Add IOMMU protocol definition.

2017-05-02 Thread Yao, Jiewen
Thanks, Ard. It is a good open that if we really need both SetAttribute and SetMappingAttribute. Looking at code again, I prefer to remove SetAttribute(). I do not suggest we define MapInfo, because I want to make it DMA engine implementation choice. All we want is just to set an access

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Yao, Jiewen
That is awesome! I am glad to see a real example - GenericSmmuStaticPciDmaDxe Let's continue the discussion on if we can make it simpler. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, May 2, 2017 6:15 PM To: Yao,

Re: [edk2] SMRAM sizes on large hosts

2017-05-02 Thread Kinney, Michael D
Laszlo, Is it possible to add more TSEG sizes to the Q35 board? There may be things we can do to reduce the per CPU SMRAM overhead, but those will likely take some time, be more complex, and require significant validation. And...we may run into the same issue again if there continues to be

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Yao, Jiewen
Awesome. Thank you! From: Brijesh Singh [mailto:brijesh.si...@amd.com] Sent: Wednesday, May 3, 2017 5:09 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: brijesh.si...@amd.com; Ni, Ruiyu ; Leo Duran ; Ard Biesheuvel

Re: [edk2] SMRAM sizes on large hosts

2017-05-02 Thread Yao, Jiewen
Yes, increasing TSEG might be an easy way. I have seen a physical board using 16M TSEG or even 32M TSEG on a large memory and many core system. Thank you Yao Jiewen From: Kinney, Michael D Sent: Wednesday, May 3, 2017 4:49 AM To: Laszlo Ersek ; Fan, Jeff

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Yao, Jiewen
It is a good question. I did consider that before. In our scenario, we need support VTd dynamic opt-in/opt-out. I hope to keep all these logic inside of VTd driver. If we need a default path-through driver, a platform need more complex logic to decide when to run the default pass-through and

Re: [edk2] [RFC] [PATCH V4 0/3] Add IOMMU support.

2017-05-02 Thread Brijesh Singh
Hi Yao, On 04/29/2017 08:51 AM, Jiewen Yao wrote: V4 == Refine the EDKII_IOMMU_PROTOCOL. 1) Add AllocateBuffer/FreeBuffer/Map/Unmap() API. They are similar to DmaLib in EmbeddedPkg and similar to the previous BmDmaLib (by leo.du...@amd.com). These APIs are

[edk2] [Patch] Maintainers.txt: Update maintainers for MdeModulePkg

2017-05-02 Thread Eric Dong
Cc: Feng Tian Cc: Zeng Star Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt

Re: [edk2] [Patch] Maintainers.txt: Update maintainers for MdeModulePkg

2017-05-02 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Dong, Eric Sent: Wednesday, May 3, 2017 10:23 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [Patch] Maintainers.txt: Update maintainers for

Re: [edk2] [patch] NetworkPkg: Fix issue the iSCSI client can not send reset packet.

2017-05-02 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, April 28, 2017 2:42 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] [patch] MdeModulePkg: Fix issue the iSCSI client can not send reset packet correctly.

2017-05-02 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, April 28, 2017 2:41 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] [Patch] NetworkPkg: Fix PXEv6 boot failure when DhcpBinl offer received.

2017-05-02 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Thursday, April 27, 2017 9:51 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: [Patch] NetworkPkg: Fix PXEv6 boot failure when DhcpBinl offer received. In case of the DHCP

Re: [edk2] [Patch] Maintainers.txt: Update maintainers for MdeModulePkg

2017-05-02 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, May 3, 2017 10:33 AM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: RE: [Patch]

Re: [edk2] [patch] NetworkPkg: Fix bug in iSCSI mode ipv6 when enabling target DHCP.

2017-05-02 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Friday, April 28, 2017 2:40 PM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan Subject: [patch] NetworkPkg: Fix bug in

Re: [edk2] [Patch] NetworkPkg: Fix PXEv6 boot failure when DhcpBinl offer received.

2017-05-02 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Thursday, April 27, 2017 9:51 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg: Fix PXEv6

[edk2] [Patch 2/2] SecurityPkg: Consume SmmIoLib.

2017-05-02 Thread Eric Dong
Update code to consume SmmIoLib to pass build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Jiewen Yao --- SecurityPkg/SecurityPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [Patch 1/2] SecurityPkg OpalPasswordSmm: Consume SmmIoLib.

2017-05-02 Thread Eric Dong
Update code to consume SmmIoLib to check Mmio validation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Jiewen Yao --- .../Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c| 30 +

[edk2] [Patch 0/2] Consume New SmmIoLib.

2017-05-02 Thread Eric Dong
After MdePkg add new SmmIoLib, update OpalPasswordSmm driver to consume it. Eric Dong (2): SecurityPkg OpalPasswordSmm: Consume SmmIoLib. SecurityPkg: Consume SmmIoLib. SecurityPkg/SecurityPkg.dsc| 1 + .../Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c| 30

Re: [edk2] Does edk2 supports RFC standards 3132?

2017-05-02 Thread Ye, Ting
Hi karunakar, As I known the RFC 3132 is not supported yet. Do you have any use cases that need "IP paging" described there? Thanks, Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Karunakar P Sent: Tuesday, May 02, 2017 3:10 PM To:

Re: [edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-02 Thread Andrew Fish
> On May 2, 2017, at 6:57 AM, Amit kumar wrote: > > Hi, > > Am trying to optimize an application using AVX/AVX2, but my code hangs while > trying to access YMM registers. > The instruction where my code hangs is : > > > vmovups ymm0, YMMWORD PTR [rax] > > > I have

Re: [edk2] [PATCH 2/3] OvmfPkg: introduce FD_SIZE_4MB (mainly) for Windows HCK

2017-05-02 Thread Laszlo Ersek
On 05/02/17 01:38, Jordan Justen wrote: > On 2017-05-01 16:07:48, Laszlo Ersek wrote: >> On 05/01/17 21:20, Jordan Justen wrote: >>> >>> At this I'd just like figure out what to do about the 4MB layout, so >>> can we stop getting worked up over this side show? >> >> Thanks for calling it a side

[edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-02 Thread Amit kumar
Hi, Am trying to optimize an application using AVX/AVX2, but my code hangs while trying to access YMM registers. The instruction where my code hangs is :  vmovups ymm0, YMMWORD PTR [rax]  I have verified the cpuid in OS and it supports AVX and AVX2 instruction.  Processor i7 6th gen. Can

Re: [edk2] [PATCH] ShellPkg: Update package version to 1.01

2017-05-02 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Monday, May 01, 2017 10:28 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg: Update package version to 1.01 > Importance: High > >

Re: [edk2] [PATCH] ShellPkg/UefiHandleParsingLib: Fix memory leak

2017-05-02 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, May 02, 2017 2:34 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > > Subject: [PATCH]

Re: [edk2] Accessing AVX/AVX2 instruction in UEFI.

2017-05-02 Thread Kinney, Michael D
Amit, The information from Andrew is correct. The document that covers this topic is the Intel(r) 64 and IA-32 Architectures Software Developer Manuals https://software.intel.com/en-us/articles/intel-sdm Volume 1, Section 13.5.3 describes the AVX State. There are More details about