[edk2] [PATCH] ShellPkg/alias: Fix flag parsing logic

2017-10-19 Thread Ruiyu Ni
From: Huajing Li Existing logic to parse the flags isn't complete and cannot detect some invalid combinations of flags. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey ---

[edk2] [PATCH] ShellPkg/editor: Fix system hang when console max column > 200

2017-10-19 Thread Ruiyu Ni
EditorClearLine() assumes the console max column is less than 200. When the max column is bigger than 200, the code incorrectly modifies the content out side of Line buffer. It may cause system hang or reset. The patch changes the function to print several times when the max column is bigger than

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-19 Thread Laszlo Ersek
On 10/18/17 16:36, Duran, Leo wrote: > Yao, Paolo, Lazlo, et al, > > The offset disparity has proved manageable within SmmCpuFeaturesLib, so I’m > inclined to leave macro definitions as-is and just drop this patch-set. > > Agreed? Sure. Out of curiosity, what does it mean for you that the

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-19 Thread Laszlo Ersek
On 10/19/17 04:42, Eric Dong wrote: > MicrocodeDetect function will run by every threads, and it will > use PcdGet to get PcdCpuMicrocodePatchAddress and > PcdCpuMicrocodePatchRegionSize, if change both PCD default to dynamic, > system will in non-deterministic behavior. > > By design, UEFI/PI

Re: [edk2] [PATCH] OvmfPkg: fix dynamic default for oprom verification policy PCD without SB

2017-10-19 Thread Laszlo Ersek
On 10/19/17 04:14, Jordan Justen wrote: > On 2017-10-17 15:23:21, Laszlo Ersek wrote: >> I missed the following, both while reviewing and while testing commit >> 6041ac65ae87 ("OvmfPkg/PlatformPei: DENY_EXECUTE_ON_SECURITY_VIOLATION >> when SEV is active", 2017-10-05): >> >> If "-D

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-19 Thread Ni, Ruiyu
With the subject change suggested by Laszlo, Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 19, 2017 4:08 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Ni,

Re: [edk2] [Patch] NetworkPkg/TlsAuthConfigDxe: Remove the extra FreePool

2017-10-19 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Wu, Jiaxin Sent: Thursday, October 19, 2017 1:58 PM To: edk2-devel@lists.01.org Cc: Long, Qin ; Ye, Ting ; Fu, Siyuan ; Wu,

Re: [edk2] [Patch] NetworkPkg/TlsAuthConfigDxe: Remove the extra FreePool

2017-10-19 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Thursday, October 19, 2017 1:58 PM To: edk2-devel@lists.01.org Cc: Long, Qin; Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: [Patch] NetworkPkg/TlsAuthConfigDxe: Remove the extra FreePool Cc: Long Qin

Re: [edk2] [PATCH] EmbeddedPkg/DtPlatformDxe: remove /chosen/stdout-path on GOP registration

2017-10-19 Thread Ard Biesheuvel
On 19 October 2017 at 21:55, Leif Lindholm wrote: > On Thu, Oct 19, 2017 at 08:21:41PM +0100, Ard Biesheuvel wrote: >> The presence of a /chosen/stdout-path property will force Linux to use >> the serial port as the primary console, even if a graphical console is >>

Re: [edk2] [PATCH] EmbeddedPkg/DtPlatformDxe: remove /chosen/stdout-path on GOP registration

2017-10-19 Thread Leif Lindholm
On Thu, Oct 19, 2017 at 10:19:44PM +0100, Ard Biesheuvel wrote: > On 19 October 2017 at 21:55, Leif Lindholm wrote: > > On Thu, Oct 19, 2017 at 08:21:41PM +0100, Ard Biesheuvel wrote: > >> The presence of a /chosen/stdout-path property will force Linux to use > >> the

[edk2] [PATCH] EmbeddedPkg/DtPlatformDxe: remove /chosen/stdout-path on GOP registration

2017-10-19 Thread Ard Biesheuvel
The presence of a /chosen/stdout-path property will force Linux to use the serial port as the primary console, even if a graphical console is available as well. But the presence of the Graphics Output Protocol (GOP) is a strong indication that the user may prefer to use his keyboard and mouse

[edk2] dynamic PCD impact on temporary PEI memory

2017-10-19 Thread Laszlo Ersek
Hi, I've encountered an interesting phenomenon, and I'd like to discuss it before I submit an OvmfPkg patch. * Background #1: OVMF uses 32KB total memory for temporary SEC/PEI heap and stack, combined. The fixed PCDs for the base address of this (combined) area, and for its size, are set in the

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

2017-10-19 Thread Yao, Jiewen
I remember MdeModulePkg cannot depend on UefiCpuPkg. Is that correct, Mike? Maybe we can define a new one in MdeModulePkg, such as gEdkiiSmmMemoryAttributeProtocol. Thank you Yao Jiewen From: Wang, Jian J Sent: Friday, October 20, 2017 8:55 AM To: Yao, Jiewen ;

Re: [edk2] [PATCH] ShellPkg/alias: Fix flag parsing logic

2017-10-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, October 19, 2017 12:44 AM > To: edk2-devel@lists.01.org > Cc: Li, Huajing ; Carsey, Jaben > > Subject: [PATCH] ShellPkg/alias: Fix

Re: [edk2] [PATCH] ShellPkg/editor: Fix system hang when console max column > 200

2017-10-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, October 18, 2017 11:15 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/editor: Fix system hang when console max column > >

Re: [edk2] [patch 4/4] UefiCpuPkg/MtrrLib: Make comments align with function

2017-10-19 Thread Ni, Ruiyu
Dandan, Thanks for fixing that. Reviewed-by: Ruiyu Ni -Original Message- From: Bi, Dandan Sent: Friday, October 20, 2017 9:00 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Ni, Ruiyu Subject: [patch 4/4] UefiCpuPkg/MtrrLib:

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-19 Thread Dong, Eric
Hi Laszlo & Ruiyu, I have fix the typo and push the change. Thanks. Thanks, Eric > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, October 19, 2017 5:23 PM > To: Laszlo Ersek ; Dong, Eric ; > edk2-devel@lists.01.org > Cc: Crystal Lee

Re: [edk2] [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros

2017-10-19 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 19, 2017 2:01 AM > To: Duran, Leo ; 'Yao, Jiewen' > ; Paolo Bonzini ; edk2- > de...@lists.01.org > Cc: Ni, Ruiyu

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

2017-10-19 Thread Wang, Jian J
I took a look at current available protocols and found that we have already gEfiSmmCpuProtocolGuid and gEfiSmmCpuServiceProtocolGuid. Just like gEfiCpuArchProtocolGuid which provides the API to update memory attributes (MTRR and paging), how about we add new interfaces to gEfiSmmCpuProtocolGuid

[edk2] [patch 3/4] MdeModulePkg/DxeIplPeim: Refine coding style in function comments

2017-10-19 Thread Dandan Bi
Make the comments align with the function. And add some missing function comments. Cc: Jian J Wang Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi ---

[edk2] [patch 4/4] UefiCpuPkg/MtrrLib: Make comments align with function

2017-10-19 Thread Dandan Bi
Cc: Eric Dong Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- UefiCpuPkg/Include/Library/MtrrLib.h | 2 +- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 2 +- 2 files changed, 2

[edk2] [patch 0/4] Fix coding style issue

2017-10-19 Thread Dandan Bi
This pacth series maily refine the coding style, such as adding some missing comments, making comments alin with function... Dandan Bi (4): IntelFrameworkModulePkg/Csm: Refine coding style in comments IntelFrameworkModule/LegacyBios: not use explicit comparisons for BOOLEAN type

[edk2] [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in comments

2017-10-19 Thread Dandan Bi
Make the comments follow Edk2 coding style: 1. Make the comments starts with /** and end with **/. 2. Make the comments descrition end with '.' Cc: Jian J Wang Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN

2017-10-19 Thread Dandan Bi
Cc: Jian J Wang Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

2017-10-19 Thread Wang, Jian J
I forgot the dependency part. If so, it's ok to me to add a new protocol like gEdkiiSmmMemoryAttributeProtocol. I think this protocol will l be implemented in PiSmmCpuDxeSmm driver. If no other comments on this, I'll update the code and send the v3 patch soon. From: Yao, Jiewen Sent: Friday,