Re: [edk2] [RFC] ACPI table HID/CID allocation

On 25/11/17 12:56, Udit Kumar wrote:>> -Original Message- From: Daniel Thompson [mailto:daniel.thomp...@linaro.org] Sent: Thursday, November 23, 2017 1:42 AM To: Ard Biesheuvel Cc: Udit Kumar ; Leif Lindholm ;

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

Hi Jiewen, On 11/24/17 02:40, Yao, Jiewen wrote: > Maybe, can we revisit the original requirement on why we need disable BME at > ExitBootService for OVMF? > > I recall we have lots of discussion at September. It is good to refresh. > > == > [edk2] [PATCH 0/4]

Re: [edk2] [PATCH] ArmVirtPkg/PrePi: don't export PE/COFF and LZMA libraries via HOBs

On 11/24/17 10:51, Ard Biesheuvel wrote: > The PrePi code we inherited from ArmPlatformPkg contains a rather > obscure optimization, where entry points of the PE/COFF and LZMA > handling routines are recorded in special HOBs, allowing DXE core > to call into that code directly rather than carry

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

It is a way also I am thinking. Hope no OS takes any assumption related to AhciReset(). Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, November 27, 2017 8:30 PM To: Yao, Jiewen ; Ni, Ruiyu ; Paolo

Re: [edk2] [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom

On 11/26/17 16:22, Leif Lindholm wrote: > (Adding Laszlo to cc based on a single comment I make below.) > > On Tue, Nov 21, 2017 at 04:23:36PM +0530, kalyan-nagabhirava wrote: >> [Guids.common] >>gHiKeyTokenSpaceGuid = { 0x91148425, 0xcdd2, 0x4830, { 0x8b, >> 0xd0, 0xc6, 0x1c,

Re: [edk2] Unable to Loacte EdkiiIoMmuProtocol.

You need include a driver to produce gEdkiiIoMmuProtocolGuid. One sample is IntelSiliconPkg\Feature\VTd\IntelVTdDxe Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Amit > kumar > Sent: Monday, November 27, 2017 7:24 PM >

Re: [edk2] [RFC] ACPI table HID/CID allocation

> >> Hmnnn it sounds like jedec,spi-nor meets this test. > >> > >> There is only one property in the DT bindings that describes the > >> device itself (fast read support) rather than its "bus address" (chip > >> select, frequency). Further, that single property is obsolete, at > >> least for

Re: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

Hello Ray, On 11/27/17 02:19, Ruiyu Ni wrote: > The patches caused Windows 10 S4 resume failure. > Considering the similar changes are reverted from PciBus driver, > revert the patches from AtaAtapiPassThru as well. > > Ruiyu Ni (2): > MdeModulePkg/AtaAtapiPassThru: Revert patch to disable Bus

Re: [edk2] [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure

Hi Ray, adding Ard, Jordan, Liming and Yonghong: On 11/27/17 02:38, Ruiyu Ni wrote: > Original code breaks a single assembly code to multiple lines. > But build tool doesn't support such usage in Windows OS environment. > > Changing the multiple lines to one line to resolve the build failure. >

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP

On Mon, Nov 27, 2017 at 04:21:48PM +0530, Meenakshi Aggarwal wrote: > v3: > Added patch-prefix I only meant you could apply this in future. However, this new posting has ended up with ([PATCH ...][PATCH...]), which is not ideal. There is no need to edit the patch subject for each version - just

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

Yes, Laszlo, you are right. Back to that time, we did not realize there will be S4 issue. Now, I agree with you that AhciReset is a better way. And I think we also need test different UEFI OS (normal boot/S4) to see if there is other issue. Hope AhciReset() is good enough, and won't bring

Re: [edk2] [PATCH v2 3/3] ShellPkg/dp: Convert from NULL class library to Dynamic Command

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, November 26, 2017 9:56 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Kinney, Michael D > > Subject: [PATCH v2 3/3]

[edk2] Accessing memory above 0xFFFFFFFF limit.

Hi. I am trying to allocate a mem buffer above 4Gb address but the allocation since i am unable to locate EdkiiIoMmuProtocol. Status = gBS->LocateProtocol (, NULL, (VOID **)); Status = mIoMmuProtocol->AllocateBuffer ( mIoMmuProtocol, MaxAllocateType,

Re: [edk2] [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom

On Mon, Nov 27, 2017 at 02:02:32PM +0100, Laszlo Ersek wrote: > On 11/26/17 16:22, Leif Lindholm wrote: > > (Adding Laszlo to cc based on a single comment I make below.) > > > > On Tue, Nov 21, 2017 at 04:23:36PM +0530, kalyan-nagabhirava wrote: > > >> [Guids.common] > >>

Re: [edk2] [PATCH] ArmVirtPkg/PrePi: don't export PE/COFF and LZMA libraries via HOBs

On 27 November 2017 at 12:32, Laszlo Ersek wrote: > On 11/24/17 10:51, Ard Biesheuvel wrote: >> The PrePi code we inherited from ArmPlatformPkg contains a rather >> obscure optimization, where entry points of the PE/COFF and LZMA >> handling routines are recorded in special

Re: [edk2] Accessing memory above 0xFFFFFFFF limit.

On 11/27/17 13:20, Amit kumar wrote: > > Hi. > I am trying to allocate a mem buffer above 4Gb address but the allocation > since i am unable to locate EdkiiIoMmuProtocol. > > Status = gBS->LocateProtocol (, NULL, (VOID > **)); > Status = mIoMmuProtocol->AllocateBuffer ( >

Re: [edk2] [PATCH 1/5] MdeModulePkg/BdsDxe: fall back to a Boot Manager Menu loop before hanging

Hi Ray, On 11/23/17 14:09, Laszlo Ersek wrote: > On 11/23/17 04:43, Ni, Ruiyu wrote: >> Thanks for the patch. It follows the idea described in: >> https://lists.01.org/pipermail/edk2-devel/2017-April/010294.html. >> >> Reviewed-by: Ruiyu Ni > > Thank you, Ray! I might commit

Re: [edk2] Unable to Loacte EdkiiIoMmuProtocol.

Should drivers call gEdkiiIoMmuProtocolGuid directly or just use PciIo Protocol? Thanks, Andrew Fish > On Nov 27, 2017, at 3:24 AM, Amit kumar wrote: > > Hi. > I am trying to allocate a mem buffer above 4Gb address but the allocation > since i am unable to locate

Re: [edk2] [PATCH] MdeModulePkg/Core: Merge memory map after filtering paging capability

Hello Jian, On 11/27/17 06:34, Jian J Wang wrote: > Once the paging capabilities were filtered out, there might be some adjacent > entries > sharing the same capabilities. It's recommended to merge those entries for > the OS > compatibility purpose. > > This patch makes use of existing method

Re: [edk2] EDK2 build issues

Liming, We have a top level GNUmakefile vs. having script files to build targets. Thus building BaseTools, or using build are subtasks of this higher level makefile. Looks like you have added some fixes to the BaseTools! Thanks, Andrew Fish > On Nov 22, 2017, at 9:28 PM, Gao, Liming

[edk2] [PATCH 1/2] OvmfPkg/QemuBootOrderLib: skip already matched / appended UEFI boot opts

The SetBootOrderFromQemu() function implements a nested loop where - the outer loop iterates over all OpenFirmware (OFW) device paths in the QEMU boot order, and translates each to a UEFI device path prefix; - the inner loop matches the current (translated) prefix against all active UEFI

[edk2] [PATCH 0/2] OvmfPkg/QemuBootOrderLib: multiplicity update for OFW <-> UEFI matching

Two small patches with verbose commit messages. Repo: https://github.com/lersek/edk2.git Branch: qemu_boot_order_multimatch Cc: Ard Biesheuvel Cc: Jordan Justen Laszlo Ersek (2): OvmfPkg/QemuBootOrderLib: skip already matched /

[edk2] [PATCH 2/2] OvmfPkg/QemuBootOrderLib: let an OFW devpath match multiple UEFI boot opts

This means that SetBootOrderFromQemu() will preserve all UEFI boot options matched by any given OFW devpath, such as PXEv4, HTTPv4, PXEv6 and HTTPv6 boot options for the same NIC. Currently we stop the matching / appending for the OFW devpath coming from the outer loop whenever we find the first

Re: [edk2] [PATCH] MdeModulePkg/PerformanceLib: add lock protection

Reviewed-by: Star Zeng with the redundant with at " with with " in the commit log. Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Monday, November 27, 2017 11:32 AM To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

On Mon, Nov 27, 2017 at 06:06:33AM +, Meenakshi Aggarwal wrote: > Hi Leif, > > This is regarding Big-Endian Library patch ([PATCH v2 1/9] > Platform/NXP: Add support for Big Endian Mmio APIs) > > We have started this discussion before and the suggestion was to > create a separate .inf file

[edk2] Unable to Loacte EdkiiIoMmuProtocol.

Hi. I am trying to allocate a mem buffer above 4Gb address but the allocation since i am unable to locate EdkiiIoMmuProtocol. Status = gBS->LocateProtocol (, NULL, (VOID **)); Status = mIoMmuProtocol->AllocateBuffer ( mIoMmuProtocol, MaxAllocateType,

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Support UPD allocation outside FspWrapper

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel, > Chiu > Sent: Thursday, November 23, 2017 10:30 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH]

[edk2] [PATCH v2 2/3] BaseTools: Update BaseTools top GNUMakefile with the clear dependency

https://bugzilla.tianocore.org/show_bug.cgi?id=786 After GNUmakefile dependency is fixed up, it can make with -j N to enable multiple thread build in base tools C source and save build time. In my linux host machine, make -j 4 to compile BaseTools and save ~60% time. Contributed-under:

[edk2] [PATCH v2 1/3] BaseTools: Replace ARCH with HOST_ARCH in C Makefile to avoid conflict

https://bugzilla.tianocore.org/show_bug.cgi?id=793 ARCH is too generic. It may cause confuse of target arch or host arch. To be clarified, replace it with HOST_ARCH in BaseTools C Makefile. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao

[edk2] [Patch] NetworkPkg: Update IScsiDxe to pass XCODE build

Fix the warning equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liang Vincent --- NetworkPkg/IScsiDxe/IScsiDhcp.c| 2 +-

[edk2] [PATCH v2 3/3] BaseTools: Update C tools top GNUMakefile to adjust tool order

Place the tool that takes much build time at the first. This can improve build performance when make -j N used. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/GNUmakefile | 6 +++--- 1 file changed, 3 insertions(+),

[edk2] [PATCH v2 0/3] BaseTools: Update Makefiles with clear ARCH and dependency

https://bugzilla.tianocore.org/show_bug.cgi?id=793 https://bugzilla.tianocore.org/show_bug.cgi?id=786 In V2: Update BaseTools top GNUmakefile with the clear dependency Liming Gao (3): BaseTools: Replace ARCH with HOST_ARCH in C Makefile to avoid conflict BaseTools: Update BaseTools top

[edk2] [Patch] MdeModulePkg: Update PeiCore to pass XCODE tool chain

It fixes the warning for loop has empty body [-Werror,-Wempty-body]. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liang Vincent --- MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[edk2] [Patch] SignedCapsulePkg: Update EdkiiSystemCapsuleLib to check PCD value

If PCD value is not set, register PcdCallBack to hook PCD value set Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Jiewen Yao --- .../EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c | 86 +-

[edk2] [patch] PcAtChipsetPkg: Add description for new added PCD in commit e78aab9d2

Cc: Leo Duran Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- PcAtChipsetPkg/PcAtChipsetPkg.uni | 9 + 1 file changed, 9 insertions(+) diff --git

[edk2] [Patch] MdeModulePkg/NetLib: Add NetLibDetectMediaWaitTimeout() API to support EFI_NOT_READY media state detection

In wireless connection, connecting state needs to be cared more about. ECR 1772 redefined the state EFI_NOT_READY to represent connecting state and can be retrieved from Aip protocol. This patch adds a new API to check media state at a specified time interval when network is connecting until the

Re: [edk2] [PATCH] MdeModulePkg/Core: Merge memory map after filtering paging capability

Make sense. Thanks for the comment. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 28, 2017 2:21 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star

Re: [edk2] [patch] PcAtChipsetPkg: Add description for new added PCD in commit e78aab9d2

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Tuesday, November 28, 2017 11:51 AM > To: edk2-devel@lists.01.org > Cc: Leo Duran ; Ni, Ruiyu > Subject: [patch] PcAtChipsetPkg: Add description

Re: [edk2] [RFC v1 00/15] *** Proposal for StandaloneMmPkg ***

HI I am sorry that I missed this mail before. I found only 0/15 and 13/15 are in my mail box. :-( I do not know why others are filtered. Is that possible to post the whole patch to your private git? As such, we can review it in more efficient way. Basically, I think it is a good idea to have

Re: [edk2] [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Hi Star, On 27/11/17 01:46, Zeng, Star wrote: Reviewed-by: Star Zeng with some minor comments in the separated patches. Thank you for the review. I will resend the series with updating the description in the corresponding headers. Would you mind if I keep you

Re: [edk2] [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Sure. :) Thanks, Star -Original Message- From: Julien Grall [mailto:julien.gr...@linaro.org] Sent: Monday, November 27, 2017 6:39 PM To: Zeng, Star ; Dong, Eric ; pankaj.ban...@nxp.com; ler...@redhat.com; leif.lindh...@linaro.org Cc:

Re: [edk2] [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

I mean not mind. -Original Message- From: Zeng, Star Sent: Monday, November 27, 2017 6:47 PM To: Julien Grall ; Dong, Eric ; pankaj.ban...@nxp.com; ler...@redhat.com; leif.lindh...@linaro.org Cc: edk2-devel@lists.01.org; Ni, Ruiyu

[edk2] [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms

Linaro and RDK are working on standardizing the boot process for RDK STB boxes using Uefi. Added applications are reference implementation of RDK STB boot process on Arm platforms Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: kalyan-nagabhirava

Re: [edk2] [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command

I just realized OVMF platform is referencing the INF. I will search in all edkII code. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, November 28, 2017 3:35 PM > To: Ni, Ruiyu

Re: [edk2] [PATCH 1/2] OvmfPkg/QemuBootOrderLib: skip already matched / appended UEFI boot opts

On 27 November 2017 at 19:03, Laszlo Ersek wrote: > The SetBootOrderFromQemu() function implements a nested loop where > > - the outer loop iterates over all OpenFirmware (OFW) device paths in the > QEMU boot order, and translates each to a UEFI device path prefix; > > - the

Re: [edk2] [PATCH 2/2] OvmfPkg/QemuBootOrderLib: let an OFW devpath match multiple UEFI boot opts

On 27 November 2017 at 19:03, Laszlo Ersek wrote: > This means that SetBootOrderFromQemu() will preserve all UEFI boot options > matched by any given OFW devpath, such as PXEv4, HTTPv4, PXEv6 and HTTPv6 > boot options for the same NIC. Currently we stop the matching / appending

Re: [edk2] [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom

HI Leif, we didn't implemented enabling USB host and Secure boot support on Hikey , we just took the code from openplatfrompkg (hikey branch) , we have implemented secureboot and DRI -disaster recovery image (HTTP image download) application and tested on HIkey platform , so for that purpose we

Re: [edk2] [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command

On 27 November 2017 at 05:55, Ruiyu Ni wrote: > UEFI Shell spec defines Shell Dynamic Command protocol which is just > for the purpose to extend internal command. > So tftp command is changed from NULL class library to be a driver > producing DynamicCommand protocol. > > The

Re: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

Laszlo, The Windows resume issue is urgent to fix. I'd like to check-in the patches first. If I didn't know the change may cause combability issue, I'd be very fine to change it to AhciReset() then submit the patch, then after got a R-b, I'd be very happy to check in that patch. But since now I

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Sorry, 1.3 should be for your 1.4. I just noticed I missed your 1.3 comment. Here's my opinion for it: Current changes (use global variables to reserve resources) to InitializeCpuExceptionHandlers() is for DXE only. For PEI, if we really need to worry about the stack overflow and stack

Re: [edk2] [PATCH v3 0/4] Add VS2017 tool chain for evaluation

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Pete Batard Sent: Thursday, November 23, 2017 12:26 AM To: edk2-devel@lists.01.org Cc: Gao, Liming

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Thanks Jian. I just talked to some other person, who think it is valuable to have stack guard in PEI as well, because they have seen stack overflow issue in PEI. I do think we need consider that, although it is not implemented in this patch series. My thought for API is that the API design