Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates

2018-03-27 Thread Laszlo Ersek
Siyuan, Jiaxin, do you have any comments please? Thanks, Laszlo On 03/22/18 17:39, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: http_and_tls_updates > > Patch #4 fixes TianoCore BZ#909 > . > > Patches #2 and #3

Re: [edk2] Question regarding structure PCD

2018-03-27 Thread Laszlo Ersek
On 03/26/18 22:16, Kinney, Michael D wrote: > Jeff, > > You can provide default values for structure fields > in the DEC file. > > Liming has an example posted in the following branch: > > https://github.com/lgao4/edk2/tree/UDK2018 > > DEC file example in TestPkg: > >

Re: [edk2] [PATCH v2] BaseTools: Update Rsa2048Sha256Sign to use openssl standard options

2018-03-27 Thread Gao, Liming
Qin: Thanks for your suggestion. It also work. I agree this style is better. Thanks Liming >-Original Message- >From: Long, Qin >Sent: Tuesday, March 27, 2018 4:33 PM >To: Zhu, Yonghong ; Gao, Liming >; edk2-devel@lists.01.org >Cc: Kinney,

Re: [edk2] How to make a memory mapped to FV ffs efi program?

2018-03-27 Thread Laszlo Ersek
On 03/27/18 07:28, Andrew Fish wrote: > David, > > I'm not sure what you are asking? Per UEFI Spec boot policy there are > well know NVRAM variables that define boot policy. See UEFI Spec 3.3 > Globally Defined Variables. Look at BootOrder, BootNext, Boot etc. > > The memory mapped volume

Re: [edk2] [PATCH v2] BaseTools: Update Rsa2048Sha256Sign to use openssl standard options

2018-03-27 Thread Long, Qin
This ("sha1 -sha256") looks a little odd. Could we try "openssl dgst -sha256 "? Best Regards & Thanks, LONG, Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu, Yonghong Sent: Tuesday, March 27, 2018 3:56 PM To: Gao, Liming

Re: [edk2] [PATCH v2] BaseTools: Update Rsa2048Sha256Sign to use openssl standard options

2018-03-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, March 27, 2018 1:48 PM To: edk2-devel@lists.01.org Cc: Liao, Jui-pengX ; Kinney, Michael D ; Zhu,

Re: [edk2] [PATCH v2] BaseTools: Update Rsa2048Sha256Sign to use openssl standard options

2018-03-27 Thread Liao, Jui-pengX
Hi all, The "openssl dgst -sha256" is working as well. [configuration] Xcode 9 Openssl 0.9.8zh 14 Jan 2016 Best regards George Liao -Original Message- From: Gao, Liming Sent: Tuesday, March 27, 2018 4:49 PM To: Long, Qin ; Zhu, Yonghong ;

[edk2] [Patch] BaseTools: Update Rsa2048Sha256Sign to use openssl dgst option

2018-03-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu Cc: Qin Long --- BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py | 6 +++--- 1 file changed, 3 insertions(+), 3

[edk2] How to make a memory mapped to FV ffs efi program?

2018-03-27 Thread david moheban
Some months back I played around with the Simple File System code examples in the Edk2 package and am familiar sort of on how it works. I was just curious on how certain firmware packages take a Efi Shell and make it available to boot from the F8 or F11 (or whatever) boot menu. I suppose to make

Re: [edk2] How to make a memory mapped to FV ffs efi program?

2018-03-27 Thread Laszlo Ersek
On 03/27/18 13:43, david moheban wrote: > I was just curious on how certain firmware packages take a Efi Shell > and make it available to boot from the F8 or F11 (or whatever) boot > menu. I suppose to make your own you have to write a dxe driver that > adds the location via guid to the boot

[edk2] [Patch] BaseTools: Fix two cases that use GUID CName as PCD Value

2018-03-27 Thread Yonghong Zhu
1. use CName format in components section: [Components] TestPkg/TestDriver.inf { PcdToken.PcdName |{GUID(TestGuid)}|VOID*|16 } 2. Use Guid CName format in INF and the Guid is defined in the DEC file but not write in driver's [Guids] section. PcdToken.PcdName |

Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates

2018-03-27 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 22, 2018 9:39 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject:

[edk2] [Patch 5/5] Vlv2TbltDevicePkg: Sync FLASH libraries from UDK2017 branch

2018-03-27 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=911 Update Minnow Max FLASH libraries to match libraries in the UDK2017 development branch in edk2-platforms. https://github.com/tianocore/edk2-platforms/tree/devel-MinnowBoardMax-UDK2017 Cc: David Wei Cc: Mang Guo

[edk2] [Patch 2/5] Vlv2TbltDevicePkg: Fix VS2015 build breaks

2018-03-27 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=911 Fix minor code issues that break VS2015 builds. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney

[edk2] [Patch 3/5] Vlv2TbltDevicePkg: Fix build issues in DSC/FDF

2018-03-27 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=911 Fix a the following issues in DSC/FDF files * Remove references to drivers that are not present * Enable the Tianocore boot logo and BGRT table * Enable full UEFI shell * Enable more debug messages in DXE phase Cc: David Wei

[edk2] [Patch 4/5] Vlv2TbltDevicePkg: Display logo on BOOT_ON_FLASH_UPDATE

2018-03-27 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=911 Update PlatformBdsLib to show boot logo when the boot mode is BOOT_ON_FLASH_UPDATE. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch 1/5] Vlv2TbltDevicePkg: Fix build scripts

2018-03-27 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=911 Update build scripts to work with edk2 and Vlv2Binaries in PACKAGES_PATH. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao

[edk2] [Patch 0/5] Fix Vlv2TbltDevicePkg build and boot issues

2018-03-27 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=911 Fix a the following issues * Update build scripts to work when Vlv2Binaries are placed in PACKAGES_PATH * Fix some compiler build breaks when using VS2015 * Remove references to drivers that are not present * Enable the Tianocore boot logo and

Re: [edk2] [PATCH 0/5] NetworkPkg: HTTP and TLS updates

2018-03-27 Thread Wu, Jiaxin
Series Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, March 23, 2018 12:39 AM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan

Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

2018-03-27 Thread Zeng, Star
Is there a PCD pointers to the siglist? For adding PcdMaxVolatileVariableSize: non-authenticated, volatile, I think it is acceptable if there are use cases. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent:

Re: [edk2] [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge

2018-03-27 Thread Guo Heyi
Hi Leif, Ard, Any comments for this series of patches? Thanks, Heyi On Wed, Mar 21, 2018 at 09:03:06AM +0800, Heyi Guo wrote: > For BAR address translation support was added to edk2 generic PciHostBridge by > commit 74d0a33, now we can also use it for D03/D05 platforms. > This series of patches

Re: [edk2] internal structure of EFI_TLS_CA_CERTIFICATE_VARIABLE

2018-03-27 Thread Laszlo Ersek
Hi, On 03/21/18 02:30, Fu, Siyuan wrote: > Hi, Laszlo > > The data structure of EFI_TLS_CA_CERTIFICATE_VARIABLE is > EFI_SIGNATURE_LIST and we have documented this in HTTPs Boot wiki > page: > https://github.com/tianocore/tianocore.github.io/wiki/HTTPS-Boot > > You can refer section 31.4.1

[edk2] [PATCH v1 3/4] BaseTools: move regular expression compile out of function call.

2018-03-27 Thread Jaben Carsey
move to the root of the file and dont recompile. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py | 12

[edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

2018-03-27 Thread Jaben Carsey
Since PcdValue is a string, no need to test it's type() for string Also remove the block used if it's a list (which is never is) Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey

[edk2] [PATCH v1 0/4] BaseTools: remove code without affect

2018-03-27 Thread Jaben Carsey
this is a refactoring of the code to make it more readable and less wasteful *** BLURB HERE *** Jaben Carsey (4): BaseTools: remove irrelevant code BaseTools: expression can use single in instead of 3 API calls. BaseTools: move regular expression compile out of function call. BaseTools:

[edk2] [PATCH v1 2/4] BaseTools: expression can use single in instead of 3 API calls.

2018-03-27 Thread Jaben Carsey
change 3 StartsWith() calls to a single 'in' operation. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py |

[edk2] [PATCH v1 4/4] BaseTools: dont use enumerate when un-needed

2018-03-27 Thread Jaben Carsey
Since we only use the item from the list and not the numeric value, dont bother with enumerate() Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

Re: [edk2] [Patch V2] BaseTools/BinToPcd: Add support for multiple binary input files

2018-03-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Thursday, March 22, 2018 6:54 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Sean Brogan ;

Re: [edk2] [PATCH v1 1/1] BaseTools: refactor repeated RegExp when no special searching is needed.

2018-03-27 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Tuesday, March 27, 2018 8:33 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/1]

Re: [edk2] [PATCH v1 1/4] BaseTools: remove irrelevant code

2018-03-27 Thread Zhu, Yonghong
Hi Jaben, Current we support flexible PCD value format, example: UINT64 type PCD can use {0x1, 2, 'A', UINT16(10), "B"} as its value, so the block can't be removed since it maybe a list after SplitPcdValueString function. https://bugzilla.tianocore.org/show_bug.cgi?id=541 is the feature

Re: [edk2] [Patch] BaseTools: Update Rsa2048Sha256Sign to use openssl dgst option

2018-03-27 Thread Long, Qin
Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Gao, Liming Sent: Tuesday, March 27, 2018 8:59 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Long, Qin Subject: [Patch] BaseTools: