Hi Sumit,
On Tue, Aug 28, 2018 at 10:04 PM, Sumit Garg wrote:
> Hi Achin,
>
> On Tue, 28 Aug 2018 at 18:38, Achin Gupta wrote:
>>
>> Hi Sumit,
>>
>> Apologies for not replying sooner. Some questions and thoughts inline.
>>
>> On Mon, Aug 27, 2018 at 03:28:52PM +0530, Sumit Garg wrote:
>> > On
> > So you do not really need an MM partition running alongside OP-TEE?
> >
>
> Agree that most of secure services can be implemented as static
> (pseudo) TAs. But if I think about services like RAS error handling and
> firmware updates. Is Trusted OS (OP-TEE or any third party OS) an
>
From: zhijufan
[PcdsDynamicHii]
gFooTokenSpaceGuid.PcdBar|L"Variable"|gVarNameSpaceGuid|0x0|FALSE|NV,BS
This patch add the variable namespace GUIDs in "Guid.xref" that are
used with dynamic HII PCDs.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=452
Cc: Liming Gao
Cc: Yonghong Zhu
Hao,
Thanks for the comments.
I just sent out a patch with title "[edk2] [PATCH] EmulatorPkg: formalize line
endings".
My patch sets will be re-generated after the line ending formalization patch is
commit.
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, August
Reviewed-by: Eric Dong
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, August 29, 2018 11:22 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Laszlo Ersek
> Subject: [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message
>
> It's reported the debug message in CpuDxe
It's reported the debug message in CpuDxe driver is quite annoying in
boot and shell, and slow down the boot process. To solve this issue,
this patch changes the DEBUG_INFO to DEBUG_VERBOSE. On a typical Intel
real platform, at least 16s boot time can be saved.
Cc: Eric Dong
Cc: Laszlo Ersek
On 8/29/2018 9:54 AM, Wu, Hao A wrote:
-Original Message-
From: Ni, Ruiyu
Sent: Monday, August 27, 2018 3:53 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A; Andrew Fish
Subject: [PATCH 07/10] EmulatorPkg/AutoScanPei: Report the correct CPU
address size
REF:
Against the below condition code in Ip4Route():
//
// We will always try to use the direct destination address when /32 subnet
mask is used.
//
if (RtEntry == NULL && SubnetMask != IP4_ALLONE_ADDRESS) {
return NULL;
}
If there is no default route { Dest: 0.0.0.0, Mask:
Hi Ray,
One general-level comment, I saw some file was originally with Unix line
ending format (LF), but after the series, the line ending is in a mixed
state (both containing Unix LF & Windows CRLF). Can you help to perform
the line ending format cleanup for those files?
Also, please help to
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, August 27, 2018 3:53 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Andrew Fish
> Subject: [PATCH 07/10] EmulatorPkg/AutoScanPei: Report the correct CPU
> address size
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1119
>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, August 27, 2018 3:53 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Andrew Fish
> Subject: [PATCH 05/10] EmulatorPkg/Win: Do not zero out file content
>
> The patch changes the behavior to not zero out file content
> when the file
On 8/28/2018 10:55 PM, Carsey, Jaben wrote:
looks good to me. Ray?
Reviewed-by: Jaben Carsey
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu
Siyuan
Sent: Monday, August 27, 2018 6:53 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Ye, Ting
On 8/28/2018 11:42 AM, shenglei wrote:
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore
On 8/28/2018 11:42 AM, shenglei wrote:
The PCDs below are unused, so they have been removed from inf.
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in DpApp.inf
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize in
DpDynamicCommand.inf
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
On 8/28/2018 11:42 AM, shenglei wrote:
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution
New formal release in https://www.7-zip.org/sdk.html is 18.05.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
.../LzmaCustomDecompressLib/LZMA-SDK-README.txt| 6 +-
.../LzmaArchCustomDecompressLib.inf| 6 +-
Liming Gao (3):
IntelFrameworkModulePkg Lzma: Update LZMA SDK version to 18.05
MdeModulePkg Lzma: Update LZMA SDK version to 18.05
BaseTools Lzma: Update LZMA SDK version to 18.05
.../Source/C/LzmaCompress/LZMA-SDK-README.txt |4 +-
BaseTools/Source/C/LzmaCompress/LzmaCompress.c
New formal release in https://www.7-zip.org/sdk.html is 18.05.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
.../LzmaCustomDecompressLib/LZMA-SDK-README.txt| 6 +-
.../LzmaArchCustomDecompressLib.inf| 6 +-
Reverse the checking and only assign once to each variable.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 15 ---
1 file changed, 8 insertions(+), 7
Hi Achin,
On Tue, 28 Aug 2018 at 18:38, Achin Gupta wrote:
>
> Hi Sumit,
>
> Apologies for not replying sooner. Some questions and thoughts inline.
>
> On Mon, Aug 27, 2018 at 03:28:52PM +0530, Sumit Garg wrote:
> > On Fri, 24 Aug 2018 at 23:33, Matteo Carlini wrote:
> > >
> > > +Achin
> > >
>
This looks like a great change. Why not delete the bat file?
Reviewed-by Jaben Carsey:
Jaben
> On Aug 28, 2018, at 8:28 AM, Liming Gao wrote:
>
> From: Dongao Guo
>
> Add NmakeSubdirs.py to replace NmakeSubdirs.bat in VS Makefile. This script
> will
> invoke nmake in multi thread mode.
From: Dongao Guo
Add NmakeSubdirs.py to replace NmakeSubdirs.bat in VS Makefile. This script will
invoke nmake in multi thread mode. It can save more than half time of BaseTools
C clean build.
GCC make supports multiple thread in make phase. So, GNNmakefile doesn't need
apply
this script.
For 13,14,15,16 about the ShellPkg content.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Monday, August 27, 2018 8:43 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v3 00/16] Removed
looks good to me. Ray?
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu
> Siyuan
> Sent: Monday, August 27, 2018 6:53 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Ye, Ting ; Wu, Jiaxin
>
> Subject: [edk2]
Hi Ard,
Apologies for the delay! CIL.
On Fri, Aug 24, 2018 at 03:55:29PM +0100, Ard Biesheuvel wrote:
> On 21 August 2018 at 07:50, Sughosh Ganu wrote:
> > hi Ard,
> >
> > On Tue July 23, 2018 at 11:03PM +0530, Supreeth Venkatesh wrote:
> >>
> >> On Sat, 2018-07-21 at 20:06 +0900, Ard
Hi Sumit,
Apologies for not replying sooner. Some questions and thoughts inline.
On Mon, Aug 27, 2018 at 03:28:52PM +0530, Sumit Garg wrote:
> On Fri, 24 Aug 2018 at 23:33, Matteo Carlini wrote:
> >
> > +Achin
> >
> > SPD (for OP-TEE and other Trusted-OSes payloads running at S-EL1) and SPM
>
1. Not append trailing zero for PcdValue
2. make sure the point to Variable Name in PCD
DataBase 2 bytes aligned.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 6 ++
Hi, Jiaxin
The IP4 routing logic for /32 subnet mask can be explain as below, maybe I need
to add it to the commit log or in code comments.
Ip4Output() is called to send a packet
If a matching route cache (src, dest -> xxx) can be find,
send the packet to address xxx
Hi Siyuan,
Below is my code review understanding, maybe something is wrong, please correct
me.
> The "default route" means a route entry with zero SubnetAddress and zero
> SubnetMask, which will match all the dest address that can't match any other
> non-zero Subnet* route entry.
> The
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhang, Shenglei
>Sent: Wednesday, August 22, 2018 1:23 PM
>To: edk2-devel@lists.01.org
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [PATCH] MdePkg: Add the missing spec version information for
>header files
>
>Cc: Michael D Kinney
Change MRC parameters in FSP-M UPD to enable different memory configurations.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei
CC: Mike Wu
CC: Mang Guo
---
.../Board/UP2/BoardInitPreMem/BoardInitMiscs.c | 145 -
Hi Dandan,
Two comments.
1. The "if (PeerGroupCount > 0) {" for Type 9 is redundant.
2. The length check for Type 17 new XXXSize fields is wrong.
With them corrected, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
Hi, Jiaxin
The "default route" means a route entry with zero SubnetAddress and zero
SubnetMask, which will match all the dest address that can't match any other
non-zero Subnet* route entry.
The "instance route table" is a list of route entries which belong to an IP
child instance.
The
Hi Siyuan,
In Ip4SendFrameToDefaultRoute(), you tried to find the default gateway IP
address by using the found RtCacheEntry->Tag, I'm confused why it's the default
gateway? In my understanding, tag is the cache's corresponding route entry.
Besides, why we must send the frame to
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Tuesday, August 28, 2018 6:08 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming
Subject: [PATCH v1 1/1] BaseTools: AutoGen.py remove unused import
AutoGen does not use
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099
Update SmbiosView to parse the new definitions which
are introduced in SMBIOS3.2.0
V2:
1. Add structure length check before dump the fileds in
Type 9 and Type 17 in case some fileds are not organized
and reported by drivers.
2. Dump the
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Wednesday, August 22, 2018 3:17 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix one expression bug to support ~ operate
37 matches
Mail list logo
