[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Add new test of UFSDeviceConfig Protocol

2018-10-11 Thread Eric Jin
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh --- uefi-sct/SctPkg/CommonGenFramework.bat | 1 + uefi-sct/SctPkg/CommonGenFramework.sh | 1 + uefi-sct/SctPkg/Config/Data/Category.ini | 7 +

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Add new test of PartitionInfo Protocol

2018-10-11 Thread Eric Jin
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh --- uefi-sct/SctPkg/CommonGenFramework.bat | 1 + uefi-sct/SctPkg/CommonGenFramework.sh | 1 + uefi-sct/SctPkg/Config/Data/Category.ini | 7 ++

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-11 Thread Marcin Wojtas
wt., 9 paź 2018 o 13:51 Marcin Wojtas napisał(a): > > wt., 9 paź 2018 o 13:45 Ard Biesheuvel napisał(a): > > > > On 9 October 2018 at 13:32, Marcin Wojtas wrote: > > > wt., 9 paź 2018 o 13:28 Wu, Hao A napisał(a): > > >> > > >> > -Original Message- > > >> > From: edk2-devel

[edk2] TianoCore Community Meeting Minutes

2018-10-11 Thread stephano
Thank you all for a great set of meetings! This is an overview of the topics discussed and the tasks that were assigned. Please feel free to send me any questions or comments. Licensing - Licensing was discussed and no questions or comments came up. Please feel free to contact me

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Fix the corner case of ExtractConfig API

2018-10-11 Thread Eric Jin
There may be no output with the ExtractConfig API The export data may be changed automatically Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh Cc: Jiaxin Wu --- .../BlackBoxTest/HIIConfigAccessBBTestFunction.c | 67

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Add checkpoint of LocateProtocol()

2018-10-11 Thread Eric Jin
Clarify return value for NULL pointer in LocateProtocol() API When input parameter Protocol is NULL, EFI_INVALID_PARAMETER should be returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh Cc: Jiaxin Wu ---

[edk2] [PATCH] BaseTools: Not compare the VOID* difference in the DSC and DEC file

2018-10-11 Thread Yonghong Zhu
For structure Pcd, the type defined in the DEC file is the struct name while if this Pcd used in the DSC file, it should add VOID* keywords when it have max size info. so this patch filter the type compare for this case. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Add not-granularity-aligned cases in Erase Block Protocol

2018-10-11 Thread Eric Jin
Add not-granularity-aligned cases Correct end of line Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh Cc: Jiaxin Wu --- .../EraseBlock/BlackBoxTest/EraseBlockBBTest.inf | 114 +-- .../BlackBoxTest/EraseBlockBBTestConformance.c |

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Define new AIP info block for wireless NIC

2018-10-11 Thread Eric Jin
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh Cc: Jiaxin Wu --- .../AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c | 5 +++-- .../Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestMain.c| 5 +++--

[edk2] [PATCH] BaseTools: increment build generate inf file lost .depex file

2018-10-11 Thread Yonghong Zhu
From: Yunhua Feng increment build generate inf file in output directory lost .depex file info. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1244 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng ---

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-11 Thread Wu, Hao A
> -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Thursday, October 11, 2018 11:43 PM > To: Wu, Hao A > Cc: Ni, Ruiyu; Ard Biesheuvel; Tian, Feng; Tomasz Michalec; Dong, Eric; edk2- > devel-01; Gao, Liming; nad...@marvell.com; Kinney, Michael D; Zeng, Star >

[edk2] [patch 3/3] MdePkg: Handle AcpiExp device path when optional para is not specified

2018-10-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1243 AcpiExp text device path: AcpiExp(HID,CID,UIDSTR) And according to UEFI spec, the CID parameter is optional and has a default value of 0. But current implementation miss to check following cases for the AcpiExp. FromText:when text device is

[edk2] [patch 2/3] MdePkg: Handle USBxxx device path when optional para is not specified

2018-10-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1243 According to UEFI spec, for the Messaging Device Path with USB Class SubType, some paras are optional in the text device path. Take UsbClass(VID,PID,Class,SubClass,Protocol) for example, The VID is an integer between 0 and 65535 and is

[edk2] [patch 1/3] MdePkg: Handle Sata device path when optional para is not specified

2018-10-11 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1243 Sata device path format:Sata(HPN, PMPN, LUN) According to UEFI Spec, the PMPN is an integer between 0 and 65535 and is optional. If not provided, the default is 0x. This commit is to do the enhancement for Sata device path when

[edk2] [patch 0/3] MdePkg/UefiDevicePathLib: Enahncement for Sata/Usbxx/AcpiExp device path

2018-10-11 Thread Dandan Bi
https://bugzilla.tianocore.org/show_bug.cgi?id=1243 This pacth series is mainly to do the enahncement for Sata/Usbxx/AcpiExp device path to handle the cases when some optional paremeter is not specified in the text device path. Cc: Ruiyu Ni Cc: Michael D Kinney Cc: Liming Gao Dandan Bi (3):

Re: [edk2] [PATCH v2 0/4] SdMmcOverride extension

2018-10-11 Thread Wu, Hao A
Hi Marcin, Please grant me some time for this series. Since I found that the extension of the SdMmc override protocol (mainly the 3rd and 4th patch of the series) may have something overlaps with a (internal) request to configure the driver strength parameter and operating clock frequency of the

Re: [edk2] [PATCH] BaseTools: Allow multiple PciDeviceId in Fdf OptionROM override

2018-10-11 Thread Zhu, Yonghong
Hi Pilar, Will you update a V2 to cover Jaben's comment ? Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, October 8, 2018 11:00 PM To: Gao, Liming ; Tomas Pilar (tpilar) ;

[edk2] [PATCH] BaseTools: Add --uefi option to enable UefiCompress method

2018-10-11 Thread Yonghong Zhu
From: Yunhua Feng Add one new option --uefi to enable UefiCompress. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/C/TianoCompress/TianoCompress.c | 81 +---

[edk2] [edk2-test][Patch] uefi-sct\SctPkg:Add two checkpoints of GetNextVariable()

2018-10-11 Thread Eric Jin
If a VariableName buffer on input is not a Null-terminated string, EFI_INVALID_PARAMETER is returned. If input values of VariableName and VendorGuid are not a name and GUID of an existing variable, EFI_INVALID_PARAMETER is returned. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 0/4] SdMmcOverride extension

2018-10-11 Thread Marcin Wojtas
Hi Hao, pt., 12 paź 2018 o 07:25 Wu, Hao A napisał(a): > > Hi Marcin, > > Please grant me some time for this series. > > Since I found that the extension of the SdMmc override protocol (mainly > the 3rd and 4th patch of the series) may have something overlaps with a > (internal) request to

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Add TPL Check in SimpleTextIn/SimpleTextInEx

2018-10-11 Thread Eric Jin
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh Cc: Jiaxin Wu --- .../BlackBoxTest/SimpleTextInBBTestFunction.c | 186 .../SimpleTextInputExBBTestConformance.c | 190 ++--

Re: [edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-10-11 Thread Marcin Wojtas
pt., 12 paź 2018 o 03:41 Wu, Hao A napisał(a): > > > -Original Message- > > From: Marcin Wojtas [mailto:m...@semihalf.com] > > Sent: Thursday, October 11, 2018 11:43 PM > > To: Wu, Hao A > > Cc: Ni, Ruiyu; Ard Biesheuvel; Tian, Feng; Tomasz Michalec; Dong, Eric; > > edk2- > > devel-01;

Re: [edk2] [PATCH] ShellPkg-Cd: Ensure all valid cd targets are handled properly

2018-10-11 Thread Ni, Ruiyu
On 10/8/2018 10:53 PM, Carsey, Jaben wrote: Seems good to me. Any thoughts Ray? Reviewed-by: Jaben Carsey Pushed. -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [edk2-test][Patch] Enable the DNS/BLE DevicePath test

2018-10-11 Thread Eric Jin
Add new test for DNS/BlueToothLE DevicePath Resort the assertion guid of DevicePath test Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../BlackBoxTest/DevicePathBBTestFunction.c| 96 ++--

[edk2] [Patch 3/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo Oniguruma https://github.com/kkos/oniguruma this change is merged from oniguruma develop branch. from commit 1db8a2726dfad0401f928cb8474bd770f07040a7. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao ---

[edk2] [Patch 1/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo Oniguruma https://github.com/kkos/oniguruma this change is merged from oniguruma develop branch. from commit 396a757dffafc0c7eb269433c29a0ba961d73ad6. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao ---

[edk2] [Patch 4/4] MdeModulePkg/RegularExpressionDxe: Add null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo There are five check not necessary in logic ,just for pass static analysis. More detail please refer to comment in code. And the rest changes are all accepted by owner, they are reasonable. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch 0/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
Some check are the real issues. Some are for pass static analysis. Dongao Guo (4): MdeModulePkg/RegularExpressionDxe: Miss null pointer check MdeModulePkg/RegularExpressionDxe: Miss null pointer check MdeModulePkg/RegularExpressionDxe: Miss null pointer check

[edk2] [Patch 2/4] MdeModulePkg/RegularExpressionDxe: Miss null pointer check

2018-10-11 Thread Liming Gao
From: Dongao Guo Oniguruma https://github.com/kkos/oniguruma this change is merged from oniguruma develop branch. from commit ea36d810f1d9b28f3ef20bd8d453bea2f7fb598b Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dongao Guo Reviewed-by: Liming Gao ---

[edk2] [Patch v5] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-11 Thread Eric Dong
V5: 1. Add ASSERT to indicate this assumption that environment is 32 bit mode. 2. Add description in INF about this driver's expected result in different environment. V4: Only disable paging when it is enabled. V3 changes: No need to change inf file. V2 changes: Only disable paging in 32 bit

[edk2] [Patch] BaseTools: Enhance the *P Flag display for Structure Pcd

2018-10-11 Thread Yonghong Zhu
Cover the case: 1.only define the structure Pcd in DEC file, it should not have any Flag. 2.In the DEC file and DSC file only have the PCD's default value, and without the field value, it should have *P Flag. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [Patch v5] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-11 Thread Ni, Ruiyu
On 10/11/2018 3:05 PM, Eric Dong wrote: V5: 1. Add ASSERT to indicate this assumption that environment is 32 bit mode. 2. Add description in INF about this driver's expected result in different environment. V4: Only disable paging when it is enabled. V3 changes: No need to change inf file.

[edk2] [edk2-test][Patch] Correct typo in CreateEMMCDeviceNode()

2018-10-11 Thread Eric Jin
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh --- .../DevicePathFromText/BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH] ShellPkg/dmem: Only dump sizeof (EFI_SYSTEM_TABLE) bytes for gST

2018-10-11 Thread Ruiyu Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1236 When "dmem" runs without additional arguments, it dumps the memory content of EFI_SYSTEM_TABLE. But today's implementation dumps 512 bytes. It's not correct because sizeof (EFI_SYSTEM_TABLE) is less than 512, the 512-read causes page fault

[edk2] [Patch] Build Spec: Add description for Structure Pcd display in the module

2018-10-11 Thread Yonghong Zhu
The detail rules are totally same with Global Pcd section. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 13_build_reports/136_global_pcd_section.md | 12 ++--

[edk2] [edk2-test][Patch] uefi-sct\SctPkg: Add the new test of ResetNotification Protocol

2018-10-11 Thread Eric Jin
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin Cc: Supreeth Venkatesh --- uefi-sct/SctPkg/CommonGenFramework.bat | 3 +- uefi-sct/SctPkg/CommonGenFramework.sh | 3 +- uefi-sct/SctPkg/Config/Data/Category.ini | 9 +-

Re: [edk2] [Patch v5] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.

2018-10-11 Thread Laszlo Ersek
On 10/11/18 09:05, Eric Dong wrote: > V5: > 1. Add ASSERT to indicate this assumption that environment is 32 bit mode. > 2. Add description in INF about this driver's expected result >in different environment. > > V4: > Only disable paging when it is enabled. > > V3 changes: > No need to

Re: [edk2] [PATCH] ShellPkg/dmem: Only dump sizeof (EFI_SYSTEM_TABLE) bytes for gST

2018-10-11 Thread Jim.Dailey
Is the line: Size = gST->Hdr.HeaderSize; possibly a better way of handling this? Either way: Reviewed-by: Jim Dailey -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, October 11, 2018 2:53 AM To:

[edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1241 FSP will support both API and DISPATCH mode and require one field from Global Data Structure to tell which mode is selected by boot loader. Use one reserved byte for FSP API mode indicator - FspApiModeEnabled and maintain backward

Re: [edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Yao, Jiewen
Thanks Chasel. I suggest we test the real function besides just pass build. Please make sure your test below combination: 1) FSP wrapper with this change + FSP binary with this change. 2) FSP wrapper with this change + FSP binary without this change. Thank you Yao Jiewen > -Original

Re: [edk2] [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

2018-10-11 Thread Chiu, Chasel
Hi Jiewen, This one just adding a new field in FspGlobalData structure which never been consumed in current code base. I'm checking if we should combine DISPATCH mode support code together instead of just header change. Thanks! Chasel -Original Message- From: Yao, Jiewen Sent: