Re: [edk2] [PATCH 0/2] Add sanity check for FilePath device path

2019-01-28 Thread Wang, Jian J
Miss the test info: - Boot shell - Boot to Fedora 26 (Qemu/x64) - Boot to Ubuntu 18.04 (Qemu/x64) - Boot to Windows 10 (Qemu/x64) - Boot to Windows 7 (Qemu/x64) Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang >

[edk2] [PATCH v3 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-28 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 This feature is used for finding GPT partition. Follow the following step to check. 1) Check Protective MBR. 2) Check GPT primary/backup header. 3) Check GPT primary/backup entry array. Cc: Ruiyu Ni Cc: Zhang Chao B Contributed-under:

[edk2] [PATCH v3 2/3] MdePkg/UefiGpt.h: Add new definition for enable GPT support

2019-01-28 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 This definition comes from UEFI Spec to support GPT in FatPei driver. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen Reviewed-by: Liming Gao ---

[edk2] [PATCH v3 1/3] FatPkg: Break down Part.c file.

2019-01-28 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 Break down partition parsing logic to 2 parts, Eltorito and MBR. Cc: Ruiyu Ni Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen Reviewed-by: Hao Wu --- FatPkg/FatPei/Eltorito.c | 239

[edk2] [PATCH v2 0/3] FatPkg/GPT: Introduce GPT patch v3

2019-01-28 Thread Chen A Chen
No function change, fix code style issue. Chen A Chen (3): FatPkg: Break down Part.c file. MdePkg/UefiGpt.h: Add new definition for enable GPT support FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature. FatPkg/FatPei/Eltorito.c | 239 ++

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-28 Thread Bi, Dandan
Hi Neo, Thank you very much for the patch. Some minor comments 1) Besides the skip check in this patch, could you help to add additional check for RelocDir->Size before calling PeCoffLoaderImageAddress to calculate the RelocBase and RelocBaseEnd? Since when RelocDir->Size==0, we can just

Re: [edk2] [PATCH v3] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()

2019-01-28 Thread Ni, Ruiyu
On 1/29/2019 2:53 PM, Shenglei Zhang wrote: From: Mike Turner Introduce public functions Base64Encode and Base64Decode. https://bugzilla.tianocore.org/show_bug.cgi?id=1370 v2:1.Remove some white space. 2.Add unit test with test vectors in RFC 4648.

[edk2] [PATCH v3 2/4] MdeModulePkg/CapsuleApp: Add a function used to get next DevicePath

2019-01-28 Thread Chen A Chen
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482 Add a new function to support Capsule-on-Disk feature. This function is used to get next full DevicePath from a load option. Cc: Jian J Wang Cc: Hao Wu Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v3 0/4] Introduce CapsuleApp patch v3

2019-01-28 Thread Chen A Chen
Fix Typo and code style issue, no any function change. According to package owner's input, Split this patch to smaller granularity. Chen A Chen (4): MdePkg/UefiSpec.h: Add definition to support Capsule-on-Disk feature MdeModulePkg/CapsuleApp: Add a function used to get next DevicePath

[edk2] [PATCH v3 3/4] MdeModulePkg/CapsuleApp: Add functions to support Capsule-on-Disk

2019-01-28 Thread Chen A Chen
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482 This file provide some basic function to support Capsule-on-Disk. Cc: Jian J Wang Cc: Hao Wu Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen ---

[edk2] [PATCH v3 4/4] MdeModulePkg/CapsuleApp: Enhance CapsuleApp to support Capsule-on-Disk

2019-01-28 Thread Chen A Chen
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482 CapsuleApp is used for trigger capsule update. Add -OD option in CapsuleApp to support doing capsule update via storage. Add -F and -L options to support dumping information feature. Finish unit test for -F and -L options. Already verify this

[edk2] [PATCH v3 1/4] MdePkg/UefiSpec.h: Add definition to support Capsule-on-Disk feature

2019-01-28 Thread Chen A Chen
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482 UEFI Spec define this definition to support Capsule-on-Disk. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- MdePkg/Include/Uefi/UefiSpec.h | 5

Re: [edk2] [PATCH v4 2/7] MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly

2019-01-28 Thread Ni, Ruiyu
On 12/25/2018 4:17 PM, Shenglei Zhang wrote: Introduce two public functions CharToUpper and AsciiToUpper. They have the same functions as InternalCharToUpper and InternalBaseLibAsciiToUpper.Considering the internal functions will be removed,so directly I change their function names to the public

[edk2] [PATCH v3] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()

2019-01-28 Thread Shenglei Zhang
From: Mike Turner Introduce public functions Base64Encode and Base64Decode. https://bugzilla.tianocore.org/show_bug.cgi?id=1370 v2:1.Remove some white space. 2.Add unit test with test vectors in RFC 4648. https://github.com/shenglei10/edk2/tree/encode_test

Re: [edk2] [PATCH edk2-platforms 02/41] Silicon/NXP : Add support for Watchdog driver

2019-01-28 Thread Meenakshi Aggarwal
> -Original Message- > From: Leif Lindholm > Sent: Monday, December 17, 2018 11:06 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; michael.d.kin...@intel.com; edk2- > de...@lists.01.org; Udit Kumar ; Varun Sethi > > Subject: Re: [PATCH edk2-platforms 02/41] Silicon/NXP :

[edk2] [RFC] Proposal to split Pkgs

2019-01-28 Thread Ni, Ray
Hello, I'd like to propose to split today's BIG packages in following ways: ==Overview = 1. Separate Industry standard definitions from UEFI and PI interfaces. 2. Separate UEFI and PI interfaces from implementations. a. Separate UEFI and PI interfaces to different

Re: [edk2] Network Stack Budgeting

2019-01-28 Thread Tomas Pilar (tpilar)
Hi Siyuan, I had to do some tweaks due to the fact that people in the wild want to PXE boot whole WDS installations which are upwards of 300MB. I have an internal set of queues where the NIC receives into. Snp.Receive() will get a packet from this store. I had to implement a separate queue for

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-28 Thread Laszlo Ersek
On 01/28/19 11:46, Mark Rutland wrote: > On Wed, Jan 23, 2019 at 10:54:56AM +0100, Laszlo Ersek wrote: >> On 01/23/19 10:26, Ard Biesheuvel wrote: >>> On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: On 01/22/19 16:37, Ard Biesheuvel wrote: >> > Is SetUefiImageMemoryAttributes() being

[edk2] [platforms: PATCH v3 3/5] Marvell/Library: Introduce common header for the SMC ID's

2019-01-28 Thread Marcin Wojtas
Marvell firmware allows to use SiP services other than for ComPhy handling. In order to avoid spreading the SMC ID's definitions across many files, introduce common header for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v3 4/5] Marvell/Library: ArmadaSoCDescLib: Add North Bridge description

2019-01-28 Thread Marcin Wojtas
From: Grzegorz Jaszczyk For upcomming patch there is need to get AP806 base, provide required getter function for it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm ---

[edk2] [platforms: PATCH v3 5/5] Marvell/Armada7k8k: Read DRAM settings from ARM-TF

2019-01-28 Thread Marcin Wojtas
From: Grzegorz Jaszczyk The memory controller registers are marked as secure in the latest ARM-TF for Armada SoCs. It is available however get the DRAM information via SiP services in the EL3, so use it instead of accessing the registers directly. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5

2019-01-28 Thread Ard Biesheuvel
On Mon, 28 Jan 2019 at 02:56, Bi, Dandan wrote: > > Reviewed-by: Bi Dandan > Thanks all Pushed as 12a0a80b4aee..945c1d55c933 > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Friday, January 25, 2019 4:12 PM

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-28 Thread Mark Rutland
On Wed, Jan 23, 2019 at 03:02:14PM +0100, Ard Biesheuvel wrote: > On Wed, 23 Jan 2019 at 10:55, Laszlo Ersek wrote: > > > > On 01/23/19 10:26, Ard Biesheuvel wrote: > > > On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: > > >> On 01/22/19 16:37, Ard Biesheuvel wrote: > > > > >>> Is

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-28 Thread Ard Biesheuvel
On Mon, 28 Jan 2019 at 11:23, Mark Rutland wrote: > > On Wed, Jan 23, 2019 at 03:02:14PM +0100, Ard Biesheuvel wrote: > > On Wed, 23 Jan 2019 at 10:55, Laszlo Ersek wrote: > > > > > > On 01/23/19 10:26, Ard Biesheuvel wrote: > > > > On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: > > > >> On

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-28 Thread Feng, Bob C
Hi Laszlo, I sent out 2 patches to fix this issue. And I also pushed the patches to the repo https://github.com/BobCF/edk2.git branch py3basetools Thanks, Bob -Original Message- From: Feng, Bob C Sent: Monday, January 28, 2019 10:33 AM To: 'Laszlo Ersek' Cc: edk2-devel@lists.01.org;

Re: [edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2019-01-28 Thread Mark Rutland
On Wed, Jan 23, 2019 at 10:54:56AM +0100, Laszlo Ersek wrote: > On 01/23/19 10:26, Ard Biesheuvel wrote: > > On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote: > >> On 01/22/19 16:37, Ard Biesheuvel wrote: > > >>> Is SetUefiImageMemoryAttributes() being > >>> called to remap the memory R-X ? > >>

[edk2] [platforms: PATCH v3 2/5] Marvell/Armada7k8k: Shift PEI stack base and extend memory reservation

2019-01-28 Thread Marcin Wojtas
Recent changes in the ARM-TF configure its runtime serices region as protected, hence the hitherto PEI stack base address (0x41F) violated it. Additional region needs to also be reserved to cover OP-TEE In order to fix this, add more regions which are non-accessible by the OS to cover: * the

[edk2] [platforms: PATCH v3 0/5] Armada7k8k memory handling update

2019-01-28 Thread Marcin Wojtas
Hi, The third version of the patchset moves the new common header for Marvell SMC ID's to the IndustryStandard directory. What is more important, now 3 regions (described by new PCDs) are reserved separately. For that purpose a preparation patch was added, which extract existing reservation code

[edk2] [platforms: PATCH v3 1/5] Marvell/Armada7k8k: Refactor reserving memory regions

2019-01-28 Thread Marcin Wojtas
Extract reserving memory region in the Hob list into a separate routine. It is a preparation for adding multiple of such regions in a following patch. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

<    1   2