[edk2] [PATCH 09/14] ArmVirtPkg: don't set PcdDebugPrintErrorLevel in RELEASE builds

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Qemu,QemuKernel,Xen} x {RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Restrict the PCD setting to ($(TARGET) !=

[edk2] [PATCH 10/14] ArmVirtPkg/ArmVirtXen: don't set PcdPL031RtcBase

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Remove the setting. ("feat-1" stands for "-D

[edk2] [PATCH 14/14] ArmVirtPkg/ArmVirtXen: don't set Pcd*ImageVerificationPolicy

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Xen} x {DEBUG,NOOPT,RELEASE} x {feat-1} (6 builds in total), PcdOptionRomImageVerificationPolicy, PcdFixedMediaImageVerificationPolicy, and

[edk2] [PATCH 03/14] ArmVirtPkg/{ArmVirtQemu, ArmVirtQemuKernel}: don't set PcdTrustzoneSupport

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Qemu,QemuKernel} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (24 builds in total), the PCD is not used in any of those builds. Remove the setting. ("feat-1"

[edk2] [PATCH 01/14] ArmVirtPkg/ArmVirtQemuKernel: don't set PcdCPUCoresStackBase

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {QemuKernel} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Remove the setting. ("feat-1" stands for

[edk2] [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs

2019-02-06 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: armvirt_pcd_clean (1) The procedure described below depends on: [edk2] [PATCH] BaseTools/BuildReport: fix report for platforms/arches without struct PCDs

[edk2] [PATCH 04/14] ArmVirtPkg: don't set PcdPostCodePropertyMask

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Qemu,QemuKernel,Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (36 builds in total), the PCD is not used in any of those builds. Remove the setting.

[edk2] [PATCH 08/14] ArmVirtPkg: don't set PcdDebugClearMemoryValue

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Qemu,QemuKernel,Xen} x {RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Rather than just restrict the PCD setting to

[edk2] [PATCH 12/14] ArmVirtPkg/ArmVirtXen: don't set PcdShellFile

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Remove the setting. ("feat-1" stands for "-D

[edk2] [PATCH 06/14] ArmVirtPkg/PrePi: drop wrong PcdCoreCount dependency

2019-02-06 Thread Laszlo Ersek
The PcdCoreCount dependency in the "ArmVirtPrePiUniCoreRelocatable.inf" file is false; the module doesn't consume the PCD. Clean up the INF. Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 07/14] ArmVirtPkg: don't set PcdCoreCount

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Qemu,QemuKernel,Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (36 builds in total), the PCD is not used in any of those builds. Remove the setting.

[edk2] [PATCH 05/14] ArmVirtPkg: clean up PcdSetNxForStack setting (applies to ArmVirtQemu only)

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {QemuKernel,Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (24 builds in total), the PCD is not used in any of those builds. Move the setting from

[edk2] [PATCH 02/14] ArmVirtPkg: don't set PcdRelocateVectorTable

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Qemu,QemuKernel,Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (36 builds in total), the PCD is not used in any of those builds. Remove the setting.

[edk2] [PATCH 13/14] ArmVirtPkg/ArmVirtXen: don't set PcdTurnOffUsbLegacySupport

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Restrict the setting to the ArmVirtQemu and

[edk2] [PATCH 11/14] ArmVirtPkg/ArmVirtXen: don't set PcdTerminalTypeGuidBuffer

2019-02-06 Thread Laszlo Ersek
According to the PCDs not used by modules or in conditional directives sections of all the build reports for {AARCH64,ARM} x {Xen} x {DEBUG,NOOPT,RELEASE} x {feat-0,feat-1} (12 builds in total), the PCD is not used in any of those builds. Restrict the setting to the ArmVirtQemu and

Re: [edk2] [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference

2019-02-06 Thread Ryszard Knop
Mike, As mentioned in previous mails, we can't change some of our code to meet the coding standard. I've filled BZ #1516 with everything we need, plus what CryptoPkg provides for reference. Thanks, Richard. On Wed, 2019-01-30 at 20:58 +, Kinney, Michael D wrote: > Hi Richard, > > It is

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 1:03 PM, Philippe Mathieu-Daudé wrote: [...] > > Reported-by: Leif Lindholm > Fixes: f8d11e5a4aaa90bf63b4789f3993dd6d16c60787 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Philippe Mathieu-Daude > Tested-by: Leif Lindholm > Acked-by: Laszlo Ersek > --- >

Re: [edk2] [PATCH] AppPkg: Various typo

2019-02-06 Thread Philippe Mathieu-Daudé
Hi Antoine, I'd rename the patch subject as "AppPkg: Fix various typos" On 2/6/19 7:10 AM, Antoine Coeur wrote: > Various typo in AppPkg, ignoring Python folder. Ditto. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur Reviewed-by: Philippe Mathieu-Daude >

[edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Philippe Mathieu-Daudé
With Python3, the dict.value() method returns an iterator. If a dictionary is updated while an iterator on its keys is used, a RuntimeError is generated. Converting the iterator to a list() forces a copy of the mutable keys in an immutable list which can be safely iterated. Commit f8d11e5a4aaa

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-06 Thread Laszlo Ersek
On 02/06/19 18:44, Rebecca Cran wrote: > On Wednesday, 6 February 2019 09:36:43 MST Laszlo Ersek wrote: > >> please refer to the HTTP_BOOT_ENABLE define in the OVMF DSC files; the >> default value is FALSE. >> >> If you'd like HTTP over IPv6, then please pass -D NETWORK_IP6_ENABLE on >> the

Re: [edk2] [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs

2019-02-06 Thread Ard Biesheuvel
On Wed, 6 Feb 2019 at 12:11, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > Branch: armvirt_pcd_clean > > (1) The procedure described below depends on: > > [edk2] [PATCH] > BaseTools/BuildReport: fix report for platforms/arches without struct PCDs > >

[edk2] [PATCH v2] ArmPlatformPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in ArmPlatformPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++-- ArmPlatformPkg/Include/Library/ArmPlatformLib.h| 2 +- ArmPlatformPkg/Include/Library/PL011UartLib.h | 2 +-

[edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in CryptoPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 06, 2019 8:26 AM > To: Philippe Mathieu-Daudé ; Kinney, Michael D > ; edk2-devel@lists.01.org; Carsey, Jaben > > Cc: Leif Lindholm > Subject: Re:

[edk2] [PATCH v2] ArmPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in ArmPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- .../Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.c | 2 +- ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c | 2 +- ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 2 +-

[edk2] [PATCH] CorebootPayloadPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in CorebootPayloadPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- CorebootPayloadPkg/FbGop/FbGop.c | 8 +- CorebootPayloadPkg/FbGop/FbGop.h | 8 +- .../Library/PciHostBridgeLib/PciHostBridge.h | 2 +-

Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos

2019-02-06 Thread Laszlo Ersek
On 02/06/19 16:48, Antoine Coeur wrote: > Fix various typos in ArmVirtPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c

[edk2] [PATCH v2] AppPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in AppPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- AppPkg/Applications/Enquire/Enquire.c | 2 +- AppPkg/Applications/Sockets/DataSource/DataSource.c | 4 ++-- AppPkg/Applications/Sockets/SetHostName/SetHostName.c |

[edk2] [PATCH v2] ArmVirtPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in ArmVirtPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- ArmVirtPkg/ArmVirt.dsc.inc | 2 +- ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c| 2 +-

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-06 Thread Laszlo Ersek
Hello Rebecca, On 02/06/19 07:06, Rebecca Cran via edk2-devel wrote: > I'm trying to fetch a file over HTTP in a boot loader, but gBS- >> LocateHandleBuffer doesn't find either of the >> EFI_TCP4_SERVICE_BINDING_PROTCOL > or EFI_HTTP_SERVICE_BINDING_PROTOCOL. > > I'm running a build of OVMF

[edk2] [PATCH] CorebootModulePkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in CorebootModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- .../Include/Library/CbParseLib.h | 36 +-- .../BaseSerialPortLib16550.c | 12 +++ .../Library/CbParseLib/CbParseLib.c

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-06 Thread Rebecca Cran via edk2-devel
On Wednesday, 6 February 2019 09:36:43 MST Laszlo Ersek wrote: > please refer to the HTTP_BOOT_ENABLE define in the OVMF DSC files; the > default value is FALSE. > > If you'd like HTTP over IPv6, then please pass -D NETWORK_IP6_ENABLE on > the "build" cmdline as well. Thanks. I'm already

Re: [edk2] [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs

2019-02-06 Thread Laszlo Ersek
On 02/06/19 16:46, Ard Biesheuvel wrote: > On Wed, 6 Feb 2019 at 12:11, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> Branch: armvirt_pcd_clean >> >> (1) The procedure described below depends on: >> >> [edk2] [PATCH] >> BaseTools/BuildReport: fix report for

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Laszlo Ersek
On 02/06/19 13:03, Philippe Mathieu-Daudé wrote: > With Python3, the dict.value() method returns an iterator. > If a dictionary is updated while an iterator on its keys is used, > a RuntimeError is generated. > Converting the iterator to a list() forces a copy of the mutable > keys in an immutable

[edk2] [PATCH v2] BeagleBoardPkg: Fix various typos

2019-02-06 Thread Antoine Coeur
Fix various typos in BeagleBoardPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++-- BeagleBoardPkg/Library/BeagleBoardLib/Clock.c | 2 +-

Re: [edk2] [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Laszlo Ersek
On 02/05/19 22:20, Carsey, Jaben wrote: > Laszlo, > > not sure which Andrew you wanted, but he didn’t get added so far as I can > tell. He did, it's just the mailman2 list software pulling tricks on us again. The default setting for list subscribers is to eliminate duplicates. That is, if you

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-06 Thread Philippe Mathieu-Daudé
Hi Antoine, On 2/6/19 6:24 PM, Antoine Coeur wrote: > Fix various typos in CryptoPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4

Re: [edk2] [PATCH v5 edk2-platforms 18/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add ATF binaries

2019-02-06 Thread Kinney, Michael D
Hi Pete, We have the edk2-non-osi repository for binaries. Do some of the patches in this series really belong there? https://github.com/tianocore/edk2-non-osi Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Pete Batard >

Re: [edk2] [PATCH v5 edk2-platforms 18/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add ATF binaries

2019-02-06 Thread Pete Batard
Hi Michael, On 2019.02.06 22:39, Kinney, Michael D wrote: Hi Pete, We have the edk2-non-osi repository for binaries. Not exactly sure what your point is since this patch is tagged *NON-OSI* in its subject line which means it is intended to go into edk2-non-osi, and we already went over

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't restored sometimes

2019-02-06 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Friday, February 01, 2019 4:59 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray; Wu, Hao A; Bi, Dandan > Subject: [PATCH] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't > restored sometimes > > From: Ruiyu Ni > > REF:

Re: [edk2] OVMF and TCP4, HTTP protocols

2019-02-06 Thread Rebecca Cran via edk2-devel
On Wednesday, 6 February 2019 12:05:08 MST Laszlo Ersek wrote: > Is "loader.efi" opaque, or do we know what it does? It's the FreeBSD loader, so I have the complete source code for it and can rebuild it. > For example, if it opens SNP with BY_DRIVER|EXCLUSIVE attributes, then > everything on

Re: [edk2] [PATCH v5 edk2-platforms 18/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add ATF binaries

2019-02-06 Thread Kinney, Michael D
Hi Pete, When I saw it as a single patch series, I did assume all the patches were for the edk2-platforms repo. And it looked like non-OSI binaries were going into the edk2-platforms repo. Patch #0 did not make this clear either that multiple repos were targeted. I have not seen a patch series

Re: [edk2] [PATCH v2] ArmPlatformPkg: Fix various typos

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 4:46 PM, Antoine Coeur wrote: > Fix various typos in ArmPlatformPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++-- > ArmPlatformPkg/Include/Library/ArmPlatformLib.h| 2 +- >

Re: [edk2] [PATCH v2] BaseTools: Fix build failure when specifying multiple BUILDTARGET

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 10:11 PM, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > And pushed. Thanks! And I learned the hard way git config 'user.name' is obviously different than 'sendemail.from'... Liming asked me to not use non-ASCII character in commit message so I fixed my user.name, but forgot

[edk2] FW: [PATCH] BaseTools/BuildReport: fix report for platforms/arches without struct PCDs

2019-02-06 Thread Carsey, Jaben
I sent this earlier, but failed the mailing list part. Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Vladimir Olovyannikov via edk2-devel > Sent: Tuesday, February 05, 2019 8:58 AM > To: Laszlo Ersek

Re: [edk2] [PATCH v2] AppPkg: Fix various typos

2019-02-06 Thread Philippe Mathieu-Daudé
Hi Antoine, On 2/6/19 4:37 PM, Antoine Coeur wrote: > Fix various typos in AppPkg. Thanks for updating the title and description. The content looks the same than v1, so you could have kept my R-b tag. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur

Re: [edk2] [PATCH v2] BeagleBoardPkg: Fix various typos

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 4:51 PM, Antoine Coeur wrote: > Fix various typos in BeagleBoardPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur Reviewed-by: Philippe Mathieu-Daude > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++-- >

Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos

2019-02-06 Thread Philippe Mathieu-Daudé
On 2/6/19 4:48 PM, Antoine Coeur wrote: > Fix various typos in ArmVirtPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur Reviewed-by: Philippe Mathieu-Daude > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- >

Re: [edk2] [PATCH] CryptoPkg: Fix various typos

2019-02-06 Thread Wang, Jian J
Coeur, > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Antoine Coeur > Sent: Thursday, February 07, 2019 1:25 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] CryptoPkg: Fix various typos > > Fix various typos in CryptoPkg. > >

[edk2] [PATCH] BeagleBoardPkg: Various typo

2019-02-06 Thread Antoine Coeur
Various typo in BeagleBoardPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++-- BeagleBoardPkg/Library/BeagleBoardLib/Clock.c | 2 +- BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoff.c |

Re: [edk2] [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference

2019-02-06 Thread Ryszard Knop
Andrew, Unfortunately, not assigning something too large or using math functions is not an option for us, as we share a significant amount of code with Linux/FreeBSD drivers and maintainers of that code don't want changes similar to the ones below (especially that, for all the other drivers,