[edk2] [PATCH 2/4] EmbeddedPkg/DwEmmc: Fix SendCommand parameters

2019-02-22 Thread tien . hock . loh
From: "Loh, Tien Hock" Only send BIT_CMD_CHECK_RESPONSE_CRC if MMC commands needs it. Fixes parameters to ACMD6 where if CMD is application command, ie. CMD55 is sent before ACMD6, to do response instead of data transfer. Added CMD51 handling as CMD51 is a data transfer, and needs BIT_CMD_READ

[edk2] [PATCH 3/4] EmbeddedPkg/DwEmmc: Fix DMA transfer length

2019-02-22 Thread tien . hock . loh
From: "Loh, Tien Hock" DMA should not transfer more than requested length otherwise FIFO might run into buffer underrun and causes errors in future transfers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Loh Tien Hock --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c |

[edk2] [PATCH 0/4] EmbeddedPkg/DwEmmc: Fix bugs causing DwEmmc to fail to initialize

2019-02-22 Thread tien . hock . loh
From: "Tien Hock, Loh" This patch series fixes bugs with DwEmmc driver, namely: * Added CMD6 handling * Fixed workaround querying SendCommand using delays * Fix DMA transfer length causing buffer underrun in FIFO * Check DMA completion before returning from SendCommand Loh, Tien Hock (3):

Re: [edk2] [PATCH V2 2/3] UefiCpuPkg/ExceptionLib: Add CET support.

2019-02-22 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Yao, Jiewen > Sent: Friday, February 22, 2019 7:00 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek > ; Yao, Jiewen > Subject: [PATCH V2 2/3] UefiCpuPkg/ExceptionLib: Add CET support. > > REF:

Re: [edk2] [PATCH V3 0/4] Add SMM CET support

2019-02-22 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Yao, Jiewen > Sent: Friday, February 22, 2019 9:31 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; Laszlo Ersek ; Yao, Jiewen > > Subject: [PATCH V3 0/4] Add SMM CET support > > REF:

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-22 Thread Laszlo Ersek
On 02/22/19 05:15, Jiewen Yao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 > > This patch series implement add CET ShadowStack support for SMM. > > The CET document can be found at: >

Re: [edk2] [Patch edk2 wiki] Add new feature: WiFi Connection Manager for edk2-stable201903 in EDK-II-Release-Planning

2019-02-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wang, Fan > Sent: Wednesday, February 13, 2019 11:27 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch edk2 wiki] Add new feature: WiFi Connection Manager for > edk2-stable201903 in EDK-II-Release-Planning > > Cc:

Re: [edk2] [PATCH V2 1/3] MdePkg/BaseLib: Add Shadow Stack Support for X86.

2019-02-22 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Yao, Jiewen > Sent: Friday, February 22, 2019 7:00 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek > ; Yao, Jiewen > Subject: [PATCH V2 1/3] MdePkg/BaseLib: Add Shadow Stack Support for X86. > > REF:

[edk2] [PATCH V3 3/4] UefiCpuPkg/ExceptionLib: Add CET support.

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 Add information dump for Control Protection exception. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yao Jiewen ---

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-22 Thread Yao, Jiewen
Thanks Laszlo. 2) I have checked NASM instruction list at https://www.nasm.us/xdoc/2.14.02/html/nasmdocb.html SSP related instruction is not there. I believe using DB maybe the only choice at this moment. I will create include file. 3) I will fix comment. Thanks to catch that. >

[edk2] [PATCH V3 4/4] UefiCpuPkg/PiSmmCpu: Add Shadow Stack Support for X86 SMM.

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 We scan the SMM code with ROPgadget. http://shell-storm.org/project/ROPgadget/ https://github.com/JonathanSalwan/ROPgadget/tree/master This tool reports the gadget in SMM driver. This patch enabled CET ShadowStack for X86 SMM. If CET is

[edk2] [PATCH V3 2/4] MdePkg/BaseLib: Add Shadow Stack Support for X86.

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 This patch adds SSP - shadow stack pointer to JumpBuffer. It will be used for the platform that enabled CET/ShadowStack. We add gEfiMdePkgTokenSpaceGuid.PcdControlFlowEnforcementPropertyMask to control the global enable/disable. Cc:

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-22 Thread Yao, Jiewen
The V3 patch is posted. I add NASM.INC files. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yao, Jiewen > Sent: Friday, February 22, 2019 8:11 PM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ;

[edk2] [PATCH V3 1/4] MdePkg/Include: Add Nasm.inc

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 This is to add CET related instruction in Nasm because CET instruction is not supported yet. See https://www.nasm.us/xdoc/2.14.02/html/nasmdocb.html Cc: Michael D Kinney Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek

[edk2] [PATCH V3 0/4] Add SMM CET support

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 V3: Add Nasm.inc to include CET related instruction as MACRO. This is the only place to use DB. Any other NASM just use the MACRO - SETSSBSY, READSSP_[E|R]AX, INCSSP_[E|R]AX = V2: Fix emulation platform issue. The NT32

[edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-22 Thread Gao, Liming
Hi, all https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning lists edk2-stable201903 tag planning. Now, we enter into Soft Feature Freeze phase. In this phase, the feature without Reviewed-by or Acked-by tags will be delayed after the upcoming stable tag. The patch

Re: [edk2] [PATCH] MdeModulePkg: Rename confusion function name

2019-02-22 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Chen, Chen A > Sent: Friday, February 22, 2019 8:34 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Ni, Ray ; Gao, > Liming > Subject: [PATCH] MdeModulePkg: Rename confusion function name > > REF:

Re: [edk2] [PATCH] IntelSiliconPkg/MicrocodeUpdate: Fix incorrect checksum issue

2019-02-22 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen > A Chen > Sent: Friday, February 22, 2019 8:49 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] IntelSiliconPkg/MicrocodeUpdate: Fix incorrect > checksum

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-22 Thread Rebecca Cran via edk2-devel
On 2/8/19 10:52 AM, Andrew Fish wrote: I think the patch workflow is kind of like a coding standards. Some folks advocate for lots of small patches (common in open source projects), and some folks advocate for a patch per bug. I think the biggest upside to the patch granularity is it is much

Re: [edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-22 Thread Laszlo Ersek
On 02/22/19 02:05, Bi, Dandan wrote: > Hi Laszlo, > > Thanks for helping fix it. > Reviewed-by: Bi Dandan Thanks! I'll wait for Ray's review too. Cheers! Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, February 21, 2019 6:41 PM >> To:

[edk2] [PATCH V2 1/3] MdePkg/BaseLib: Add Shadow Stack Support for X86.

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 This patch adds SSP - shadow stack pointer to JumpBuffer. It will be used for the platform that enabled CET/ShadowStack. We add gEfiMdePkgTokenSpaceGuid.PcdControlFlowEnforcementPropertyMask to control the global enable/disable. Cc: Eric

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-22 Thread Yao, Jiewen
Thank you Laszlo. I just fixed the emulation platform issue (NT32). So I posted the V2 version. Please review the latest version and ignore this one. Sorry for the inconvenience. Thank you Yao Jiewen > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday,

Re: [edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-22 Thread Ni, Ray
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 21, 2019 6:41 PM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Ni, Ray ; Sean Brogan > ; Zeng, Star > Subject: [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib:

[edk2] [Patch] BaseTools: Add parameter check for the AsciiStringToUint64

2019-02-22 Thread Feng, Bob C
If the input parameter AsciiString length is greater than 255, the GenFv will hang. This patch is to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/Common/ParseInf.c | 4 ++-- 1 file changed, 2

Re: [edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-22 Thread Laszlo Ersek
On 02/22/19 12:50, Ni, Ray wrote: > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, February 21, 2019 6:41 PM >> To: edk2-devel@lists.01.org >> Cc: Bi, Dandan ; Wu, Hao A ; >> Wang, Jian J ; Ni, Ray ; Sean Brogan >> ; Zeng, Star >> Subject:

Re: [edk2] [patch edk2-wiki] Update ECC wiki page

2019-02-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, > Dandan > Sent: Monday, February 18, 2019 3:36 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [patch edk2-wiki] Update ECC wiki page > >

Re: [edk2] [Patch] BaseTools: Add parameter check for the AsciiStringToUint64

2019-02-22 Thread Gao, Liming
Bob: This function is used to convert string to UINT64. So, the string len should not be too long. I think UINT8 max value 255 is enough for its usage. Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Friday, February 22, 2019 6:05 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-22 Thread Ard Biesheuvel
On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Incremental builds are still broken for me, even with this patch. Is anyone else seeing the same? > >-Original Message- > >From: Feng, Bob C > >Sent: Wednesday, February 20, 2019 11:22 PM > >To:

[edk2] [PATCH v1 1/1] ArmPkg: Fix writes to GICv3 GICD_IROUTER reg

2019-02-22 Thread Sami Mujawar
According to ARM Generic Interrupt Controller Architecture Specification, GIC architecture version 3.0 and version 4.0, GICD_IROUTER is a 64-bit register. Fixed code to use 64 bit MMIO write operations so that the Aff3 value (bits [39:32]) is written to GICD_IROUTER. Contributed-under: TianoCore

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-22 Thread Laszlo Ersek
On 02/22/19 20:21, Ard Biesheuvel wrote: > On Fri, 22 Feb 2019 at 08:26, Gao, Liming wrote: >> >> Reviewed-by: Liming Gao >> > > Incremental builds are still broken for me, even with this patch. Is > anyone else seeing the same? I am not; but I've been using Python3.4 for a while now (it is

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-22 Thread Laszlo Ersek
Hi Liming, On 02/22/19 15:25, Gao, Liming wrote: > Hi, all > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > lists edk2-stable201903 tag planning. Now, we enter into Soft Feature Freeze > phase. In this phase, the feature without Reviewed-by or Acked-by tags

Re: [edk2] Configure bugs.tianocore.org as an alias for bugzilla.tianocore.org?

2019-02-22 Thread stephano
On 2/22/2019 12:13 PM, Laszlo Ersek wrote: On 02/22/19 20:56, stephano wrote: That IP address maps back to "ec2-54-245-252-80.us-west-2.compute.amazonaws.com" (reverse DNS). Huh, good to know, thank you. /me texting Bezos to complain... ___

Re: [edk2] Configure bugs.tianocore.org as an alias for bugzilla.tianocore.org?

2019-02-22 Thread stephano
On 2/21/2019 4:15 PM, Rebecca Cran via edk2-devel wrote: Could we allow people to access the Bugzilla tracker via bugs.tianocore.org (in addition to bugzilla.tianocore.org) please? Sure, let me look into this. I know it is an "easy" fix, but I'm not the admin, so I'll work with that vendor

Re: [edk2] Configure bugs.tianocore.org as an alias for bugzilla.tianocore.org?

2019-02-22 Thread Laszlo Ersek
On 02/22/19 20:56, stephano wrote: > > On 2/21/2019 4:15 PM, Rebecca Cran via edk2-devel wrote: >> Could we allow people to access the Bugzilla tracker via >> bugs.tianocore.org (in addition to bugzilla.tianocore.org) please? > > Sure, let me look into this. I know it is an "easy" fix, but I'm

Re: [edk2] [Patch] BaseTools: Enable component override functionality

2019-02-22 Thread Felix Polyudov
Bob, Do you know if DSC specification has been updated to document this new behavior? If not, it should be updated. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF Sent: Thursday, January 10, 2019 9:39 PM To: edk2-devel@lists.01.org Cc:

[edk2] [PATCH] Update resolv.conf to use Google's DNS servers.

2019-02-22 Thread Rebecca Cran via edk2-devel
The current servers listed appear to be unusable. I suspect most people will get correct DNS servers via DHCP, but the defaults should work for anyone. --- StdLib/Efi/StdLib/etc/resolv.conf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/StdLib/Efi/StdLib/etc/resolv.conf

Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-22 Thread Rebecca Cran via edk2-devel
On 2/22/19 10:18 PM, Rebecca Cran wrote: -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2 I removed the sourceforge git mirror because the latest changeset is from a couple of weeks ago. We already have Github and Bitbucket, so I'm not sure of the value of having a third mirror

[edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror

2019-02-22 Thread Rebecca Cran via edk2-devel
--- Maintainers.txt | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 7f1061d6c1..d9d3d840c5 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -31,11 +31,10 @@ Descriptions of section entries: EDK II -- -W:

[edk2] [PATCH 4/4] EmbeddedPkg/DwEmmc: Check DMA completion in SendCommand

2019-02-22 Thread tien . hock . loh
From: "Tien Hock, Loh" DwEmmcReadBlockData and DwEmmcWriteBlockData needs to check for the transfer completion before returning. This also adds error checking to the DMA transfer. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tien Hock, Loh ---

[edk2] [PATCH 1/4] EmbeddedPkg/DwEmmc: Remove unnecessary MicroSecondDelay

2019-02-22 Thread tien . hock . loh
From: "Loh, Tien Hock" Existing implementation checks for error regardless of if DWEMMC_INT_CMD_DONE is set, causing the loop check to errors out even when it shouldn't if the MicroSecondDelay doesn't do long enough delays. This removes MicroSecondDelay and updates the function to check for

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-22 Thread Laszlo Ersek
Hi Jiewen, On 02/22/19 05:15, Jiewen Yao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 > > This patch series implement add CET ShadowStack support for SMM. > > The CET document can be found at: >

[edk2] [PATCH V2 3/3] UefiCpuPkg/PiSmmCpu: Add Shadow Stack Support for X86 SMM.

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 We scan the SMM code with ROPgadget. http://shell-storm.org/project/ROPgadget/ https://github.com/JonathanSalwan/ROPgadget/tree/master This tool reports the gadget in SMM driver. This patch enabled CET ShadowStack for X86 SMM. If CET is

[edk2] [PATCH V2 2/3] UefiCpuPkg/ExceptionLib: Add CET support.

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 Add information dump for Control Protection exception. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yao Jiewen ---

[edk2] [PATCH V2 0/3] Add SMM CET support

2019-02-22 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 V2: Fix emulation platform issue. The NT32 platform cannot access CR4 register. So we add a global PCD to choose disable CR4 access in SetJump/LongJump. gEfiMdePkgTokenSpaceGuid.PcdControlFlowEnforcementPropertyMask =

Re: [edk2] [PATCH V3 0/4] Add SMM CET support

2019-02-22 Thread Laszlo Ersek
Hi Jiewen, On 02/22/19 14:30, Jiewen Yao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 > > V3: > Add Nasm.inc to include CET related instruction as MACRO. > This is the only place to use DB. > Any other NASM just use the MACRO - > SETSSBSY, READSSP_[E|R]AX, INCSSP_[E|R]AX >

Re: [edk2] [PATCH V3 0/4] Add SMM CET support

2019-02-22 Thread Yao, Jiewen
Good comment! Response inline thank you! Yao, Jiewen > 在 2019年2月23日,上午5:42,Laszlo Ersek 写道: > > Hi Jiewen, > >> On 02/22/19 14:30, Jiewen Yao wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 >> >> V3: >> Add Nasm.inc to include CET related instruction as MACRO. >> This is

Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

2019-02-22 Thread Rebecca Cran via edk2-devel
Sorry, I've fixed the subject line and added maintainers to the Cc list. This patch also changes the domain from intel.com to example.com, to be more applicable to consumers outside Intel. -- Rebecca Cran On 2/22/19 8:38 PM, Rebecca Cran wrote: The current servers listed appear to be