Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

2015-11-20 Thread Scott Duplichan
Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: ]Sent: Friday, November 20, 2015 01:37 AM ]To: Scott Duplichan ]Cc: Paolo Bonzini ; edk2-devel@lists.01.org ; Zeng, Star ] ]Subject: Re: [edk2] [Patch]

[edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

2015-11-20 Thread Ard Biesheuvel
The PrePeiCore vector table for AArch64 mode is only half populated. However unlikely, if exceptions from lower exception levels are ever taken, they should be reported correctly, rather than causing a recursive undefined instruction fault on the zero padding that was introduced by commit SVN

Re: [edk2] [PATCH] ArmPkg: Flush cache after allocating UC memory

2015-11-20 Thread Leif Lindholm
On Fri, Nov 20, 2015 at 12:20:56PM +0100, Ard Biesheuvel wrote: > On 20 November 2015 at 10:29, Heyi Guo wrote: > > Hi Ard, > > > > Do we have special reason of not cleaning the allocated pages? If not > > having, I think it is safer to use "clean and invalidate". > >

Re: [edk2] [PATCH] ArmPkg: ArmLib: purge incorrect ArmDrainWriteBuffer () alias

2015-11-20 Thread Ard Biesheuvel
On 19 November 2015 at 17:25, Leif Lindholm wrote: > In ArmLib, there exists an alias for ArmDataSynchronizationBarrier, > named after one of several names for the pre-ARMv6 cp15 operation that > was formalised into the Data Synchronization Barrier in ARMv6. > > This

Re: [edk2] [PATCH] ArmPkg: ArmLib: purge incorrect ArmDrainWriteBuffer () alias

2015-11-20 Thread Leif Lindholm
On 20 November 2015 at 12:08, Ard Biesheuvel wrote: > On 19 November 2015 at 17:25, Leif Lindholm wrote: >> In ArmLib, there exists an alias for ArmDataSynchronizationBarrier, >> named after one of several names for the pre-ARMv6 cp15

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

2015-11-20 Thread Mark Rutland
On Fri, Nov 20, 2015 at 01:39:26PM +0100, Ard Biesheuvel wrote: > The PrePeiCore vector table for AArch64 mode is only half populated. > However unlikely, if exceptions from lower exception levels are ever > taken, they should be reported correctly, rather than causing a > recursive undefined

Re: [edk2] [PATCH V2 05/12] EmulatorPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-20 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2015-11-17 03:07:21, Star Zeng wrote: > It is also to add GetControl/SetControl/SetAttributes implementation > for DxeEmuSerialPortLib. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc:

[edk2] [PATCH 3/3] ArmPlatformPkg/ArmJunoPkg: Create SMBIOS/DMI data for Juno

2015-11-20 Thread Jeremy Linton
SMBIOS data is consumed by a wide range of enterprise applications. Fill in the basic requirements of the SMBIOS specification by hardcoding the minimum required structures and data using Juno information. With this change both the EFI shell and linux dmidecode commands return useful information.

[edk2] [PATCH 0/3] ArmPlatformPkg/ArmJunoPkg: Adds SMBIOS data for ARM Juno

2015-11-20 Thread Jeremy Linton
SMBIOS data is consumed by a wide range of enterprise applications. This patch adds basic SMBIOS data for the ARM Juno. Most of the data is static. The system memory layout and juno revision are updated depending on the platform. To accomplish the juno revision detection the Juno revision code in

Re: [edk2] [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

2015-11-20 Thread Miller, Carl H
looks like my original fix submittal, which Mr. Gao said caused failure on his system. -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Friday, November 20, 2015 1:10 AM To: Zhu, Yonghong; edk2-devel@lists.01.org Cc: Hauch, Larry; Miller, Carl H Subject: RE:

Re: [edk2] [PATCH v4 14/41] OvmfPkg: LockBox: use SMM stack with -D SMM_REQUIRE

2015-11-20 Thread Laszlo Ersek
On 11/20/15 07:02, Jordan Justen wrote: > Reviewed-by: Jordan Justen Thank you! But, I think you reviewed this one earlier: http://thread.gmane.org/gmane.comp.bios.edk2.devel/3788/focus=4205 In that message, you wrote: With those move into a new patch, or into

Re: [edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Fu, Siyuan
Hi, Guo It's not a bug, for EfiPxeLoadFile function the input FilePath should always be an end device path node. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Friday, November 20, 2015 4:23 PM To: edk2-devel@lists.01.org Cc:

[edk2] [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

2015-11-20 Thread Yonghong Zhu
We have a new simple and effective method to resolve the original issue that the PATH env's update error when the path contains space, so this patch remove the last check in and use the new method to fix the original issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

2015-11-20 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, November 20, 2015 5:08 PM To: edk2-devel@lists.01.org Cc: Hauch, Larry; carl.mil...@pnnl.gov Subject: [edk2] [Patch]

[edk2] Dynamic PCD Variable Storage in PEI Phase

2015-11-20 Thread Narinder Dhillon
Hi All, Is it possible to set a dynamic PCD variable in PEI phase and get it in DXE phase ? I am having trouble setting it. Log below. Thanx, add-symbol-file

Re: [edk2] How to add /O1 (min size) compile option to edk2 apps ?

2015-11-20 Thread Andrew Fish
> On Nov 20, 2015, at 2:42 PM, Shubha Ramani wrote: > > Forgot to mentionunder[BuildOptions] in the *.inf file > Shubha D. ramanishubharam...@gmail.com > shubharam...@yahoo.com > > >On Friday, November 20, 2015 2:41 PM, Shubha Ramani >

Re: [edk2] [Patch V3 2/2] MdeModulePkg FileExplorerDxe: Create file explorer Protocol.

2015-11-20 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Dong, Eric [mailto:eric.d...@intel.com] Sent: Wednesday, November 11, 2015 12:30 AM To: af...@apple.com Cc: edk2-devel@lists.01.org; Sheng, Cecil (HPS SW) ; El-Haj-Mahmoud, Samer

[edk2] How to add /O1 (min size) compile option to edk2 apps ?

2015-11-20 Thread Shubha Ramani
For instance, if I already have this:MSFT:NOOPT_*_*_CC_FLAGS   = /D ENABLE_PRINT How do I also add /O1 (that's capitol letter "O" 1). Thanks, Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com ___ edk2-devel mailing list

Re: [edk2] How to add /O1 (min size) compile option to edk2 apps ?

2015-11-20 Thread Shubha Ramani
Forgot to mentionunder[BuildOptions] in the *.inf file  Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com On Friday, November 20, 2015 2:41 PM, Shubha Ramani wrote: For instance, if I already have this:MSFT:NOOPT_*_*_CC_FLAGS   = /D

Re: [edk2] Dynamic PCD Variable Storage in PEI Phase

2015-11-20 Thread Andrew Fish
> On Nov 20, 2015, at 4:52 PM, Narinder Dhillon wrote: > > Hi All, > > Is it possible to set a dynamic PCD variable in PEI phase and get it > in DXE phase ? > Yes. > I am having trouble setting it. Log below. > > Thanx, > > add-symbol-file >

[edk2] [PATCH] MdeModulePkg/Pxe: Fix bug of checking input FilePath

2015-11-20 Thread Heyi Guo
There is a simple bug in below code and will cause PXE always returning invalid parameter: if (FilePath == NULL || !IsDevicePathEnd (FilePath)) { return EFI_INVALID_PARAMETER; FilePath should *not* be end node, so return invalid parameter when FilePath *is* device path end.

Re: [edk2] [PATCH v4 22/41] OvmfPkg: SmmCpuFeaturesLib: implement SMRAM state save map access

2015-11-20 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org > Cc: Paolo Bonzini

Re: [edk2] [PATCH v4 21/41] OvmfPkg: SmmCpuFeaturesLib: remove unnecessary bits

2015-11-20 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org > Cc: Paolo Bonzini

Re: [edk2] How to add /O1 (min size) compile option to edk2 apps ?

2015-11-20 Thread Kinney, Michael D
Andrew, A minor correction on DEBUG and RELEASE. DEBUG - Size optimized with symbolic debug information included. There are some platforms DSC files that overload the build target DEBUG to also enable the libraries and PCD settings to generate log messages. Some other platforms use a

Re: [edk2] [PATCH v4 08/41] OvmfPkg: add DXE_DRIVER for providing TSEG-as-SMRAM during boot-time DXE

2015-11-20 Thread Kinney, Michael D
Laszlo, Minor comments included below. Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org >

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-20 Thread Kinney, Michael D
Laszlo, Minor comments included below. I know from later items in this thread that SMM_COMMUNICATE has already been removed in your local branch. Reviewed-by: Michael Kinney Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent:

Re: [edk2] [PATCH v4 09/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-11-20 Thread Kinney, Michael D
Laszlo, Minor comments included below. Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org >

Re: [edk2] [PATCH v4 20/41] OvmfPkg: import SmmCpuFeaturesLib from UefiCpuPkg

2015-11-20 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org > Cc: Paolo Bonzini

Re: [edk2] [PATCH v4 23/41] OvmfPkg: SmmCpuFeaturesLib: customize state save map format

2015-11-20 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org > Cc: Paolo Bonzini

Re: [edk2] [PATCH v4 24/41] OvmfPkg: use relaxed AP SMM synchronization mode

2015-11-20 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org > Subject: [edk2] [PATCH v4 24/41]

Re: [edk2] [PATCH v4 26/41] OvmfPkg: build PiSmmCpuDxeSmm for -D SMM_REQUIRE

2015-11-20 Thread Kinney, Michael D
Laszlo, Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, November 3, 2015 1:01 PM > To: edk2-de...@ml01.01.org > Cc: Paolo Bonzini