[edk2] [PATCH v6] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-07 Thread Cecil Sheng
Add the definition for the new UEFI 2.6 EFI_HII_IMAGE_EX_PROTOCOL and EFI_IMAGE_DECODER_PROTOCOL. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cecil Sheng Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Abner Chang --- MdePkg/Include/Protocol/HiiImageEx.h | 245

Re: [edk2] [PATCH v5] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-07 Thread Dong, Eric
Hi Cecil, The gEfiImageDecoderProtocolGuid value in the .h file is not consistent with the value in the dec file. Please correct it. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Tuesday, March 08, 2016 1

Re: [edk2] [PATCH v6] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Zeng, Star
Reviewed-by: Star Zeng On 2016/3/8 14:00, Cinnamon Shia wrote: The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum number of PEI performance log entries. Contributed-under: TianoCore Contribution Agreement 1.0 Signe

[edk2] [PATCH v6] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Cinnamon Shia
The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum number of PEI performance log entries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia Reviewed-by: Samer EL-Haj-Mahmoud Reviewe

[edk2] [PATCH 1/2] OvmfPkg PciHostBridgeDxe: Convert Ia32/IoFifo.asm to NASM

2016-03-07 Thread Jordan Justen
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert Ia32/IoFifo.asm to Ia32/IoFifo.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Laszlo Ersek --- OvmfPkg/PciHostBridgeDxe/Ia32/IoFifo.S | 134 - ...

[edk2] [PATCH 2/2] OvmfPkg PciHostBridgeDxe: Convert X64/IoFifo.asm to NASM

2016-03-07 Thread Jordan Justen
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert X64/IoFifo.asm to X64/IoFifo.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Laszlo Ersek --- OvmfPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf | 3 +- OvmfPkg/PciHostBridgeDxe

[edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

2016-03-07 Thread Jordan Justen
The script is updated to support both python 2.7 and python 3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Yonghong Zhu Cc: Liming Gao Cc: Erik Bjorge --- BaseTools/Scripts/ConvertMasmToNasm.py | 87 ++ 1 file change

[edk2] [PATCH 1/3] BaseTools ConvertMasmToNasm: Set gitemail when git is not found

2016-03-07 Thread Jordan Justen
Fixes: https://github.com/tianocore/edk2/issues/63 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen Cc: Yonghong Zhu Cc: Liming Gao Cc: Michael Kinney --- BaseTools/Scripts/ConvertMasmToNasm.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[edk2] [PATCH 2/3] BaseTools ConvertMasmToNasm: Fix exception when no arguments are given

2016-03-07 Thread Jordan Justen
Convert to use the argparse library rather than optparse. As part of the conversion, the script will now give an error message if no arguments are given. Previously the script would give an exception when no arguments were given. Fixes: https://github.com/tianocore/edk2/issues/65 Contributed-unde

[edk2] [PATCH] ShellPkg: Per UEFI Shell 2.2 SPEC to make Shell supports 'NoNesting'.

2016-03-07 Thread Qiu Shumin
This patch makes Shell support -nonesting invocation option. This option specifies that EFI_SHELL_PROTOCOL.Execute API nesting of a new Shell instance is optional and dependent on the 'nonesting' Shell environment variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jab

[edk2] [PATCH v5] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-07 Thread Cecil Sheng
Add the definition for the new UEFI 2.6 EFI_HII_IMAGE_EX_PROTOCOL and EFI_IMAGE_DECODER_PROTOCOL. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cecil Sheng Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Abner Chang --- MdePkg/Include/Protocol/HiiImageEx.h | 245

Re: [edk2] [PATCH] MdeModulePkg AcpiTableDxe: Use Rsdt to check against NULL

2016-03-07 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Zeng, Star Sent: Monday, March 07, 2016 3:46 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Ard Biesheuvel; Qiu, Shumin; Tian, Feng Subject: [PATCH] MdeModulePkg AcpiTableDxe: Use Rsdt to check against NULL Some static scan tool may rega

Re: [edk2] [PATCH v5] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Zeng, Star
Cinnamon, Some comments below. On 2016/3/8 3:38, Cinnamon Shia wrote: The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum number of PEI performance log entries. Contributed-under: TianoCore Contribution Agreement 1.

Re: [edk2] [PATCH v2] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-03-07 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cohen, Eugene Sent: Wednesday, March 2, 2016 7:40 AM To: edk2-devel@lists.01.org; Ard Biesheuvel ; Gao, Liming ; Zhu, Yonghong Subject: [edk2] [PATCH v2] BaseTools: Update

Re: [edk2] [PATCH 2/5] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

2016-03-07 Thread Brian J. Johnson
On 03/07/2016 03:38 AM, Gerd Hoffmann wrote: Hi, Okay, my vote is 0x8000_ (2GB) then. I will modify the patch as follows: simultaneously with programming the exbar at 2GB, I will lower the start of the 32-bit PCI aperture from the current 3GB (0xC000_) to (2GB+256MB == 0x9000_).

[edk2] [PATCH v5] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Cinnamon Shia
The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum number of PEI performance log entries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia Reviewed-by: Samer EL-Haj-Mahmoud Reviewe

Re: [edk2] [PATCH] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData

2016-03-07 Thread Evan Lloyd
Hi Ard. Some responses inline below, but the real response is "You are right, please don't merge this patch just yet." > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 07 March 2016 05:23 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; Leif Lindholm >

Re: [edk2] [PATCH v3] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Kinney, Michael D
Cinnamon, Minor rewording of the detailed descriptions of the PCDs included below. With those comment changes: Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, March 7, 2016

Re: [edk2] [PATCH v4] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Shia, Cinnamon Sent: Monday, March 7, 2016 12:48 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Shia, Cinnamon Subject: [PATCH v4] MdeModulePkg: Increase the maximum number of PEI performance log entries The maxi

[edk2] [PATCH v4] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Cinnamon Shia
The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum number of PEI performance log entries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia Reviewed-by: Samer EL-Haj-Mahmoud Reviewe

[edk2] [PATCH v3] MdeModulePkg: Increase the maximum number of PEI performance log entries

2016-03-07 Thread Cinnamon Shia
The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum number of PEI performance log entries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia Reviewed-by: Samer EL-Haj-Mahmoud --- ..

Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread Shia, Cinnamon
Hi Mike, Thanks for your feedbacks. It make sense to me. Will fix it in patch v3 and update the commit message for the new changes. Thanks, Cinnamon Shia -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, March 8, 2016 12:13 AM To: Shia, Cinn

Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread Kinney, Michael D
Cinnamon, How about the following changes: 1) Use a PCD name of PcdMaxPeiPerformanceLogEntries16 to show it is 16-bits. Also allows for more expansion if we need more than 16-bits later. 2) Make the default value of PcdMaxPeiPerformanceLogEntries16 be 0, which is the disabled value. 3) Use Pcd

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

2016-03-07 Thread Carsey, Jaben
Also for series. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Monday, March 07, 2016 4:57 AM > To: edk2-devel@lists.01.org; Shia, Cinnamon > Subject: Re: [edk2] [PATCH v2 1/2] Per

[edk2] [PATCH v2 2/3] ArmPkg: ARM/AArch64 implementation of CpuExceptionHandlerLib

2016-03-07 Thread Cohen, Eugene
Introduce ARM and AArch64 instances of the CpuExceptionHandlerLib which provides exception handling and registration of handlers regardless of execution phase. Two variants of the ArmExceptionLib are provided: one where exception handlers reside within the module (meeting appropriate architectura

[edk2] [PATCH v2 3/3] ArmPkg: Update CpuDxe to use CpuExceptionHandlerLib

2016-03-07 Thread Cohen, Eugene
Use the new ARM/AArch64 implementation of the base CpuExceptionHandlerLib library from CpuDxe to centralize exception handling. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen --- ArmPkg/Drivers/CpuDxe/AArch64/Exception.c| 154 - ArmPkg/Drivers

Re: [edk2] [PATCH 0/3] Implement ARM/AArch64 instance of CpuExceptionHandlerLib

2016-03-07 Thread Cohen, Eugene
Here's the second revision of the patch series with these changes: 1. Remove the unnecessary patching of the CommonExceptionEntry since the linker already does it 2. Remove a duplicate write to VBAR in the case where exception handlers are relocated Both of these only affect Patch 2/3, 1 and 3

[edk2] [PATCH v2 1/3] ArmPkg: Add ArmReadHcr to enable read-modify-write of HCR

2016-03-07 Thread Cohen, Eugene
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen --- ArmPkg/Include/Chipset/AArch64.h | 5 + ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 6 ++ 2 files changed, 11 insertions(+) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/In

Re: [edk2] [PATCH v3] NetworkPkg: Add URI configuration form to HTTP boot driver.

2016-03-07 Thread Laszlo Ersek
On 03/07/16 13:39, Gao, Liming wrote: > Laszlo: > > I have used GCC windows binary tools in my daily work. It is very > helpful for the windows user. GCC Windows binary can be got from > http://sourceforge.net/projects/edk2developertoolsforwindows/files/Tool%20Chain%20Binaries/x86. > I would sug

Re: [edk2] [GIT PULL] CryptoPkg/OpensslLib: Fix CRLF breakage in process_files.sh

2016-03-07 Thread David Woodhouse
On Sat, 2016-03-05 at 20:05 +0100, Ard Biesheuvel wrote: > On 5 March 2016 at 17:54, David Woodhouse wrote: > > Please PULL this commit from: > > > > git://git.infradead.org/users/dwmw2/edk2.git fix-crlf-crap > > > > Fetched and pushed, thanks! Thanks, Ard. -- dwmw2 smime.p7s Descri

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

2016-03-07 Thread El-Haj-Mahmoud, Samer
Series Reviewed-by: Samer EL-Haj-Mahmoud On 2016/3/7 11:23, Cinnamon Shia wrote: > Support UEFI shell execution break. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Cinnamon Shia > --- > PerformancePkg/Dp_App/Dp.c | 36 -- > Performan

Re: [edk2] [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud -Original Message- From: Shia, Cinnamon Sent: Monday, March 7, 2016 1:57 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Shia, Cinnamon Subject: [PATCH v2] MdeModulePkg: Change the type of PcdMaxPeiPerformanceLogEntries to UINT16 Change t

Re: [edk2] [PATCH 2/2] NetworkPkg: Use the New Functions from HttpLib

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud -Original Message- From: Belaam, Ghazi Sent: Friday, March 4, 2016 4:08 PM To: edk2-devel@lists.01.org Cc: feng.t...@intel.com; star.z...@intel.com; siyuan...@intel.com; jiaxin...@intel.com; El-Haj-Mahmoud, Samer ; Belaam, Ghazi Subject: [PATCH 2/2] N

Re: [edk2] [PATCH 1/2] ModulePkg/DxeHttpLib: Adding Functions to HttpLib

2016-03-07 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer EL-Haj-Mahmoud > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ghazi Belaam > Sent: Saturday, March 5, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Wu, Jiaxin > ; Fu, Siyuan ; Zeng, Star > > Subject:

Re: [edk2] [PATCH v3] NetworkPkg: Add URI configuration form to HTTP boot driver.

2016-03-07 Thread Gao, Liming
Laszlo: I have used GCC windows binary tools in my daily work. It is very helpful for the windows user. GCC Windows binary can be got from http://sourceforge.net/projects/edk2developertoolsforwindows/files/Tool%20Chain%20Binaries/x86. I would suggest we add wiki in GitHub to let user know how

[edk2] [PATCH] NetworkPkg: HttpBootDxe: fix gcc build failure

2016-03-07 Thread Laszlo Ersek
Commit fa848a404894 ("NetworkPkg: Add URI configuration form to HTTP boot driver") causes the build to fail with gcc: > NetworkPkg/HttpBootDxe/HttpBootConfig.c: In function > 'HttpBootAddBootOption': > NetworkPkg/HttpBootDxe/HttpBootConfig.c:148:14: > error

Re: [edk2] [PATCH v3] NetworkPkg: Add URI configuration form to HTTP boot driver.

2016-03-07 Thread Laszlo Ersek
This patch (which is only ~1900 lines in size, including context...) On 03/04/16 09:38, Fu Siyuan wrote: > This patch updates the HTTP boot driver to produce a setup page for the boot > file URI configuration. A new boot option will be created for the manual > configured URI address. This change i

Re: [edk2] [Patch] MdeModulePkg/Bds: Fix VS2010/VS2012 build failure.

2016-03-07 Thread Wang, Sunny (HPS SW)
Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, March 07, 2016 1:30 PM To: edk2-devel@lists.01.org Cc: Ruiyu Ni; Shumin Qiu Subject: [edk2] [Patch] MdeModulePkg/Bds: Fix VS2010/VS2012 build failure.

Re: [edk2] [PATCH 2/5] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

2016-03-07 Thread Gerd Hoffmann
Hi, > Okay, my vote is 0x8000_ (2GB) then. > > I will modify the patch as follows: simultaneously with programming the > exbar at 2GB, I will lower the start of the 32-bit PCI aperture from the > current 3GB (0xC000_) to (2GB+256MB == 0x9000_). Is that alright? Yes, that should wor

Re: [edk2] [PATCH 2/5] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

2016-03-07 Thread Laszlo Ersek
Thank you for this message! Some comments below: On 03/07/16 09:47, Gerd Hoffmann wrote: > Hi, > >> PCI: MMCONFIG at [mem 0xb000-0xbfff] reserved in E820 > > Ok, I see you mimic seabios behavior here, resulting in a somewhat odd > memory layout (not your fault, of course). > > Short

Re: [edk2] [PATCH 2/5] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

2016-03-07 Thread Gerd Hoffmann
Hi, > PCI: MMCONFIG at [mem 0xb000-0xbfff] reserved in E820 Ok, I see you mimic seabios behavior here, resulting in a somewhat odd memory layout (not your fault, of course). Short history lesson: Traditional i440fx memory layout (before we did gigabyte alignment) was memory up to 0x

Re: [edk2] [PATCH 3/5] OvmfPkg: add DxePciLibI440FxQ35

2016-03-07 Thread Laszlo Ersek
On 03/07/16 04:51, Jordan Justen wrote: > On 2016-03-06 06:28:26, Laszlo Ersek wrote: [snip] >> So here's what I would like, in decreasing order of preference: >> >> * Keep the patch, as is. (Most preferred.) >> >> * Keep the library instance under OvmfPkg, but set MODULE_TYPE to >> DXE_DRIVER,

Re: [edk2] [patch] ShellPkg: Merge Ping6 and Ifconfig6 tools to Shell command.

2016-03-07 Thread Wu, Jiaxin
Looks good to me. Reviewed-by: Jiaxin Wu > -Original Message- > From: Zhang, Lubo > Sent: Wednesday, March 2, 2016 10:14 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Wu, Jiaxin > ; Ye, Ting ; Fu, Siyuan > > Subject: [patch] ShellPkg: Merge Ping6 and Ifconfig6 tools to Shell c

Re: [edk2] [PATCH 1/2] ModulePkg/DxeHttpLib: Adding Functions to HttpLib

2016-03-07 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ghazi Belaam > Sent: Saturday, March 5, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Wu, Jiaxin ; Fu, > Siyuan ; Zeng, Star > Subject: [edk2] [PATCH 1/

Re: [edk2] [PATCH 2/2] NetworkPkg: Use the New Functions from HttpLib

2016-03-07 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Ghazi Belaam [mailto:ghazi.bel...@hpe.com] > Sent: Saturday, March 5, 2016 6:08 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star ; Fu, > Siyuan ; Wu, Jiaxin ; samer.el- > haj-mahm...@hpe.com; Ghazi Belaam > Subject: [PATC