[edk2] [PATCH v3] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Ard Biesheuvel
On ARM, manipulating live page tables is cumbersome since the architecture mandates the use of break-before-make, i.e., replacing a block entry with a table entry requires an intermediate step via an invalid entry, or TLB conflicts may occur. Since it is not generally feasible to decide in the pag

Re: [edk2] [Patch] BaseTools: add the support for --pcd feature to patch the binary efi

2016-04-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Tuesday, April 12, 2016 11:10 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: add the support for --pcd feature to patch > the

Re: [edk2] [Patch 0/2] Tool generate hash value for each output EFI image

2016-04-11 Thread Gao, Liming
Reviewed-by: Liming Gao for this serial. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, April 07, 2016 2:01 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Tool generate hash value for each out

[edk2] [Patch] BaseTools: add the support for --pcd feature to patch the binary efi

2016-04-11 Thread Yonghong Zhu
the original --pcd feature can override the Pcd value when build the source driver, while it missed the binary driver. this patch add the support to patch the binary efi for --pcd feature. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Py

[edk2] [Patch] BaseTools: Add mixed PCD support feature

2016-04-11 Thread Yonghong Zhu
Problem statement: The current build system requires that a PCD must use the same access method for all modules. A Binary Module may use a different PCD access method than: 1.A source tree build it is integrated into. 2.Other Binary Modules in platform build that use the same PCD. Solution: 1. Sou

[edk2] [Patch] QuarkSocPkg: Add /Oi option to let MemoryInit pass build.

2016-04-11 Thread Liming Gao
MemoryInit uses the intrinsic memset function. To keep it pass build in VS tool chain without source code change, /Oi option will be added. Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- QuarkSocPkg/QuarkNorthCluster/MemoryInit/Pei/Memor

Re: [edk2] [Patch 0/6] Reference PCDs/Protocols defined in MdeModulePkg

2016-04-11 Thread Tian, Feng
Sorry for missing #4 patch. It's ok to me as well. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Tian, Feng Sent: Monday, April 11, 2016 4:07 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Tian, Feng Subject: RE: [edk2] [Patch 0/6] Reference PCDs/Protocols d

Re: [edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

2016-04-11 Thread Kinney, Michael D
Liming, Please add /Oi to MemoryInitPei.inf for now. Thanks, Mike From: Gao, Liming Sent: Monday, April 11, 2016 5:26 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Subject: RE: [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit This way still requires to include L

Re: [edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

2016-04-11 Thread Gao, Liming
This way still requires to include Library\BaseMemoryLib.h. Another way is to append /Oi option in [BuildOptions] section for VS tool chain. It has no change to memory init code. Thanks Liming From: Kinney, Michael D Sent: Tuesday, April 12, 2016 7:54 AM To: Gao, Liming ; edk2-devel@lists.01.org

Re: [edk2] [Patch] QuarkSocPkg: Remove intrinsic memset function usages in MemoryInit

2016-04-11 Thread Kinney, Michael D
Liming, I think I would prefer we minimize changes to the memory init C sources. Maybe it would be better if we added #define memset() to SetMem() in meminit_utils.h based on a define name set in a [BuildOptions] section of MemoryInitPei.inf Thanks, Mike > -Original Message- > From:

Re: [edk2] TCPIP Client for UEFI

2016-04-11 Thread Andrew Fish
> On Apr 11, 2016, at 4:29 PM, Jim Slaughter wrote: > > Hello Patrick,Thank you.I do not have a setup screen with this BIOS/uEFI. Its > n SOC on a board but not really a consumer PC type.I need to figure out a way > to setup the NIC, find something already written or write it myself. I am not

Re: [edk2] TCPIP Client for UEFI

2016-04-11 Thread Jim Slaughter
Hello Patrick,Thank you.I do not have a setup screen with this BIOS/uEFI. Its n SOC on a board but not really a consumer PC type.I need to figure out a way to setup the NIC, find something already written or write it myself. I am not sure if a setup can be done after the actual uefi boot. think

Re: [edk2] [PATCH] ShellPkg : Cache the environment variable into memory to enhance the performance.

2016-04-11 Thread Carsey, Jaben
2 comments below. Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Sunday, April 10, 2016 5:55 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH] ShellPkg : Cache the environment variable into memory to > enhance

Re: [edk2] [RFC] EDK2 Staging Proposal 4th Draft

2016-04-11 Thread Laszlo Ersek
On 04/11/16 20:23, Kinney, Michael D wrote: > Laszlo, > > I agree branch maintainer should be able to choose to rebase the branch as > needed. > Branch maintainers can also create V1, V2, ..., Vn versions of the feature > branch > as needed. > > Advertising features under development in either

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Laszlo Ersek
On 04/11/16 18:22, Ard Biesheuvel wrote: > On 11 April 2016 at 16:50, Laszlo Ersek wrote: >> On 04/11/16 16:34, Ard Biesheuvel wrote: >>> On 11 April 2016 at 16:12, Laszlo Ersek wrote: On 04/11/16 15:43, Ard Biesheuvel wrote: >> >> [snip] >> >>> I simply want to check that the 'pci-ecam-gene

Re: [edk2] [RFC] EDK2 Staging Proposal 4th Draft

2016-04-11 Thread Kinney, Michael D
Laszlo, I agree branch maintainer should be able to choose to rebase the branch as needed. Branch maintainers can also create V1, V2, ..., Vn versions of the feature branch as needed. Advertising features under development in either personal github branches or the Staging branch is important.

Re: [edk2] [PATCH] EmbeddedPkg: Add GICD table init macro for ACPI 6.0

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 14:31, Heyi Guo wrote: > Hello, > > Any comments on this patch? > I think it looks fine. Leif? > On 04/07/2016 09:32 AM, Heyi Guo wrote: >> >> Add macro to help initialize GICD structure in MADT table according to >> ACPI 6.0. >> >> Contributed-under: TianoCore Contribution A

Re: [edk2] [PATCH v2] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 18:47, Mark Rutland wrote: > On Mon, Apr 11, 2016 at 06:08:29PM +0200, Ard Biesheuvel wrote: >> +//VOID >> +//ArmReplaceLiveTranslationEntry ( >> +// IN UINT64 *Entry, >> +// IN UINT64 Value >> +// ) >> +ASM_PFX(ArmReplaceLiveTranslationEntry): >> + .macro __replace_ent

Re: [edk2] [PATCH v2] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Mark Rutland
On Mon, Apr 11, 2016 at 06:08:29PM +0200, Ard Biesheuvel wrote: > +//VOID > +//ArmReplaceLiveTranslationEntry ( > +// IN UINT64 *Entry, > +// IN UINT64 Value > +// ) > +ASM_PFX(ArmReplaceLiveTranslationEntry): > + .macro __replace_entry, el > + mrs x8, sctlr_el\el > + and x9, x8, #~CT

Re: [edk2] [PATCH v2] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 18:08, Ard Biesheuvel wrote: > On ARM, manipulating live page tables is cumbersome since the architecture > mandates the use of break-before-make, i.e., replacing a block entry with > a table entry requires an intermediate step via an invalid entry, or TLB > conflicts may occur

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 16:50, Laszlo Ersek wrote: > On 04/11/16 16:34, Ard Biesheuvel wrote: >> On 11 April 2016 at 16:12, Laszlo Ersek wrote: >>> On 04/11/16 15:43, Ard Biesheuvel wrote: > > [snip] > >> I simply want to check that the 'pci-ecam-generic' DT node we end up >> consuming is the only on

[edk2] [PATCH v2] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Ard Biesheuvel
On ARM, manipulating live page tables is cumbersome since the architecture mandates the use of break-before-make, i.e., replacing a block entry with a table entry requires an intermediate step via an invalid entry, or TLB conflicts may occur. Since it is not generally feasible to decide in the pag

Re: [edk2] BaseTools: Refinded Multiple Workspaces support.

2016-04-11 Thread Marvin Häuser
Hello Liming, Yeah, I didn't quite think the MODULE_DIR comment through, you are definitely right about that. Though it would be nice to fix PLATFORM_DIR nevertheless (it still is $(WORKSPACE)\AnyPkg, even though it is in a PACKAGES_PATH folder), so Makefiles etc. can use it to build their own

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Laszlo Ersek
On 04/11/16 16:34, Ard Biesheuvel wrote: > On 11 April 2016 at 16:12, Laszlo Ersek wrote: >> On 04/11/16 15:43, Ard Biesheuvel wrote: [snip] > I simply want to check that the 'pci-ecam-generic' DT node we end up > consuming is the only one that exists in the device tree. In fact, I > think it ma

Re: [edk2] [RFC] EDK2 Staging Proposal 4th Draft

2016-04-11 Thread Laszlo Ersek
On 04/07/16 19:27, Kinney, Michael D wrote: > Hello, > > We left off with the 3rd draft of the edk2-staging proposal with some really > good feedback. The consistent feedback was to keep any process here simple > and to use features already available from github where it makes sense to do > so

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 16:12, Laszlo Ersek wrote: > On 04/11/16 15:43, Ard Biesheuvel wrote: >> On 11 April 2016 at 15:34, Laszlo Ersek wrote: >>> On 04/11/16 14:17, Ard Biesheuvel wrote: On 8 April 2016 at 21:15, Laszlo Ersek wrote: >>> >>> [snip] >>> > I think this patch is not the right

Re: [edk2] [PATCH] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 16:10, Mark Rutland wrote: > Hi Ard, > > On Mon, Apr 11, 2016 at 03:57:15PM +0200, Ard Biesheuvel wrote: >> On ARM, manipulating live page tables is cumbersome since the architecture >> mandates the use of break-before-make, i.e., replacing a block entry with >> a table entry r

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Laszlo Ersek
On 04/11/16 15:43, Ard Biesheuvel wrote: > On 11 April 2016 at 15:34, Laszlo Ersek wrote: >> On 04/11/16 14:17, Ard Biesheuvel wrote: >>> On 8 April 2016 at 21:15, Laszlo Ersek wrote: >> >> [snip] >> I think this patch is not the right approach. I would like to preserve the ability

Re: [edk2] [PATCH] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Mark Rutland
Hi Ard, On Mon, Apr 11, 2016 at 03:57:15PM +0200, Ard Biesheuvel wrote: > On ARM, manipulating live page tables is cumbersome since the architecture > mandates the use of break-before-make, i.e., replacing a block entry with > a table entry requires an intermediate step via an invalid entry, or TL

Re: [edk2] BaseTools: Refinded Multiple Workspaces support.

2016-04-11 Thread Gao, Liming
Marvin: Sorry. I miss this mail. I agree to fix PLATFORM_DIR variable value. But, PLATFORM_DIR variable points to the package that places platform DSC file. The built module may be from the different packages. So, PLATFORM_DIR can't be used to construct MODULE_DIR. After multiple workspaces are

[edk2] [PATCH] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-11 Thread Ard Biesheuvel
On ARM, manipulating live page tables is cumbersome since the architecture mandates the use of break-before-make, i.e., replacing a block entry with a table entry requires an intermediate step via an invalid entry, or TLB conflicts may occur. Since it is not generally feasible to decide in the pag

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Ard Biesheuvel
On 11 April 2016 at 15:34, Laszlo Ersek wrote: > On 04/11/16 14:17, Ard Biesheuvel wrote: >> On 8 April 2016 at 21:15, Laszlo Ersek wrote: > > [snip] > >>> I think this patch is not the right approach. >>> >>> I would like to preserve the ability to write a DXE_DRIVER that accesses >>> PCI config

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Laszlo Ersek
On 04/11/16 14:17, Ard Biesheuvel wrote: > On 8 April 2016 at 21:15, Laszlo Ersek wrote: [snip] >> I think this patch is not the right approach. >> >> I would like to preserve the ability to write a DXE_DRIVER that accesses >> PCI config space through this PciExpressLib instance, regardless of i

Re: [edk2] [PATCH] EmbeddedPkg: Add GICD table init macro for ACPI 6.0

2016-04-11 Thread Heyi Guo
Hello, Any comments on this patch? Regards. Heyi On 04/07/2016 09:32 AM, Heyi Guo wrote: Add macro to help initialize GICD structure in MADT table according to ACPI 6.0. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Cc: Leif Lindholm Cc: Ard Biesheuvel --

Re: [edk2] [PATCH v2 13/24] ArmVirtPkg/BaseCachingPciExpressLib: construct at first invocation

2016-04-11 Thread Ard Biesheuvel
On 8 April 2016 at 21:15, Laszlo Ersek wrote: > On 04/08/16 11:45, Ard Biesheuvel wrote: >> Instead of using a constructor, which may reference a dynamic PCD which is >> set by the DXE entry point of its user, defer the assignment of the global >> mPciExpressBaseAddress until the first the library

Re: [edk2] [PATCH 1/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-11 Thread Laszlo Ersek
On 04/11/16 13:50, Fan, Jeff wrote: > Reviewed-by: Jeff Fan > > VS2013 build pass. Thanks a lot, Jeff. Commit fb8b54694c53. Cheers Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 1/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-11 Thread Fan, Jeff
Reviewed-by: Jeff Fan VS2013 build pass. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, April 08, 2016 6:22 PM To: edk2-devel-01 Cc: Justen, Jordan L; Ni, Ruiyu; Fan, Jeff; Mark Subject: [PATCH 1/1] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of

Re: [edk2] [Patch 0/6] Reference PCDs/Protocols defined in MdeModulePkg

2016-04-11 Thread Tian, Feng
#1,2,3 &6 patch looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, April 11, 2016 3:47 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] [Patch 0/6] Reference P

[edk2] [PATCH v2 5/6] NetworkPkg: HTTPS support over IPv4 and IPv6

2016-04-11 Thread Jiaxin Wu
v2: To support the multiple certificate configuration, EFI_SIGNATURE_LIST format is used for the variable 'TlsCaCertificate'. This patch is used to enable HTTPS feature. HttpDxe driver will consume TlsDxe driver. It can both support http and https feature, it’s depended on the information in URL,

[edk2] [PATCH v2 4/6] NetworkPkg: TlsDxe driver implementation over OpenSSL

2016-04-11 Thread Jiaxin Wu
v2: Refine the MAX_BUFFER_SIZE This patch is the implementation of EFI TLS Protocol and EFI TLS Configuration Protocol Interfaces. Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin Cc: El-Haj-Mahmoud Samer Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/

[edk2] [PATCH v2 3/6] CryptoPkg: Add new TlsLib library

2016-04-11 Thread Jiaxin Wu
v2: Refine the MAX_BUFFER_SIZE This patch is used to add new TlsLib library, which is wrapped over OpenSSL. The implementation provides TLS library functions for EFI TLS protocol. Cc: Long Qin Cc: Ye Ting Cc: Fu Siyuan Cc: El-Haj-Mahmoud Samer Contributed-under: TianoCore Contribution Agreeme

[edk2] [Patch 5/6] Vlv2TbltDevicePkg: Reference the PCD defined in MdeModulePkg

2016-04-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: David Wei --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++-- Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 4 ++-- Vlv2TbltDevicePkg/PlatformPkgX64.dsc| 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)

[edk2] [Patch 6/6] IntelFrameworkModulePkg: Remove unused PCD/Protocol

2016-04-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- .../Include/Protocol/Ps2Policy.h | 41 -- .../IntelFrameworkModulePkg.dec| 26 -- 2 files changed, 67 deletions(-) delete mode

[edk2] [Patch 2/6] IntelFrameworkModulePkg/Ps2AbsPointer: Use PCD defined in MdeModulePkg

2016-04-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- .../Bus/Isa/Ps2MouseAbsolutePointerDxe/Ps2MouseAbsolutePointer.h | 4 ++-- .../Isa/Ps2MouseAbsolutePointerDxe/Ps2MouseAbsolutePointerDxe.inf| 5 ++--- 2 files changed, 4 insertions(+), 5 del

[edk2] [Patch 3/6] IntelFrameworkModulePkg/Ps2Mouse: Use PCD defined in MdeModulePkg

2016-04-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2Mouse.h | 4 ++-- IntelFrameworkModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --

[edk2] [Patch 4/6] IntelFrameworkModulePkg/KeyboardDxe: Use PCD defined in MdeModulePkg

2016-04-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/KeyboardDxe.inf | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/Keyboar

[edk2] [Patch 0/6] Reference PCDs/Protocols defined in MdeModulePkg

2016-04-11 Thread Ruiyu Ni
The PCD/Protocol used by ISA device drivers are defined in MdeModulePkg. Change all modules/platforms to reference the new PCDs/Protocols and remove the old PCDs/Protocols. Ruiyu Ni (6): IntelFrameworkModulePkg/Ps2Kbd: use PCD/Protocol in MdeModulePkg IntelFrameworkModulePkg/Ps2AbsPointer: Use

[edk2] [Patch 1/6] IntelFrameworkModulePkg/Ps2Kbd: use PCD/Protocol in MdeModulePkg

2016-04-11 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 4 ++-- IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2keyboardDxe.inf | 8 2 files changed, 6 insertions(+), 6 deleti