Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, June 02, 2016 4:26 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Zhang, Lubo
Subject: [Patch] NetworkPkg: Remove TokenEntry from Token list before freed
TokenEntry should be removed from Token list before freed.
Series reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, May 31, 2016 10:17 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo
; Hegde Nagaraj P ; Gary Lin
Subject: [Patch 0/3] NetworkPkg: Support TCP Cancel function and move timeout
handlin
Series reviewed by: cinnamon.s...@hpe.com
-Original Message-
From: Yao, Jiewen [mailto:jiewen@intel.com]
Sent: Sunday, June 12, 2016 3:34 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Gao, Liming ;
Shia, Cinnamon
Subject: RE: [edk2] [PATCH V2 0/3] Remove TimerLib
Marvin:
This is a better. I suggest to create two patch sets. I think you focuses on
the first. For the second, UNREACHABLE is a decorator, and has no real impact.
1. For static code analyzer, add ANALYZER_UNREACHABLE macro in BaseLib.h, and
use it in _ASSERT() macro in DebugLib.h
2. For un re
Hi, Yakovlev
Any response on this?
Thanks
Feng
-Original Message-
From: Tian, Feng
Sent: Monday, June 6, 2016 9:27 AM
To: Evgeny Yakovlev ; edk2-devel@lists.01.org
Cc: Tian, Feng
Subject: RE: [edk2] [PATCH] MdeModulePkg/UsbBusDxe: Fixed USB descriptor length
check
Hi, Evgenv
Thanks
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, June 13, 2016 9:42 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [patch] MdeModulePkg/UiApp: Fix the incorrect use of the HiiHandle
>
> In current code, when adding string package, it will retur
Reviewed-by: Eric Dong
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Sunday, June 12, 2016 5:24 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/5] Get SIO data from SIO interface
>
> LegacyBios driver origina
In Current UI code, we use oneof opcode without storage for language
menu. If we change the language form A->B, then go to another form and
then go back to the front page, the language menu always shows A. Now
we fix this issue by getting current language and set the related value
to oneof opcode w
In current code, when adding string package, it will return
'gStringPackHandle'. But the code use the 'gHiiHandle' to get
string. It is incorrect. This patch is to fix this issue.
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/App
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, June 08, 2016 3:39 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming; Dong, Eric
> Subject: [patch] MdeModulePkg/Database: Fix incorrect calculation of baseline
> in FontPackage
>
> When adding font packa
Dear package maintainers and reviewers,
Please do not approve this patch yet. I have thought further about the
consequences of decorating CpuDeadLoop() and CpuBreakpoint() with the
ANALYZER_NORETURN attribute and fear that the Analyzer, against the original
intention, could issue incorrect warn
Hello Andrew,
Yes, I agree with you, these should have the attribute/macro call added in a
separate patch once this one has been approved. As you mentioned yourself, it
will hopefully eliminate unnecessary stack cleanups and maybe point out
developer mistakes in case code is placed at the wrong
> On Jun 12, 2016, at 6:40 AM, Marvin Häuser wrote:
>
> Hey Andrew, hey Liming,
>
> First, the more important patch is probably the Patch 2/2, which flags
> CpuBreakpoint() and CpuDeadLoop() as ANALYZER_NORETURN to pretend to the
> analyzer the functions can't exit for the sake of surpressing
Hey Andrew, hey Liming,
First, the more important patch is probably the Patch 2/2, which flags
CpuBreakpoint() and CpuDeadLoop() as ANALYZER_NORETURN to pretend to the
analyzer the functions can't exit for the sake of surpressing warnings.
I personally don't understand why the patch should be se
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
---
.../Csm/LegacyBiosDxe/LegacyBiosDxe.inf| 1 +
.../Csm/LegacyBiosDxe/LegacyBiosInterface.h| 2 +
.../Csm/LegacyBiosDxe/LegacySio.c | 222 -
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
---
IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacySio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacySio.c
b/IntelFramework
LegacyBios driver originally only fills the SIO data from IsaIo interface.
When the system doesn't have IsaIo interface but only SIO interface,
the code which gets the SIO data needs to be updated to handle the new case.
Ruiyu Ni (5):
IntelFrameworkModulePkg/LegacyBios: Get SIO data in separate
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
---
.../Csm/LegacyBiosDxe/LegacyBiosDxe.inf | 3 ++-
.../Csm/LegacyBiosDxe/LegacyBiosInterface.h | 3 ++-
IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacySio.c | 17 +
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
---
.../Csm/LegacyBiosDxe/LegacySio.c | 90 ++
1 file changed, 57 insertions(+), 33 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacySio.c
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
---
.../Csm/LegacyBiosDxe/LegacySio.c | 34 +++---
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacySio.c
For current implementation, if the device is pyrite type, driver
will suppress the "keep user data" option. Base on the feedback
from user, they prefer grayout the menu instead of suppress it.
Now base on this feedback to update the driver.
Contributed-under: TianoCore Contribution Agreement 1.0
Yes, that is a better idea to maintain the dependency.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Sunday, June 12, 2016 3:28 PM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Yao, Jiewen
> ; Gao, Liming ; Cinnamon
> Shia
> Subject:
Define PERFORMANCE_PROPERTY, and install performance property configuration
table in DxeCorePerformanceLib and SmmCorePerformanceLib.
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Cinnamon Shia
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModul
Thanks all for the R-b. Sorry to disturb you again.
Just considered more about the implementation to use PEI performance log HOB,
that will make DP hardly depends on *PeiPerformanceLib*.
As user may want to only dump DXE or SMM performance data, then
PeiPerformanceLib will be not linked and PEI
Current UefiDpLib implementation depends on TimerLib,
as different platforms may implement and use their
own TimerLib, it makes the dp command needs to be built
by platform. The TimerLib dependency can be removed by
using performance property configuration table to make
UefiDpLib to be generic.
Cc
Current DP implementation depends on TimerLib, as different
platforms may implement and use their own TimerLib, it makes
the dp needs to be built by platform. The TimerLib dependency
can be removed by using performance property configuration
table to make DP to be generic.
V3:
Define and install p
Current Dp_App implementation depends on TimerLib,
as different platforms may implement and use their
own TimerLib, it makes the dp application needs to
be built by platform. The TimerLib dependency can
be removed by using performance property configuration
table to make Dp_App to be generic.
Cc:
27 matches
Mail list logo
