[edk2] [PATCH] UefiCpuPkg/MpInitLib: Add missing point mark

2017-01-04 Thread Jeff Fan
Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Dandan Bi --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [patch] MdeModulePkg/StaControllerDxe: Fix coding style issue

2017-01-04 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Bi, Dandan Sent: Thursday, January 5, 2017 1:22 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [patch] MdeModulePkg/StaControllerDxe: Fix coding style issue Remove the empty

[edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Fix incorrect MODULE_TYPE

2017-01-04 Thread Dandan Bi
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg/Bds: Fix a bug that may causes S4 fails to resume

2017-01-04 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, January 5, 2017 11:18 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [PATCH] MdeModulePkg/Bds: Fix a bug that may causes S4 fails to > resume > > When firmware

[edk2] [Patch 2/2] CryptoPkg/TlsLib: Refine the coding style.

2017-01-04 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- CryptoPkg/Library/TlsLib/TlsConfig.c | 4 ++-- CryptoPkg/Library/TlsLib/TlsProcess.c |

[edk2] [Patch 1/2] MdePkg, NetworkPkg: Refine the coding style.

2017-01-04 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdePkg/Include/IndustryStandard/Tls1.h | 10 +-

[edk2] [Patch 0/2] Refine the coding style.

2017-01-04 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Jiaxin Wu (2): MdePkg, NetworkPkg: Refine the coding

[edk2] [PATCH] MdeModulePkg/Bds: Fix a bug that may causes S4 fails to resume

2017-01-04 Thread Ruiyu Ni
When firmware boots to UiApp, the memory type information settings are saved to NV storage and the settings in HOB are changed as well. Because UiApp is an APPLICATION type of boot option, system doesn't reset when settings change. But when user selects OS to boot in UiApp, because the settings in

Re: [edk2] [PATCH 1/2] SecuritPkg: Tcg2: Fix coding style issue

2017-01-04 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Thursday, January 5, 2017 10:18 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Zhang, Chao B

Re: [edk2] [PATCH 2/2] SecurityPkg: Add Pcd PROMPT/HELP & Chang default setting

2017-01-04 Thread Zeng, Star
Please correct the typo "Inital" in dec and uni files. With that, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Zhang, Chao B Sent: Thursday, January 5, 2017 10:19 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Zhang, Chao B

[edk2] [PATCH 2/2] SecurityPkg: Add Pcd PROMPT/HELP & Chang default setting

2017-01-04 Thread Zhang, Chao B
Update PCD PcdTcg2PhysicalPresenceFlags default setting. Also add PROMPT, HELP string. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/SecurityPkg.dec | 2 +-

[edk2] [PATCH 1/2] SecuritPkg: Tcg2: Fix coding style issue

2017-01-04 Thread Zhang, Chao B
Fix coding style issue Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 14 +++--- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 16

Re: [edk2] [PATCH 1/4] MdePkg/BaseLib: Add safe string functions [Ascii]StrnSizeS

2017-01-04 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Wednesday, January 4, 2017 7:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Gao, Liming ; Kinney, Michael D >

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-04 Thread Yao, Jiewen
Sorry, fix typo: I agree we do *not* use EFI_ prefix here. But using _EFI as suffix is also odd. :) Do we have better name? Such as POWER_MGMT_REGISTER_Q35_ADDRESS ? Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, Jiewen Sent: Thursday,

Re: [edk2] [PATCH] SecurityPkg: Tcg2ConfigDxe: Display TPM2 HID in Tcg2Config

2017-01-04 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Chao B > Sent: Wednesday, January 4, 2017 3:19 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin ; Yao, Jiewen ; Zhang, > Chao B > Subject: [PATCH]

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-04 Thread Yao, Jiewen
Hi I agree we do use EFI_ prefix here. But using _EFI as suffix is also odd. :) Do we have better name? Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Thursday, January 5, 2017 6:02 AM To: Laszlo Ersek ;

[edk2] [PATCH 1/4] MdePkg: Add BaseIoFifoLib library

2017-01-04 Thread Leo Duran
The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. The patch moves the I/O Fifo routines into a common BaseIofifoLib library supporting IA32 and X64 architectures under MdePkg. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 3/4] Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library.

2017-01-04 Thread Leo Duran
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Reviewed-by: Leo Duran --- UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c | 1 - UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.h | 1 + UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf| 10

[edk2] [PATCH 4/4] Modify QemuFwCfgLib to use new BaseIoFifoLib library.

2017-01-04 Thread Leo Duran
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Reviewed-by: Leo Duran --- OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm | 55 --- OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 1 +

[edk2] [PATCH 0/4] *** BaseIoFifoLib ***

2017-01-04 Thread Leo Duran
The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. The patch series moves the I/O Fifo routines into a common BaseIofifoLib library supporting IA32 and X64 architectures under MdePkg. The intent of this patch series is twofold: 1)

[edk2] [PATCH 2/4] Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf

2017-01-04 Thread Leo Duran
This patch adds the new BaseIoFifoLib (IoFifoLib class) library consumed by the UefiCpuPkg/CpuIo2Dxe driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Reviewed-by: Leo Duran ---

Re: [edk2] [PATCH 1/1] Add BGRT ACPI table inclusion support in OVMF

2017-01-04 Thread Bhupesh SHARMA
Hi Laszlo, Many thanks for taking out the time to review this. On Tue, Jan 3, 2017 at 8:16 PM, Laszlo Ersek wrote: > On 12/26/16 06:25, Bhupesh Sharma wrote: >> During debugging Linux kernel for ACPI BGRT support >> (especially on VMs), it is sometimes very useful to have >>

Re: [edk2] [PATCH RFC 02/14] OvmfPkg/XenOvmf: Update debug IO port for Xen

2017-01-04 Thread Laszlo Ersek
On 12/08/16 16:33, Anthony PERARD wrote: > This is a debug IO port that will output directly to the Xen Hypervisor > console. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenOvmf.dsc | 3 +++ > 1 file

Re: [edk2] [PATCH RFC 01/14] OvmfPkg: Create platform XenOvmf

2017-01-04 Thread Laszlo Ersek
On 12/08/16 16:33, Anthony PERARD wrote: > This is a copy of OvmfX64, removing VirtIO and some SMM. (1) Please provide more details in the commit message: - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITION - removed: VirtioLib class resolution - removed: DXE_SMM_DRIVER and SMM_CORE lib

Re: [edk2] [PATCH] ShellPkg: Fix a bug ">>v" cannot append data to environment variable

2017-01-04 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Please verify appropriate copyright before commit (I guess this file needs year update). > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, January 03, 2017 7:23 PM >

Re: [edk2] [PATCH v3] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address

2017-01-04 Thread Leif Lindholm
On Tue, Dec 13, 2016 at 07:56:09PM -0600, Daniil Egranov wrote: > Changed code structure per Leif Lindholm's request Needs a commit message describing what the patch does. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Daniil Egranov > ---

[edk2] [PATCH 3/4] MdePkg/BaseLib: Enhance the return value for string to uint functions

2017-01-04 Thread Hao Wu
For the following 8 APIs in MdePkg/BaseLib: [Ascii]StrDecimalToUintn [Ascii]StrDecimalToUint64 [Ascii]StrHexToUintn [Ascii]StrHexToUint64 They will ASSERT for DEBUG build when the input string exceeds the range of UINTN/UINT64. However, for RELEASE build, incorrect value will be returned. This

[edk2] [PATCH 0/4] Add and refine sting APIs in MdePkg/BaseLib

2017-01-04 Thread Hao Wu
The series does the following things: 1). Add safe string functions [Ascii]StrnSizeS 2). Add safe string functions [Ascii]StrDecimalToUintnS, [Ascii]StrDecimalToUint64S, [Ascii]StrHexToUintnS and [Ascii]StrHexToUint64S 3). Refine the return value of string funcitons

[edk2] [PATCH 4/4] MdePkg/BaseLib: Add safe string functions [U|A]StrnTo[A|U]StrS

2017-01-04 Thread Hao Wu
Add the following 2 APIs: UnicodeStrnToAsciiStrS AsciiStrnToUnicodeStrS These APIs are used to enhance APIs UnicodeStrToAsciiStrS and AsciiStrToUnicodeStrS (without 'n' in names) by: 1. Adds an input parameter 'Length' to specify the maximum number of Ascii/Unicode characters to convert. 2. Adds

[edk2] [PATCH 2/4] MdePkg/BaseLib: Add safe string functions that convert str to value

2017-01-04 Thread Hao Wu
Add the following 8 APIs: [Ascii]StrDecimalToUintnS [Ascii]StrDecimalToUint64S [Ascii]StrHexToUintnS [Ascii]StrHexToUint64S These safe version APIs are used to enhance their counterpart (APIs without trailing 'S' in function names). These safe version APIs perform checks to the input string and

[edk2] [PATCH 1/4] MdePkg/BaseLib: Add safe string functions [Ascii]StrnSizeS

2017-01-04 Thread Hao Wu
Add StrnSizeS() and AsciiStrnSizeS() APIs. These 2 safe version APIs are used to replace StrSize() and AsciiStrSize(). Those two APIs use similar checks as [Ascii]StrnLenS(). Cc: Jiewen Yao Cc: Liming Gao Cc: Michael Kinney

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-04 Thread Laszlo Ersek
On 01/04/17 02:30, Jordan Justen wrote: > On 2016-12-02 02:48:44, Laszlo Ersek wrote: >> EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to >> access in UEFI encoding, not in edk2/PciLib encoding. Convert the >> ICH9_GEN_PMCON_1 register's address to UEFI representation before

Re: [edk2] unable to build update capsule image

2017-01-04 Thread Iddamsetty, Aravind (Artesyn)
Hi Yao Jiewen, Thank you so much, after I set the OPENSSL_PATH I was able to generate capsule image. Thanks & Regards, Aravind. From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, January 04, 2017 1:44 PM To: Iddamsetty, Aravind [ENGINEERING/IN]; edk2-devel@lists.01.org Subject:

Re: [edk2] unable to build update capsule image

2017-01-04 Thread Yao, Jiewen
I found we mentioned below in \Vlv2TbltDevicePkg\Build_IFWI.bat If capsule update is needed, please update CAPSULE_ENABLE = TRUE in Config.dsc. If recovery is needed, please update RECOVERY_ENABLE = TRUE in Config.dsc. If either of above is TRUE, please set OPENSSL_PATH

Re: [edk2] unable to build update capsule image

2017-01-04 Thread Yao, Jiewen
Hi Enabling capsule requires signing. So you need generate the openssl.exe. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Iddamsetty, Aravind (Artesyn) > Sent: Wednesday, January 4, 2017 3:14 PM > To: