[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Fix some GCC build error.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- Platform/BroxtonPlatformPkg/BuildBios.sh | 2 +- .../DxeFspWrapperPlatformResetLib/DxeFspWrapperPlatformResetLib.c | 2 +-

Re: [edk2] [Patch] BaseTools: Fix the bug that FixedPcdGetPtr failure for CArray Pcd

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Friday, May 12, 2017 11:23 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug that FixedPcdGetPtr failure for CArray >Pcd > >This

Re: [edk2] [Patch] BaseTools: Fix the bug for CArray PCD override in command line

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Friday, May 12, 2017 1:12 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug for CArray PCD override in command >line > >This patch

[edk2] [Patch] BaseTools: Fix the bug for CArray PCD override in command line

This patch updated the CArray PCD override format from B"{}" to H"{}" which align to build spec. Besides, it also do the clean up for the function BuildOptionPcdValueFormat. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

[edk2] TFTP over IPv6 across /64 subnet

Hello all, Does the current EDKII supports TFTP over IPv6 across /64 subnet? If not, does EDKII have any plans to support? Thanks in advance. Regards, Naveen ___ edk2-devel mailing list

[edk2] [PATCH v2] support sparse image in AndroidFastbootApp

Changelog: v2: * Rebase code base. * Fix ident. * Fix sizeof (). Haojian Zhuang (1): EmbeddedPkg/AndroidFastbootApp: support sparse image .../AndroidFastboot/AndroidFastbootApp.c | 100 +++-- .../AndroidFastboot/AndroidFastbootApp.h | 29

[edk2] [PATCH] EmbeddedPkg/AndroidFastbootApp: support sparse image

Support sparse image that is reformatted from large raw image and splitted into a few smaller images. The sparse image follows the rule of Android Sparse Image format. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang ---

[edk2] [Patch] BaseTools: Fix the bug that FixedPcdGetPtr failure for CArray Pcd

This patch for the bug FixedPcdGetPtr report failure for the CArray type Pcd. 1) correct the Fixed Pcd list; 2) correct the Fixed Pcd in Library AutoGen file to same with Driver AutoGen file format. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables)

On Mon, May 08, 2017 at 12:27:59PM +0800, Gary Lin wrote: > On Sat, May 06, 2017 at 09:30:18PM +0200, Laszlo Ersek wrote: > > (All hail Saturday!) > > > > Gary, can you please fetch this from my repo (URL & branch name below) > > and test it with Xen? Please test both the 4MB and the 2MB build.

Re: [edk2] [PATCH V5 0/3] Add IOMMU support.

Good question. Comments below: From: Justen, Jordan L Sent: Friday, May 12, 2017 4:52 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Leo Duran ; Ard Biesheuvel ; Brijesh Singh

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error

On 05/11/17 09:27, Jeff Fan wrote: > Cc: Jiewen Yao > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan > --- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 2 +- > 1 file changed, 1

Re: [edk2] [PATCH V5 0/3] Add IOMMU support.

This design seems to force a platform the use APRIORI to provide the IoMmu protocol. Isn't this something we try to avoid? One thought is that the PciHostBridge driver could add a depex on IoMmu protocol conditionally based on a feature PCD, right? Unfortunately, in this case it seems that the

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 05/11/17 19:43, Jordan Justen wrote: > On 2017-05-11 08:53:39, Laszlo Ersek wrote: >> (5) Please mention that the driver is being added to the APRIORI DXE >> file for a separate reason as well (not just for the early clearing of >> the C bit on MMIO/NonExistent): OvmfPkg's DXE phase modules

Re: [edk2] [RFC v4 09/13] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for SEC phase

On 05/11/2017 11:24 AM, Laszlo Ersek wrote: On 05/11/17 00:09, Brijesh Singh wrote: Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh ---

Re: [edk2] [RFC v4 07/13] OvmfPkg/QemuFwCfgLib: Provide Pei and Dxe specific library

On 05/11/2017 10:40 AM, Laszlo Ersek wrote: [snip...] BASE_NAME = QemuFwCfgLib (1) Please update this to "QemuFwCfgDxeLib". Done. [snip..] BASE_NAME = QemuFwCfgLib (2) Please update this to "QemuFwCfgPeiLib". Done. thanks -Brijesh

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 05/11/2017 10:19 AM, Laszlo Ersek wrote: (1) Please mention that the C bit is cleared for MMIO GCD entries in order to cover the ranges that were added during the PEI phase (through memory resource descriptor HOBs). Also mention that the NonExistent ranges are processed in order to cover,

Re: [edk2] [RFC v4 05/13] OvmfPkg/PlatformPei: Set memory encryption PCD when SEV is enabled

On 05/11/2017 09:37 AM, Laszlo Ersek wrote: Please replace the last paragraph in the commit message with the following (mostly based on ): The patch sets the memory encryption PCD. The PCD is consumed by the

Re: [edk2] [RFC v4 04/13] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

On 05/11/2017 09:04 AM, Laszlo Ersek wrote: I have the following suggestions for this patch: (1) The InternalMemEncryptSevIsEnabled() function is identical between "Ia32/MemEncryptSevLib.c" and "X64/MemEncryptSevLib.c". In addition, that function is the only one exported by

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 05/11/2017 12:43 PM, Jordan Justen wrote: On 2017-05-11 08:53:39, Laszlo Ersek wrote: (5) Please mention that the driver is being added to the APRIORI DXE file for a separate reason as well (not just for the early clearing of the C bit on MMIO/NonExistent): OvmfPkg's DXE phase modules that

Re: [edk2] [RFC v4 13/13] OvmfPkg/QemuFwCfgLib: Add SEV support

comments below: On 05/11/17 00:09, Brijesh Singh wrote: > When SEV is enabled, use a bounce buffer to perform the DMA operation. > > > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 2017-05-11 08:53:39, Laszlo Ersek wrote: > (5) Please mention that the driver is being added to the APRIORI DXE > file for a separate reason as well (not just for the early clearing of > the C bit on MMIO/NonExistent): OvmfPkg's DXE phase modules that tailor > their behavior to SEV presence

[edk2] Nt32 emulator: Source level debugging

Hi all, I encountered an issue again which may be open since around 4 years (see "Source-level-debugging (NT32 + MS Visual Studio 2010)". So if still anyone has issues with debugging modules in NT32Pkg because of no/wrong symbols loaded then this may help you out: In my case the issue was caused

Re: [edk2] [RFC v4 12/13] OvmfPkg/QemuFwCfgLib: Add option to dynamic alloc FW_CFG_DMA Access

On 05/11/17 00:09, Brijesh Singh wrote: > Update InternalQemuFwCfgDmaBytes() to work with DMA Access pointer. > The change provides the flexibility to dynamically allocate the "Access" > when SEV is enabled. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brijesh

Re: [edk2] [RFC v4 11/13] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for Dxe phase

comments below: On 05/11/17 00:09, Brijesh Singh wrote: > When SEV is enabled, the DMA must be performed on unencrypted pages. > So when get asked to perfom FWCFG DMA read or write, we allocate a > intermediate (bounce buffer) unencrypted buffer and use this buffer > for DMA read or write. > >

Re: [edk2] [RFC v4 10/13] OvmfPkg/QemuFwCfgLib: Implement SEV internal functions for PEI phase

On 05/11/17 00:09, Brijesh Singh wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf

Re: [edk2] [RFC v4 09/13] OvmfPkg/QemuFwCfgLib: Implement SEV internal function for SEC phase

On 05/11/17 00:09, Brijesh Singh wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf

Re: [edk2] [PATCH 0/2] ShellPkg/memmap: Dump memory map information for all memory types

For series. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Thursday, May 11, 2017 3:27 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] ShellPkg/memmap: Dump

Re: [edk2] [RFC v4 08/13] OvmfPkg/QemuFwCfgLib: Prepare for SEV support

On 05/11/17 00:09, Brijesh Singh wrote: > Add SEV specific internal functions which will be used while intergrating > the SEV support into QemuFwCfgLib. > > > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

On 05/11/17 17:19, Laszlo Ersek wrote: > comments below: > > On 05/11/17 00:09, Brijesh Singh wrote: >> When SEV is enabled, the MMIO memory range must be mapped as unencrypted >> (i.e C-bit cleared) and DMA must be performed on unencrypted memory. >> >> The patch adds a DXE driver that runs

Re: [edk2] [RFC v4 07/13] OvmfPkg/QemuFwCfgLib: Provide Pei and Dxe specific library

comments below: On 05/11/17 00:09, Brijesh Singh wrote: > Current QemuFwCfgLib.inf is used in both Pei and Dxe phases. Add Pei > and Dxe inf file to provide a seperate QemuFwCfgLib instances for Pei > and Dxe phases. > > > Cc: Jordan Justen > Cc: Laszlo Ersek

Re: [edk2] [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver

comments below: On 05/11/17 00:09, Brijesh Singh wrote: > When SEV is enabled, the MMIO memory range must be mapped as unencrypted > (i.e C-bit cleared) and DMA must be performed on unencrypted memory. > > The patch adds a DXE driver that runs early in boot and clears the memory > encryption

Re: [edk2] [RFC v4 05/13] OvmfPkg/PlatformPei: Set memory encryption PCD when SEV is enabled

On 05/11/17 00:09, Brijesh Singh wrote: > Secure Encrypted Virtualization (SEV) guest VMs have the concept of > private and shared memory. Private memory is encrypted with the > guest-specific key, while shared memory may be encrypted with hypervisor > key. Certain types of memory (namely

Re: [edk2] [RFC v4 04/13] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library

On 05/11/17 00:09, Brijesh Singh wrote: > Add Secure Encrypted Virtualization (SEV) helper library. > The library provides the routines to: > - set or clear memory encryption bit for a given memory region. > - query whether SEV is enabled. > > > Cc: Jordan Justen >

Re: [edk2] [PATCH] MdeModulePkg SmiHandlerProfile: Fix memory leak in DumpSmiChildContext

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, May 11, 2017 5:57 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg SmiHandlerProfile: Fix memory leak in >

Re: [edk2] [RFC v4 03/13] OvmfPkg: Update dsc to use IoLib from BaseIoLibIntrinsicSev.inf

On 05/11/17 00:09, Brijesh Singh wrote: > When SEV is enabled then we must unroll the rep String I/O instructions. > > The patch updates dsc file to use SEV version of IoLib inf. The main > difference between BaseIoLibIntrinsic.inf and BaseIoLibIntrinsicSev.inf > is, SEV version checks if its

Re: [edk2] [RFC v4 02/13] OvmfPkg/ResetVector: Set C-bit when building initial page table

On 05/11/17 00:09, Brijesh Singh wrote: > SEV guest VMs have the concept of private and shared memory. Private > memory is encrypted with the guest-specific key, while shared memory > may be encrypted with hypervisor key. Certain types of memory (namely > instruction pages and guest page tables)

[edk2] Display Hii Progress Bar

Hi, I am implementing progress bar on Hii form. I used one function 'BootLogoUpdateProgress()' but output is coming on console window, when I move mouse on progress bar it erases that. Will you please suggest me a specific way to implement progress bar on Hii. Thanks in advance Regards, Vikash

[edk2] [PATCH 2/2] ShellPkg/memmap: Dump memory map information for all memory types

The patch dumps memory map information for all memory types. But to follow the SFO format of "memmap" defined in Shell 2.2 spec, the patch doesn't dump the memory map information for OEM/OS memory types. But it does include the OEM/OS memory in the total size in SFO format. Contributed-under:

[edk2] [PATCH 1/2] ShellPkg/memmap: Refine code

The patch changes Buffer to Descriptors, changes (UINT8 *Walker) to (EFI_MEMORY_DESCRIPTOR *Walker). The change makes lots of type conversion unnecessary. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey

[edk2] [PATCH 0/2] ShellPkg/memmap: Dump memory map information for all memory types

The patch dumps memory map information for all memory types. But to follow the SFO format of "memmap" defined in Shell 2.2 spec, the patch doesn't dump the memory map information for OEM/OS memory types. But it does include the OEM/OS memory in the total size in SFO format. Ruiyu Ni (2):

[edk2] [PATCH] MdeModulePkg SmiHandlerProfile: Fix memory leak in DumpSmiChildContext

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=530 In DumpSmiChildContext() of SmiHandlerProfile.c and SmiHandlerProfileInfo.c, the return buffer from ConvertDevicePathToText() should be freed after used. Cc: Jiewen Yao Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 0/2] Fix SmmCpuFeaturesLib issues

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, May 10, 2017 2:50 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Fix SmmCpuFeaturesLib issues Jeff Fan (2):

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Check ProcessorId == INVALID_APIC_ID

Reviewed-by: Eric Dong -Original Message- From: Fan, Jeff Sent: Wednesday, May 10, 2017 4:34 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Dong, Eric Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Check ProcessorId == INVALID_APIC_ID If PcdCpuHotPlugSupport is TRUE,

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error

Reviewed-by: jiewen@intel.com > -Original Message- > From: Fan, Jeff > Sent: Thursday, May 11, 2017 3:27 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error > >

Re: [edk2] [PATCH] SecurityPkg: Add TCG Spec info to TCG related modules

Reviewed-by: Qin Long > -Original Message- > From: Zhang, Chao B > Sent: Thursday, May 11, 2017 1:15 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin; Yao, Jiewen; Zhang, Chao B > Subject: [PATCH] SecurityPkg: Add TCG Spec info to TCG related modules > > Add TCG

Re: [edk2] [PATCH] EmbeddedPkg/AndroidFastbootApp: support sparse image

On 2017/5/4 18:48, Leif Lindholm wrote: On Fri, Apr 14, 2017 at 05:55:32PM +0800, Haojian Zhuang wrote: Support sparse image that is reformatted from large raw image and splitted into a few smaller images. The sparse image follows the rule of Android Sparse Image format. Contributed-under:

[edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix logic check error

Cc: Jiewen Yao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] Convention for creating dynamic HII forms

Hi Dev, I add my comments below. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of dgur...@codeaurora.org Sent: Thursday, May 11, 2017 4:39 AM To: edk2-devel@lists.01.org Subject: [edk2] Convention for creating dynamic HII forms Hi,

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Fixed some GCC build errors.

Reviewed-by: lushifex Shifei -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of zwei4 Sent: Thursday, May 11, 2017 11:37 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Fixed some

Re: [edk2] [Patch] BaseTools: Correct VOID* PatchPcd Size in Library Autogen

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Wednesday, May 10, 2017 8:53 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Correct VOID* PatchPcd Size in Library Autogen > > This

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Fix some GCC build errors.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- .../Common/Acpi/AcpiPlatformDxe/AcpiPlatform.c | 5 +- .../Common/Acpi/AcpiPlatformDxe/AcpiPlatform.h | 9 +- .../Acpi/AcpiPlatformDxe/AcpiPlatformHooks.c | 7 +-