[edk2] [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line

2017-07-31 Thread hegdenag
If DAD failed, we print "It failed to set", print the IPv6 address and exit. We need a better error string and also, after printing the IPv6 address, we need a new line else the Shell> prompt will overwrite the IPv6 address. Fixed these issues in this patch. Contributed-under: TianoCore

[edk2] [PATCH] ShellPkg/dblk: Honor the BlockIo alignment requirement.

2017-07-31 Thread Ruiyu Ni
From: HuajingLi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni --- ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c | 17 - 1 file changed, 12

Re: [edk2] [PATCH 2/2] IntelSiliconPkg/IntelVTdDxe: Add explicit NULL pointer checks

2017-07-31 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao > Wu > Sent: Tuesday, August 1, 2017 12:32 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen >

Re: [edk2] [PATCH 1/2] IntelSiliconPkg/IntelVTdDxe: Fix typo for VTd IOTLB domain ID

2017-07-31 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Tuesday, August 1, 2017 12:32 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH 1/2] IntelSiliconPkg/IntelVTdDxe: Fix typo for VTd

[edk2] [PATCH 0/2] IntelSiliconPkg/IntelVTdDxe: Code refinements

2017-07-31 Thread Hao Wu
Cc: Jiewen Yao Hao Wu (2): IntelSiliconPkg/IntelVTdDxe: Fix typo for VTd IOTLB domain ID IntelSiliconPkg/IntelVTdDxe: Add explicit NULL pointer checks IntelSiliconPkg/IntelVTdDxe/TranslationTable.c | 6 -- IntelSiliconPkg/IntelVTdDxe/VtdReg.c | 2 +- 2

Re: [edk2] [Patch] NetworkPkg/Ip6Dxe: Fix the IPv6 PXE boot option goes missing issue

2017-07-31 Thread Hegde, Nagaraj P
Reviewed-by: Hegde, Nagaraj P Tested-by: Hegde, Nagaraj P -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Sunday, July 30, 2017 7:37 PM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P ;

[edk2] [PATCH 1/2] IntelSiliconPkg/IntelVTdDxe: Fix typo for VTd IOTLB domain ID

2017-07-31 Thread Hao Wu
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelSiliconPkg/IntelVTdDxe/VtdReg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelSiliconPkg/IntelVTdDxe/VtdReg.c

[edk2] [PATCH 2/2] IntelSiliconPkg/IntelVTdDxe: Add explicit NULL pointer checks

2017-07-31 Thread Hao Wu
Add explicit NULL pointer check to make the codes more straight-forward. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelSiliconPkg/IntelVTdDxe/TranslationTable.c | 6 -- 1 file changed, 4

[edk2] [Patch v2 2/3] UefiCpuPkg: Add Processor Trace feature definition.

2017-07-31 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [Patch v2 1/3] UefiCpuPkg: Add Pcds used by processor trace feature.

2017-07-31 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/UefiCpuPkg.dec | 10 ++ 1 file changed, 10 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dec

[edk2] [Patch v2 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-07-31 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- .../CpuCommonFeaturesLib/CpuCommonFeatures.h | 66 +++ .../CpuCommonFeaturesLib/CpuCommonFeaturesLib.c| 11 +

[edk2] [Patch v2 0/3] Enable Processor trace feature.

2017-07-31 Thread Eric Dong
Enable processor trace feature. V2 update: 1. Add device capability check logic in Support function. 2. Correct the function comments. Eric Dong (3): UefiCpuPkg: Add Pcds used by processor trace feature. UefiCpuPkg: Add Processor Trace feature definition. UefiCpuPkg: Enable Processor Trace

Re: [edk2] [Patch] BaseTools: Fix the bug to correctly check Pcd type that in FDF file

2017-07-31 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, July 27, 2017 11:38 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fix the bug to correctly check Pcd type that in > FDF

Re: [edk2] [Patch 0/6] BaseTools: Fix some segmentation fault in Tools

2017-07-31 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, July 27, 2017 9:42 AM > To: edk2-devel@lists.01.org > Cc: che...@pdx.edu; Gao, Liming >

Re: [edk2] [Patch 0/2] Fix the bug when cleaning up the TLS instance

2017-07-31 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: Monday, July 31, 2017 1:41 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Long, Qin ; Wu, Jiaxin Subject:

Re: [edk2] [PATCH v1 2/4] OvmfPkg: IommuDxe: Provide support for mapping BusMasterCommonBuffer operation

2017-07-31 Thread Brijesh Singh
On 07/31/2017 02:49 PM, Ard Biesheuvel wrote: On 31 July 2017 at 20:31, Brijesh Singh wrote: The current implementation was making assumption that AllocateBuffer() returns a buffer with C-bit cleared. Hence when we were asked to Map() with BusMasterCommonBuffer, we do

Re: [edk2] [PATCH v1 2/4] OvmfPkg: IommuDxe: Provide support for mapping BusMasterCommonBuffer operation

2017-07-31 Thread Ard Biesheuvel
On 31 July 2017 at 20:31, Brijesh Singh wrote: > The current implementation was making assumption that AllocateBuffer() > returns a buffer with C-bit cleared. Hence when we were asked to > Map() with BusMasterCommonBuffer, we do not change the C-bit on > host buffer. > > In

Re: [edk2] [PATCH v1 3/4] OvmfPkg: IommuDxe: Zero the shared page(s) on Unmap()

2017-07-31 Thread Brijesh Singh
I just realized that this patch contains some changes which should be part of Patch 2/3. Please ignore this patch for now. I will fix it as part of v2 when addressing review feedback. thanks -Brijesh On 07/31/2017 02:31 PM, Brijesh Singh wrote: To support the Map(), we allocate bounce buffer

[edk2] [PATCH v1 3/4] OvmfPkg: IommuDxe: Zero the shared page(s) on Unmap()

2017-07-31 Thread Brijesh Singh
To support the Map(), we allocate bounce buffer with C-bit cleared, the buffer is referred as a DeviceAddress. Typically, DeviceAddress is used as communication block between guest and hypervisor. When guest is done with communication block, it calls Unmap().The Unmap() free's the DeviceAddress,

[edk2] [PATCH v1 4/4] OvmfPkg : QemuFwCfgLib: Map DMA buffer with CommonBuffer when SEV is enable

2017-07-31 Thread Brijesh Singh
Commit 09719a01b11b (OvmfPkg/QemuFwCfgLib: Implement SEV internal function for Dxe phase) uses IOMMU protocol to allocate and free DMA buffer used by QemuFwCfgDxe when SEV is enabled. During the initial commit we made assumption that IOMMU.AllocateBuffer() will provide a buffer with C-bit

[edk2] [PATCH v1 2/4] OvmfPkg: IommuDxe: Provide support for mapping BusMasterCommonBuffer operation

2017-07-31 Thread Brijesh Singh
The current implementation was making assumption that AllocateBuffer() returns a buffer with C-bit cleared. Hence when we were asked to Map() with BusMasterCommonBuffer, we do not change the C-bit on host buffer. In previous patch, we changed the AllocateBuffer() to not clear C-bit during

[edk2] [PATCH v1 1/4] OvmfPkg: IommuDxe: Do not clear C-bit in Allocate() and Free()

2017-07-31 Thread Brijesh Singh
As per the discussion [1], the buffer allocated using IOMMU->AllocateBuffer() need not result in a buffer that is immediately usable for the DMA device operation. Client is required to call Map() unconditionally with BusMasterCommonBuffer before performing the desired DMA bus master operation.

[edk2] [PATCH v1 0/4] OvmfPkg : IoMmuDxe: BusMasterCommonBuffer support when SEV is active

2017-07-31 Thread Brijesh Singh
The patch series implements multiple recommendation came during IOMMU support discussion [1] for the SEV guest. Non of these patches fixes Virtio support for SEV guest, instead it fixes the SEV IoMmuDxe support to comply with EFI PCI protocol spec on DMA bus master accesses. I did some

Re: [edk2] issue about booting centos fail with edk2

2017-07-31 Thread Laszlo Ersek
On 07/31/17 02:27, Zhu Yijun wrote: > Hi all, > > I install a CentOS-7-aarch64 guest img by qemu cdrom, but it hung at UEFI > probability. > > Basic info: > libvirt 1.3.5 > QEMU 2.6.2 > UEFI: master branch with commit "688c7d2 BaseTools: Fix the bug that > warn()

Re: [edk2] [RFC v1 0/3] Add VIRTIO_F_IOMMU_PLATFORM support

2017-07-31 Thread Laszlo Ersek
On 07/29/17 03:37, Brijesh Singh wrote: > On 7/28/17 7:52 PM, Brijesh Singh wrote: > [snip] >> AMD APM document a procedure which must be used to perform in-place >> encryption/decryption. We must follow those steps to ensure that data is >> flush into memory using the correct C-bit. Not doing so

Re: [edk2] [staging/cadence-aarch64 PATCH] CadencePkg: switch to to generic ResetSystemRuntimeDxe

2017-07-31 Thread Leif Lindholm
On Tue, Jul 25, 2017 at 05:23:31PM +0100, Scott Telford wrote: > Change CadenceCspResetSystemLib to implement ResetSystemLib, consumed by > MdeModulePkg/Universal/ResetSystemRuntimeDxe. > > Wire all reset variants to ResetCold, except for ResetShutdown and > EnterS3WithImmediateWake, which return

Re: [edk2] [Patch][edk2-platforms/minnowboard-max-udk2017] Add new platform branch minnowboard-max-udk2017

2017-07-31 Thread Kinney, Michael D
Guo Mang, A platform in the edk2-platforms repository should not contain the packages from the edk2 repository. Instead, the instructions for the platform should require both the edk2 repo and the edk2-platform repo to be cloned with the correct branches checked out and PACKAGES_PATH set so the

Re: [edk2] [Patch 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-07-31 Thread Fan, Jeff
Eric, Please correct the following comments. " Enhanced Intel SpeedStep" should be " Intel Processor Trace ". + @retval TRUE Enhanced Intel SpeedStep feature is supported. + @retval FALSEEnhanced Intel SpeedStep feature is not supported. Jeff -Original Message- From:

Re: [edk2] [Patch 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-07-31 Thread Fan, Jeff
Eric, ProcTraceGetConfigData() is invoked by BSP only. Instead, ProcTraceSupport() will be invoked by BSP/Aps. Please move CPUID check on Proc Trace capability to ProcTraceSupport(). Thanks! Jeff -Original Message- From: Dong, Eric Sent: Wednesday, July 19, 2017 3:10 PM To:

[edk2] [Patch][edk2-platforms/minnowboard-max-udk2017] Add new platform branch minnowboard-max-udk2017

2017-07-31 Thread Guo, Mang
Create a new branch (minnowboard-max-udk2017) on edk2-platforms for MinnowBoard Max. This code base is based on UDK2017 core packages. Code is ready in https://github.com/mangguo321/edk2-platforms/tree/minnowboard-max-udk2017 Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] MdeModulePkg PiSmmCoreMemoryAllocLib: Fix a FreePool() assertion issue

2017-07-31 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star >Zeng >Sent: Monday, July 31, 2017 3:47 PM >To: edk2-devel@lists.01.org >Cc: Yao, Jiewen ; Gao, Liming

[edk2] [PATCH] MdeModulePkg PiSmmCoreMemoryAllocLib: Fix a FreePool() assertion issue

2017-07-31 Thread Star Zeng
When PiSmmCore links against PeiDxeDebugLibReportStatusCode, the code flow below will cause a FreePool() assertion issue. PiSmmCoreMemoryAllocationLibConstructor() -> SmmInitializeMemoryServices() -> DEBUG ((DEBUG_INFO, "SmmAddMemoryRegion\n")) in SmmAddMemoryRegion() -> DebugPrint() ->

Re: [edk2] [Patch 1/2] CryptoPkg/TlsLib: Remove the redundant free of BIO objects

2017-07-31 Thread Long, Qin
Reviewed-by: Long Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Monday, July 31, 2017 1:41 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin ; Long, Qin