[edk2] [Patch][edk2-platforms/minnowboard-max-udk2017] Vlv2TbltDevicePkg: Enable signed capsule by default

2017-09-17 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Vlv2TbltDevicePkg/PlatformPkgConfig.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vlv2TbltDevicePkg/PlatformPkgConfig.dsc b/Vlv2TbltDevicePkg/PlatformPkgConfig.dsc

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64: enable frame pointers for RELEASE builds

2017-09-17 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Saturday, September 16, 2017 3:34 PM >To: Ard Biesheuvel >Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhu,

Re: [edk2] Failed to clear configuration in Ip4Config2 Protocol

2017-09-17 Thread Wu, Jiaxin
Hi karunakar, You can verify the DNS device path with HTTP boot feature. After the successful HTTP boot DNS parsing, the device path should be like: //../Mac(...)[/Vlan(...)][/Wi-Fi(...)]/IPv4(...)[/Dns(...)]/Uri(...). That is recommend way for the verification. Besides, you can also

Re: [edk2] [PATCH v2 0/3] UDF partition driver fix

2017-09-17 Thread Ni, Ruiyu
Paulo, Could you please paste a "map -r" output on a CDROM which contains Eltorito volume? I want to confirm that the result is expected. Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Sunday, September 17, 2017 9:13 PM > To:

Re: [edk2] [PATCH] RFC Inform UEFI memory to Linux

2017-09-17 Thread Ard Biesheuvel
On 17 September 2017 at 21:07, Udit Kumar wrote: > Hi Ard, > >> Thanks for the patch. But please consider carefully what you're doing: >> My point is really that you can just remove lines 124 - 189 instead. > > We want, OS to re-use firmware volume area. Therefore making

[edk2] [Patch V2] BaseTools: Fix a bug to correct SourceFileList

2017-09-17 Thread Yonghong Zhu
We met a case that use two microcode files in the Microcode.inf file, one is .mcb file, another is .txt file. then it cause build failure because the SourceFileList include the .txt file's output file, while this output file is still not be generated, so it cause GetFileDependency report failure.

Re: [edk2] Failed to clear configuration in Ip4Config2 Protocol

2017-09-17 Thread Karunakar P
Hi Jiaxin, Thank you very much for your info, Yes it works fine for manual configuration. And also could you please provide steps to verify "Add DNS device path node" feature. Thanks, karunakar -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Monday, September

Re: [edk2] [PATCH] RFC Inform UEFI memory to Linux

2017-09-17 Thread Udit Kumar
Hi Ard, > Thanks for the patch. But please consider carefully what you're doing: > My point is really that you can just remove lines 124 - 189 instead. We want, OS to re-use firmware volume area. Therefore making firmware volume visible. You are right, removing lines 124-189 will do the

Re: [edk2] Check Ipv6 Support for ISCSI attempt page

2017-09-17 Thread Karunakar P
Hi Ting Ye, Thanks for your reply. [Here the bug details] Bug 710 - IPv6 support condition check for HTTP and ISCSI https://bugzilla.tianocore.org/show_bug.cgi?id=710 Thanks, karunakar -Original Message- From: Ye, Ting [mailto:ting...@intel.com] Sent: Monday, September 18, 2017 8:23

[edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: Fix out-of-sync issue in page

2017-09-17 Thread Jian J Wang
>From CpuDxe driver perspective, it doesn't update GCD memory attributes from current page table setup during its initialization. So the memory attributes in GCD might not reflect all memory attributes in real world. Cc: Jiewen Yao Cc: Star Zeng Cc:

[edk2] [PATCH 1/2] MdeModulePkg/Core: Fix out-of-sync issue in GCD

2017-09-17 Thread Jian J Wang
>From GCD perspective, its SetMemorySpaceAttributes() method doesn't accept page related attributes. That means users cannot use it to change page attributes, and have to turn to CPU arch protocol to do it, which is not be allowed by PI spec. Cc: Jiewen Yao Cc: Star Zeng

[edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

2017-09-17 Thread Jian J Wang
There're two issues here actually. >From GCD perspective, its SetMemorySpaceAttributes() method doesn't accept page related attributes. That means users cannot use it to change page attributes, and have to turn to CPU arch protocol to do it, which is not be allowed by PI spec. >From CpuDxe

Re: [edk2] Check Ipv6 Support for ISCSI attempt page

2017-09-17 Thread Ye, Ting
Hi Karunakar, Thanks for capturing this. We agree that it's reasonable to add similar check to HTTP and ISCSI. Could you please help to file a bugzilla tracker for this? Thanks, Ting Ye -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Karunakar

Re: [edk2] Failed to clear configuration in Ip4Config2 Protocol

2017-09-17 Thread Wu, Jiaxin
Hi Karunakar, According the UEFI Spec, the Ip4Config2DataTypeManualAddress, Ip4Config2DataTypeGateway and Ip4Config2DataTypeDnsServer configuration data are not allowed to set via SetData() if the policy is DHCP. So, the clear feature is only for the manual configuration. This is our design

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Skip measurement for OEM type

2017-09-17 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: Zeng, Star Sent: Thursday, September 14, 2017 7:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; Chiu, Chasel Subject: [PATCH]

Re: [edk2] [PATCH 0/3] UDF partition driver fix

2017-09-17 Thread Ni, Ruiyu
Paulo, I checked carefully of patch #1, 50% carefully of #2, 20% carefully of #3. I could only give comments from the EDKII coding style perspective. I do provide some other comments, but please understand they are from a person that knows very little about UDF. (I know the concept of Volume. But

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes

2017-09-17 Thread Ni, Ruiyu
Paulo, With the change in partition driver, I suppose UdfDxe driver only needs to take care of area covered by the partition descriptor. But why StartMainVolumeDescriptorSequence() still reads LVD, TD, and PD? I thought the UdfDxe driver's logic can be simplified a lot. There should be no

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-17 Thread Ni, Ruiyu
Paulo, Several comments: 1. Can below logic be removed in PartitionDxe/Udf.c? while (!IsDevicePathEnd (DevicePathNode)) { // // Do not allow checking for UDF file systems in CDROM "El Torito" // partitions, and skip duplicate installation of UDF file system child // nodes. //

Re: [edk2] [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions

2017-09-17 Thread Ni, Ruiyu
Continue reading the patch #2, I think we can change IS_PD to: #define IS_UDF_PD(Tag) ((Tag)->TagIdentifier == 5) Using the above way, we can avoid caller to supply an invalid buffer. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

Re: [edk2] [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions

2017-09-17 Thread Ni, Ruiyu
#define _GET_TAG_ID(_Pointer) \ (((UDF_DESCRIPTOR_TAG *)(_Pointer))->TagIdentifier) #define IS_PD(_Pointer) \ ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 5)) #define IS_LVD(_Pointer) \ ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 6)) #define IS_TD(_Pointer) \ ((BOOLEAN)(_GET_TAG_ID (_Pointer) == 8))

Re: [edk2] [PATCH 0/3] UDF partition driver fix

2017-09-17 Thread Paulo Alcantara
Hi Jiewen, On 16/09/2017 20:52, Yao, Jiewen wrote: Thank you Paulo, to provide a fix for this driver. No problem! I'm trying to do the best I can in my very short time. I do not have comment for this specific patch. I would defer the review work to Star and Ruiyu. OK. I do have some

Re: [edk2] [PATCH 0/3] UDF partition driver fix

2017-09-17 Thread Yao, Jiewen
Thank you Laszlo. You analysis is great! Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Sunday, September 17, 2017 6:07 PM To: Yao, Jiewen ; Paulo Alcantara Cc: Ni, Ruiyu

[edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

2017-09-17 Thread Paulo Alcantara
Do not use entire block device size for the UDF logical partition, instead reserve the appropriate space (LVD space) for it. Cc: Eric Dong Cc: Ruiyu Ni Cc: Star Zeng Cc: Laszlo Ersek Reported-by: Ruiyu Ni

[edk2] [PATCH v2 0/3] UDF partition driver fix

2017-09-17 Thread Paulo Alcantara
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 Hi, This patchset fixes a bug in Partition driver that UDF partitions occupied the entire disk space instead of using LVD space only. BTW, I've only tested it under OVMF and built it with GCC only. That would be appreciable if someone

[edk2] [PATCH v2 3/3] MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes

2017-09-17 Thread Paulo Alcantara
This patch reworks the driver to support Partition driver changes. Cc: Eric Dong Cc: Paulo Alcantara Cc: Ruiyu Ni Cc: Star Zeng Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

[edk2] [PATCH v2 1/3] MdePkg: Add UDF volume structure definitions

2017-09-17 Thread Paulo Alcantara
This patch adds a fewe more UDF structures in order to detect Logical Volume and Partition descriptors during Main Volume Descriptor Sequence in Partition driver. Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek Cc: Ruiyu

Re: [edk2] [PATCH 0/3] UDF partition driver fix

2017-09-17 Thread Laszlo Ersek
Hi Jiewen, I agree these are important questions; even earlier I noticed the following remark in "PartitionDxe.inf": # Caution: This module requires additional review when modified. # This driver will have external input - disk partition. # This external input must be validated carefully to

[edk2] [PATCH 1/3] IntelSiliconPkg/VTdInfoPpi: Let it follow DMAR table.

2017-09-17 Thread Jiewen Yao
We notice that there is real usage in PEI to show the graphic output. As such we need report RMRR table in PEI to let VTdPmrPei driver skip the IGD UMA region. Now the VTD_INFO PPI uses the same DMAR data structure. Cc: Star Zeng Contributed-under: TianoCore Contribution

[edk2] [PATCH 0/3] IntelSiliconPkg/InteVTdPei: Add RMRR support in PEI

2017-09-17 Thread Jiewen Yao
We notice that there is real usage in PEI to show the graphic output. The Integrated Graphic Device is blocked by current IntelVTdPei because the DMA buffer is fully controlled by VTd PEIM. The UMA is not allowed. In DXE phase, the UMA is reported via RMRR table. As such, we need similar way in

[edk2] [PATCH 3/3] IntelSiliconPkg/VTdInfoSample: Add RMRR table.

2017-09-17 Thread Jiewen Yao
Let system report RMRR table for the platform support PEI graphic. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/Feature/VTd/PlatformVTdInfoSamplePei/PlatformVTdInfoSamplePei.c

[edk2] [PATCH 2/3] IntelSiliconPkg/IntelVTdPmrPei: Parse RMRR table.

2017-09-17 Thread Jiewen Yao
In order to support PEI graphic, we let VTdPmrPei driver parse DMAR table RMRR entry and allow the UMA access. If a system has no PEI IGD, no RMRR is needed. The behavior is unchanged. If a system has PEI IGD, it must report RMRR in PEI phase. The PeiVTdPrm will program the IGD VTd engine to