[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change Build Script

Change GCC build script for Benson Glacier FAB B and Minnowboard 3 Next pre-production board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- BuildBIOS.sh| 7 +++- Platform/BroxtonPlatformPkg/BuildBxtBios.sh

Re: [edk2] [PATCH v2 1/9] Platform/NXP: Add support for Big Endian Mmio APIs

Hi Leif, > Hmm, was there a cover letter for this v2? I can only find the one from v1 in > my > inbox? Usually it is helpful to keep the cover letter and add comments on what > has changed since the previous revision. > > Also, can you generate the patches with > --subject-prefix="PATCH

Re: [edk2] [RFC] Add EFI lock when creating new gauge record

Heyi: I agree your fix. Its impact is acceptable. Thanks Liming >-Original Message- >From: Heyi Guo [mailto:heyi@linaro.org] >Sent: Saturday, November 25, 2017 5:10 PM >To: Zeng, Star ; edk2-devel@lists.01.org >Cc: Carsey, Jaben ; Daryl

[edk2] [Patch v2] MdeModulePkg: Free NET_BUF data after it is sent out to avoid memory leak

V2: * Since packet has already been referred by DhcpSb->LastPacket, and will be freed when sending another packet or clean up, there is no need to add an extra free function in NetbufFromExt. Cc: Jiaxin Wu Cc: Ye Ting Cc: Fu Siyuan

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

Hi Leif, This is regarding Big-Endian Library patch ([PATCH v2 1/9] Platform/NXP: Add support for Big Endian Mmio APIs) We have started this discussion before and the suggestion was to create a separate .inf file keeping APIs name same e.g. MmioRead/MmioWrite in MdePkg. But we can't go with

[edk2] [PATCH v2 1/3] ShellPkg/ShellLib: Constructor doesn't depend on ShellParameters

When ShellLib is linked to a driver producing DynamicCommand protocol, ShellParameters protocol is set by DynamicCommand.Handler(). The driver image handle doesn't have ShellParameters protocol installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni

[edk2] [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command

UEFI Shell spec defines Shell Dynamic Command protocol which is just for the purpose to extend internal command. So tftp command is changed from NULL class library to be a driver producing DynamicCommand protocol. The guideline is: 1. Only use NULL class library for Shell spec defined commands.

[edk2] [PATCH v2 3/3] ShellPkg/dp: Convert from NULL class library to Dynamic Command

UEFI Shell spec defines Shell Dynamic Command protocol which is just for the purpose to extend internal command. So dp command is changed from NULL class library to be a driver producing DynamicCommand protocol. The guideline is: 1. Only use NULL class library for Shell spec defined commands. 2.

[edk2] [PATCH v2 0/3] Convert from NULL class library to Dynamic Command

UEFI Shell spec defines Shell Dynamic Command protocol which is just for the purpose to extend internal command. So tftp and dp are changed from NULL class library to be drivers producing DynamicCommand protocol. The guideline is: 1. Only use NULL class library for Shell spec defined commands.

Re: [edk2] [PATCH] MdeModulePkg/Core: Merge memory map after filtering paging capability

Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Monday, November 27, 2017 1:35 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star ; Laszlo Ersek Subject: [PATCH]

[edk2] [PATCH] MdeModulePkg/Core: Merge memory map after filtering paging capability

Once the paging capabilities were filtered out, there might be some adjacent entries sharing the same capabilities. It's recommended to merge those entries for the OS compatibility purpose. This patch makes use of existing method MergeMemoryMap() to do it. This is done by simply turning this

Re: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, November 27, 2017 9:20 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to

Re: [edk2] [PATCH v2 1/9] Platform/NXP: Add support for Big Endian Mmio APIs

Hi Leif, I forgot to attach a cover letter for v2, sent v3 with cover letter and added --subject-prefix="PATCH edk2-platforms". Thanks for the review. Regards, Meenakshi > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Sunday, November 26, 2017 9:19

[edk2] [PATCH edk2-platforms] [PATCH v3 8/9] Compilation : Add the fdf, dsc and dec files.

The firmware device, description and declaration files. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec | 29 ++ Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 77 +

[edk2] [PATCH edk2-platforms] [PATCH v3 9/9] Build : Add build script and environment script

Build script and Environment setup script. Readme to explain how to run build script Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Env.cshrc | 77

[edk2] [PATCH edk2-platforms] [PATCH v3 6/9] Silicon/Maxim : Add support for DS1307 RTC library

Real time clock Apis on top of I2C Apis Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Silicon/Maxim/Library/Ds1307RtcLib/Ds1307Rtc.h | 59 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 327

[edk2] [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP

v3: Added patch-prefix v2: 1. Incorporated styling comments 2. Removed/Rewrite function referred from linux 3. Created DS1307 Library under Silicon/Maxim and make it i2c driver based. 4. Created i2c driver Meenakshi Aggarwal (9): Platform/NXP: Add support for Big Endian Mmio APIs

[edk2] [PATCH edk2-platforms] [PATCH v3 3/9] SocLib : Add support for initialization of peripherals

Add SocInit function that initializes peripherals and print board and soc information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Include/Bitops.h | 179 +

[edk2] [PATCH edk2-platforms] [PATCH v3 7/9] Platform/NXP: Add support for ArmPlatformLib

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- .../Library/PlatformLib/ArmPlatformLib.c | 105 .../Library/PlatformLib/ArmPlatformLib.inf | 70

[edk2] [PATCH edk2-platforms] [PATCH v3 5/9] Platform/NXP: Add support for I2c driver

I2C driver produces gEfiI2cMasterProtocolGuid which can be used by other modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Drivers/I2cDxe/I2cDxe.c | 728 +

[edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

Installs watchdog timer arch protocol Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Drivers/WatchDog/WatchDog.c | 421 ++ Platform/NXP/Drivers/WatchDog/WatchDog.h | 37 +++

[edk2] [PATCH edk2-platforms] [PATCH v3 1/9] Platform/NXP: Add support for Big Endian Mmio APIs

This library add supports for BE read/write and other MMIO helper function. In this data swapped after reading from MMIO and before write using MMIO. It can be used by any module with BE address space. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal

[edk2] [PATCH edk2-platforms] [PATCH v3 4/9] Platform/NXP : Add support for DUART library

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- Platform/NXP/Library/DUartPortLib/DUart.h | 128 Platform/NXP/Library/DUartPortLib/DUartPortLib.c | 331 +

Re: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

Both patches are reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Monday, November 27, 2017 9:20 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru:

[edk2] [PATCH] MdeModulePkg/PerformanceLib: add lock protection

DXE performance gauge record access functions might be reentered since we are supporting something like USB hot-plug, which is a timer event where gBS->ConnectController might be called and then PERF will be called in CoreConnectSingleController. When StartGaugeEx is being reentered, not only the

Re: [edk2] [RFC] Add EFI lock when creating new gauge record

Thanks; will do that. Regards, Gary (Heyi Guo) 在 11/27/2017 10:06 AM, Zeng, Star 写道: I am ok with the approach. If no comment from others, I think you can post the patch for code review. Liming, do you have any comment? :) Thanks, Star -Original Message- From: Heyi Guo

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Good catch. I’ll add them. Thanks. From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Saturday, November 25, 2017 9:28 PM To: Wang, Jian J ; Yao, Jiewen ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Dong, Eric

Re: [edk2] [PATCH v2 2/8] MdeModulePkg/CpuExceptionHandlerLib.h: Add a new API

If we use union data, other arch of processors can add their own definitions in it without interfering ours. Is the MdeModulePkg for IA32 only? This data is used to reserve resources in different boot phases. Unless we can limit its uses in just UefiCpuPkg, maybe MdeModulePkg is the only

[edk2] [Patch] BaseTools: Replace ARCH with HOST_ARCH in C Makefile to avoid conflict

https://bugzilla.tianocore.org/show_bug.cgi?id=793 ARCH is too generic. It may cause confuse of target arch or host arch. To be clarified, replace it with HOST_ARCH in BaseTools C Makefile. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao

Re: [edk2] [PATCH v2] SecurityPkg/SecureBootConfigDxe: Fix deleting signature data issue.

Reviewed-by: Chao Zhang -Original Message- From: Chen, Chen A Sent: Monday, November 27, 2017 10:03 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Zhang, Chao B Subject: [PATCH v2]

Re: [edk2] [RFC] Add EFI lock when creating new gauge record

I am ok with the approach. If no comment from others, I think you can post the patch for code review. Liming, do you have any comment? :) Thanks, Star -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Saturday, November 25, 2017 5:10 PM To: Zeng, Star

[edk2] [PATCH v2] SecurityPkg/SecureBootConfigDxe: Fix deleting signature data issue.

Replace "(UINT8 *)NewVariableData" with (UINT8 *)NewVariableData + Offset" to avoid the header of EFI_SIGNATURE_LIST being copied to the front of NewVariableData every time and update ListWalker when handling the current EFI_SIGNATURE_LIST finishes. Cc: Zhang Chao

[edk2] [PATCH] SecurityPkg/SecureBootConfigDxe: Fix deleting signature data issue.

Replace "(UINT8 *)NewVariableData" with (UINT8 *)NewVariableData + Offset" to avoid the header of EFI_SIGNATURE_LIST being copied to the front of NewVariableData every time and update ListWalker when handling the current EFI_SIGNATURE_LIST finishes. Cc: Zhang Chao

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Typos in commit log? Propated -> propagated Instropecting -> introspecting Thanks, Star -Original Message- From: Julien Grall [mailto:julien.gr...@linaro.org] Sent: Saturday, November 25, 2017 12:21 AM To: Zeng, Star ; Dong, Eric ;

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes

Could you also update the description for EFI_SERIAL_SET_ATTRIBUTES in MdePkg/Include/Protocol/SerialIo.h? That could be done in a separated patch. + @retval EFI_INVALID_PARAMETER One or more attributes has an unsupported value. Thanks, Star -Original Message- From: Julien Grall

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes

Could you also update the description for EFI_SERIAL_SET_ATTRIBUTES in MdePkg/Include/Protocol/SerialIo.h? That could be done in a separated patch. Thanks, Star -Original Message- From: Julien Grall [mailto:julien.gr...@linaro.org] Sent: Saturday, November 25, 2017 12:20 AM To: Zeng,

Re: [edk2] [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Reviewed-by: Star Zeng with some minor comments in the separated patches. Thanks, Star -Original Message- From: Julien Grall [mailto:julien.gr...@linaro.org] Sent: Saturday, November 25, 2017 12:20 AM To: Zeng, Star ; Dong, Eric

[edk2] [PATCH] OvmfPkg/Sec: Fix 64bit SEC build failure

Original code breaks a single assembly code to multiple lines. But build tool doesn't support such usage in Windows OS environment. Changing the multiple lines to one line to resolve the build failure. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni

[edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

The patches caused Windows 10 S4 resume failure. Considering the similar changes are reverted from PciBus driver, revert the patches from AtaAtapiPassThru as well. Ruiyu Ni (2): MdeModulePkg/AtaAtapiPassThru: Revert patch to disable Bus Master MdeModulePkg/AtaAtapiPassThru: Revert patch to

[edk2] [PATCH 1/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable Bus Master

This patch caused Windows 10 S4 resume failure. Considering the similar changes are reverted from PciBus driver, revert the patch from AtaAtapiPassThru as well. Revert "MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()" This reverts commit

[edk2] [PATCH 2/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

This patch caused Windows 10 S4 resume failure. Considering the similar changes are reverted from PciBus driver, revert the patch from AtaAtapiPassThru as well. Revert "MdeModulePkg/AtaAtapiPassThru: disable the device at ExitBootServices()" This reverts commit

[edk2] [PATCH 3/3] ShellPkg/dp: Convert from NULL class library to Dynamic Command

UEFI Shell spec defines Shell Dynamic Command protocol which is just for the purpose to extend internal command. So dp command is changed from NULL class library to be a driver producing DynamicCommand protocol. The guideline is: 1. Only use NULL class library for Shell spec defined commands. 2.

[edk2] [PATCH 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command

UEFI Shell spec defines Shell Dynamic Command protocol which is just for the purpose to extend internal command. So tftp command is changed from NULL class library to be a driver producing DynamicCommand protocol. The guideline is: 1. Only use NULL class library for Shell spec defined commands.

[edk2] [PATCH 0/3] Convert from NULL class library to Dynamic Command

UEFI Shell spec defines Shell Dynamic Command protocol which is just for the purpose to extend internal command. So tftp and dp are changed from NULL class library to be drivers producing DynamicCommand protocol. The guideline is: 1. Only use NULL class library for Shell spec defined commands. 2.

[edk2] [PATCH 1/3] ShellPkg/ShellLib: Constructor doesn't depend on ShellParameters

When ShellLib is linked to a driver producing DynamicCommand protocol, ShellParameters protocol is set by DynamicCommand.Handler(). The driver image handle doesn't have ShellParameters protocol installed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni

Re: [edk2] [PATCH v2 1/9] Platform/NXP: Add support for Big Endian Mmio APIs

Hmm, was there a cover letter for this v2? I can only find the one from v1 in my inbox? Usually it is helpful to keep the cover letter and add comments on what has changed since the previous revision. Also, can you generate the patches with --subject-prefix="PATCH edk2-platforms" to ensure a

Re: [edk2] [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom

(Adding Laszlo to cc based on a single comment I make below.) On Tue, Nov 21, 2017 at 04:23:36PM +0530, kalyan-nagabhirava wrote: > Added required library packages related to secure boot in hikey.dsc and > Blockvariable driver[ > from 96-board edk2 fork] to support the NV storage of the

Re: [edk2] [platforms: PATCH v2 1/4] Platform/Marvell: Introduce MvFvbDxe variable support driver

On Sun, Nov 26, 2017 at 02:38:18PM +0100, Marcin Wojtas wrote: > Hi Leif, > > 2017-11-25 15:09 GMT+01:00 Leif Lindholm : > > > + // Check the Variable Store Guid > > > + if (!CompareGuid (>Signature, ) > > > && > > > + !CompareGuid (>Signature, > > > + ))

Re: [edk2] [platforms: PATCH v2 1/4] Platform/Marvell: Introduce MvFvbDxe variable support driver

Hi Leif, 2017-11-25 15:09 GMT+01:00 Leif Lindholm : > > On Tue, Nov 21, 2017 at 07:46:18AM +0100, Marcin Wojtas wrote: > > MvFvbDxe driver introduces non-volatile EFI variable support > > for Armada platforms. It relies on memory-mapped SPI read access. > >

Re: [edk2] [PATCH edk2-non-osi] Platform/Socionext: add Developer Box ARM-TF binary

On 24 November 2017 at 16:59, Leif Lindholm wrote: > On Sun, Nov 12, 2017 at 05:10:42PM +, Ard Biesheuvel wrote: >> Add a prebuilt RELEASE binary of ARM Trusted Firmware built from commit >> 42ad2cff0106358d1e29c3c96a4ebe92d08d4eba. >>

Re: [edk2] [PATCH 0/2] remove ARM BdsLib and FdtPlatformDxe

On 25 November 2017 at 13:38, Leif Lindholm wrote: > On Mon, Nov 20, 2017 at 11:45:03AM +, Ard Biesheuvel wrote: >> Remove two pieces of legacy that are only used by platforms residing under >> Platform/ARM in edk2-platforms, and really shouldn't serve as examples

Re: [edk2] [PATCH] EmbeddedPkg Omap35xxPkg: remove EBL and associated libraries

On 24 November 2017 at 17:21, Leif Lindholm wrote: > On Wed, Nov 15, 2017 at 03:45:53PM +, Ard Biesheuvel wrote: >> EBL is a deprecated, small memory footprint alternative for the >> UEFI Shell that is no longer in use by any platforms in EDK2 or >> in

Re: [edk2] [PATCH 00/19] ArmPlatformPkg: remove unused or migrated modules

On 25 November 2017 at 11:47, Leif Lindholm wrote: > On Wed, Nov 15, 2017 at 04:56:18PM +, Ard Biesheuvel wrote: >> Remove everything from ArmPlatformPkg that is either unused, or so highly >> specific to development platforms manufactured by ARM Ltd. that they

Re: [edk2] [PATCH edk2-platforms 0/4] Platform/ARM: import BdsLib and FdtPlatformDxe

On 25 November 2017 at 13:28, Leif Lindholm wrote: > On Mon, Nov 20, 2017 at 11:37:10AM +, Ard Biesheuvel wrote: >> The only remnant of the deprecated ARM BDS in EDK2 is its BdsLib, which is >> depended upon by FdtPlatformDxe in EmbeddedPkg, which itself is something

Re: [edk2] [PATCH edk2-platforms v2 00/13] Move ArmPlatformPkg stuff into edk2-platforms

On 25 November 2017 at 12:12, Leif Lindholm wrote: > On Thu, Nov 16, 2017 at 05:58:30PM +, Ard Biesheuvel wrote: >> This is mostly a preparatory series that will allow us to get rid of a lot >> of code that is specific to only a single ARM development platform out of

Re: [edk2] [PATCH edk2-platforms v5 0/6] add remaining support for Socionext SynQuacer

On 25 November 2017 at 12:23, Leif Lindholm wrote: > On Fri, Nov 17, 2017 at 07:04:17PM +, Ard Biesheuvel wrote: >> These are the remaining patches that still need review after the majority >> of the Socionext SynQuacer support patches were merged. > > All remaining

Re: [edk2] [RFC] ACPI table HID/CID allocation

Hi Andrew > Udit, > > I think it is more like you only need ACPI if you don't have a driver. Ok, then ACPI or say firmware needs to export AML methods, which are known to OS. > If it is standard bus with standard drivers the OS code can do power > management > without any help from ACPI.