Hi Yunhua,
Please separate this patch into two. And remember to update copyright year.
Best Regards,
Zhu Yonghong
-Original Message-
From: Feng, YunhuaX
Sent: Tuesday, January 09, 2018 10:14 AM
To: edk2-devel@lists.01.org
Cc: Feng, YunhuaX ; Zhu, Yonghong
; Gao, Liming
Subject: [PATC
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Bi, Dandan
Sent: Tuesday, January 9, 2018 3:25 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Gao, Liming
Subject: [patch] MdeModulePkg/VarCheckHii: Update data type for variable
"ArrayIndex"
In some case the ArrayIndex wit
In some case the ArrayIndex with UINT16 may be not large enough to
hold the multiplication result of HiiQuestion->VarOffset * 8;
So this patch update the data type to fix this potential issue.
Cc: Star Zeng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dan
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wang, Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu,
> Siyuan
> Subject: [Patch 1/2] MdeModulePkg: Fixed two issues when error occurs in
> Mtftp4Start.
>
> * This function s
Hi Star,
I agree with both the use cases.
I think only 'gDS->FreeMemorySpace' need to be updated, currently it directly
sets the 'ImageHandle = NULL' instead it should do below.
- If the memory is not in use by drivers, do the cleanup and set the
'ImageHandle = NULL'
- If the memory is in use
Hi, Jiaxin,
The patch is good to me.
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, January 9, 2018 10:56 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [Patch 0/2] IScsiDxe: Set ExitBootServiceEvent to NULL after
EBC compiler doesn't treat EFI_xxx as constant due to these macros
are UINT64 type in 64bit env and UINT32 type in 32bit env.
So it reports error when "case EFI_xxx" is used.
The patch changes to use if-else to fix EBC build failure.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-o
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, January 08, 2018 8:35 PM
> To: Meenakshi Aggarwal
> Cc: Leif Lindholm ; Kinney, Michael D
> ; edk2-devel@lists.01.org; Udit Kumar
> ; Varun Sethi
> Subject: Re: [PATCH edk2-platforms v2 1/2] S
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, January 08, 2018 8:42 PM
> To: Meenakshi Aggarwal
> Cc: Leif Lindholm ; Kinney, Michael D
> ; edk2-devel@lists.01.org; Udit Kumar
> ; Varun Sethi
> Subject: Re: [PATCH edk2-platforms v2 2/2] L
On 1/9/2018 10:56 AM, Jiaxin Wu wrote:
There are two place to close the ISCSI ExitBootServiceEvent:
One is IScsiOnExitBootService callback function.
Another is ISCSI driver stop() function.
When OS loader triggers ExitBootServiceEvent, firstly, the exit boot service
callback function will close
On 1/8/2018 7:16 PM, Meenakshi Aggarwal wrote:
Description:
Commands with 4 MB PRD length entries fail if PRD[DBC] is
set to the value according to AHCI standard spec.
Due to a logic error, 3F_h is misinterpreted by the
device as zero length.
Is the logic error mentioned here is the error i
Code forgot to initialize the optional weight between adjacent
vertices. It caused wrong MTRR result was calculated for some
memory settings.
The logic was incorrectly removed when converting from POC
code. The patch adds back the initialization.
Contributed-under: TianoCore Contribution Agreemen
*SetMemoryAttribute*() API cannot handle the setting request that
looks like <0, MAX_ADDRESS, Type>. The buggy parameter checking
logic returns Unsupported for this case.
The patch fixes the checking logic to handle such case.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
The patch only change the comments and variable name so
doesn't impact the functionality.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
Cc: Star Zeng
---
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 190 +--
1 file chang
The patch sets fix four issues.
For details, please refer to the invidual patch.
Patch 2/4 fixes the most critical bug.
Ruiyu Ni (4):
UefiCpuPkg/MtrrLib: Refine the debug messages
UefiCpuPkg/MtrrLib: Fix bug that may calculate wrong MTRR result
UefiCpuPkg/MtrrLib: Handle one setting request
MtrrSetMemoryAttributesInMtrrSettings() missed the debug messages
of memory attribute request and status. The patch moves all debug
messages from MtrrSetMemoryAttributeInMtrrSettings() to
MtrrSetMemoryAttributesInMtrrSettings() and refines the debug message
to carry more information.
Contributed-u
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Feng, YunhuaX
Sent: Tuesday, January 09, 2018 9:56 AM
To: edk2-devel@lists.01.org
Cc: Feng, YunhuaX ; Zhu, Yonghong
; Gao, Liming
Subject: [PATCH] BaseTools: Correct Target Path in CodaTargetList replace P
There are two place to close the ISCSI ExitBootServiceEvent:
One is IScsiOnExitBootService callback function.
Another is ISCSI driver stop() function.
When OS loader triggers ExitBootServiceEvent, firstly, the exit boot service
callback function will close and free the ExitBootServiceEvent, then s
There are two place to close the ISCSI ExitBootServiceEvent:
One is IScsiOnExitBootService callback function.
Another is ISCSI driver stop() function.
When OS loader triggers ExitBootServiceEvent, firstly, the exit boot service
callback function will close and free the ExitBootServiceEvent, then s
There are two place to close the ISCSI ExitBootServiceEvent:
One is IScsiOnExitBootService callback function.
Another is ISCSI driver stop() function.
When OS loader triggers ExitBootServiceEvent, firstly, the exit boot service
callback function will close and free the ExitBootServiceEvent, then s
Done.
-Chema
On Mon, Jan 8, 2018 at 5:42 PM, Gao, Liming wrote:
> Chema:
> Sorry for late response. I think the change is good. For windows and gcc,
> how about use the same error message for the unknown or unsupported arch?
>
> +else
> +$(error Bad HOST_ARCH)
> endif
>
> +!ELSE
> +!ERROR "U
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [edk2] [Patch 2/2] MdeModulePkg
Chema:
Sorry for late response. I think the change is good. For windows and gcc, how
about use the same error message for the unknown or unsupported arch?
+else
+$(error Bad HOST_ARCH)
endif
+!ELSE
+!ERROR "Unknown HOST_ARCH variable"
!ENDIF
Thanks
Liming
>-Original Message-
>From: c
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [edk2] [Patch 2/2] MdeModulePkg: F
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang Fan
> Sent: Tuesday, January 9, 2018 9:19 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [edk2] [Patch 1/2] MdeModulePkg: F
* In function Mtftp4WrqSendBlock(), when packet is not needed, function
returns EFI_ABORTED but not freed the packet buffer. It results some
memory leak and this patch is to fix this issue.
Cc: Jiaxin Wu
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0
Signe
See descriptions in each patch.
Wang Fan (2):
MdeModulePkg: Fixed two issues when error occurs in Mtftp4Start.
MdeModulePkg: Freed packet buffer when error occurs to avoid memory
leak.
.../Universal/Network/Mtftp4Dxe/Mtftp4Impl.c | 20
MdeModulePkg/Universal/
* This function sets returned status as token status and signal token
when error occurs, and it results token status not compliance with
spec definition. This patch fixed this issue.
* This function restore Tpl twice when Mtftp4WrqStart() returns an
error, this patch fixed this issue.
Cc: Ji
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, January 2, 2018 11:34 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Kinney,
> Michael D ; Wu, Jiaxin
> Subject: [Patch] NetworkPkg/HttpDxe: Fix build warning error if CHAR8 is
> unsigned.
>
On 01/08/18 22:06, Carsey, Jaben wrote:
> Agree that the internal use is questionable.
>
> Reviewed-by: Jaben Carsey
>
>> -Original Message-
>> From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
>> Sent: Monday, January 08, 2018 10:07 AM
>> To: Laszlo Ersek ; edk2-devel-01 > de...@lists
Agree that the internal use is questionable.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
> Sent: Monday, January 08, 2018 10:07 AM
> To: Laszlo Ersek ; edk2-devel-01 de...@lists.01.org>
> Cc: Carsey, Jaben ; Gao, Liming
> ; Rebecc
Hi Laszlo,
On 01/05/2018 05:38 AM, Laszlo Ersek wrote:
Hi Brijesh,
(Adding Ray, based on Jian's and Ray's feedback in another branch of
this thread.)
This time I prefer to write a shorter email:
(1) First of all, congrats on your family :)
Thank you :)
(2) Please file a new TianoCore BZ:
On 12 December 2017 at 10:56, Wu, Hao A wrote:
> Hi Ard,
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
>> Biesheuvel
>> Sent: Tuesday, December 12, 2017 3:00 PM
>> To: edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuv
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: 23 December 2017 16:07
> To: Evan Lloyd
> Cc: edk2-devel@lists.01.org; Arvind Chauhan ;
> Daniil Egranov ; Thomas Abraham
> ; "ard.biesheu...@linaro.org"@arm.com;
> "leif.lindh...@linaro.org"@arm.com;
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: 03 January 2018 16:56
> To: Evan Lloyd ; edk2-devel@lists.01.org
> Cc: "ard.biesheu...@linaro.org"@arm.com;
> "leif.lindh...@linaro.org"@arm.com;
> "matteo.carl...@arm.com"@arm.com; "ler...@redhat.com"@arm.com;
>
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: 03 January 2018 17:08
> To: Evan Lloyd ; edk2-devel@lists.01.org
> Cc: "ard.biesheu...@linaro.org"@arm.com;
> "leif.lindh...@linaro.org"@arm.com;
> "matteo.carl...@arm.com"@arm.com; "ler...@redhat.com"@arm.com;
>
Reviewed by thomas.pal...@hpe.com
Regards,
Thomas Palmer
"I have only made this letter longer because I have not had the time to make it
shorter" - Blaise Pascal
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, January 6, 2018 2:04 PM
To: edk2-devel-01
On 8 January 2018 at 15:55, Meenakshi Aggarwal
wrote:
> Enable support of SATA drives on ls1046 board.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal
> ---
> Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc | 8
> Platform/NX
Hi Meenakshi,
This is looking much better - thanks for rewriting it. I do have some
comments below
On 8 January 2018 at 15:55, Meenakshi Aggarwal
wrote:
> This patch adds support of SATA controller, which
> Initialize SATA controller,
> apply platform specific errata and
> Register itself as Non
There are two cases here.
Case 1:
1. gDS->AddMemorySpace
The memory range is automatically allocated for use by the UEFI memory
services.
2. No any driver allocates memory at this memory range by
gBS->AllocatePages()/AllocatePool().
3. gDS->FreeMemorySpace
4. gDS->RemoveMemorySpace
Case 2:
1
Hello,
We are currently attempting to find an 'OS-independent' way of applying
some updated microcode early during the efi boot sequence (note we
cannot flash the motherboard firmware directly since we have not yet
been provided with the latest constructor firmwares)
Would it somehow be poss
Hi Star,
I agree with you that 'gDS->AddMemorySpace' should always pass, but if these
functions are made to
return the Status, we should ideally check the Status and take necessary
actions upon failure.
After going through the code, if a memory space for
EfiGcdMemoryTypeSystemMemory (or EfiGc
Reviewed-by: Liming Gao
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, January 8, 2018 6:03 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [PATCH] MdePkg/PciExpressLib.h: Add missing include of PciExpress21.h
>
> PCI_ECAM_ADDRESS() macro is defined in PciExpress21
On 01/08/18 06:39, Jian J Wang wrote:
>> v3 changes:
>> a. Split the patch into two patch files.
>> b. Pass MpServiceProtocol test cases in PI SCT.
>
>> v2 changes:
>> a. Use each AP's ApTopOfStack to get the stack base address instead of
>>cpu0's ApTopOfStack which is actually set incorrectly
Hi,
We will set PCD value to 0 to support our board and its default value is set to
maximum data length.
If someone change its value to any other value in their package, then he/she
must be aware of the consequences.
I cannot say how controller will react if value is other than 0x3f_ and 0
Add support of DWC3 controller driver which
Performs DWC3 controller initialization and
Register itself as NonDiscoverableMmioDevice
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal
---
Platform/NXP/Drivers/UsbHcdInitDxe/UsbHcd.c | 213 +
Enable support of USB drives on ls2088 board.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal
---
Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 1 +
Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf | 13 +
2 files changed, 14 insertions(+)
dif
Following set of patches add DWC3 (USB) controller driver
and enable USB support on LS2088RDB board.
DWC3 controller driver register USB as NonDiscoverableMmioDevice
of NonDiscoverableDeviceTypeXhci.
Meenakshi Aggarwal (2):
USB : Add DWC3 USB controller initialization driver.
LS2088 : Enable
How will the code work based on your patch if the this PCD is configured to
other value, for example 0x20/0x30?
Thanks,
Star
-Original Message-
From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com]
Sent: Monday, January 8, 2018 5:54 PM
To: Zeng, Star ; ard.biesheu...@lina
Enable support of SATA drives on ls1046 board.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal
---
Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc | 8
Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf | 12
This patch adds support of SATA controller, which
Initialize SATA controller,
apply platform specific errata and
Register itself as NonDiscoverableMmioDevice
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal
---
Platform/NXP/Drivers/SataInitDxe/SataInit.c
V2:
1. Pci Emulation layer removed.
2. Made SATA driver as NonDiscoverablePciDevice.
3. Add support of SATA on LS1046RDB board.
Meenakshi Aggarwal (2):
SATA : Added SATA controller driver.
LS1046 : Enable support of SATA controller
Platform/NXP/Drivers/SataInitDxe/SataInit.c| 285 ++
PCI_ECAM_ADDRESS() macro is defined in PciExpress21.h so
always include PciExpress21.h in the library header file.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Liming Gao
---
MdePkg/Include/Library/PciExpressLib.h | 4 +++-
1 file changed, 3 insertions(+),
> -Original Message-
> From: Zeng, Star [mailto:star.z...@intel.com]
> Sent: Monday, January 08, 2018 3:18 PM
> To: Meenakshi Aggarwal ;
> ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2-
> de...@lists.01.org; Dong, Eric
> Cc: Ni, Ruiyu ; Zeng, Star
> Subject: RE: [edk2] [RFC]
So this PCD needs to be defined as 0x3F or may be 0x40, then it needs
to be configured to 0 for your case, right?
Could the PCD be configured to other values?
According to the statement you provided, is it possible to handle the case in
the device firmware?
" Due to a logic error, 3F_FF
55 matches
Mail list logo
