[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add Memory test code.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../PlatformBootManagerLib/PlatformBootManager.c | 23 +- .../PlatformBootManagerLib.inf | 1 + 2 files changed, 23 insertions(+), 1 deletion(-) diff

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

Just thought more about the case. If a memory range has WB attribute, and code is to set RUNTIME attribute, then the WB attribute will be clear in GCD database, it seems wrong. :( For this case, need have OR operation ( | RUNTIME) to original attribute in GCD database? Thanks, Star

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

That is good idea. Just add more description as the code comment, please. It is easy for code review later. Thank you Yao Jiewen > -Original Message- > From: Zeng, Star > Sent: Tuesday, April 3, 2018 10:33 AM > To: Yao, Jiewen ; Wang, Jian J

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

Agree. And I agree we need the fix at https://lists.01.org/pipermail/edk2-devel/2018-April/023364.html from Mike for compatibility. And I think more precious and precise information need to be added into the commit log or code comments since we have been crazy about handling attributes in the

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

I have a discussion with Star/Jian. The expectation for the CPU driver is to handle PageAttribute. The expectation for the platform driver is to use GetAttribute(), AND/OR attribute, then call SetAttribute(). Because the DRAM always has a cache attribute (no matter UC or WB), 0 should not

Re: [edk2] [PATCH 0/2] Refine some comments about SmmMemoryAttribute

For this series: Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Tuesday, April 03, 2018 9:52 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Yao, Jiewen

[edk2] [PATCH 1/2] MdeModulePkg SmmMemoryAttribute.h: Refine some comments

1. Fix some "support" to "supported". 2. Fix some "set" to "clear" in ClearMemoryAttributes interface. 3. Remove redundant comments for GetMemoryAttributes interface. Cc: Jian J Wang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH 0/2] Refine some comments about SmmMemoryAttribute

1. Fix some "support" to "supported". 2. Fix some "set" to "clear" in ClearMemoryAttributes interface. 3. Remove redundant comments for GetMemoryAttributes interface. Cc: Jian J Wang Cc: Jiewen Yao Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [PATCH 2/2] UefiCpuPkg PiSmmCpuDxeSmm: Refine some comments about SmmMemoryAttribute

1. Fix some "support" to "supported". 2. Fix some "set" to "clear" in ClearMemoryAttributes interface. 3. Remove redundant comments for GetMemoryAttributes interface. Cc: Jian J Wang Cc: Jiewen Yao Cc: Eric Dong Cc: Laszlo Ersek

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

The NX Memory Protection and Heap Guard features need to clear paging attributes. Allowing 0 attribute is the current only choice without changing arch protocol. Maybe It's time to introduce a new protocol. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Tuesday, April

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

Current gCpu->SetMemoryAttributes does not support getting memory attributes, and has no clear description about clearing memory attributes. I noticed we introduced SmmMemoryAttribute(MdeModulePkg\Include\Protocol\SmmMemoryAttribute.h) protocol for heap guard feature in SMM environment.

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

Mike, Agree the problem. We need support only RUNTIME attribute. We need support only cache attributes. We need support only page attributes. We need support RUNTIME + cache + page attributes. Do we need support the 0 Attributes case to clear page attributes? There was discussion about the 0

[edk2] [Patch] ShellPkg/dblk: Avoid overwriting Media->IoAlign

According to the UEFI Specification, data values in EFI_BLOCK_IO_MEDIA are read-only. This patch introduces a local variable to avoid overwriting IoAlign and reduces unnecessary overallocation. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under:

[edk2] [Patch] MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls

This patch fixes an issue with VlvTbltDevicePkg introduced by commit: https://github.com/tianocore/edk2/commit/5b91bf82c67b586b9588cbe4bbffa1588f6b5926 This patch filters the call to gCpu->SetMemoryAttributes() if the requested attributes is 0. It also removes the #define

[edk2] OVMF UsbBulkTransfer returns EFI_OUT_OF_RESOURCES

Hello, I can pass a host USB device to QEMU boot with OVMF, and it shows up as a EFI_USB_IO_PROTOCOL device and the interface descriptors and endpoints are detected correctly. A UsbControlTransfer operation succeeds. However, UsbBulkTransfer returns EFI_OUT_OF_RESOURCES regardless of how

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

Star, This commit breaks Vlv2TbltDevicePkg. On this platform, there are 2 calls to gDS->SetMemorySpaceAttributes() for an MMIO range to set only the EFI_MEMORY_RUNTIME bit. With this commit, ConverToCpuArchAttributes()returns 0, and 0 is passed to gCpu->SetMemoryAttributes()that returns

Re: [edk2] [Patch] Build Spec: update chapter 2.7's format

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, April 02, 2018 4:47 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [Patch] Build spec: Add some clarification and clean up for build report

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, April 02, 2018 11:30 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

[edk2] [Patch] Build Spec: update chapter 2.7's format

This patch update chapter 2.7's format since we found the PDF of this section is ugly. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong

Re: [edk2] OVMF package : Question about Qemu/Xen support

Hi, Laszlo: I have a question you would like to ask you. Could I study pcie native hot plug feature with ovmf? It seems qemu emulates Q35 chipset. And ovmf provides PciHotPlugInitDxe driver. Thanks Best wishes, -邮件原件- 发件人: Laszlo Ersek [mailto:ler...@redhat.com] 发送时间: 2018年3月5日 17:15