Reviewed-by: Liming Gao
Because some platform has been broken, I will push this patch soon.
> -Original Message-
> From: Feng, YunhuaX
> Sent: Friday, October 26, 2018 2:08 PM
> To: edk2-devel@lists.01.org
> Cc: Zhu, Yonghong ; Gao, Liming
> Subject: [PATCH 1/1] BaseTools: Roll back co
Roll back code modify by commit 9e47e6f90880,
if ForceRebase not False or True, the GenFv command not need add parameter
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py
V2:
Add the missing "gBS->FreePool (Data);".
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new EhciInsertAsyncIntTransfer function from
EhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, EhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
EhcMonitorAsyncRequests
EhcFlushAsyncIntM
V2: Thanks for Ray's feedback.
Add the missing "FreePool (Data);".
Remove the unnecessary indentation change.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Please refer to the log message of each commit for more details.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J Wang
Cc: Jiewen Yao
Star
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, XhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
XhcMonitorAsyncRequests
XhcFlushAsyncIntM
V2:
Add the missing "FreePool (Data);".
Remove the unnecessary indentation change.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, EhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
E
Series Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, October 25, 2018 4:56 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [Patch 0/2] Mtftp: Correct the total received and saved block number.
The block returned from Mtftp4Rem
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, XhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
X
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
Sent: Friday, October 26, 2018 12:54 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zeng, Star
Subject: [edk2] [PATCH] MdeModulePkg/Core: fix an IA32 build failure
REF: https://bugzill
On 2018/10/26 12:57, Ni, Ruiyu wrote:
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc
BaseTools collects PCD information in early phase in order to prepare
StrucutrePcd value. At this point, it doesn't know whether the library inf is
used or not. So, it checks PCD from all INF files listed in DSC/FDF. This is a
behavior change. I don't realize that the unused library INF SmmLockB
On 2018/10/26 12:57, Ni, Ruiyu wrote:
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new EhciInsertAsyncIntTransfer function from
EhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J Wang
On 10/25/2018 6:58 PM, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1277
The failure is caused by data type conversion between UINTN and UINT64,
which is checked in at 63ebde8ef6d4ff497d054ccc010904ecd4441198.
Cc: Star Zeng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: J
Liming,
I saw MdeModulePkg only builds
MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf at EBC
arch.
You mean even the *unused* library INF files will be considered? Why? Sorry I
am still confused.
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Friday,
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, October 25, 2018 2:50 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Support combo CPU
> feature style.
>
> Current code assume only one
Star:
This option is not the default option. To pass GCC build, GCC tool chain adds
it. XCODE tool chain doesn't require it, it is not listed for XCODE.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng,
> Star
> Sent: Fri
Star:
Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect
PCD information from all INF files list in DSC/FDF. But before, only the used
library INF files are considered. This change is to decide which PCD is really
used, then generate the structure PCD value in the earl
On 2018/10/26 9:57, Liming Gao wrote:
SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is
defined in MdeModulePkg.dec for IA32 and X64 only.
Could we explain more in the commit log about why this change is not
needed before but required now?
Thanks,
Star
Contributed
On 2018/10/26 10:33, Liming Gao wrote:
This patch makes RegularExpressionDxe pass XCODE5 build.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Star Zeng
---
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4
1 file changed,
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 26, 2018 11:19 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Desimone, Nathaniel L
> ; Chiu, Chasel
> Subject: [PATCH] IntelFsp2Pkg: Fix GCC49/XCODE build failure
>
> REF: https://b
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1276
Fixed potentially uninitialized variable build failure
caused by commit: b1cc6f672f3b924cdb190e5b92db3b47f46a8911
Test: Verified on internal platform and boots successfully.
Cc: Jiewen Yao
Cc: Desimone Nathaniel L
Contributed-under: Tian
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Feng, YunhuaX
Sent: Thursday, October 25, 2018 2:00 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: Use VENDOR_DEVICE_PATH structure for Debug Port
device pat
Reviewed-by: Star Zeng
As I know, you did Recovery test with USB disk for these patches.
I think you can add the test information into the commit message of patches.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Thu
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Feng, YunhuaX
Sent: Thursday, October 25, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming
Subject: [PATCH 1/1] BaseTools: Fix BPDG tool print traceback info issue
Fix BPDG tool pri
This patch makes RegularExpressionDxe pass XCODE5 build.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Star Zeng
---
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4
1 file changed, 4 insertions(+)
diff --git
a/MdeModulePkg
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Friday, October 12, 2018 7:26 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Dong, Eric
> Subject: [patch 0/2] MdeModulePkg/HiiDatabaseDxe: Make sure database update
> behaviors are atomic
>
> The main purpos
SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is
defined in MdeModulePkg.dec for IA32 and X64 only.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Cc: Star Zeng
---
MdeModulePkg/MdeModulePkg.dsc | 2 ++
1 file changed, 2 insertions(+
Reviewed-by: Bob Feng
-Original Message-
From: Zhao, ZhiqiangX
Sent: Wednesday, October 24, 2018 9:01 PM
To: edk2-devel@lists.01.org
Cc: Zhao, ZhiqiangX ; Gao, Liming
; Zhu, Yonghong ; Feng, Bob C
Subject: [PATCH] BaseTools:Not miss the full assign value of FixedAtBuild
structure PCD
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Dong, Eric
> Sent: Friday, October 26, 2018 9:15 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [Patch] SecurityPkg/Include/Library/TcgStorageOpalLib.h: Update
> Pyrite spec revision.
>
> Pyrite 2.0 spec
Sure. Thanks.
Regards,
Jian
> -Original Message-
> From: Zeng, Star
> Sent: Friday, October 26, 2018 9:19 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Ni, Ruiyu
> ; Yao, Jiewen ; Laszlo Ersek
> ; Zeng, Star
> Subject: Re: [edk2] [PATCH v4 6/6] MdeModulePkg/C
Sorry missing that one. I'll update it. Thanks for the comments.
Regards,
Jian
> -Original Message-
> From: Zeng, Star
> Sent: Friday, October 26, 2018 9:18 AM
> To: Wang, Jian J ; edk2-devel boun...@lists.01.org>; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Ni, Ruiyu
> ; Yao, Jie
On 2018/10/25 15:18, Jian J Wang wrote:
v4 changes:
a. replace hard-coded memory attributes with the value got from
CoreGetMemorySpaceDescriptor()
b. remove the enclosure of CoreAcquireGcdMemoryLock() and
CoreReleaseGcdMemoryLock() around CoreAddRange()
Freed-memory guard is used to det
On 2018/10/25 15:20, Wang, Jian J wrote:
Sorry, forgot to update commit message:
This issue is hidden in current code but exposed by introduction
of freed-memory guard feature due to the fact that the feature
will turn all pool allocation to page allocation.
The solution is moving the memory a
On 2018/10/25 15:17, Jian J Wang wrote:
v4 changes:
Updated per comments from Star. Please refer to individual patch
file for details (#2/5/6)
Minor comments to patch 5 and 6, please see the individual feedback.
With them addressed, Reviewed-by: Star Zeng to
patch 1, 2, 5 and 6.
And remembe
Pyrite 2.0 spec has been published, update the spec link info for this file.
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
SecurityPkg/Include/Library/TcgStorageOpalLib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Se
Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Long Qin
Sent: Wednesday, October 24, 2018 9:22 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting
Subject: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer overflow
issu
Reviewed-by: Eric Dong
> -Original Message-
> From: Wang, Jian J
> Sent: Thursday, October 25, 2018 3:18 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Laszlo Ersek ;
> Zeng, Star ; Kinney, Michael D
> ; Yao, Jiewen ; Ni,
> Ruiyu
> Subject: [PATCH v4 4/6] UefiCpuPkg/CpuDxe: prevent
Reviewed-by: Eric Dong
> -Original Message-
> From: Wang, Jian J
> Sent: Thursday, October 25, 2018 3:18 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Laszlo Ersek ;
> Zeng, Star ; Kinney, Michael D
> ; Yao, Jiewen ; Ni,
> Ruiyu
> Subject: [PATCH v4 3/6] UefiCpuPkg/CpuDxe: consider
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, October 25, 2018 8:05 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch 1/2 V2] BaseTools: Add $(INC)-like su
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1275
The LookupFreeMemRegion() in RuntimeMemAllocate.c is used to look-up
free memory region for runtime resource allocation, which was designed
to support runtime authenticated variable service.
The ReqPages in this function is the required page
From: zhijufan
Update the build rule to:
"$(NASM)" -I${s_path}(+) $(NASM_INC)(+) $(NASM_FLAGS)
-o $dst ${d_path}(+)${s_base}.iii
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Conf/build_rule.template | 2 +-
1 f
V2:
1. remove FileMacro variable
2. Make sure the NASM_INC file path have '\' in the end
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1085
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
zhijufan (2):
BaseTools: Add $
From: zhijufan
current edk2\BaseTools\Conf\build_rule.template, the compile of nasm
source files does not have the $(INC) support.
The '-I' option only includes the directory of the nasm source file
(${s_path}(+)). Hence, it will be impossible for nasm files to include
files outside of the nasm
Yes, I agree. I will help to update a V2.
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Thursday, October 25, 2018 10:20 PM
To: Zhu, Yonghong ; edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: RE: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when
co
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, October 25, 2018 12:38 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch 1/2] BaseTools: Add $(INC)-like support when
> compiling .nas
Reviewed-by: Bob Feng
-Original Message-
From: Carsey, Jaben
Sent: Wednesday, October 24, 2018 1:29 AM
To: edk2-devel@lists.01.org
Cc: Feng, Bob C ; Zhu, Yonghong ;
Gao, Liming
Subject: [Patch v3 6/6] BaseTools/GenFds: create and use new variable in
FdfParser
replace lots of '}' and
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Thursday, October 25, 2018 8:42 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Shaw, Kevin W ;
> Cohen; Eugene
> Subject: [Patch] FDF spec: Add PI1.5 standalone SMM support in FDF file
Thanks, Laszlo.
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 25, 2018 12:59 AM
To: Long, Qin ; edk2-devel@lists.01.org
Cc: Ye, Ting
Subject: Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Fix potential integer
overflow issue.
On 10/24/18 15:22, Long Qin wrote:
> The LookupF
On Thursday, October 25, 2018 12:48 AM ruiyu...@intel.com wrote:
>On 10/25/2018 12:35 AM, jim.dai...@dell.com wrote:
>> Add a function to return the fully-qualified version of some path.
>>
>> ...
>> +CHAR16*
>> +EFIAPI
>> +FullyQualifyPath(
>> + IN OUTCHAR16 **Path
>This API assumes *Pa
Hi Hao,
Were you able to find time for evaluating my patchset?
Best regards,
Marcin
pt., 12 paź 2018 o 14:50 Marcin Wojtas napisał(a):
>
> pt., 12 paź 2018 o 14:48 Wu, Hao A napisał(a):
> >
> > > -Original Message-
> > > From: Marcin Wojtas [mailto:m...@semihalf.com]
> > > Sent: Friday,
V2: Update it to MM_CORE_STANDALONE and MM_STANDALONE
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=551
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Cc: Cohen, Eugene
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
1_introduction/12_terms
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tomas
Pilar (tpilar)
Sent: Wednesday, October 24, 2018 7:43 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2] BaseTools: Allow multipl
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben
Carsey
Sent: Wednesday, October 24, 2018 1:29 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch v3 0/6] BaseTools/GenFds: cleanup Ge
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, EhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
EhcMonitorAsyncRequests
EhcFlushAsyncIntM
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new XhciInsertAsyncIntTransfer function from
XhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J Wang
Cc: Jiewen Yao
Contributed-under: Tiano
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Please refer to the log message of each commit for more details.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J Wang
Cc: Jiewen Yao
Star Zeng (4):
MdeModulePkg XhciDxe: Extract new XhciInsertAsyncIntTransfer function
MdeModulePkg EhciDxe: Extr
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
In current code, XhcMonitorAsyncRequests (timer handler) will do
unmap and map operations for AsyncIntTransfers to "Flush data from
PCI controller specific address to mapped system memory address".
XhcMonitorAsyncRequests
XhcFlushAsyncIntM
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1274
Extract new EhciInsertAsyncIntTransfer function from
EhcAsyncInterruptTransfer.
It is code preparation for following patch,
no essential functional change.
Cc: Ruiyu Ni
Cc: Hao Wu
Cc: Jian J Wang
Cc: Jiewen Yao
Contributed-under: Tiano
The patches sync the similar fixes to UsbBusDxe to UsbBusPei.
Ruiyu Ni (2):
MdeModulePkg/UsbBusPei: Fix out-of-bound read access to descriptors
MdeModulePkg/UsbBusPei: Reject descriptor whose length is bad
MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c | 93 +++-
MdeMod
Today's implementation reads the Type/Length field in the USB
descriptors data without checking whether the offset to read is
beyond the data boundary.
The patch fixes this issue by syncing the fix in commit
4c034bf62cbc1f3c5f4b5df25de97f0f528132b2
*MdeModulePkg/UsbBus: Fix out-of-bound read acces
Today's implementation doesn't check whether the length of
descriptor is valid before using it.
The patch fixes this issue by syncing the similar fix to UsbBusDxe.
70c3c2370a2aefe71cf0f6c1a1e063f7d74e1d79
*MdeModulePkg/UsbBus: Reject descriptor whose length is bad
Additionally the patch also reje
The block returned from Mtftp4RemoveBlockNum is not the total received and
saved block number if it works in passive (Slave) mode.
The issue was exposed by the EMS test.
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
---
.../Universa
The block returned from Mtftp6RemoveBlockNum is not the total received and
saved block number if it works in passive (Slave) mode.
The issue was exposed by the EMS test.
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
---
NetworkPkg/M
The block returned from Mtftp4RemoveBlockNum is not the total received and
saved block number if it works in passive (Slave) mode.
The issue was exposed by the EMS test.
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Jiaxin Wu (2):
From: zhijufan
Update the build rule to:
"$(NASM)" -I${s_path}(+) $(NASM_INC)(+) $(NASM_FLAGS)
-o $dst ${d_path}(+)${s_base}.iii
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Conf/build_rule.template | 2 +-
1 f
From: zhijufan
current edk2\BaseTools\Conf\build_rule.template, the compile of nasm
source files does not have the $(INC) support.
The '-I' option only includes the directory of the nasm source file
(${s_path}(+)). Hence, it will be impossible for nasm files to include
files outside of the nasm
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1085
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
zhijufan (2):
BaseTools: Add $(INC)-like support when compiling .nasm files
BaseTools: Update nasm file build rule to s
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, October 23, 2018 5:34 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Desimone, Nathaniel L
> ; Chiu, Chasel
> Subject: [PATCH v2] IntelFsp2Pkg: FSP should not override IDT
>
> REF: https://
Patch to update the memory attributes of the region where StandaloneMM
drivers are loaded. Based on the review comments from Ard, this code
has now been moved under StandaloneMmPkg directory.
This patch needs to be applied on top of the following patch series -
"ArmPkg related changes for Standalo
The StandaloneMM image executes in S-EL0 on reference Arm platforms
and is deployed by the trusted firmware as BL32 image. Memory for the
Standalone MM drivers is marked as RW+XN initially, allowing the
drivers to be loaded into the memory. Once loaded, the memory
attributes need to be changed to R
From: Achin Gupta
The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard
Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its
architectural context including the initial translation tables for the
S-EL1/EL0 translation regime. The MM environment will still request
From: Achin Gupta
This patch adds the definitions, sources, packages and library classes
needed to compile and link MMU Library suitable for use in S-EL0.
Currently, this is used only during the Standalone MM Core
initialization and hence defined as MM_CORE_STANDALONE Module.
Contributed-under:
From: Achin Gupta
PI v1.5 Specification Volume 4 defines Management Mode Core Interface
and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a
means of communicating between drivers outside of MM and MMI
handlers inside of MM.
This patch implements the EFI_MM_COMMUNICATION_PROTOCOL
From: Achin Gupta
This patch adds the Management Mode(MM) - Secure Partition
Manager(SPM) SVC return codes.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sughosh Ganu
---
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 7 +++
1 file changed, 7 insertions(+)
diff --gi
From: Achin Gupta
This patch defines PCDs to describe the base address and size of
communication buffer between normal world (uefi) and standalone MM
environment in the secure world.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sughosh Ganu
---
ArmPkg/ArmPkg.dec | 3 +
The MM_VERSION SMC call uses SMC32 calling convention. Fix the macro
to reflect the correct value.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sughosh Ganu
---
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The following patch series adds support for Management Mode related
changes for aarch64 based platforms.
Changes since v2:
Based on review comments from Ard, moved the memory attribute updation
changes out of DebugPeCoffExtraActionLib into an extra action library
added in StandaloneMM package. The
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Monday, October 22, 2018 3:49 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Shaw, Kevin W
> ; Gao, Liming
> Subject: [edk2] [Patch]
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Tuesday, October 23, 2018 7:10 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Fix VPD PCD Sub-section display bug
>
> origi
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Wednesday, October 24, 2018 3:38 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: list .nasm include inc fi
Sorry, forgot to update commit message:
> This issue is hidden in current code but exposed by introduction
> of freed-memory guard feature due to the fact that the feature
> will turn all pool allocation to page allocation.
>
> The solution is moving the memory allocation in CoreGetMemorySpaceMap
> v4 changes:
> a. add more comments from Laszlo
This issue is hidden in current code but exposed by introduction
of freed-memory guard feature due to the fact that the feature
will turn all pool allocation to page allocation.
The solution is move the memory allocation in CoreGetMemorySpaceMap()
> v4 changes: none
The freed-memory guard feature will cause an recursive calling
of InitializePageTablePool(). This is due to a fact that
AllocateAlignedPages() is used to allocate page table pool memory.
This function will most likely call gBS->FreePages to free unaligned
pages and then cause an
> v4 changes:
> a. replace hard-coded memory attributes with the value got from
>CoreGetMemorySpaceDescriptor()
> b. remove the enclosure of CoreAcquireGcdMemoryLock() and
>CoreReleaseGcdMemoryLock() around CoreAddRange()
Freed-memory guard is used to detect UAF (Use-After-Free) memory iss
> v4 changes: none
Non-stop mode was introduced / explained in commit 8f2613628acf
("MdeModulePkg/MdeModulePkg.dec: add new settings for PCDs",
2018-08-30).
The macro HEAP_GUARD_NONSTOP_MODE was added to CpuDxe in commit
dcc026217fdc ("UefiCpuPkg/CpuDxe: implement non-stop mode for uefi",
2018-08
> v4 changes:
> a. refine PCD description of PcdHeapGuardPropertyMask
UAF (Use-After-Free) memory issue is kind of illegal access to memory
which has been freed. It can be detected by a new freed-memory guard
enforced onto freed memory.
BIT4 of following PCD is used to enable the freed-memory gua
> v4 changes: none
This cleanup is meant for avoiding misuse of newly introduced BIT4
(UAF detection) of PCD PcdHeapGuardPropertyMask, because it applies
to all types of physical memory. In another words,
PcdHeapGuardPoolType and PcdHeapGuardPageType don't have effect to
the BIT4 of PcdHeapGuardPr
> v4 changes:
> Updated per comments from Star. Please refer to individual patch
> file for details (#2/5/6)
Freed-memory guard is a new feauture used to detect UAF (Use-After-Free)
memory issue.
Tests:
a. Feature basic unit/functionality test
b. OVMF regression test
Jian J Wang (6):
MdeModule
92 matches
Mail list logo