Re: [edk2] [PATCH V2] BaseTools: Fix regression issue by b23414f6540d

Reviewed-by: Jaben Carsey > -Original Message- > From: Zhu, Yonghong > Sent: Monday, August 20, 2018 10:33 PM > To: Feng, YunhuaX ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > ; Zhu, Yonghong > Subject: RE: [PATCH V2] BaseTools: Fix regression

[edk2] [PATCH v1 1/1] BaseTools: remove unused setter functions

Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/DecBuildData.py | 17 +-- BaseTools/Source/Python/Workspace/DscBuildData.py | 17 +-- BaseTools/Source/Python/Workspace

[edk2] [PATCH v1 1/1] BaseTools: remove unused code

the if statment just has pass statement. invert if condition and just use do the else work. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/InfBuildData.py | 6 +- 1 file changed, 1

Re: [edk2] [PATCH] ShellPkg/edit: Fix heap access out-of-bounds

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, August 15, 2018 11:33 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Wang, Jian J > > Subject: [PATCH] ShellPkg/edit: Fix heap access out-of-bounds > Importance: High

Re: [edk2] [Patch V2] BaseTools: Clean up not used code in BuildClassObject

with this change. Reviewed-by: Jaben Carsey > -Original Message- > From: Zhu, Yonghong > Sent: Monday, August 13, 2018 1:12 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > > Subject: [Patch V2] BaseTools: Clean up not used code in BuildClassObject >

Re: [edk2] [PATCH 0/2] Fix two bugs regarding shell redirection

Both look good. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, August 08, 2018 8:45 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] Fix two bu

Re: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions

Reviewed-by: Jaben Carsey > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 08, 2018 10:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH] ShellPkg Shell: Remove redundant functions > Importance: High > &

Re: [edk2] [PATCH 00/26] MdeModulePkg Remove redundant functions

I have a question: How do we know that no platforms use these functions given that not all of everyone's platforms are stored in the same place? I agree with Leif on timing; I really like cleanup. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.

[edk2] [PATCH v1 1/1] BaseTools: Eot - fix variable names

1) currently a couple classes use m instead of self (including some mixed functions that should have previously failed). 2) deleted some blank lines. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python

Re: [edk2] [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive compare

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, August 07, 2018 2:14 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Jim Dailey > > Subject: [PATCH] ShellPkg/set: Fix EfiShellSetEnv to use case sensitive > compare >

Re: [edk2] [PATCH v1 0/5] Refactor AutoGen - class ModuleAutoGen

Please ignore the numbering. My error. There are only 3 parts of this series. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jaben Carsey > Sent: Friday, August 03, 2018 8:11 AM > To: edk2-devel@lists.01.org > Subject: [e

[edk2] [PATCH v1 2/5] BaseTools: AutoGen - tag a function as cachable

MakeFile generation is once per module, so mark it as such. also move the time stamp creation function inside as it's only called from one place. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python

[edk2] [PATCH v1 1/5] BaseTools: AutoGen refactor ModuleAutoGen caching

: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 1147 +--- BaseTools/Source/Python/AutoGen/GenC.py|2 +- BaseTools/Source/Python/AutoGen/GenMake.py | 12 +- BaseTools/Source/Pyt

[edk2] [PATCH v1 3/5] BaseTools: AutoGen refactor to iterate less

-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 138 ++-- 1 file changed, 66 insertions(+), 72 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 55c84fe4fbc2..7c67f40bff00 100644 --- a/BaseTools

[edk2] [PATCH v1 0/5] Refactor AutoGen - class ModuleAutoGen

. Jaben Carsey (5): BaseTools: AutoGen refactor ModuleAutoGen caching BaseTools: AutoGen - tag a function as cachable BaseTools: AutoGen refactor to iterate less BaseTools/Source/Python/AutoGen/AutoGen.py | 1852 +--- BaseTools/Source/Python/AutoGen/BuildEngine.py | 36

Re: [edk2] [PATCH v1 1/1] PatchCheck - add error message for invalid parameter

Absolutely. I should have thought to add that. "Python ScriptCheck.py t" Assuming there is no commit or file called "t". Basically just anything that is not a commit identifier nor a filename. I found it when I tried to select a commit and misspelled it. -Jaben >

[edk2] [PATCH v1 1/1] PatchCheck - add error message for invalid parameter

Currently if an invalid parameter is passed, it gives a stack trace. This changes it to an error message. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Scripts/PatchCheck.py | 9 ++--- 1 file changed, 6

Re: [edk2] [patch 2/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure

Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Sunday, July 29, 2018 7:27 PM > To: edk2-devel@lists.01.org > Cc: Alexei Fedorov ; Ni, Ruiyu > ; Carsey, Jaben > Subject: [patch 2/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 > bu

Re: [edk2] [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure

Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Sunday, July 29, 2018 7:27 PM > To: edk2-devel@lists.01.org > Cc: Alexei Fedorov ; Ni, Ruiyu > ; Carsey, Jaben > Subject: [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 > bu

Re: [edk2] [patch 3/4] ShellPkg: Remove DxeSmmPerformanceLib

Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Sunday, July 29, 2018 10:45 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > ; Gao, Liming > Subject: [patch 3/4] ShellPkg: Remove DxeSmmPerformanceL

Re: [edk2] [PATCH] BaseTools: Parse decimal format INF_VERSION incorrect

Can we change the code to allocate fewer strings? '0x' + '{0:04x}{1:04x}'.format(...) Could be just: '0x{0:04x}{1:04x}'.format(... Jaben > On Jul 25, 2018, at 5:41 PM, Zhu, Yonghong wrote: > > Reviewed-by: Yonghong Zhu > > Best Regards, > Zhu Yonghong > >

Re: [edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

Never mind most of that. I have to figure out how to configure gitk to show .dsc changes. It's all good. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Wednesday, July 25, 2018 1:47 PM > To: Alex

Re: [edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

Alexei, I did it, but I just realized it looks like it didn't make a change. Shoot. I think it was already pushed, but I am not sure. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Alexei Fedorov > Sent: Wednesday, J

Re: [edk2] Library class misname

used the library with the wrong name? What if there was a library with correct name also included? -Jaben > -Original Message- > From: Gao, Liming > Sent: Tuesday, July 24, 2018 5:45 PM > To: Carsey, Jaben ; Laszlo Ersek > ; edk2-devel-01 > Subject: RE: [edk2] [PATCH]

Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution

Laszlo, Do you think that using the incorrect name for a library instance should generate an error? I would have thought it would have... -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, J

[edk2] [PATCH v1 1/1] BaseTools: AutoGen - change class variable to funciton variable

This variable is only used in one function, make it local there. Also when iterating on the variable, use dict.items() to get value instead of re-looking up the value multiple times. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben

Re: [edk2] [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"

Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Thursday, July 19, 2018 12:08 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop" &g

Re: [edk2] [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

Reviewed-by: Jaben Carsey Adding Eric Dong also. > -Original Message- > From: AlexeiFedorov [mailto:alexei.fedo...@arm.com] > Sent: Friday, July 13, 2018 8:17 AM > To: edk2-devel@lists.01.org > Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; > matt

Re: [edk2] [PATCH v2 00/16] BaseTools: Adopt absolute import

Nice. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Friday, July 13, 2018 3:19 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH v2 00/16] Base

Re: [edk2] [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors

This patch look good, and with this the v1 looks good, but I don't see a single patch that I could apply and push. Can you send out a single patch with all the changes? -Jaben > -Original Message- > From: AlexeiFedorov [mailto:alexei.fedo...@arm.com] > Sent: Friday, July 13,

Re: [edk2] [Patch] ShellPkg/TftpDynamicCommand: Fix the potential assertion and memory leak issue.

Reviewed-by: Jaben Carsey > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, July 11, 2018 5:46 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Carsey, Jaben > Subject: RE: [Patch] ShellPkg/TftpDynamicCommand: Fix the potential > assertion

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

; ; Gao, Liming ; Carsey, > Jaben ; Yao, Jiewen ; > Kinney, Michael D ; Zhang, Chao B > > Subject: Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from > eMMC/SD/USB > Importance: High > > On 07/11/18 14:05, Laszlo Ersek wrote: > > > - The OpenF

Re: [edk2] [Patch V2] BaseTools: Fix parsing multiple nest !include issue

If you change the raw string ("!INCLUDE) to use the one defined in DataType.py (TAB_INCLUDE), then I like it. Note that you will need to lower() instead of upper() to support this change. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2

[edk2] [PATCH v1 1/1] BaseTools: AutoGen - clean up access

1) add a property so others can access needed data 2) change GenMake to use property 3) add local variable in GenMake to speed up access Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen

[edk2] [PATCH v1 1/1] BaseTools: AutoGen - move constructor out of loop

Create the 2 comparison objects once outside the loop. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH v1 1/1] BaseTools: Move variable out of Global

Move single use list from GlobalData (gTempInfs) into the file that uses it as _TempInfs Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/GlobalData.py | 7 --- BaseTools/Source/Python

Re: [edk2] [patch] ShellPkg/DP: Add more check for input parameters

Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Monday, June 25, 2018 10:13 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ruiyu ; > Carsey, Jaben > Subject: [patch] ShellPkg/DP: Add more check for input parameters > Importa

[edk2] [PATCH v1 1/1] BaseTools: AutoGen - Remove unused variables.

There are 2 variables that we populate, but never use. remove them entirely. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 10 -- 1 file changed, 10 deletions

Re: [edk2] [PATCH v3 01/20] BaseTools: Fix a typo in ini.py

Reviewed-by: Jaben Carsey Note: I am not a maintainer of BaseTools and do not push commits for it :) > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, June 20, 2018 9:43 PM > To: edk2-devel@li

[edk2] [PATCH v1 09/11] BaseTools: refactor to stop re-allocating strings

strings are immutable. allocate minimal duplication. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 30 BaseTools/Source/Python/AutoGen/GenC.py

[edk2] [PATCH v1 11/11] BaseTools: remove extra assignment

there is no use to assign back to a variable. just return the result. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/Expression.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[edk2] [PATCH v1 08/11] BaseTools: refactor to change object types

change to object types that are closer to use case. for example: when using a list as a double ended queue, use the built in object. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen

[edk2] [PATCH v1 07/11] BaseTools: refactor file opening/writing

change mode minimal needed permissions change to use with statement Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 57 - BaseTools/Source/Python

[edk2] [PATCH v1 04/11] BaseTools: remove repeated calls to startswith/endswith

As both can take a tuple, use that instead of calling repeatedly. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/GenMake.py | 2 +- BaseTools/Source/Python/AutoGen

[edk2] [PATCH v1 05/11] BaseTools: use set presence instead of series of equality

Instead of testing each equality individually, just make a set and test once. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Ecc/Configuration.py | 10 +- 1 file changed, 1 insertion(+), 9

[edk2] [PATCH v1 06/11] BaseTools: refactor section generation

use with for opening files remove unneeded variables dont seek to 0 for just opened file Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/DataType.py | 1 + BaseTools/Source

[edk2] [PATCH v2 00/11] BaseTools Refactoring

performing operation since strings are immutable and must be completely reallocated and moved for each concatenation. v2: Update for concerns sent by Yonghong. Jaben Carsey (11): BaseTools: decorate base classes to prevent instantiation BaseTools: Workspace - create a base class BaseTools

[edk2] [PATCH v1 01/11] BaseTools: decorate base classes to prevent instantiation

use python's ABC (abstract base class) to raise type errors if we instantiate classes we designed to be used only as base classes for other classes. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python

[edk2] [PATCH v1 02/11] BaseTools: Workspace - create a base class

refactor 3 classes and create a new base class for their shared functions. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Workspace/BuildClassObject.py | 140 +++- 1 file changed

[edk2] [PATCH v1 03/11] BaseTools: remove unused code

delete commented out code delete never used class/variable/function/import refactor to remove Ffs class dont construct class just for class attribute Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python

Re: [edk2] [PATCH] ShellPkg/comp: return NOT_EQUAL when compared files are different

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, June 13, 2018 10:55 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [edk2] [PATCH] ShellPkg/comp:

Re: [edk2] [PATCH 01/37] AppPkg: Removing ipf which is no longer supported from edk2.

> -Original Message- > From: Chen, Chen A > Sent: Tuesday, June 12, 2018 8:43 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > ; Kinney, Michael D > > Subject: [PATCH 01/37] AppPkg: Removing ipf which is no longer supported > fr

Re: [edk2] [PATCH 11/37] EdkShellBinPkg: Removing ipf which is no longer supported from edk2.

oving rules for Dsc file: > * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC. > * Remove any IPF specific sections. > * Remove statements from [BuildOptions] that provide IPF specific flags. > > Cc: Ruiyu Ni > Cc: Michael D Kinney > Signed-off-by:

Re: [edk2] [PATCH 12/37] EdkShellPkg: Removing ipf which is no longer supported from edk2.

oving rules for Dsc file: > * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC. > * Remove any IPF specific sections. > * Remove statements from [BuildOptions] that provide IPF specific flags. > > Cc: Ruiyu Ni > Cc: Michael D Kinney > Signed-off-b

Re: [edk2] [PATCH 31/37] ShellPkg: Removing ipf which is no longer supported from edk2.

> -Original Message- > From: Chen, Chen A > Sent: Tuesday, June 12, 2018 8:46 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > ; Ni, Ruiyu ; Kinney, Michael > D > Subject: [PATCH 31/37] ShellPkg: Removing ipf which is no longer supported &

Re: [edk2] [PATCH 35/37] StdLibPrivateInternalFiles: Removing ipf from edk2.

> -Original Message- > From: Chen, Chen A > Sent: Tuesday, June 12, 2018 8:46 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > ; Kinney, Michael D > > Subject: [PATCH 35/37] StdLibPrivateInternalFiles: Removing ipf from edk2. > Importanc

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

Jim, I think I see what you mean. If scan code is 0, then don’t test the shift state and just use the character raw? Jaben Sent from my iPad > On Jun 4, 2018, at 9:02 AM, "jim.dai...@dell.com" wrote: > > Please disregard the stupid "Confidential" line that ou

[edk2] [PATCH v1 1/1] BaseTools: Refactoring to save time

d sdict class Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 38 +- BaseTools/Source/Python/AutoGen/GenC.py | 454 ++-- BaseTools/Source/Python/AutoG

Re: [edk2] [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class.

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, May 24, 2018 1:57 PM > To: edk2-devel@lists.01.org; Laszlo Ersek > Cc: Justen, Jordan L ; af...@apple.com >

[edk2] [PATCH v1 1/1] BaseTools: Add missing content to EOT tool.

Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/Eot/Eot.py | 1444 +++- BaseTools

Re: [edk2] [RFC] Formalize source files to follow DOS format

We could do something like we do for compiler flags... append or overwrite depending on syntax. > -Original Message- > From: Gao, Liming > Sent: Thursday, May 24, 2018 1:35 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; Carsey, Jaben > <jaben.car...@int

Re: [edk2] [RFC] Formalize source files to follow DOS format

Follow pep8 for coding style. The technical benefit is things like that If an exception occurs we still close the file. > -Original Message- > From: Gao, Liming > Sent: Thursday, May 24, 2018 1:31 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01

Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set

Marvin, I have seen funny stuff when outlook shows me the email with patch, but it's part of the displaying not the sending bits... -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gao, Liming > Sent: Tuesday, May 22,

Re: [edk2] [RFC] Formalize source files to follow DOS format

Mike, Perhaps a default set of file extensions that can be overridden? -Jaben > On May 21, 2018, at 3:41 PM, Kinney, Michael D <michael.d.kin...@intel.com> > wrote: > > Liming, > > We have a set of standard flags for tools that > should always be present. >

Re: [edk2] [RFC] Formalize source files to follow DOS format

Liming, One Pep8 thing. Can you change to use the with statement for the file read/write? Other small thoughts. I think that FileList should be changed to a set as order is not important. Maybe wrapper the re.sub function with your own so all the .encode() are in one location? As we move to

[edk2] [PATCH v1 1/2] BaseTools: refactor to remove functions

refactoring almost identical functions to delete and use the other. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Sou

[edk2] [PATCH v1 2/2] BaseTools: Cleanup unneeded code

Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/AutoGen/AutoGen.py | 335 +---

[edk2] [PATCH v1 0/2] BaseTools: cleanup for speed

the first patch merges 2 almost identical functions by moving optional output to the WorkspaceCommon version and then calls it from AutoGen. the second patch is lots of small cleanups. Jaben Carsey (2): BaseTools: refactor to remove functions BaseTools: Cleanup unneeded code BaseTools

Re: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

Still looks good to me. Ray? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, May 17, 2018 5:43 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, R

Re: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

Marvin, Can you resubmit your patch without the modification to the intel copyright? Can you also do this for any other outstanding (not yet pushed) patches also? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häus

Re: [edk2] [PATCH] BaseTools: Fix --hash Package and Module hash value.

Derek, The change is good. I have a comment/question on the message. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Order of list enumeration is not arbitrary, it's based on python lists being inherently insertion-ordered objects. If insertion order is irrelevant, should we co

Re: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

I have no clue on OSS laws/rules, I was just confused. I think that you do no need to update any copyright (except your own). The code change looks good and that is about all I can really say. :) -Jaben > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlo

[edk2] [PATCH v1 11/11] BaseTools: remove extra assignment

there is no use to assign back to a variable. just return the result. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/So

[edk2] [PATCH v1 07/11] BaseTools: refactor file opening/writing

change mode minimal needed permissions change to use with statement Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Sou

[edk2] [PATCH v1 09/11] BaseTools: refactor to stop re-allocating strings

strings are immutable. allocate minimal duplication. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/

[edk2] [PATCH v1 08/11] BaseTools: refactor to change object types

change to object types that are closer to use case. for example: when using a list as a double ended queue, use the built in object. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH v1 06/11] BaseTools: refactor section generation

use with for opening files remove unneeded variables dont seek to 0 for just opened file Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com&

[edk2] [PATCH v1 03/11] BaseTools: remove unused code

1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/AutoGen/GenMake.py | 17 ++-- BaseTools/Source/Python/CommonDataClass/DataClass.py | 47 +-- BaseTools/Source/Python/Ecc/Database.py| 76 + BaseTools/Sour

[edk2] [PATCH v1 02/11] BaseTools: Workspace - create a base class

refactor 3 classes and create a new base class for their shared functions. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseT

[edk2] [PATCH v1 00/11] BaseTools refactoring

performing operation since strings are immutable and must be completely reallocated and moved for each concatenation. Jaben Carsey (11): BaseTools: decorate base classes to prevent instantiation BaseTools: Workspace - create a base class BaseTools: remove unused code BaseTools: remove repeated

[edk2] [PATCH v1 04/11] BaseTools: remove repeated calls to startswith/endswith

As both can take a tuple, use that instead of calling repeatedly. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Sou

[edk2] [PATCH v1 05/11] BaseTools: use set presence instead of series of equality

Instead of testing each equality individually, just make a set and test once. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseT

Re: [edk2] [Patch] BaseTools: Enhance error message when file is not exist for Gensec

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Sunday, May 13, 2018 5:46 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTool

[edk2] [PATCH v2 1/1] BaseTools: loop to retry remove when it fails.

oCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/Common/LongFilePathOs.py | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Common/LongFilePathOs.py b/BaseTo

Re: [edk2] [PATCH v1 1/1] BaseTools: loop to retry remove when it fails.

Absolutely true. I am really trying to start the discussion as the error is occurring more and more for me. I can send a v1 patch with timeout added. Yonghong and Liming, And thoughts? -Jaben > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, May 09, 201

Re: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

Ignore. Duplicate. Already sent out. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jaben Carsey > Sent: Wednesday, May 09, 2018 1:51 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com> > Su

[edk2] [PATCH v1 1/1] BaseTools: loop to retry remove when it fails.

There is a common race condition when the OS fails to release a file fast enough. this adds a retry loop. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.c

Re: [edk2] [Patch] BaseTools: Remove the redundant code

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Gotta love removing code. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, May 9, 2018 5:32 AM > To: edk2-devel@lists.01.org >

[edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M

the "0x" was missing. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/GenFds/FvImageSection.py

[edk2] error while removing a file

Does anyone else see this issue? I see this, but cannot guarantee to see it so I cannot be sure about fixing it. I have a patch that I would like to work with others seeing the issue on... -Jaben My error looks like this, but I think the exact text is dependent on python version: build.py

Re: [edk2] [PATCH] ShellPkg/UefiShellCommandLib: Do not error-exit when PlatformLang is missing.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: Saturday, May 05, 2018 5:07 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <

Re: [edk2] [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Fix ls on entirely empty directories.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Saturday, May 05, 2018 5:11 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.c

Re: [edk2] [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Saturday, May 05, 2018 1:23 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.c

Re: [edk2] [PATCH v3 1/1] BaseTools: Ecc - add dict for config file to internal translation

Thanks. I don’t push BaseTools, but will await Liming or Yonghong to review and push. Yonghong/Liming, Can you strip the trailing space before you commit? -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 04, 2018 2:44 PM >

[edk2] [PATCH v3 1/1] BaseTools: Ecc - add dict for config file to internal translation

. Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/Ec

Re: [edk2] [PATCH v2 1/1] BaseTools: Ecc - add dict for config file to internal translation

Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 04, 2018 11:25 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel.com>; Zhu, Yonghong > <yonghong@intel.com> > Subject: Re: [PATCH v2 1/1] Ba

Re: [edk2] [PATCH v1 1/1] BaseTools: Ecc - add dict for config file to internal translation

I worked up and sent out a v2. I think that if we only use the translation when acing the dict, we can leave the rest of the code as it. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 04, 2018 9:20 AM > To: Carsey, Jaben <jaben.c

[edk2] [PATCH v2 1/1] BaseTools: Ecc - add dict for config file to internal translation

ng Zhu <yonghong@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/Ecc/Configuration.py | 101 +++- 1 file changed, 98 in

[edk2] [PATCH v1 1/1] BaseTools: Ecc - add dict for config file to internal translation

Cc: Liming Gao <liming@intel.com> Cc: Yonghong Zhu <yonghong@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- BaseTools/Source/Python/Ecc/Configuration

Re: [edk2] [PATCH v1 17/27] BaseTools: DataType - cleanup list constants

? -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 04, 2018 4:15 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> > Subject: Re: [edk2] [PATCH v1 17/27]

<    1   2   3   4   5   6   7   8   9   10   >