Re: [edk2] [PATCH] ArmPkg/BdsLib: Increase fallback tftp buffer size

2015-11-06 Thread Laszlo Ersek
On 11/06/15 18:01, Ashutosh Singh wrote: > When performing a tftp download from a server which does not support > rfc2349 transfer size option (such as netkit-tftpd), the existing code > falls back to allocating an 8MB buffer. Since this is insufficient for > an uncompressed AArch64 Linux kernel im

Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II

2015-11-09 Thread Laszlo Ersek
On 11/09/15 16:07, Scott Duplichan wrote: > Hello Liming, > > You are right, the select-all, paste method skips the mail header. > I don't know of a solution that retains the mail header. Here's one way. (1) Locate the email that you are interested in in the mailing list archive. If your email

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-09 Thread Laszlo Ersek
On 11/09/15 16:52, Conen, Johannes wrote: > Hello everyone, > > after switching from UDK2014 to UDK2015, I noticed that the network > commands (ifconfig / ping) don't work anymore. ifconfig just exits > with no feedback and ping says "Config no mapping" (logical, as it is > not possible to get an

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-09 Thread Laszlo Ersek
side note: On 11/09/15 21:30, Laszlo Ersek wrote: >> Shell> ifconfig -s eth0 dhcp >> Shell> ifconfig -l eth0 >> >> - >> >> name : eth0 >> Media State : Media present >> po

Re: [edk2] testing Centos 7.1 boot from iscsi with EDK -> kernel crashes after launch by GRUB

2015-11-09 Thread Laszlo Ersek
On 11/09/15 14:50, P.A.M. van Dam (Pascal) wrote: > > Good day all, > > I decided to do some testing with iSCSI boot from within a KVM. > > My setup is a Centos 7.1 KVM host with several Fedora 22 and Centos 7.1 > guests in it. The iSCSI storage has been configured > from a LenovoEMC EPX6300 N

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-09 Thread Laszlo Ersek
On 11/09/15 21:49, Leif Lindholm wrote: > On Mon, Nov 09, 2015 at 09:30:03PM +0100, Laszlo Ersek wrote: >>> after switching from UDK2014 to UDK2015, I noticed that the network >>> commands (ifconfig / ping) don't work anymore. ifconfig just exits >>> with n

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-10 Thread Laszlo Ersek
ion > Process Automation > Manufacturing Karlsruhe > PD PA MF-K IPC 2 > Oestliche Rheinbrueckenstr. 50 > 76187 Karlsruhe, Germany > mailto:johannes.co...@siemens.com > > > -Ursprüngliche Nachricht- > Von: Wu, Jiaxin [mailto:jiaxin...@intel.com] > Gesendet: Dienstag, 10. Novem

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-10 Thread Laszlo Ersek
how UDK releases account for compatibility in general. (My *guess* is that UDK2015 generally targets (or moved towards) UEFI 2.5, and Ip4Config (version 1) is apparently deprecated in UEFI 2.5.) Thanks Laszlo > > Greetings > Johannes > > -Ursprüngliche Nachricht- >

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-10 Thread Laszlo Ersek
On 11/10/15 11:43, Leif Lindholm wrote: > On Tue, Nov 10, 2015 at 11:28:10AM +0100, Laszlo Ersek wrote: >> On 11/10/15 11:20, Conen, Johannes wrote: >>> Hmm, you're right. is it briefly mentioned in the "ShellPkg >>> Notes.txt" - I must adm

Re: [edk2] ShellPkg: Network commands (ifconfig/ping) broken

2015-11-10 Thread Laszlo Ersek
On 11/10/15 15:36, Carsey, Jaben wrote: > > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, November 10, 2015 3:54 AM >> To: Leif Lindholm >> Cc: edk2-devel@li

Re: [edk2] Filesystem issues since "OvmfPkg: enable SATA controller"

2015-11-10 Thread Laszlo Ersek
Adding John Snow (IDE maintainer in QEMU) On 11/10/15 17:55, Mark Rutland wrote: > I've been trying to test an EFI application on x86_64 using Ubuntu 14.04's > QEMU > 2.0.0. I have a directory 'foo' containing the application, and I get QEMU to > create a virtual FAT device: > > $ qemu-system-x8

Re: [edk2] Filesystem issues since "OvmfPkg: enable SATA controller"

2015-11-10 Thread Laszlo Ersek
On 11/10/15 19:48, John Snow wrote: > > > On 11/10/2015 01:17 PM, Laszlo Ersek wrote: >> Adding John Snow (IDE maintainer in QEMU) >> >> On 11/10/15 17:55, Mark Rutland wrote: >>> I've been trying to test an EFI application on x86_64 using Ubuntu 14.04&

Re: [edk2] testing Centos 7.1 boot from iscsi with EDK -> kernel crashes after launch by GRUB

2015-11-12 Thread Laszlo Ersek
Please don't drop the list and other CC's from the discussion when the initial report is sent to the list. Keeping full context. On 11/11/15 08:38, P.A.M. van Dam (Pascal) wrote: > On Mon, Nov 09, 2015 at 10:02:52PM +0100, Laszlo Ersek wrote: >> On 11/09/15 14:50, P.A.M. van

Re: [edk2] [PATCH v4 02/41] OvmfPkg: Sec: force reinit of BaseExtractGuidedSectionLib handler table

2015-11-13 Thread Laszlo Ersek
On 11/11/15 21:01, Jordan Justen wrote: > On 2015-11-03 13:00:38, Laszlo Ersek wrote: >> BaseExtractGuidedSectionLib uses a table at the static physical address >> PcdGuidedExtractHandlerTableAddress, and modules that are linked against >> BaseExtractGuidedSectionLib are expe

Re: [edk2] Help: edk2 Ovfm pkg building error:

2015-11-13 Thread Laszlo Ersek
On 11/13/15 09:44, maojunhong wrote: > > > Help: edk2 Ovfm pkg building error: > > : error C0DE: Unknown fatal error when processing > [e:\edk2\OvmfPkg\PlatformDxe\Platform.inf] > > > > SVN version: edk2 18610 > > > > > > > > > > E:\edk2>build -a IA32 -p OvmfPkg\OvmfPkgIa32.dsc > >

Re: [edk2] testing Centos 7.1 boot from iscsi with EDK -> kernel crashes after launch by GRUB

2015-11-13 Thread Laszlo Ersek
On 11/13/15 12:22, P.A.M. van Dam (Pascal) wrote: > On Thu, Nov 12, 2015 at 07:17:49PM +0100, Laszlo Ersek wrote: > > Good afternoon all, > >> Please don't drop the list and other CC's from the discussion when the >> initial report is sent to the list. Keeping f

Re: [edk2] [PATCH v2 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-13 Thread Laszlo Ersek
On 11/13/15 15:55, Ard Biesheuvel wrote: > The ARM architecture version 7 and later mandates that device mappings > have the XN (non-executable) bit set, to prevent speculative instruction > fetches from read-sensitive regions. This implies that we should not map > regions as device if we want to e

Re: [edk2] Alter OVMF/UEFI iSCSI settings outside of the OVMF UI

2015-11-13 Thread Laszlo Ersek
On 11/13/15 13:39, P.A.M. van Dam (Pascal) wrote: > Good morning all, > > What I would like to do is pre-configure the NVRAM of the Virtual Machines > (guests) with the > ISCSI config. So have initiator, iSCSI host and target preconfigured in the > NVRAM before the guest > gets started. This way

Re: [edk2] [PATCH v2 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-13 Thread Laszlo Ersek
On 11/13/15 18:16, Ard Biesheuvel wrote: > On 13 November 2015 at 17:55, Ard Biesheuvel > wrote: >> On 13 November 2015 at 17:40, Laszlo Ersek wrote: >>> On 11/13/15 15:55, Ard Biesheuvel wrote: >>>> The ARM architecture version 7 and later mandates that devi

[edk2] [PATCH] MdeModulePkg: SmmLockBoxPeiLib: work without EFI_PEI_SMM_COMMUNICATION_PPI

2015-11-13 Thread Laszlo Ersek
TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: This allows me to drop the null implementation of EFI_PEI_SMM_COMMUNICATION_PPI from the patch "OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI". MdeModulePkg/Library/SmmLockBoxLib/SmmLockBo

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-13 Thread Laszlo Ersek
then I can drop the SmmCommunication PPI null implementation from this OVMF patch. (I've tested S3 that way.) Thanks! Laszlo > > Thank you > Yao Jiewen > > -Original Message- > From: Justen, Jordan L > Sent: Thursday, November 12, 2015 6:41 AM > To: Kinney,

Re: [edk2] [PATCH v4 13/41] OvmfPkg: LockBox: -D SMM_REQUIRE excludes our fake lockbox

2015-11-13 Thread Laszlo Ersek
On 11/11/15 22:25, Jordan Justen wrote: > On 2015-11-03 13:00:49, Laszlo Ersek wrote: >> When the user builds OVMF with -D SMM_REQUIRE, our LockBox implementation >> must not be used, since it doesn't actually protect data in the LockBox >> from the runtime guest OS.

Re: [edk2] [PATCH] MdeModulePkg: SmmLockBoxPeiLib: work without EFI_PEI_SMM_COMMUNICATION_PPI

2015-11-16 Thread Laszlo Ersek
again for that) that Jordan and Mike asked for. Thus, I've now committed this: SVN r18823. Thank you again for the good idea and your flexibility to address this in SmmLockBoxPeiLib. Laszlo > > > > -----Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] &g

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-16 Thread Laszlo Ersek
refreshed the commit message, noting why we don't need EFI_PEI_SMM_COMMUNICATION_PPI from under UefiCpuPkg.) I can post v5 tomorrow, or wait for more v4 feedback. Thanks! Laszlo > > -Jordan > >> >>> -Original Message- >>> From: edk2-devel [mailto:edk2

Re: [edk2] [PATCH 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-17 Thread Laszlo Ersek
On 11/17/15 10:35, Star Zeng wrote: > It is also to add GetControl/SetControl/SetAttributes implementation > for EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under

Re: [edk2] [PATCH 10/12] OvmfPkg XenConsoleSerialPortLib: Add GetControl/SetControl/SetAttributes implementation

2015-11-17 Thread Laszlo Ersek
Although this also updates Ard's code, mainly, I think I can comment on it: On 11/17/15 10:35, Star Zeng wrote: > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > S

Re: [edk2] [PATCH 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-17 Thread Laszlo Ersek
On 11/17/15 11:55, Zeng, Star wrote: > On 2015/11/17 18:09, Laszlo Ersek wrote: >> On 11/17/15 10:35, Star Zeng wrote: >>> It is also to add GetControl/SetControl/SetAttributes implementation >>> for EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib. >>> >

Re: [edk2] [PATCH V2 00/12] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

2015-11-17 Thread Laszlo Ersek
orked code is at g...@github.com:lzeng14/edk2.git > branch SerialDxeV2. > > * New in V2: > According the suggestion from Laszlo Ersek , > zero *Control first in SerialPortGetControl() for > EmulatorPkg/Omap35xxPkg/OvmfPkg updates. Please don't post a new version right after gettin

Re: [edk2] [PATCH V2 00/12] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

2015-11-17 Thread Laszlo Ersek
On 11/17/15 14:00, Zeng, Star wrote: > On 2015/11/17 20:24, Laszlo Ersek wrote: >> On 11/17/15 12:07, Star Zeng wrote: >>> Generally, this patch series are to upstream SerialDxe from >>> EmbeddedPkg to MdeModulePkg, >>> relatively, they are also to upstream Ser

Re: [edk2] [PATCH v3 2/4] ArmVirtPkg/ArmVirtPlatformLib: do not map executable NOR region as device

2015-11-18 Thread Laszlo Ersek
t;*VirtualMemoryMap = VirtualMemoryTable; > } > Thanks, this update is very welcome. Please don't forget to test it on phys hw / KVM. (If you haven't done so yet.) Reviewed-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v4 14/41] OvmfPkg: LockBox: use SMM stack with -D SMM_REQUIRE

2015-11-20 Thread Laszlo Ersek
classes for DXE_SMM_DRIVER modules.) >> >> - In PEI, the S3 Resume PEIM (UefiCpuPkg/Universal/Acpi/S3Resume2Pei) >> retrieves data from the LockBox. It is capable of searching SMRAM >> itself. >> >> We resolve LockBoxLib to >> &qu

Re: [edk2] [PATCH 0/2] ArmVirtPkg: limit IPA space to prevent page table memory waste

2015-11-23 Thread Laszlo Ersek
On 11/21/15 10:44, Ard Biesheuvel wrote: > Hello all, > > After Drew pointed out that mach-virt now populates the memory region beyond > DRAM, I am proposing this approach instead. Since KVM limits its IPA space to > 40 bits, there is simply no point in supporting anything beyond that for > ArmVir

Re: [edk2] [PATCH 1/2] ArmVirtPkg/ArmVirtPlatformLib: reduce ID map size to GCD region size

2015-11-23 Thread Laszlo Ersek
On 11/21/15 10:44, Ard Biesheuvel wrote: > The ID mapping routines on virtual platforms simply map the entire > address space as device memory, and then punch some holes for regions > that need to be mapped cacheable. On virtual platforms hosted on CPUs > that support a large physical address range

Re: [edk2] [PATCH v4 08/41] OvmfPkg: add DXE_DRIVER for providing TSEG-as-SMRAM during boot-time DXE

2015-11-23 Thread Laszlo Ersek
ailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, November 3, 2015 1:01 PM >> To: edk2-de...@ml01.01.org >> Subject: [edk2] [PATCH v4 08/41] OvmfPkg: add DXE_DRIVER for providing >> TSEG-as-SMRAM during boot-time DXE >> >

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-23 Thread Laszlo Ersek
ith STATIC under OvmfPkg, - I can move the definition of the global variable to the top, remove its initializer, and assign the members in the driver entry point instead, if you'd like me to. Thanks! Laszlo > > Mike > >> -Original Message- >> From: Lasz

Re: [edk2] [PATCH v4 09/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-11-23 Thread Laszlo Ersek
devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, November 3, 2015 1:01 PM >> To: edk2-de...@ml01.01.org >> Subject: [edk2] [PATCH v4 09/41] OvmfPkg: implement >> EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER >>

Re: [edk2] [PATCH V3 10/12] OvmfPkg XenConsoleSerialPortLib: Implement Get(Set)Control/SetAttributes

2015-11-23 Thread Laszlo Ersek
On 11/23/15 02:44, Star Zeng wrote: > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng > --- > .../XenConsoleSerialPortLib.c

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-23 Thread Laszlo Ersek
plement the functions simultaneously with the driver > replacement. (1) The commit message has been updated the way I asked, thank you for that. (See also (3) below.) However, > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contribut

Re: [edk2] [PATCH 1/2] ArmVirtPkg/ArmVirtPlatformLib: reduce ID map size to GCD region size

2015-11-23 Thread Laszlo Ersek
On 11/23/15 12:53, Ard Biesheuvel wrote: > On 23 November 2015 at 12:41, Laszlo Ersek wrote: >> On 11/21/15 10:44, Ard Biesheuvel wrote: >>> The ID mapping routines on virtual platforms simply map the entire >>> address space as device memory, and then punch some hole

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 from BSPHandler() to PerformRemainingTasks().

2015-11-23 Thread Laszlo Ersek
Hi Jiewen, On 11/23/15 14:50, jiewen yao wrote: > In this way, we can centralize the silicon configuration in > PerformRemainingTasks() function. > If there are more features need to be configured, they can put in > PerformRemainingTasks() only. > > Contributed-under: TianoCore Contribution Agr

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 from BSPHandler() to PerformRemainingTasks().

2015-11-23 Thread Laszlo Ersek
On 11/23/15 16:32, Yao, Jiewen wrote: > Comments below: > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, November 23, 2015 10:39 PM > To: Yao, Jiewen; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Fan, Jeff > Subject: Re: [

Re: [edk2] [PATCH 0/6] ArmVirtPkg: add ARM support to ArmVirtXen

2015-11-23 Thread Laszlo Ersek
/ArmXenRelocatablePlatformLib - ArmVirtPkg/PrePi - ArmVirtPkg/ArmVirtXen.* I think the QEMU build is safe from regressions. So for those patches, you have my Acked-by: Laszlo Ersek (as a formality :)) Cheers Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg/ArmVirtPlatformLib: reduce ID map size to GCD region size

2015-11-23 Thread Laszlo Ersek
VirtualMemoryTable[2].PhysicalBase; > VirtualMemoryTable[2].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; > >// Remap the FD region as normal executable memory > Reviewed-by: Laszlo Ersek Wei, can you please test this version on the ThunderX? Thanks Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg/ArmVirtPlatformLib: reduce ID map size to GCD region size

2015-11-23 Thread Laszlo Ersek
On 11/23/15 21:04, Wei Huang wrote: > > > On 11/23/2015 11:16 AM, Laszlo Ersek wrote: >> On 11/23/15 18:10, Ard Biesheuvel wrote: >>> The ID mapping routines on virtual platforms simply map the entire >>> address space as device memory, and then punch some hole

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-23 Thread Laszlo Ersek
On 11/23/15 21:13, Kinney, Michael D wrote: > Laszlo, > > Comments below. > > Mike > >> -Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Monday, November 23, 2015 4:34 AM >> To: Kinney, Michael D ; edk2-de...@ml01.

Re: [edk2] [PATCH v4 08/41] OvmfPkg: add DXE_DRIVER for providing TSEG-as-SMRAM during boot-time DXE

2015-11-23 Thread Laszlo Ersek
tyle of the other packages, while allowing me to use ctags without much inconvenience. :) Thanks Laszlo > > Mike > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Monday, November 2

Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-23 Thread Laszlo Ersek
patch style (1) in OvmfPkg specific modules is ok until > you can find a solution to your ctags issue. Thank you. Laszlo > > Mike > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >>

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 function to PerformPreTasks().

2015-11-24 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" > Cc: "Fan, Jeff" > Cc: "Kinney, Michael D" > Cc: "Laszlo Ersek" > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 ++ > UefiC

Re: [edk2] [PATCH v4 09/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

2015-11-24 Thread Laszlo Ersek
Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Monday, November 23, 2015 4:56 AM >> To: Kinney, Michael D ; edk2-de...@ml01.01.org >> Subject: Re: [edk2] [PATCH v4 09/41] OvmfPkg: implement >> EFI_SMM_

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-24 Thread Laszlo Ersek
On 11/24/15 02:01, Zeng, Star wrote: > On 2015/11/23 22:01, Laszlo Ersek wrote: [snip] >> (2) although I see that you unified the GetControl / SetControl / >> SetAttributes implementations between >> - EarlyFdtPL011SerialPortLib and >> - FdtPL011SerialPortLib, >&

Re: [edk2] Dynamic PCD Variable Storage in PEI Phase

2015-11-24 Thread Laszlo Ersek
On 11/24/15 00:25, Andrew Fish wrote: > >> On Nov 23, 2015, at 2:03 PM, Narinder Dhillon wrote: >> >> Hi Andrew, >> >> I looked at the ArmVirtPkg and did the same before I sent the previous >> email. I am missing some step that is causing the null package to be >> picked up. Here are my changes,

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2015-11-24 Thread Laszlo Ersek
On 11/24/15 15:27, Zeng, Star wrote: > On 2015/11/24 21:17, Laszlo Ersek wrote: >> On 11/24/15 02:01, Zeng, Star wrote: >>> On 2015/11/23 22:01, Laszlo Ersek wrote: >> >> [snip] >> >>>> (2) although I see that you unified the GetControl / SetCont

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

2015-11-24 Thread Laszlo Ersek
ael D > Sent: Tuesday, November 24, 2015 2:24 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek; Yao, Jiewen; Fan, Jeff > Subject: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize > ACPI_CPU_DATA for S3 > > This module initializes the ACPI_CPU_DATA structure

Re: [edk2] [PATCH 1/2] UefiCpuPkg - Expand description of AcpuCpuData.h structures

2015-11-24 Thread Laszlo Ersek
Mike, first of all, thanks a lot for doing this. Some comments below: On 11/24/15 07:24, Michael Kinney wrote: > Provide a more detailed description of each field of the > ACPI_CPU_DATA and CPU_REGISTER_TABLE structures. > > Cc: Laszlo Ersek > Cc: "Yao, Jiewe

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

2015-11-24 Thread Laszlo Ersek
patch 0/2) in this commit message. The blurb will not be captured in the git history. > Cc: Laszlo Ersek > Cc: "Yao, Jiewen" > Cc: "Fan, Jeff" > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Mic

Re: [edk2] [PATCH V4 01/13] MdeModulePkg: TerminalDxe: avoid checking uninitialized variable

2015-11-24 Thread Laszlo Ersek
unction call set that bit in the Control variable. > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Feng Tian > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Suggested-by: Laszlo Ersek > Signed-off-by: Star Zeng > --- > MdeModulePk

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

2015-11-24 Thread Laszlo Ersek
On 11/24/15 23:48, Kinney, Michael D wrote: > Laszlo, > > Thanks for the detailed feedback. Comments included below. V2 patch to > follow. > > Mike > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, N

Re: [edk2] [PATCH v2 1/2] UefiCpuPkg/Include: Expand description of AcpiCpuData.h structures

2015-11-24 Thread Laszlo Ersek
uffer be zero-filled. This buffer used to (1) "This buffer [is] used to" > + // wake APs during an ACPI S3 resume. > + // >EFI_PHYSICAL_ADDRESS StartupVector; With that change -- and there is no need to submit a v3 just because of it; it can be fixed at commit time -- Re

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

2015-11-25 Thread Laszlo Ersek
equired. > > This patch series is in response to the OvmfPkg patch series from > Laszlo Ersek that enables SMM on OVMF. The v4 version of the patch > series from Laszlo includes an OVMF specific CPU module to initialize > the ACPI_CPU_DATA structure. > > This proposed p

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

2015-11-25 Thread Laszlo Ersek
On 11/25/15 02:04, jiewen yao wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" > Cc: "Fan, Jeff" > Cc: "Kinney, Michael D" > --- > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 39 > ++ > 1 file changed, 39 insertions(+)

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

2015-11-25 Thread Laszlo Ersek
Jordan, Paolo, any reviews or ACKs for this one? There are no changes queued for this patch in the upcoming v5. Thanks Laszlo On 11/03/15 22:01, Laszlo Ersek wrote: > Cc: Paolo Bonzini > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --

Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

2015-11-25 Thread Laszlo Ersek
! Laszlo > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Wednesday, November 25, 2015 7:49 PM > To: Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Fan, Jeff > Subject: Re: [edk2] [pat

Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM Memory Attribute table.

2015-11-25 Thread Laszlo Ersek
I have some high level questions: On 11/25/15 14:46, jiewen yao wrote: > This table is to let SMM core report SMM memory layout, > especially SMM PE/COFF driver information. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" > Cc: "Zeng, Star" > Cc: "Kinn

Re: [edk2] [patch 1/7] MdeModulePkg/PiSmmCore: Add EDKII PI SMM Memory Attribute table.

2015-11-25 Thread Laszlo Ersek
to edit it in-place (fix up the subject line, and provide a generic description in the body), before posting it. This is unlike the "nonzero" (i.e., 1-n/n) patch files, which are not supposed to be touched between generation and mailing. Thanks again! Laszlo > -Original Message

Re: [edk2] [PATCH] ArmPkg: add typecast in UncachedMemoryAllocationLib to fix build warning

2015-11-25 Thread Laszlo Ersek
On 11/25/15 18:41, Ard Biesheuvel wrote: > On 25 November 2015 at 17:35, Cohen, Eugene wrote: >> Small warning fix. >> > > Hello Eugene, > > Presumably, the warning is about the variable potentially being used > uninitialized? > If so, please drop the cast in the initializer, and update your > $

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

2015-11-25 Thread Laszlo Ersek
On 11/25/15 18:46, Jordan Justen wrote: > On 2015-11-03 13:01:17, Laszlo Ersek wrote: >> Cc: Paolo Bonzini >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> v4: >>

Re: [edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

2015-11-25 Thread Laszlo Ersek
SmmCpuFeaturesAllocatePageTableMemory() into OVMF's SmmCpuFeaturesLib instance, for v5.) Thanks! Laszlo > > Mike > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, Novem

Re: [edk2] [PATCH] ArmPkg: Initialize variable in UncachedMemoryAllocationLib's AllocatePagesFromList to fix build warning

2015-11-25 Thread Laszlo Ersek
On 11/25/15 18:59, Cohen, Eugene wrote: > Addressing Ard and Laszlo's feedback. > > Updated subject. Moved initialization to separate line. Removed the > typecast which was a carryover from a more strict convention we use in our > private code. > > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

2015-11-26 Thread Laszlo Ersek
On 11/25/15 22:29, Jordan Justen wrote: > On 2015-11-25 10:06:03, Laszlo Ersek wrote: >> On 11/25/15 18:46, Jordan Justen wrote: >>> On 2015-11-03 13:01:17, Laszlo Ersek wrote: >>> >>>> + qemu-system-i386 -cpu coreduo,-nx \ >>> >>> Sometim

Re: [edk2] [PATCH 04/23] ArmVirtPkg/ArmVirtQemu: move to ArmPkg version of PeiServicesTablePointerLib

2015-11-26 Thread Laszlo Ersek
b|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > > SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.inf > > [LibraryClasses.common.DXE_CORE] > Out of curiosity -- do you know why ArmPlatformPkg's (non-co

Re: [edk2] [PATCH 05/23] ArmVirtPkg: drop ArmPlatformGlobalVariableLib dependency

2015-11-26 Thread Laszlo Ersek
atformLib/VirtMem.c > index e5536ecd8e28..666edb47ce97 100644 > --- a/ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c > +++ b/ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > > // Number of Virtual Memory Map Descriptors > Reviewed-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 10/23] ArmVirtPkg/PrePi: remove global variable allocation from lowlevel init

2015-11-26 Thread Laszlo Ersek
e region > - mGlobalVariableBase = GlobalVariableBase; > - > - PrePiMain (UefiMemoryBase, StacksBase, GlobalVariableBase, StartTimeStamp); > + PrePiMain (UefiMemoryBase, StacksBase, StartTimeStamp); > >// DXE Core should always load and n

Re: [edk2] EDK python script

2015-11-26 Thread Laszlo Ersek
On 11/26/15 04:45, Lu, James wrote: > > Hi, > > I'm trying to build EDK BIOS with python script on Linux but got below error. > > [16:50:59]W: [Step 2/5] Build environment: > Linux-3.2.0-69-generic-x86_64-with-Ubuntu-12.04-precise > [16:50:59]W: [Step 2/5] Build start time: 16:50:59,

Re: [edk2] [PATCH V4 07/13] CorebootPayloadPkg: Use SerialDxe in MdeModulePkg

2015-11-26 Thread Laszlo Ersek
Hi Star, On 11/25/15 02:33, Star Zeng wrote: > 1. Update fdf and dsc to use SerialDxe in MdeModulePkg. > 2. Separate the code that gets SerialRegBase and SerialRegAccessType >by CbParseLib from CorebootPayloadPkg/Library/SerialPortLib to >PlatformHookLib, and then leverage BaseSerialPortLi

Re: [edk2] [PATCH V4 07/13] CorebootPayloadPkg: Use SerialDxe in MdeModulePkg

2015-11-26 Thread Laszlo Ersek
On 11/26/15 18:39, Laszlo Ersek wrote: > Hi Star, > > On 11/25/15 02:33, Star Zeng wrote: >> 1. Update fdf and dsc to use SerialDxe in MdeModulePkg. >> 2. Separate the code that gets SerialRegBase and SerialRegAccessType >>by CbParseLib from CorebootPayloadP

Re: [edk2] [patch 2/2] UefiCpuPkg/PiSmmCpu: Always set WP in CR0.

2015-11-26 Thread Laszlo Ersek
On 11/25/15 22:56, Yao, Jiewen wrote: > Hi Mike > Thanks for the suggestion. > Previously, I just want to *ADD* without touch old logic. I will use your way > to do it. > > -Original Message- > From: Kinney, Michael D > Sent: Thursday, November 26, 2015 2:01 AM > To: Yao, Jiewen; edk2-de

[edk2] please DO NOT commit unreviewed patches to subversion!

2015-11-26 Thread Laszlo Ersek
I notice that recently there have been patches committed to the subversion repository that had *never* been posted to the list, in the ultimately committed form. Examples: (1) Patches on the list: http://thread.gmane.org/gmane.comp.bios.edk2.devel/4770 [edk2] [patch 1/3] UefiCpuPkg/PiSmm

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

2015-11-26 Thread Laszlo Ersek
On 11/26/15 17:17, Laszlo Ersek wrote: > On 11/25/15 22:29, Jordan Justen wrote: >> On 2015-11-25 10:06:03, Laszlo Ersek wrote: >>> On 11/25/15 18:46, Jordan Justen wrote: >>>> On 2015-11-03 13:01:17, Laszlo Ersek wrote: >>>> >>>>> + qemu-

Re: [edk2] [patch 2/2] UefiCpuPkg/PiSmmCpu: Always set WP in CR0.

2015-11-26 Thread Laszlo Ersek
On 11/27/15 02:14, Yao, Jiewen wrote: > Hi Laszlo > Comments below: > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Friday, November 27, 2015 5:57 AM > To: Yao, Jiewen; Kinney, Michael D; edk

[edk2] [PATCH v5 00/33] OvmfPkg: support SMM for better security

2015-11-26 Thread Laszlo Ersek
uild CpuS3DataDxe for -D SMM_REQUIRE After which I plan to commit the series. Cc: Paolo Bonzini Cc: Jordan Justen Cc: Michael Kinney Cc: Jiewen Yao Thanks Laszlo Laszlo Ersek (27): OvmfPkg: introduce -D SMM_REQUIRE and PcdSmmSmramRequire OvmfPkg: Sec: force reinit of BaseExtractGuidedSection

[edk2] [PATCH v5 02/33] OvmfPkg: Sec: force reinit of BaseExtractGuidedSectionLib handler table

2015-11-26 Thread Laszlo Ersek
code paths examined in that commit. Furthermore, a non-malicious runtime OS will observe no change in behavior; see case (c) in said commit. Cc: Michael Kinney Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek [michael.d.kin...@intel.com: pr

[edk2] [PATCH v5 04/33] OvmfPkg: decompress FVs on S3 resume if SMM_REQUIRE is set

2015-11-26 Thread Laszlo Ersek
x27;t support S3 (or the user disabled it on the QEMU command line), then this patch has no effect also. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- Notes: v2: - PcdOvmfDecomprScratchEnd => PcdOvmfDecompre

[edk2] [PATCH v5 13/33] OvmfPkg: LockBoxLib: -D SMM_REQUIRE excludes our fake lockbox

2015-11-26 Thread Laszlo Ersek
ff-by: Laszlo Ersek Reviewed-by: Paolo Bonzini Reviewed-by: Jordan Justen --- Notes: v5: - split out LockBoxLib changes from "OvmfPkg: LockBox: -D SMM_REQUIRE excludes our fake lockbox" [Jordan] OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf | 3 +++ OvmfPkg/Lib

[edk2] [PATCH v5 08/33] OvmfPkg: add DXE_DRIVER for providing TSEG-as-SMRAM during boot-time DXE

2015-11-26 Thread Laszlo Ersek
YPE is not DXE_RUNTIME_DRIVER. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Michael Kinney --- Notes: v5: - list "SmramInternal.h" in "SmmAccess2Dxe.inf" as a source file [Mike] - fix up "PRODUCES" com

[edk2] [PATCH v5 07/33] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

2015-11-26 Thread Laszlo Ersek
PeiEntryPoint() and SmramAccessOpen() respectively, in order to prevent VS20xx from warning about the (otherwise fully intentional) truncation in the UINT8 casts. (Warnings reported by Michael Kinney.) Cc: Michael Kinney Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signe

[edk2] [PATCH v5 14/33] OvmfPkg: PlatformPei: don't allocate fake lockbox if SMM_REQUIRE

2015-11-26 Thread Laszlo Ersek
areas. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Paolo Bonzini Reviewed-by: Jordan Justen --- Notes: v5: - split out PlatformPei changes from "OvmfPkg: LockBox: -D SMM_REQUIRE excludes our fake lockbox" [Jordan]

[edk2] [PATCH v5 15/33] OvmfPkg: LockBox: use SMM stack with -D SMM_REQUIRE

2015-11-26 Thread Laszlo Ersek
;MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf" specifically for this one PEIM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfPkg/OvmfPkgIa32.dsc| 16 OvmfPkg/OvmfPkgIa32X64.dsc | 16 +

[edk2] [PATCH v5 20/33] OvmfPkg: set gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection to FALSE

2015-11-26 Thread Laszlo Ersek
platform that wants to eliminate the call to the hook function [altogether] can set the PCD to FALSE. So for OVMF, I think it makes sense to set this PCD to FALSE in the DSC file. Suggested-by: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek

[edk2] [PATCH v5 21/33] OvmfPkg: import SmmCpuFeaturesLib from UefiCpuPkg

2015-11-26 Thread Laszlo Ersek
erate new FILE_GUID, split off DSC changes, reflow commit message, refresh against SVN r18958] Cc: Paolo Bonzini Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v5: - refresh patch against SVN r18958 ("Add 2 APIs in SmmCpuFeaturesLib&qu

[edk2] [PATCH v5 24/33] OvmfPkg: SmmCpuFeaturesLib: customize state save map format

2015-11-26 Thread Laszlo Ersek
[ler...@redhat.com: reflow commit message, convert patch to CRLF] Cc: Paolo Bonzini Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Michael Kinney --- Notes: v3: - new in v3 OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 1 + Ov

[edk2] [PATCH v5 23/33] OvmfPkg: SmmCpuFeaturesLib: implement SMRAM state save map access

2015-11-26 Thread Laszlo Ersek
-by: Paolo Bonzini [ler...@redhat.com: reflow commit message & fix typo, convert patch to CRLF] Cc: Paolo Bonzini Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Michael Kinney --- Notes: v3: - new in v3 OvmfPkg/Library/Smm

[edk2] [PATCH v5 16/33] OvmfPkg: resolve ReportStatusCodeLib for DXE_SMM_DRIVER modules

2015-11-26 Thread Laszlo Ersek
PiSmmCpuDxeSmm depends on this library class, and it's okay to resolve it generally for all DXE_SMM_DRIVER modules. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X6

[edk2] [PATCH v5 28/33] OvmfPkg: build PiSmmCpuDxeSmm for -D SMM_REQUIRE

2015-11-26 Thread Laszlo Ersek
stance provided by UefiCpuPkg, which is expected to work for most platforms. Cc: Paolo Bonzini Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek [pbonz...@redhat.com: resolve the SmmCpuFeaturesLib class to OVMF's own instance] Contributed-under: TianoCore Co

[edk2] [PATCH v5 10/33] OvmfPkg: pull in the SMM IPL and SMM core

2015-11-26 Thread Laszlo Ersek
GenFds.py BaseTools utility with a build rule for SMM_CORE; we copy the DXE_CORE's rule. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- Notes: v5: - update the commit message to refer to UefiCpuPkg rather than to

[edk2] [PATCH v5 11/33] OvmfPkg: pull in CpuIo2Smm driver

2015-11-26 Thread Laszlo Ersek
TEM_TABLE2 (SMST). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfPkg/OvmfPkgIa32.dsc| 11 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 11 +++ OvmfPkg/OvmfPkgX64.dsc | 11 +++ OvmfPkg/OvmfPkgIa32.f

[edk2] [PATCH v5 05/33] OvmfPkg: PlatformPei: allow caching in AddReservedMemoryBaseSizeHob()

2015-11-26 Thread Laszlo Ersek
the moment. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfPkg/PlatformPei/Platform.h | 3 ++- OvmfPkg/PlatformPei/Platform.c | 9 - OvmfPkg/PlatformPei/Xen.c | 2 +- 3 files changed, 11 insertions(+), 3 deletions(-) di

[edk2] [PATCH v5 27/33] OvmfPkg: build CpuS3DataDxe for -D SMM_REQUIRE

2015-11-26 Thread Laszlo Ersek
PiSmmCpuDxe... | uses <+ ACPI_CPU_DATA from SMRAM Cc: Jordan Justen Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signe

[edk2] [PATCH v5 32/33] OvmfPkg: pull in SMM-based variable driver stack

2015-11-26 Thread Laszlo Ersek
x27;s sake. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- Notes: v2: - hook VarCheckUefiLib into VariableSmm <http://news.gmane.org/find-root.php?message_id=55dfc960.6070...@intel.com> OvmfPkg/OvmfPkgIa32.

[edk2] [PATCH v5 26/33] OvmfPkg: any AP in SMM should not wait for the BSP for more than 100 ms

2015-11-26 Thread Laszlo Ersek
r() should be adjusted instead. Cc: Paolo Bonzini Cc: Jordan Justen Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Michael Kinney --- Notes: v4: - new in v4 OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X6

[edk2] [PATCH v5 12/33] OvmfPkg: AcpiS3SaveDxe: don't fake LockBox protocol if SMM_REQUIRE

2015-11-26 Thread Laszlo Ersek
s built with -D SMM_REQUIRE and includes the real protocol provider, "MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Paolo Bonzini Reviewed-by: Jordan Justen --- OvmfPkg/AcpiS3

  1   2   3   4   5   6   7   8   9   10   >