Re: [edk2] [Patch] Nt32Pkg: Remove old useless bds platform lib.

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Dong, Eric Sent: Monday, August 3, 2015 10:57 AM To: Ni, Ruiyu ruiyu...@intel.com; edk2-devel@lists.01.org Subject: [Patch] Nt32Pkg: Remove old useless bds platform lib. Contributed-under: TianoCore Contribution

Re: [edk2] BaseTools features: multiple workspaces

Path separator in Linux seems to be :. Will you always use ;? Thanks, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Monday, August 3, 2015 11:57 AM To: edk2-devel@lists.01.org Subject: [edk2] BaseTools features:

Re: [edk2] [PATCH 00/15] Separate variable check service to library

Star, The NT32Pkg changes are good. Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Monday, August 17, 2015 4:24 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 00/15] Separate

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

the QemuVideoDxe driver as is make people easier to understand. Thanks, Ray -Original Message- From: Justen, Jordan L Sent: Tuesday, August 18, 2015 1:18 AM To: Ni, Ruiyu ruiyu...@intel.com; edk2-devel@lists.01.org Cc: Ni, Ruiyu ruiyu...@intel.com; Laszlo Ersek ler...@redhat.com Subject: Re

Re: [edk2] [Patch 0/8] Move BltLib to MdeModulePkg and create GraphicsOutputDxe driver

The code was also checked in to below URL: https://github.com/niruiyu/edk2/tree/GOP -Original Message- From: Ni, Ruiyu Sent: Monday, August 17, 2015 9:45 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ruiyu...@intel.com Subject: [Patch 0/8] Move BltLib to MdeModulePkg and create

Re: [edk2] [Patch 0/2] Update License Header to use BSD License

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Dong, Eric Sent: Wednesday, July 29, 2015 4:59 PM To: Ni, Ruiyu ruiyu...@intel.com; Gao, Liming liming@intel.com; edk2-devel@lists.01.org Subject: [Patch 0/2] Update License Header to use BSD License Some code

Re: [edk2] [Patch 0/3] Add UiApp/LegacyBootMaintUiLib used for New BdsDxe code.

Reviewed-by: Ruiyu Ni ruiyu...@intel.com Thanks a lot for filling the gap after new BDS driver is added. -Original Message- From: Dong, Eric Sent: Wednesday, July 29, 2015 4:26 PM To: Ni, Ruiyu ruiyu...@intel.com; Gao, Liming liming@intel.com; edk2-devel@lists.01.org Subject

Re: [edk2] [Patch] UiApp: Move reset menu from frontpage to BMM page.

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Dong, Eric Sent: Thursday, July 30, 2015 4:56 PM To: Ni, Ruiyu ruiyu...@intel.com; edk2-devel@lists.01.org Subject: [Patch] UiApp: Move reset menu from frontpage to BMM page. Contributed-under: TianoCore

Re: [edk2] Library refinement: OptionRomPkg/BltLib

...@redhat.com] Sent: Monday, August 10, 2015 8:35 PM To: Ni, Ruiyu ruiyu...@intel.com Cc: Justen, Jordan L jordan.l.jus...@intel.com; edk2-devel@lists.01.org edk2-de...@ml01.01.org Subject: Re: Library refinement: OptionRomPkg/BltLib On 08/10/15 05:09, Ni, Ruiyu wrote: Jordan and Laszlo, I

Re: [edk2] [PATCH] ShellPkg: Add function comments and refine code format to follow EDKII coding style.

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Wednesday, August 5, 2015 1:53 PM To: edk2-devel@lists.01.org Cc: Ronald Cron ronald.c...@arm.com; Qiu, Shumin shumin@intel.com

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

that boot order override from QEMU and legacy boot still works, we are safe to just use the new BDS. What do you think? -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 4, 2015 7:10 PM To: Ni, Ruiyu ruiyu...@intel.com Cc: edk2-de...@ml01.01.org; David

Re: [edk2] [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Zeng, Star Sent: Monday, August 10, 2015 6:10 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ruiyu...@intel.com Subject: [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case between variable HOB and NV

[edk2] Library refinement: OptionRomPkg/BltLib

Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the refined BltLib.h. The common part of the two versions is: 1. BltLibGetSizes() is removed. Because the size information is

Re: [edk2] Library refinement: OptionRomPkg/BltLib

Just drew a picture to show the current library APIs, V1 and V2 APIs, to help you understand my point. [cid:image001.png@01D0D37C.E78C2030] -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Monday, August 10, 2015 11:10 AM

[edk2] Question regarding the PixelFormat in GOP

Video experts, UEFI spec defines a pixel format (PixelBitMask) in the Graphics Output Protocol chapter. In this pixel format, below structure is used to get the bits information for each color. typedef struct { UINT32 RedMask; UINT32 GreenMask; UINT32 BlueMask; UINT32 ReservedMask; }

Re: [edk2] Question regarding the PixelFormat in GOP

GetPixelElementSize() in the spec returns the bit size not byte size which I think it's a bug of spec. Based on that, I cannot trust that code:) -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, July 20, 2015 5:59 PM To: Ni, Ruiyu; edk2-devel@lists.01.org

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

ng resource >> returned from HotPlug->GetResourcePadding() and the actual occupied >> resource by the attached device. The behavior is incorrect. >> Correct behavior is to reserve the bigger one between the padding >> resource and the actual occupied resource. >>

Re: [edk2] [PATCH] ShellPkg: Fix 'EfiShellExecute' doesn't get command status correctly.

' isn't NULL. Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin <shumin@intel.com> Signed-off-by: Jin Eric <eric@intel.com> Signed-off-by: Jaben Carsey <jaben.car...@intel.com> --- ShellPkg/Application/Sh

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

[mailto:samer.el-haj-mahm...@hpe.com] Sent: Wednesday, October 28, 2015 10:49 PM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: Wang, Sunny (HPS SW) <sunnyw...@hpe.com>; edk2-devel@lists.01.org; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com> Subject: RE: [edk2] [PATCH] MdeModulePkg:

Re: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition.

Sure I will modify the commit message to remove "Edkii". Regards, Ray -Original Message- From: Justen, Jordan L Sent: Tuesday, November 10, 2015 11:14 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Fen

Re: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition.

, November 10, 2015 3:42 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: RE: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition. On 2015-11-09 22:13:18, Ni, Ruiyu wrote: > How about define:

Re: [edk2] [Patch V2 1/5] MdeModulePkg: Add EdkiiPlatformLogo protocol definition.

Jordan, Did you mean you will provide more comments on the 1/5 patch? Regards, Ray -Original Message- From: Justen, Jordan L Sent: Tuesday, November 10, 2015 12:07 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subjec

Re: [edk2] [Patch 11/11] MdeModulePkg: Enable PlatformRecovery in BdsDxe driver

: Tuesday, November 3, 2015 5:22 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Wang, Sunny (HPS SW) <sunnyw...@hpe.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com> Subject: RE: [edk2] [Patch 11/11] MdeModulePkg:

Re: [edk2] [Patch 06/11] MdeModulePkg: Support to expand File device path

;, we need to try both non-removable and removable medias. Regards, Ray -Original Message- From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com] Sent: Tuesday, November 3, 2015 5:56 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

AM To: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org; Fan, Jeff <jeff@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: RE: [edk2] [Patch] MdeModulePkg

Re: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues

To: Ni, Ruiyu <ruiyu...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; Wang, Sunny (HPS SW) <sunnyw...@hpe.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues Hi Ray,

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

[mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, Sunny (HPS SW) Sent: Friday, October 30, 2015 6:14 PM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBo

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerBeforeDefaultBoot to PlatformBootManagerLib

Sunny, Can you use the existing PlatformBootManagerAfterConsole() hook? Thanks, Ray -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Tuesday, October 27, 2015 11:16 PM To: Wang, Sunny (HPS SW) ; edk2-devel@lists.01.org

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

AM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.01.org; Fan, Jeff <jeff@intel.com> Subject: Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug Hi Ray, On Tue, No

Re: [edk2] [PATCH v2] MdeModulePkg: Fix memory leak issues

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sunny Wang Sent: Monday, November 2, 2015 6:53 PM To: edk2-devel@lists.01.org Cc: el...@hpe.com Subject: [edk2] [PATCH v2] MdeModulePkg: Fix

Re: [edk2] PCI: "rejected due to resource confliction"

Laszlo's understanding is correct. The device was rejected because the pci host bridge driver cannot allocate such big resource for the whole PCI device tree. 1/0/0 claims the biggest resource so it was rejected. The PciIo protocol/PCI handle isn't created for that device. Shell doesn't depend

Re: [edk2] [Patch] MdeModulePkg: Fix a PciBusDxe hot plug bug

is good enough. OK I will give response to your questions firstly. Regards, Ray -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Tuesday, November 3, 2015 6:45 PM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: Tian, Feng <feng.t...@intel.com>; Kinne

Re: [edk2] [PATCH v2] MdeModulePkg: Make the BmFindLoadOption function public

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com] Sent: Monday, October 19, 2015 3:46 PM To: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu...@intel.com> Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.co

Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

Sunny, Why do you want to expose this function? Bm* needs to change to EfiBootManager* if it's public. Thanks, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sunny Wang Sent: Monday, October 12, 2015 3:15 PM To: edk2-devel@lists.01.org

Re: [edk2] [PATCH] MdeModulePkg: Make the BmFindLoadOption function public

Sunny, Your bitmask idea works. But I think it might introduce unnecessary complexity. Keeping current implementation is good enough I think. Thanks, Ray -Original Message- From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com] Sent: Tuesday, October 13, 2015 12:15 PM To: Ni, Ruiyu

Re: [edk2] It seems something wrong in GraphicsConsoleControllerDriverStart() when user defined resolution is not supported

Winddy, Thanks for reporting this issue back. I agree with your analysis. Could you please submit a patch to correct this? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of winddy Sent: Tuesday, November 17, 2015 2:19 PM To: edk2-devel

Re: [edk2] [Patch 0/3] Remove the use cases of deprecated functions.

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Thursday, August 27, 2015 10:40 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/3] Remove the use cases of deprecated functions

Re: [edk2] [Patch] SourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated

Reviewed-by: Ruiyu Ni ruiyu...@intel.com -Original Message- From: Fan, Jeff Sent: Wednesday, August 26, 2015 3:44 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ruiyu...@intel.com Subject: [Patch] SourceLevelDebugPkg/DebugTimer: Timer count value 0 not calculated Actually, TimerCycle

Re: [edk2] BDS automatically boot \

Please check OS Recovery and Platform Recovery in the UEFI chapter 3, which may meet your requirement. The problem is we do not have code to implement it yet. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Saturday, September

Re: [edk2] [PATCH] MdeModulePkg: add PartitionName protocol

Zimmermann, There are three options to get the name of a partition: 1. Directly use BlockIo interface to access the GPT meta data. 2. Group the above code into a library 3. Group the above code into a driver and expose the partition name as a protocol. I really do not think we need to go to

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

pec. > Thanks, > > Andrew Fish > > >> -Original Message- > >> From: Carsey, Jaben [mailto:jaben.car...@intel.com > <mailto:jaben.car...@intel.com>] > >> Sent: Tuesday, September 15, 2015 9:43 AM > >> To: Dailey, Jim; Ni, Ruiyu; edk

[edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

All, UEFI Shell scandalizes the help message in spec level so that a standalone UEFI shell application can never get "-?" switch, instead the Shell core (interpreter) detects the "-?" and finds .MAN file for that shell application in certain spec defined paths, then show the help extracted from

Re: [edk2] [PATCH] MdeModulePkg: PciBusDxe: Properly exit PCI function loops early if the device is not a multifunction device.

On 2015/9/15 4:19, Samer El-Haj-Mahmoud wrote: From: "Shifflett, Joseph" When looping through all PCI functions, code should not look for functions 1-7 if function 0 is not present or if function 0 indicates the device is not multifunction. Prior to this fix, the

Re: [edk2] [Patch 1/5] MdeModulePkg: Move OEMBadging protocol from IntelFrameworkModulePkg

er 29, 2015 12:08 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Fan, Jeff <jeff@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com> Subject: RE: [edk2] [Patc

Re: [edk2] [PATCH] MdeModulePkg: PciBusDxe: Properly exit PCI function loops early if the device is not a multifunction device.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Shifflett, Joseph [mailto:joseph.shiffl...@hpe.com] Sent: Wednesday, September 16, 2015 3:06 AM To: Ni, Ruiyu <ruiyu...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-dev

Re: [edk2] [PATCH v3 1/1] MdeModulePkg: exit pci function loops early if device is not multi-function

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shifflett, Joseph Sent: Wednesday, September 30, 2015 8:01 AM To: edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com> Subject: [

Re: [edk2] [Patch 1/5] MdeModulePkg: Move OEMBadging protocol from IntelFrameworkModulePkg

<liming@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Tian, Feng <feng.t...@intel.com>; Fan, Jeff <jeff@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming <liming@intel.com> Subject: RE: [edk2] [Patch 1/5] Md

Re: [edk2] [PATCH 0/2] Do not assume perf entry count has no change

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, September 29, 2015 3:15 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Do not assume perf entry count has no

Re: [edk2] BUG: UEFI won't recognize PCI busses which don't sit under a bridge

Shubha, PciBus only scan in a depth-first-search algorithm from the bus reported by PciHostBridgeResourceAllocation->StartBusEnumeration (RootBridgeHandle). Normally the bus reported out is 0, so all devices behind the bridges in BUS 0 are found and reported, so we can get the PciIo instances

Re: [edk2] [PATCH v4 01/10] DuetPkg: SataControllerDxe: fix typo in "DisqulifiedModes"

On 2015/9/19 2:41, Laszlo Ersek wrote: Ray, On 09/16/15 04:57, Laszlo Ersek wrote: Cc: Alexander Graf <ag...@suse.de> Cc: Reza Jelveh <reza.jel...@tuhh.de> Cc: Jordan Justen <jordan.l.jus...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Hannes Reinecke <h...@su

Re: [edk2] Proposal to let standalone UEFI shell application carry help inside .EFI instead of in .MAN file

So that means I can start to create patch based on my proposal? Any concerns? Thanks, Ray -Original Message- From: Rothman, Michael A Sent: Wednesday, September 16, 2015 9:20 AM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: Carsey, Jaben <jaben.car...@intel.com>; Andrew Fish <

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

Jaben, you mean to change VERSION_STRING = 1.0 to VERSION_STRING = 1.1 ? Regards, Ray -Original Message- From: Carsey, Jaben Sent: Thursday, December 3, 2015 1:27 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

g.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Cc: edk2-devel@lists.01.org Subject: RE: [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver Ray, I tried to build this module into a platform, and I am getting functio

Re: [edk2] [Patch V4] MdeModulePkg: Add PciSioSerialDxe driver

Mike, Please check the updated patch which adopted your comments. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, December 9, 2015 2:36 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

CMOS address 0x32? Regards, Ray -Original Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Friday, November 20, 2015 10:56 PM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: 'Paolo Bonzini' <pbonz...@redhat.com>; 'edk2-devel@lists.01.org' <edk2-de...@ml01.01.org&g

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

rrent patch, in this thread. As I understand, > the PCD can be given a default value that would trigger the behavior > proposed in this patch. > > Thanks > Laszlo > >> >> Mike >> >> >>> -Original Message- >>> From: Paolo B

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

, 2015 1:54 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Qiu, Shumin <shumin@intel.com> Subject: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform In multiple root bridge platforms, different root bridges may share the same segmen

Re: [edk2] [Patch V3] ShellPkg/mm: Fix mm to support multiple root bridge platform

] On Behalf Of Ruiyu Ni Sent: Tuesday, December 8, 2015 1:13 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: [edk2] [Patch V3] ShellPkg/mm: Fix mm to support multiple root bridge platform In multiple root brid

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

Yes. Regards, Ray -Original Message- From: Kinney, Michael D Sent: Thursday, December 10, 2015 9:33 AM To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com&

Re: [edk2] [Patch] MdeModulePkg: Add PciSioSerialDxe driver

Mike, The algorithm to calculate the baud rate is revised based on your offline comments. Could you please check whether it's ok? Regards, Ray -Original Message- From: Ni, Ruiyu Sent: Thursday, December 10, 2015 10:21 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

, 2015 3:49 AM To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com>; Scott Duplichan <sc...@notabs.org>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Zeng,

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

r19177 check in breaks the build. Seems like the "#include" is missing for many newly supported protocols. I verified the checked r19180 after rolling back the r19177. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

more than 100 build errors: gEfiBdsArchProtocolGuid: undeclared identifier ... Regards, Ray -Original Message- From: Justen, Jordan L Sent: Thursday, December 10, 2015 2:17 PM To: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lis

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, December 10, 2015 7:04 PM To: Ni, Ruiyu <ruiyu...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>; Zeng, Star <star.z...@intel.com&

Re: [edk2] [PATCH v2 13/20] Nt32Pkg: Convert all .uni files to utf-8

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Justen, Jordan L Sent: Saturday, December 5, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [PATCH v2 13/20] Nt32Pkg

Re: [edk2] [Patch] MdePkg: Add BasePciSegmentLibPciExpress library.

; 0xFF. I think to avoid platform boot hang, we may just create the BasePciSegmentLibPciExpress instance. What's your opinion? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Saturday, December 12, 2015 1:08 PM To:

Re: [edk2] [Patch V2 2/3] MdeModulePkg: Add PciHostBridgeLibNull

sure I will. The patch was there for a moment before all UTF8 conversion so I forgot to convert to UTF8 when sending the patch to public. Regards, Ray -Original Message- From: Justen, Jordan L Sent: Friday, January 8, 2016 5:45 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel

Re: [edk2] [Patch V2 1/3] MdeModulePkg: Add new library class PciHostBridgeLib

Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> Cc: Feng Tian <feng.t...@intel.com> Cc: Jeff Fan <jeff@intel.com> Cc: Michael Kinney <michael.d.kin...@intel.com> # Conflicts: # MdeModulePkg/MdeModulePkg.dec Signed-off-by: Ruiyu Ni <ruiyu...@in

Re: [edk2] [PATCH] ShellPkg: Refine the code format.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Saturday, December 19, 2015 7:43 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Sh

Re: [edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, December 21, 2015 4:41 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] Nt32Pkg: Fix VS2015 Build Failure

Re: [edk2] [PATCH v2 3/4] ShellPkg: Fix memory leak in ShellProtocol.

foNode->Handle, FileList, ShellInfoNode, MapName); > + EfiShellClose(ShellInfoNode->Handle); + ShellInfoNode->Handle = NULL; //*** Regards, Ray -Original Message- From: Carsey, Jaben Sent: Tuesday, December 22, 2015 9:23 AM To: Qiu, Shumin <shumin

Re: [edk2] [PATCH v2] ShellPkg: Fix memory leak when running Shell script.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Please separate the patch to two commits when you check in: The change to DoShellPrompt() is to fix the TAB-auto-completion memory leak. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumi

Re: [edk2] [Patch 2/8] MdeModulePkg: Add the missing Library uni files of ImageDecode instances

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 23, 2015 5:57 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 2/8] MdeModulePkg: Add the missing Libra

Re: [edk2] [Patch 8/8] IntelFrameworkModulePkg: Remove the undefined PCD help and prompt strings

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 23, 2015 5:57 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 8/8] IntelFrameworkModulePkg:

Re: [edk2] [Patch V2] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

prefer to keep the current fix because it makes the code simpler to read (Your change needs to hook ReadyToBoot event and hooks AcpiTable change in ReadyToBoot event callback). Regards, Ray -Original Message- From: Zeng, Star Sent: Tuesday, December 22, 2015 12:43 PM To: Ni, Ruiyu

Re: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak issues in Shell.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Monday, December 21, 2015 4:43 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin <shumin@intel.com> Subject: [edk2

Re: [edk2] [PATCH 0/3] ShellPkg: Fix memory leak in 'map' command.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Thursday, December 24, 2015 3:30 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin <shumin@intel.com> Subject: [edk2

Re: [edk2] [PATCH] ShellPkg: Free memory in 'BufferToFreeList' before return from RunShellCommand.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Qiu, Shumin Sent: Wednesday, December 23, 2015 3:36 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel

Re: [edk2] [Patch 1/3] DuetPkg: Fix GCC error to avoid the duplicated global variables in EfiLdr

Reviewed-by: ruiyu...@intel.com Thanks, Ray > 在 2015年12月16日，下午6:18，Liming Gao 写道： > > Move the global variable definitions into source code instead of head filer. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

the value in CMOS location. So we have to always save the century value in CMOS. Regards, Ray -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, November 20, 2015 6:17 AM To: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu

Re: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue

Scott, The UEFI Windows 7 is fresh installed. Could you please tell me how to check whether a platform turns on the RTC alarm? Thanks, Ray > 在 2015年11月20日，10:49，Scott Duplichan <sc...@notabs.org> 写道： > > Ni, Ruiyu [mailto:ruiyu...@intel.com] wrote: > > ]Sent: Thursday, No

Re: [edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

I am ok for the code logic. Reviewed-by: ruiyu...@intel.com Thanks, Ray > 在 2016年6月3日，下午3:23，Gary Li 写道： > > Prevent the BmRepairAllControllers routine in an infinite loop > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Li

Re: [edk2] [PATCH] Nt32Pkg/PlatformBootManagerLib: zero EFI_GRAPHICS_OUTPUT_BLT_PIXEL.Reserved

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, May 26, 2016 7:04 AM >To: edk2-devel-01 <edk2-de...@ml01.01.org> >Cc: Andrew Fish <af...@apple.com>; Justen, Jordan L >&l

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Fix for wrong data updated into MemoryTypeInformation variable

RamDiskSizeInPages. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> I will think about how to fix that corner case. Regards, Ray >-Original Message- >From: Sunny Wang [mailto:sunnyw...@hpe.com] >Sent: Monday, June 20, 2016 4:03 PM >To: edk2-devel@lists.01.org >Cc: el...@hpe.

Re: [edk2] [PATCH v2] ShellPkg: Fix 'echo' cannot display the special characters correctly.

22, 2016 11:17 PM To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [PATCH v2] ShellPkg: Fix 'echo' cannot display the special characters correctly. Very nice. I like this much

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Fix for wrong data updated into MemoryTypeInformation variable

Sunny, Under what circumstance the memory usage statistics don't count the allocation? Regards, Ray >-Original Message- >From: Sunny Wang [mailto:sunnyw...@hpe.com] >Sent: Monday, June 20, 2016 4:03 PM >To: edk2-devel@lists.01.org >Cc: el...@hpe.com; Ni, Ruiyu <ruiyu...

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Keep HTTP boot mounted RAM disk

.org >Cc: el...@hpe.com; Ni, Ruiyu <ruiyu...@intel.com>; Sunny Wang ><sunnyw...@hpe.com> >Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Keep HTTP boot mounted RAM >disk > >There may be some use cases which need to keep HTTP boot mounted RAM disk >(downlo

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Skip registering BootManagerMenu if its FFS is not found

pe.com] >Sent: Monday, June 20, 2016 5:44 PM >To: edk2-devel@lists.01.org >Cc: el...@hpe.com; Ni, Ruiyu <ruiyu...@intel.com>; Sunny Wang ><sunnyw...@hpe.com> >Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Skip registering >BootManagerMenu if its FFS is not foun

[edk2] This text was added by using code

Jiewen, Could you please remove the "EFIAPI" for SetVariableCheckHandlerMor()? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of jiewen yao Sent: Friday, January 15, 2016 2:24 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

Marcel, Please see my reply embedded below. On 2016-02-02 19:07, Laszlo Ersek wrote: On 02/01/16 16:07, Marcel Apfelbaum wrote: On 01/26/2016 07:17 AM, Ni, Ruiyu wrote: Laszlo, I now understand your problem. Can you tell me why OVMF needs multiple root bridges support? My understanding

Re: [edk2] [Patch] BaseTools: Update BaseTools to pass VS2015 compiler

Why keep the code as below: - UInt32 curAndLenPrice; - COptimal *opt; + // UInt32 curAndLenPrice; + // COptimal *opt; I think we should completely remove them instead of just commenting them. Several similar cases in your patch are found.

Re: [edk2] [PATCH 0/3] Minor update to the Data parameter for GetVariable()

Star, Should we also update the implementation to only copy the data out when Data is not NULL? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Wednesday, January 27, 2016 4:52 PM To: edk2-devel@lists.01.org

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

that the VM guest needs to be like a high-end server? This may help me to think about the possible solution to your problem. Regards, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, January 26, 2016 11:10 AM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: e

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

To: mar...@redhat.com Cc: Ni, Ruiyu <ruiyu...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Tian, Feng <feng.t...@intel.com>; Fan, Jeff <jeff@intel.com> Subject: Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe dr

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

To: Ni, Ruiyu <ruiyu...@intel.com>; Marcel Apfelbaum <mar...@redhat.com> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Tian, Feng <feng.t...@intel.com>; Fan, Jeff <jeff@intel.com>; Marcel Apfelbaum (GMail address) <marcel.apfelb...@gmai

Re: [edk2] [RFC PATCH v2] MdeModulePkg/PciHostBridge: Don't assume resources are completely missing

>-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, February 26, 2016 8:26 AM >To: edk2-devel-01 <edk2-de...@ml01.01.org> >Cc: Ni, Ruiyu <ruiyu...@intel.com> >Subject: [RFC PATCH v2] MdeModulePkg/PciHostBridge: Don't assume resources ar

Re: [edk2] [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in Editor.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Qiu, Shumin >Sent: Friday, February 26, 2016 2:54 PM >To: edk2-devel@lists.01.org >Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben ><jaben.car...@intel.com>; Ni, Ruiyu &

Re: [edk2] [PATCH 01/17] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

Thanks, Ray >> 在 2016年2月27日，下午6:17，Laszlo Ersek <ler...@redhat.com> 写道： >> >> On 02/27/16 03:13, Ni, Ruiyu wrote: >> Basically I don't agree to add a CFG space range field. >> See embedded reply in below. >> >> Regards, >> Ray >

Re: [edk2] [Patch V4 3/3] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

Laszlo, I just repost the 3rd patch. Please let me know if it doesn't follow the tradition. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Thursday, February 25, 2016 8:57 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com>; Benjamin He

Re: [edk2] [PATCH 1/2] MdePkg: Add EFI RAM Disk Protocol definitions

Hao, The HTTP boot related code depends on this header file. Could you please check in this ASAP? Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu >Sent: Thursday, February

  1   2   3   4   5   6   7   8   9   10   >