Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

It’s an implementation limitation. All page attributes will be filtered out before calling CPU arch protocol to update the attributes (Gcd.c). From: Yao, Jiewen Sent: Thursday, September 14, 2017 4:38 PM To: Laszlo Ersek <ler...@redhat.com>; Wang, Jian J <jian.j.w...@intel.com> Cc

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

l-boun...@lists.01.org] On Behalf Of Wang, Jian J Sent: Friday, September 15, 2017 8:15 AM To: Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Yao, Jiewen <jiewen@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Justen, Jordan L <jorda

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

I found there's a logic hole in code. A new patch will be sent out. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Monday, September 18, 2017 11:09 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

Jiewen, Any comments on this patch? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Tuesday, September 19, 2017 2:10 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Laszlo Ersek

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync iss

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

Ok, thanks for the review. -Original Message- From: Wu, Hao A Sent: Friday, September 22, 2017 11:21 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Anthony PERARD <anthony.per...@citrix.com> Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build err

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix out-of-sync issue in GCD

Sure. I'll submit a new patch after enough validation. Thanks for the review. -Original Message- From: Zeng, Star Sent: Wednesday, September 20, 2017 5:30 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>;

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

org] On Behalf Of Wang, Jian J Sent: Thursday, September 14, 2017 9:17 AM To: Laszlo Ersek <ler...@redhat.com> Cc: Dong, Eric <eric.d...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-devel@lists.01.org; Yao, Jiewen <jiewen@intel.com>; Wolman, Ayelle

Re: [edk2] [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core.

See my comments start with [Jian] below. -Original Message- From: Justen, Jordan L Sent: Thursday, September 14, 2017 1:28 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com>; Z

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

] Sent: Thursday, September 14, 2017 7:35 AM To: Wang, Jian J <jian.j.w...@intel.com> Cc: edk2-devel@lists.01.org; Justen, Jordan L <jordan.l.jus...@intel.com>; Dong, Eric <eric.d...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet <aye

Re: [edk2] [PATCH 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM mode code.

I'll use the tool to check the format. For the macro, it's for readability purpose. How's the library replacement suggestion from Laszlo? -Original Message- From: Justen, Jordan L Sent: Thursday, September 14, 2017 1:32 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@li

Re: [edk2] [PATCH 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM mode code.

Thanks for the comments. See my comment start with [Jian] below. -Original Message- From: Johnson, Brian (EXL - Eagan) [mailto:brian.john...@hpe.com] Sent: Thursday, September 14, 2017 12:34 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: jus...@ml01.01.org

Re: [edk2] [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core.

, September 14, 2017 12:33 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: jus...@ml01.01.org; Dong, Eric <eric.d...@intel.com>; kin...@ml01.01.org; Justen, Jordan L <jordan.l.jus...@intel.com>; wol...@ml01.01.org; Yao, Jiewen <jiewen@intel.

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

gDS-> SetMemorySpaceCapabilities() can change the Capability at any time. But I'm not sure about any side-effect of it. -Original Message- From: Zeng, Star Sent: Thursday, September 14, 2017 6:17 PM To: Laszlo Ersek <ler...@redhat.com>; Wang, Jian J <jian.j.w...@intel.com>

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

Thanks for catching it. Patch is on the way. -Original Message- From: Anthony PERARD [mailto:anthony.per...@citrix.com] Sent: Thursday, September 21, 2017 11:05 PM To: Wang, Jian J <jian.j.w...@intel.com> Cc: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org; Kinney

Re: [edk2] [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core.

- From: Justen, Jordan L Sent: Thursday, September 14, 2017 2:34 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek <ler...@red

Re: [edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

Sure. I'll change them to functions. -Original Message- From: Justen, Jordan L Sent: Thursday, September 14, 2017 1:50 PM To: Wang, Jian J <jian.j.w...@intel.com>; Laszlo Ersek <ler...@redhat.com> Cc: edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>;

Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

Got it. Thank you very much for the advice and information. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 10, 2017 4:13 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Mic

Re: [edk2] [PATCH 2/5] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

Ok. I'll change it to follow required coding style. Thanks for catching it. > -Original Message- > From: Dong, Eric > Sent: Friday, October 13, 2017 9:27 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.c

Re: [edk2] [PATCH 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

You're right. "BIT3 | BIT2" should be enclosed by parentheses. Thanks for catching this issue. > -Original Message- > From: Dong, Eric > Sent: Friday, October 13, 2017 9:24 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Ya

[edk2] ASSERT in QemuVideoDxe driver during reset

pu driver. But I think there's a good reason to put code there before. Thanks, Wang, Jian J ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ASSERT in QemuVideoDxe driver during reset

er ideas? Thanks, Wang, Jian J From: Yao, Jiewen Sent: Wednesday, September 06, 2017 7:17 PM To: Laszlo Ersek <ler...@redhat.com>; Wang, Jian J <jian.j.w...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com> Cc: edk2-devel@lists.01.org; Kinney, Michael D <mic

[edk2] [PATCH 1/4] MdeModulePkg/Core: Implement NULL pointer detection in EDK-II Core.

e Contribution Agreement 1.1 Signed-off-by: Wang, Jian J <jian.j.w...@intel.com> --- MdeModulePkg/Core/Dxe/DxeMain.inf| 3 +- MdeModulePkg/Core/Dxe/Mem/Page.c | 21 ++ MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c| 47 +

[edk2] [PATCH 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM mode code.

Laszlo Ersek <ler...@redhat.com> Cc: Justen, Jordan L <jordan.l.jus...@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com> Cc: Wolman, Ayellet <ayellet.wol...@intel.com> Suggested-by: Wolman, Ayellet <ayellet.wol...@intel.com> Contributed-under: TianoCore Contri

[edk2] [PATCH 3/4] IntelFrameworkModulePkg/Csm: Update CSM code to temporarily bypass NULL pointer detection if enabled.

Wolman, Ayellet <ayellet.wol...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang, Jian J <jian.j.w...@intel.com> --- .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 10 +++- .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 18 +++ .../Csm/Bios

[edk2] [PATCH 4/4] OvmfPkg/QemuVideoDxe: Update QemuVideoDxe driver to bypass NULL pointer detection if enabled.

.wol...@intel.com> Suggested-by: Wolman, Ayellet <ayellet.wol...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang, Jian J <jian.j.w...@intel.com> --- OvmfPkg/QemuVideoDxe/Driver.c | 15 ++- OvmfPkg/QemuVideoDxe/Qemu.h

[edk2] [PATCH 0/4] Implement NULL pointer detection feature for special pool

in page 0 needs to enable this page temporarily in advance and disable it afterwards. PcdNullPointerDetectionPropertyMask is used to control and elaborate the use cases. For example, BIT7 of this PCD must be set for Windows 7 boot on Qemu if BIT0 set; or boot will fail. Wang, Jian J (4

Re: [edk2] [PATCH 0/4] Implement NULL pointer detection feature for special pool

boot on Qemu if BIT0 set; or boot will fail. Wang, Jian J (4): Implement NULL pointer detection in EDK-II Core. Implement NULL pointer detection for SMM mode code. Update CSM code to temporarily bypass NULL pointer detection if enabled. Update QemuVideoDxe driver to bypass NULL pointer

Re: [edk2] [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

of potential attributes overridden issue, which also exists in other part of code. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, September 22, 2017 11:29 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > C

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

Good catch. Thanks for the feedback. > -Original Message- > From: Yao, Jiewen > Sent: Monday, September 25, 2017 4:51 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@i

Re: [edk2] [PATCH v2 1/6] MdeModulePkg/MdeModulePkg.dec: Add NULL pointer detection PCD

Sure. Thanks for the feedback. > -Original Message- > From: Zeng, Star > Sent: Monday, September 25, 2017 4:01 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@redh

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix assert issue on IA32 platform

Mike, Thanks for the feedback. I'll update the patch as what you suggested. And if no more other comments, I'll check in the updated one today (or tonight). Jian > -Original Message- > From: Kinney, Michael D > Sent: Saturday, September 30, 2017 12:27 AM > To: Wang, Jian

Re: [edk2] [patch] UefiCpuPkg/CpuDxe: Add missing function description comments

Thanks for adding the comment. It look good to me. > -Original Message- > From: Bi, Dandan > Sent: Monday, September 25, 2017 2:01 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Wang, Jian J <jian.j.w...@intel.com> > Subject:

Re: [edk2] [PATCH v3 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround

Thanks for the feedback. Please see my comments below. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:35 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ers

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

>From this perspective, you're right. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 1:10 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@r

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

Please see my comments inline below. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:24 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@redh

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

Clearing this block of memory has nothing to do with NULL pointer detection. I'm not sure the extra check is necessary. > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 11:31 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

of feature will be limited in such case. From: Yao, Jiewen Sent: Monday, August 28, 2017 11:10 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/2] Implement NULL pointer detection feature Thank you to enable this feature. I have 2 comments,

[edk2] [PATCH 1/2] Implement NULL pointer detection for EDK-II Core

om> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang, Jian J <jian.j.w...@intel.com> --- MdeModulePkg/Core/Dxe/DxeMain.inf| 3 ++- MdeModulePkg/Core/Dxe/Mem/Page.c | 5 +++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 1 + Mde

[edk2] [PATCH 2/2] Implement NULL pointer detection for EDK-II SMM Core and driver

ntel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang, Jian J <jian.j.w...@intel.com> --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 12 UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c| 25 - UefiCpuPkg/PiSmmCpu

[edk2] [PATCH 0/2] Implement NULL pointer detection feature

This patch is the implementation of NULL pointer detection feature, which is one of the small features of Special Pool. Wang, Jian J (2): Implement NULL pointer detection for EDK-II Core Implement NULL pointer detection for EDK-II SMM Core and driver MdeModulePkg/Core/Dxe/DxeMain.inf

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

make it dynamic. b) Add PEI and post DXE phase support. Since PEI phase requirement has been covered by following new bug tracker, it won't be included by current patch update but a separate one. Changes for Post DXE phase will be included. https://bugzilla.tianocore.org/show_bug.cgi?id=

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

rate one. https://bugzilla.tianocore.org/show_bug.cgi?id=687 c) CSM code lines which access page 0 will be enclosed by and then code. This is subject to change if critical performance issue is found. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang,

Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, October 09, 2017 11:56 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > <ayellet.wol...@intel.com>; Yao, Jiewen <jiew

Re: [edk2] [PATCH v4 5/6] IntelFrameworkModulePkg/Csm: Add code to bypass NULL pointer detection

Thanks for catching this issue. Patch has been sent out. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 12, 2017 5:30 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <mi

Re: [edk2] [PATCH v4 0/6] Add NULL pointer detection feature

d code to bypass NULL pointer detection > OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM > installing > > Wang, Jian J (1): > MdeModulePkg/MdeModulePkg.dec,.uni: Add NULL pointer detection PCD > > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

Yes, we can. But that also means public interfaces changes, which might affect internal/external users. Any formal procedure required to make such kind of changes? From: Yao, Jiewen Sent: Wednesday, October 18, 2017 1:07 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.

Re: [edk2] [PATCH v5 5/7] MdeModulePkg/DxeCore: Implement heap guard feature for UEFI

) & PcdGet64(PcdHeapGuardPoolType) == 0); ASSERT (PcdGet64(PcdDxeNxMemoryProtectionPolicy) & PcdGet64(PcdHeapGuardPageType) == 0); Thanks, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [PATCH v5 5/7] MdeModulePkg/DxeCore: Implement heap guard feature for UEFI

Thanks for the feedback. I'll add comment to explain more. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Sunday, November 12, 2017 5:51 AM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org; Kinney, Mic

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

t: Friday, November 10, 2017 8:24 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>; Yao, Jiewen > <jiewen@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Matt > Fleming <m...@codebluep

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

I tried this workaround and there're no failure in booting Fedora 26 and Windows server 2016 now. If no objection, I'll merge it into new version of this patch. > -Original Message- > From: Wang, Jian J > Sent: Wednesday, November 15, 2017 3:37 PM > To: Zeng, Star <star

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Good catch. I’ll add them. Thanks. From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Saturday, November 25, 2017 9:28 PM To: Wang, Jian J <jian.j.w...@intel.com>; Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.c

Re: [edk2] [PATCH v2 2/8] MdeModulePkg/CpuExceptionHandlerLib.h: Add a new API

. But at least in my current implementation, we can just put it in UefiCpuPkg. I’m just not sure of any future impact. From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Saturday, November 25, 2017 9:18 PM To: Wang, Jian J <jian.j.w...@intel.com>; Yao, Jiewen <jiewen@intel.co

Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map

Sorry just see this email. I just replied another one. Great to know it works for both of us. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 22, 2017 5:05 PM > To: Zeng, Star <star.z...@intel.com>; Wang, Jian J <

Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map

r all your valuable comments and test efforts on this series and all others. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 21, 2017 9:38 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subj

Re: [edk2] [PATCH v2 2/8] MdeModulePkg/CpuExceptionHandlerLib.h: Add a new API

Good idea. I think it should be defined in also in following file besides the new API MdeModulePkg\Include\Library\CpuExceptionHandlerLib.h > -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 12:08 PM > To: Wang, Jian J <jian.j.w...@intel.com>

Re: [edk2] [PATCH v2 0/8] Implement stack guard feature

I did test it with disabled. I'll try it enabled. Do you think this feature should be enabled by default or not, just like the PcdCpuSmmStackGuard? > -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 11:48 AM > To: Wang, Jian J <jian.j.w...@intel.c

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

> -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 1:50 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; > Kinney, Michael D &l

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

will be overwritten). If we want AP to initialize interrupt and exception individually, maybe we should let AP call InitializeCpuInterruptHandlers() instead. > -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 2:16 PM > To: Wang, Jian J <jian.j.w...@intel.com>; e

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

nal Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 2:25 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > <eric.d...@intel.com>; Zeng, Star <star.z...@

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Thursday, November 23, 2017 1:59 PM > To: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > <eric.d...@intel.com>; Zeng, Star <star.z...@int

Re: [edk2] [PATCH v2 8/8] UefiCpuPkg/CpuDxe: Initialize stack switch for MP

Hi, > -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 23, 2017 12:14 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@redhat.com>; > Kinney, M

Re: [edk2] [PATCH v2 8/8] UefiCpuPkg/CpuDxe: Initialize stack switch for MP

Status = InitializeCpuExceptionStackSwitchHandlers ( + + ); + } + return Status; } > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, > Jian J > Sent: Thursday, November 23, 2017 1:04 PM > To: Yao, Jiewe

Re: [edk2] [PATCH 0/2] Enable page table write protection

only after initializing the table content. > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, November 29, 2017 5:16 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Enable page table write prot

Re: [edk2] [PATCH 0/2] Enable page table write protection

There's already issue found. So there must be v2. Please wait for it. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 29, 2017 8:39 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subjec

Re: [edk2] [PATCH 0/2] Enable page table write protection

: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Enable page table write protection > > Is this code in CPU driver? > > thank you! > Yao, Jiewen > > > > 在 2017年11月29日，下午6:24，Wang, Jian J <jian.

Re: [edk2] [PATCH 0/2] Enable page table write protection

. Maybe we just need to add a PCD to turn on/off it just in case. Do you have any ideas in mind? > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, November 29, 2017 9:35 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subject:

Re: [edk2] [PATCH 0/2] Enable page table write protection

age- > From: Yao, Jiewen > Sent: Thursday, November 30, 2017 8:52 AM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/2] Enable page table write protection > > -- whenever you're trying to mark one page used as pag

Re: [edk2] [PATCH 0/2] Enable page table write protection

2017 9:36 AM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/2] Enable page table write protection > > Can you just allocate 1 more page for split? > If new one need split, you can just use the additional page

Re: [edk2] [PATCH] MdeModulePkg/Core: Merge memory map after filtering paging capability

Make sense. Thanks for the comment. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 28, 2017 2:21 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Zeng

Re: [edk2] [PATCH v2 7/8] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

l-boun...@lists.01.org] On Behalf Of Wang, > Jian J > Sent: Thursday, November 23, 2017 2:44 PM > To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Dong, Eric > <eric.d...@intel.com>; Zeng, Star <

Re: [edk2] [PATCH 0/2] Enable page table write protection

vember 30, 2017 9:59 AM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/2] Enable page table write protection > > Clarify my word below: > > Can you just predict and pre-allocate additional pages for future split i

Re: [edk2] [PATCH 0/2] Enable page table write protection

> (core) CoreAllocatePages() -> -> (core)ApplyMemoryProtectionPolicy() -> -> (cpu)SetMemoryAttributes() This has caused a problem in protecting page tables. Maybe your idea can help to solve it too. > -----Original Messa

Re: [edk2] [PATCH v3 07/11] ArmPkg/ArmExceptionLib: Add implementation of new API

Sure. Thanks for the feedback. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, December 04, 2017 9:59 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindh...@linaro.org

Re: [edk2] [PATCH v3 00/11] Implement stack guard feature

> -Original Message- > From: Yao, Jiewen > Sent: Tuesday, December 05, 2017 10:03 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v3 00/11] Implement stack guard feature > > Good enhancement. I think it resolved my compat

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

05, 2017 10:27 AM > To: Wang, Jian J <jian.j.w...@intel.com>; Zeng, Star <star.z...@intel.com>; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject: RE: [edk2] [PATCH v2 0/4] Enable page table wri

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

it in a JTAG debugger manually. > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, December 05, 2017 10:32 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com> > Subject: RE: [edk2] [PATCH v2 0/4] Enab

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable

Got it. Thanks for the feedback. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, December 12, 2017 5:27 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.

Re: [edk2] [PATCH v5] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

can't confirm above analysis yet. I think you're more familiar with kernel source than us. Maybe you could help to take a look. Thanks, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, November 10, 2017 8:24 PM > To: Wang, Jian

Re: [edk2] [PATCH v6 1/2] MdeModulePkg/DxeCore: Filter out all paging capabilities

be not necessary to validate all OS boot again. But if you want and have time, you can do it anyway. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 21, 2017 4:23 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@list

Re: [edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

to enable image protection which won't take into effect actually. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 21, 2017 4:32 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jie

Re: [edk2] [PATCH] MdeModulePkg/Core: Fix build error with old Visual Studio

Yes, MACRO should be better. It will be updated in v2 patch. Thanks for the comments. > -Original Message- > From: Zeng, Star > Sent: Monday, November 20, 2017 1:04 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d..

Re: [edk2] [PATCH v2] MdeModulePkg/Core: Fix build error with old Visual Studio

Sure. Thanks. > -Original Message- > From: Zeng, Star > Sent: Monday, November 20, 2017 2:16 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Bi, Dandan <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; > Zeng, Star

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: Fix an assert issue in pool free

Sure. Thanks for reminding. > -Original Message- > From: Zeng, Star > Sent: Monday, November 20, 2017 10:54 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Wu, Hao A <hao.a...@intel.com>;

Re: [edk2] [PATCH v6 1/2] MdeModulePkg/DxeCore: Filter out all paging capabilities

, if no one else has objections, I'll update the code. > -Original Message- > From: Yao, Jiewen > Sent: Friday, November 17, 2017 9:37 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Laszlo Ersek <

Re: [edk2] [PATCH v6 3/7] UefiCpuPkg/CpuDxe: Reduce debug message

I agree. Thanks for the comment. > -Original Message- > From: Zeng, Star > Sent: Friday, November 17, 2017 10:31 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@in

Re: [edk2] [PATCH 2/3] ShellPkg: Fix misuses of AllocateCopyPool

o: Ni, Ruiyu <ruiyu...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Bi, Dandan <dandan...@intel.com> > Subject: RE: [PATCH 2/3] ShellPkg: Fix misuses of AllocateCopyPool > >

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

intel.com>; Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: 答复: [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support Jian, For example, you could use the glob

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

need to take care of PEI code. The global can be just defined in DxeException.c file. Thanks, Jian From: Yao, Jiewen Sent: Monday, November 06, 2017 9:54 AM To: Wang, Jian J <jian.j.w...@intel.com> Cc: Fan Jeff <vanjeff_...@hotmail.com>; Kinney, Michael D <michael.d.kin...@intel.c

Re: [edk2] [PATCH 2/3] ShellPkg: Fix misuses of AllocateCopyPool

Ruiyu, Thanks for the comments. > -Original Message- > From: Ni, Ruiyu > Sent: Friday, November 03, 2017 4:23 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Bi, Dandan <dandan...@intel.

Re: [edk2] [PATCH 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

Star, Thanks for the comments. It's a good suggestion. I didn't know ReallocatePool() can do that. Thanks Jian > -Original Message- > From: Zeng, Star > Sent: Friday, November 03, 2017 5:14 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > C

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Thanks for the review. And I agree that GCD.SetMemoryAttributes should be used all the time in DxeCore. Let's fix it in another patch. > -Original Message- > From: Zeng, Star > Sent: Monday, November 06, 2017 5:16 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel

Re: [edk2] [PATCH 2/2] CryptoPkg/BaseCryptLib: Fix mismatched memory allocation/free

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Long, Qin > Sent: Tuesday, October 31, 2017 4:40 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; ler...@redhat.com; Wang, Jian J > <jian.j.w...@intel.co

Re: [edk2] [PATCH 1/2] CryptoPkg/BaseCryptLib: Fix buffer overflow issue in realloc wrapper

9 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting <ting...@intel.com>; ler...@redhat.com; Wang, Jian J > <jian.j.w...@intel.com>; Long, Qin <qin.l...@intel.com> > Subject: [PATCH 1/2] CryptoPkg/BaseCryptLib: Fix buffer overflow issue in > realloc wrapper >

Re: [edk2] [PATCH v2 1/2] CryptoPkg/BaseCryptLib: Fix buffer overflow issue in realloc wrapper

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Long, Qin > Sent: Wednesday, November 01, 2017 4:19 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Ye, Ting <ting...@intel.com>; > ler...@redha

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

I see. Thanks for the explanation. > -Original Message- > From: Yao, Jiewen > Sent: Friday, November 03, 2017 10:27 AM > To: Wang, Jian J <jian.j.w...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Fan Jeff <vanjeff_...@hotmail.com>; edk2

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 08, 2017 1:14 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@i

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Make sense. Thanks for the comment. > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, November 08, 2017 12:42 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Laszlo Ersek <ler...@redhat.com>; Yao, Jiewen <jiewen@in

Re: [edk2] [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

t; CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)- > >Length); > > > Thanks, > Star > -Original Message- > From: Wang, Jian J > Sent: Wednesday, November 8, 2017 10:12 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.

Re: [edk2] [PATCH v3] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Thanks for catching them. There'll be v5 today:) > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 09, 2017 10:13 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen...

  1   2   3   4   >