Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Sorry guys. I did update the title but v5 is still missing. A new one will be sent out. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Friday, November 10, 2017 8:42 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

10:17 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject: Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > RT_CODE in memory map > > On 11/0

Re: [edk2] [PATCH v3] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 08, 2017 10:37 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Yao, Jiewen <jiewe

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Some updates below > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang, > Jian J > Sent: Wednesday, November 08, 2017 8:11 AM > To: Laszlo Ersek <ler...@redhat.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen

Re: [edk2] [PATCH v4 2/7] MdeModulePkg/SmmMemoryAttribute.h: Add new protocol definitions

Good catch. "EFI" should be removed and "IN" should be "OUT". Thanks for the feedback. > -Original Message- > From: Zeng, Star > Sent: Thursday, November 09, 2017 1:13 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01

Re: [edk2] [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool

You're right StrCpyS is better for this case. Since the patch has checked in, maybe we can refine those code in another patch. Thanks for the comment. > -Original Message- > From: Carsey, Jaben > Sent: Wednesday, November 08, 2017 11:50 PM > To: Wang, Jian J <jian.j.w...@i

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Great. Glad to know my memory is still good enough. > -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 09, 2017 9:49 AM > To: Wang, Jian J <jian.j.w...@intel.com>; Laszlo Ersek <ler...@redhat.com>; > edk2-devel@lists.01.org > Cc: Dong, Eric &

Re: [edk2] [PATCH v4 0/7] Implement heap guard feature

Just a friendly reminder. The recent commits have fixed two blocking issues for checking in heap guard feature. 6fe575d052e36b243657a5885b5457decac41f03 (BaseCryptLib memory overflow) cf8197a39d07179027455421a182598bd698 5df73e2cc8e39da97d56da058667607f1c43acac

Re: [edk2] [PATCH v4 0/7] Implement heap guard feature

Jiewen, Thanks for the comments. 1) I agree. 2) I forgot to remove them since we added new SMM protocol to do the same thing instead. > -Original Message- > From: Yao, Jiewen > Sent: Thursday, November 09, 2017 10:53 AM > To: Wang, Jian J <jian.j.w...@intel.com>;

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Move ClearFirst4KPage/IsNullDetectionEnabled definition

Looks good to me. Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Friday, December 08, 2017 11:03 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>

Re: [edk2] [PATCH v2 0/4] Enable page table write protection

That means we can't share page table pool between DxeIpl and CpuDxe. If this is acceptable, I can remove them. > -Original Message- > From: Zeng, Star > Sent: Monday, December 04, 2017 5:11 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc

Re: [edk2] [PATCH v4 00/11] Implement stack guard feature

I missed that part. I'll add it. Thanks. Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Thursday, December 07, 2017 4:17 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v4 00/11] Implement stack guar

Re: [edk2] [PATCH v2 1/3] IntelFrameworkPkg/LegacyBios.h: Add a macro to guarantee page 0 access

Thanks for the comment. The {} will be added. Sincerely, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, December 07, 2017 3:00 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Gao, Liming <liming@intel

Re: [edk2] [PATCH v3 0/2] Enable page table write protection

Hi Laszlo, Thanks for the test. Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, December 06, 2017 4:05 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v3 0/2] En

Re: [edk2] [PATCH 2/3] IntelFrameworkModulePkg/LegacyBiosDxe: Use macro to enable/disable page 0

You're right that {} are not necessary. I'm wondering why I can't pass build without them before. They'll be removed in v2. > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 06, 2017 5:32 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.0

Re: [edk2] [PATCH 1/3] IntelFrameworkPkg/LegacyBios.h: Add a macro to guarantee page 0 access

Good catch. I think it's a typo not on purpose. Many thanks! > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 06, 2017 5:31 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com

Re: [edk2] [PATCH v3 1/2] MdeModulePkg/DxeIpl: Mark page table as read-only

Hi, > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 06, 2017 6:05 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com>; > Zeng, Star <st

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Please see my comments below. Thanks. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, October 25, 2017 8:51 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.

Re: [edk2] [PATCH v3 0/6] Implement heap guard feature

Thanks for the feedback. I'll change the patch order in v4. > -Original Message- > From: Zeng, Star > Sent: Thursday, October 26, 2017 2:53 PM > To: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > edk2-devel@lists.01.org > Cc: Ki

Re: [edk2] [PATCH v3 5/6] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

Thanks for the feedback. I'll change them in v4. > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, October 26, 2017 3:18 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d

Re: [edk2] [PATCH v3 0/6] Implement heap guard feature

Thanks for the feedback. > -Original Message- > From: Yao, Jiewen > Sent: Thursday, October 26, 2017 2:49 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Wolman, Ayellet > <ayel

Re: [edk2] [PATCH v3 0/6] Implement heap guard feature

Hi, Just a warm reminding. I didn't see any feedbacks on the v3 patch. If no more comments, I'll check in the patch soon. Thanks, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Monday, October 23, 2017 8:51 AM >

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

entries but also trying to make sure the memory capabilities in GCD service to reflect complete status of the real world. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 24, 2017 8:20 PM > To: Wang, Jian J <jian.j.w...@intel.com>

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Hi Jeff, Thanks for the feedback. Are you suggesting to fix Bugzilla 109 in this patch? Thanks, Jian From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Wednesday, November 01, 2017 10:33 AM To: Yao, Jiewen <jiewen@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Jeff, Stack guard will still work. But the developer cannot know what’s going on without exception dumping message when stack overflow occurs. Thanks, Jian From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Wednesday, November 01, 2017 10:59 AM To: Wang, Jian J <jian.j.w...@intel.com>

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

rs. > > Thanks, > Jian > > From: Fan Jeff [mailto:vanjeff_...@hotmail.com] > Sent: Wednesday, November 01, 2017 10:59 AM > To: Wang, Jian J <jian.j.w...@intel.com>; Yao, Jiewen <jiewen@intel.com>; > edk2-devel@lists.01.org > Cc: Kinney, Michael D <michae

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Hi Jiewen, Thanks for the feedback. > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, November 01, 2017 9:57 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@i

Re: [edk2] [PATCH 3/3] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

Hi Jeff, Thanks for the feedback. From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Wednesday, November 01, 2017 10:37 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen <jiewen@intel.c

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Clarify usage of PcdHeapGuardPropertyMask

Thanks. .uni file will be updated accordingly. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Thursday, December 21, 2017 1:15 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Zeng

Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

; From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, June 11, 2018 8:18 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong, > Eric > Subject: Re: [edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) > page table in SMM mode > >

Re: [edk2] [PATCH v2 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE) page table in SMM mode

Hi Laszlo, Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, June 13, 2018 11:10 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong, > Eric > Subject: Re: [edk2] [PATCH v2 1/2] Uef

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

Sent: Wednesday, October 18, 2017 1:55 PM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [PATCH v2 2/6] MdeModulePkg/PiSmmCo

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 26, 2017 6:08 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@i

Re: [edk2] [PATCH v3 0/6] Implement heap guard feature

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 26, 2017 9:27 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org; Kinney, > Michael D <mi

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

, October 20, 2017 9:37 AM To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [PATCH v2 2/6] MdeModulePkg/PiSmmCore: Implement hea

Re: [edk2] [patch 3/4] MdeModulePkg/DxeIplPeim: Refine coding style in function comments

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject:

Re: [edk2] [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming <liming@intel.com> > Subje

Re: [edk2] [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in comments

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming <liming@intel.com> > Subject:

Re: [edk2] [PATCH] MdeModulePkg VarCheckHii: Make sure the bin at required alignment

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Friday, December 29, 2017 6:14 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Yao, Jie

Re: [edk2] [PATCH] MdeModulePkg VarCheckPcd: Make sure the bin at required alignment

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Friday, December 29, 2017 6:19 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Yao, Jie

Re: [edk2] [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

h.si...@amd.com>; edk2-devel@lists.01.org > Cc: Tom Lendacky <thomas.lenda...@amd.com>; Wang, Jian J > <jian.j.w...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Justen, Jordan > L <jordan.l.jus...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> &g

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

for all your comments. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 04, 2018 8:22 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Glad to know. That saves me time to write my own case:) Regards, Jian From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Friday, January 05, 2018 11:05 AM To: Yao, Jiewen <jiewen@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Laszlo Ersek <ler...@redhat.com>; edk2-

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Hi Jeff, Do you think the change is OK? Do you know how to test switching BSP? Regards, Jian From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Friday, January 05, 2018 9:40 AM To: Laszlo Ersek <ler...@redhat.com>; Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Got it. Many thanks! Regards, Jian From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Friday, January 05, 2018 10:50 AM To: Wang, Jian J <jian.j.w...@intel.com>; Laszlo Ersek <ler...@redhat.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric &l

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Fix incorrect Guard page setup for APs

Hi, Anyone has any comments on this? Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Thursday, December 21, 2017 9:27 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Fix incorrect Guard page setup for APs

You're right. It will be updated to use more accurate wording. Thanks for catching it. Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Friday, December 22, 2017 1:22 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] MdeModulePkg/Core: Fix heap guard issues

Sorry for the email title. This is not a series patch. And I missed one more issue addressed by this patch: c. NULL address handling due to allocation failure When allocation failure, normally a NULL will be returned. But Heap Guard code will still try to adjust the starting address of it, which

Re: [edk2] [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs

Sure. Thanks. Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Monday, December 25, 2017 9:59 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@redhat.

Re: [edk2] [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up

Ok. Thanks for catching it. Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Monday, December 25, 2017 9:51 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@inte

Re: [edk2] 答复: [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

I see. Thanks a lot! Regards, Jian > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, January 05, 2018 10:55 AM > To: Fan Jeff <vanjeff_...@hotmail.com>; Wang, Jian J > <jian.j.w...@intel.com>; Laszlo Ersek <ler...@redhat.com>; edk2- >

Re: [edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: remove all code to flush TLB for APs

Right. I'll update the comments. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Friday, January 26, 2018 5:14 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Laszlo Ersek <ler...@redhat.com>; Yao, Jiewen <jiewe

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix issue in wakeup buffer initialization

; block. You'll see it in a new patch later. Anyway, thanks for the comments. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 24, 2018 11:30 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org

Re: [edk2] [PATCH] MdeModulePkg/Partition: Fix media probe

Tested-by/Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, January 25, 2018 5:45 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com> > Subject: [PATCH] MdeModulePkg/Partition:

Re: [edk2] [PATCH 1/6] UefiCpuPkg/MpInitLib: split wake up buffer into two parts

9, 2018 5:44 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Dong, > Eric <eric.d...@intel.com> > Subject: Re: [edk2] [PATCH 1/6] UefiCpuPkg/MpInitLib: split wake up b

Re: [edk2] [PATCH 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Enable NXE if it's supported

] > Sent: Monday, January 29, 2018 6:47 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Dong, > Eric <eric.d...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>; Radim

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and NULL detection

gCpu->SetMemoryAttributes() called by SetUefiImageMemoryAttributes() will return without any problem if Length is 0. Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, January 30, 2018 10:09 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-de

Re: [edk2] [PATCH] MdeModulePkg/Core: fix feature conflict between NX and NULL detection

Ok. Thanks for the comments. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, February 01, 2018 1:54 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric

Re: [edk2] [PATCH] MdePkg/SafeString: Directly return when length of source string is 0

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Friday, February 02, 2018 6:48 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Gao, Liming <liming....@intel.com>; > Wang, Jian

Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

Mike, Thanks for catching it. The patch has sent out. Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 29, 2017 9:08 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org; Kinney, > Michael D <michael.d.kin

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

Jiewen, Please take a look at this patch. Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Friday, December 29, 2017 4:37 PM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao,

Re: [edk2] [PATCH 0/4] Coding style clean-up

structure type using those field names, the tool will still report errors. Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, December 27, 2017 12:48 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org; Kinney, > Mic

Re: [edk2] [PATCH] MdePkg/BasePrintLib: Fix incorrect Precision position calculation

I revisit the code again. You're right that the commit log is not correct. The '\0' would be read and even the one pass it. Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 28, 2017 12:38 AM > To: Wang, Jian J <jian.j.w...@intel.c

Re: [edk2] [PATCH 0/4] Coding style clean-up

Theoretically, yes. But I think it's a rare case in which someone will use ESP in a structure but not to represent ESP register. Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 28, 2017 8:37 AM > To: Wang, Jian J <jian.j.w...@i

Re: [edk2] [PATCH] MdePkg/BasePrintLib: Fix incorrect Precision position calculation

Sure. Regards, Jian > -Original Message- > From: Gao, Liming > Sent: Thursday, December 28, 2017 9:57 AM > To: Wang, Jian J <jian.j.w...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen..

Re: [edk2] [PATCH 0/4] Coding style clean-up

for any structure type to exclude those special names. This can avoid the false reports as many as possible. Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 28, 2017 12:35 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@li

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

egards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 04, 2018 1:33 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

gt; correct. > > I think the problem here is that ApTopOfStack initialized at line 1501 is not > correct. > > > Regards, > Jian > > > > -----Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Thursday, January

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: fix wrong base address set as Stack Guard

nstead of InitializeApData (CpuMpData, 0, 0, NULL); Regards, Jian > -Original Message- > From: Wang, Jian J > Sent: Thursday, January 04, 2018 9:09 AM > To: Wang, Jian J <jian.j.w...@intel.com>; Laszlo Ersek <ler...@redhat.com>; > edk2-devel@lists.01.org > C

Re: [edk2] [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions

For HeapGuard.c part, Reviewed-by: Jian J Wang mailto:jian.j.w...@intel.com>> Regards, Jian From: Ni, Ruiyu Sent: Thursday, August 09, 2018 11:12 AM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star ; Wang, Jian J Subject: RE: [edk2] [PATCH 17/26] MdeMod

Re: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant functions

For HeapGuard.c part, Reviewed-by: Jian J Wang mailto:jian.j.w...@intel.com>> Regards, Jian From: Ni, Ruiyu Sent: Thursday, August 09, 2018 11:10 AM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star ; Wang, Jian J Subject: RE: [edk2] [PATCH 16/26] MdeMod

Re: [edk2] [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable

g > Cc: Zeng, Star ; Laszlo Ersek ; > Wang, Jian J > Subject: [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory > executable > > Commit b22a62be5cdc8fd19d87ec1ecfa5b28fb9be50ad > * IntelFrameworkModule/LegacyBios:Use reserved memory for legacy data > allocates reserved

Re: [edk2] [PATCH] ShellPkg/edit: Fix heap access out-of-bounds

Reviewed-by: Jian J Wang > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, August 16, 2018 2:33 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Wang, Jian J > > Subject: [PATCH] ShellPkg/edit: Fix heap access out-of-bounds > > The issue was foun

Re: [edk2] [PATCH v2 3/4] UefiCpuPkg/CpuDxe: implement non-stop mode for uefi

Hi Laszlo, Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 21, 2018 10:59 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric Subject: Re: [edk2] [PATCH v2 3/4] UefiCpuPkg/CpuDxe: implement non-stop mode for uefi I only have some

Re: [edk2] [PATCH v2 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: implement non-stop mode for SMM

Hi Laszlo, Thanks. Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 21, 2018 11:45 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric Subject: Re: [edk2] [PATCH v2 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: implement non-stop mode for SMM On 08/21

Re: [edk2] [PATCH v2 0/4] Support non-stop mode in heap guard and null detection

Hi Laszlo, Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 21, 2018 10:28 PM To: Wang, Jian J ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH v2 0/4] Support non-stop mode in heap guard and null detection On 08/21/18 05:05, Jian J Wang wrote: >&

Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

Thanks. Since there're just some minor changes, I'll not provide v3 patches and push the changes to master soon. Regards, Jian From: Dong, Eric Sent: Tuesday, August 28, 2018 9:15 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Ni, Ruiyu Subject: RE: [PATCH v2 2/4] UefiCpuPkg

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer of MdeModulePkg

Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Tuesday, August 28, 2018 1:36 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J ; > Dong, Eric ; Kinney, Michael D > ; Laszlo Ersek ; Andrew Fish > ; Leif Lindholm > Subje

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode

m] > Sent: Thursday, July 19, 2018 10:46 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric ; > Zeng, Star > Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM > mode > > On 07/18/18 04:35, Wang, Jian J wrote: > > H

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode

Hi Laszlo, Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 17, 2018 10:37 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Yao, Jiewen ; > Zeng, Star > Subject: Re: [PATCH] UefiCpuPkg/

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix incorrect check of SMM mode

Hi Laszlo, Do you have more comments? Or can you give a r-b? Regards, Jian > -Original Message- > From: Wang, Jian J > Sent: Wednesday, July 18, 2018 10:36 AM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Yao, Jiewen ; > Zeng, Star > Subject: R

Re: [edk2] [PATCH 4/4] UefiCpuPkg/CpuMpPei: support stack guard feature

Thanks for the comments. It will be fixed. Regards, Jian From: Dong, Eric Sent: Thursday, September 06, 2018 9:46 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Ni, Ruiyu ; Yao, Jiewen ; Zeng, Star ; Ware, Ryan R Subject: RE: [PATCH 4/4] UefiCpuPkg/CpuMpPei: support stack

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error

Make sense to me. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Monday, September 10, 2018 1:08 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: You, Benjamin ; Dong, Eric > ; Laszlo Ersek ; Zeng, Star > > Subject: RE: [PATCH] UefiCpuPkg/PiS

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.uni: update PCD string per dec file change

Sure. Make sense. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, August 31, 2018 9:43 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: RE: [PATCH] MdeModulePkg/MdeModulePkg.uni: update PCD string per

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message

Laszlo, Thanks for the comment. I’ll add the info. Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 29, 2018 9:54 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Dong, Eric Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message On 08

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ECC reported issues

Forgot to mention the BZ info: https://bugzilla.tianocore.org/show_bug.cgi?id=1160 Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Saturday, September 08, 2018 10:22 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan > Subject:

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation

Forgot to mention BZ info: https://bugzilla.tianocore.org/show_bug.cgi?id=1095 Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Saturday, September 08, 2018 10:48 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2]

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation

And BZ#1164: https://bugzilla.tianocore.org/show_bug.cgi?id=1164 Regards, Jian From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] Sent: Saturday, September 08, 2018 11:25 AM To: edk2-devel ; edk2-devel@lists.01.org Cc: Wu, Hao A Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an

Re: [edk2] [PATCH 0/5] expire the use of PcdSetNxForStack

also functionality overlap between them because stack memory is actually type of EfiBootServiceData, which is also controlled by BIT4 of PcdDxeNxMemoryProtectionPolicy. Regards, Jian From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, September 11, 2018 4:58 PM To: Wang, Jian J

Re: [edk2] [PATCH] ShellPkg/UefiShellLevel3CommandsLib: fix string over-read

Fair enough. It'll be updated in v2. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, January 24, 2018 11:36 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [PATCH] ShellPkg/UefiShellLevel3CommandsLib:

Re: [edk2] [PATCH 2/5] OvmfPkg/PlatformPei: expire the use of PcdSetNxForStack

, Jian J ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Justen, Jordan L ; Yao, Jiewen ; Zeng, Star ; Ard Biesheuvel Subject: Re: [edk2] [PATCH 2/5] OvmfPkg/PlatformPei: expire the use of PcdSetNxForStack On 09/11/18 07:16, Jian J Wang wrote: > BZ#: https://bugzilla.tianocore.org/show_bug.cgi?id=1

Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: suppress compiler complaining

: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, September 11, 2018 10:56 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Bi, Dandan ; Dong, Eric Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: suppress compiler complaining Jian, On 09/11/18 06:47, Jian J Wang wrote: >

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error

...@redhat.com] Sent: Tuesday, September 11, 2018 9:52 PM To: Zeng, Star ; Wang, Jian J ; edk2-devel@lists.01.org Cc: You, Benjamin ; Dong, Eric Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error On 09/10/18 07:07, Zeng, Star wrote: > I agree to add the ASSERT, but e

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error

but a GUID name is more friendly to person. (4)Good idea. I’ll add it in v2. Regards, Jian From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, September 11, 2018 10:01 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Zeng, Star ; You, Benjamin ; Dong, Eric Subject: Re: [PATCH] UefiCpuPkg

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

Thanks for fixing the issue. For this patch series: Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Wu, Hao A > Sent: Tuesday, March 06, 2018 9:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Wang, Ji

Re: [edk2] [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard

Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, March 07, 2018 11:17 AM > To: Wu, Hao A <hao.a...@intel.com>; edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Zeng, Star <star.z...@intel.com>; > Dong, Eri

Re: [edk2] [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as the macro value

Reviewed-by: Jian J Wang <jian.j.w...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Friday, March 16, 2018 9:47 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; > Kinney, M

Re: [edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

There's a bit operation error found in 32-bit platform. I'll send a v2 patch later. Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Wednesday, March 14, 2018 4:31 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH] MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol installed

Thanks catching this. New patch has sent out. Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, March 15, 2018 11:47 AM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix #PF caused by freeing read-only memory

8 2:56 PM > To: Wang, Jian J <jian.j.w...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com>; > Zeng, Star <star.z...@intel.com> > Subject: Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix #PF caused by >

<    1   2   3   4   >