On 2018/9/25 10:43, Ni, Ruiyu wrote:
On 9/25/2018 10:14 AM, Zeng, Star wrote:
Two very small comments are added below.
On 2018/9/21 15:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe
On 2018/9/21 19:12, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 ++
1 file changed, 12 insertions(+), 14 d
On 2018/9/21 15:25, Ruiyu Ni wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1196
RootBridgeIoCheckParameter() verifies that the requested MMIO access
can fit in any of the MEM/PMEM 32/64 ranges. But today's logic
somehow only checks the requested access against MEM 32/64 ranges.
It
Two very small comments are added below.
On 2018/9/21 15:25, Ruiyu Ni wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 26 +-
1 file changed, 21 insertions(+), 5
Another minor suggestion is to move IsExecuteDisableBitAvailable() to
VirtualMemory.c, then there will be no need to declare it in
VirtualMemeory.h.
Thanks,
Star
On 2018/9/21 14:00, Zeng, Star wrote:
Jian and Laszlo,
There is also a superficial comment at below.
On 2018/9/20 14:02, Jian J
Jian and Laszlo,
There is also a superficial comment at below.
On 2018/9/20 14:02, Jian J Wang wrote:
v2 changes:
a. remove macros no longer needed
b. remove DEBUG and ASSERT in ToEnableExecuteDisableFeature()
c. change ToEnableExecuteDisableFeature to EnableNonExec
BZ#1116: https
Jian,
The clarifications are very good.
There is a very superficial comment at below.
On 2018/9/20 14:02, Jian J Wang wrote:
v2 changes:
Newly added patch to clarify PCDs usage.
BZ#1116: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
The usage of following PCDs described in MdeModul
r
-Original Message-
From: Chen, Chen A
Sent: Friday, September 21, 2018 9:00 AM
To: edk2-devel@lists.01.org
Cc: Chen, Chen A ; Zeng, Star ;
Dong, Eric ; Kinney, Michael D
Subject: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file.
The PalLib will remove in MdePkg, so remove th
Reviewed-by: Star Zeng and pushed it at
8c06d18bc112c7b0547641e83a508c6784317f72.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, September 20, 2018 4:55 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg CapsuleApp:Remove
Just sent V2 patch at
https://lists.01.org/pipermail/edk2-devel/2018-September/029849.html with this
idea.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Wednesday, September 19, 2018 10:15 AM
To: Yao, Jiewen ; edk2-devel@lists.01.org
Cc: Younas khan ; Kinney, Michael D
; Gao
I think it is a good idea.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, September 19, 2018 10:13 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Younas khan ; Kinney, Michael D
; Gao, Liming
Subject: RE: [PATCH] IntelFrameworkPkg FrameworkUefiLib: Add new
You mean like below for the case?
ASSERT(FALSE);
return NULL;
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, September 19, 2018 10:08 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Younas khan ; Kinney, Michael D
; Gao, Liming
Subject: RE: [PATCH] IntelFrameworkPkg
Sure. :)
I just sent a separated patch for it at
https://lists.01.org/pipermail/edk2-devel/2018-September/029832.html.
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Tuesday, September 18, 2018 10:19 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Younas khan ; Kinney, Michael
-Original Message-
From: Wang, Jian J
Sent: Tuesday, September 18, 2018 9:22 AM
To: Laszlo Ersek ; Zeng, Star ;
edk2-devel@lists.01.org
Cc: Ard Biesheuvel ; Ni, Ruiyu ;
Yao, Jiewen
Subject: RE: [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs
I have no strong opinion for this
Ray,
Thanks for the good feedbacks.
I can remove the ASSERT and update the description in the function header.
I can also merge ScanTableInRSDT and ScanTableInXSDT.
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Friday, September 14, 2018 12:41 PM
To: Zeng, Star ; edk2-devel
-Original Message-
From: Wang, Jian J
Sent: Monday, September 17, 2018 10:11 AM
To: Laszlo Ersek ; edk2-devel@lists.01.org
Cc: Zeng, Star ; Ard Biesheuvel
; Ni, Ruiyu ; Yao, Jiewen
Subject: RE: [PATCH] MdeModulePkg/DxeIpl: support more NX related PCDs
Laszlo,
Thanks for the comments
Reviewed-by: Star Zeng
-Original Message-
From: Wang, Jian J
Sent: Friday, September 14, 2018 3:12 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; You, Benjamin ;
Dong, Eric ; Laszlo Ersek
Subject: [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: move InitSmmS3Cr3() into
else block
>
Same suggestion with Laszlo.
Reviewed-by: Star Zeng
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, September 15, 2018 4:09 AM
To: Wang, Jian J ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH v2 1/2] UefiCpuPkg
Thanks.
Please also help review [PATCH] IntelSiliconPkg IntelVTdDxe: Check HeaderType
if func 0 is implemented.
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday, September 13, 2018 2:42 PM
To: Zeng, Star ; Ni, Ruiyu ;
edk2-devel@lists.01.org
Cc: Chang, Tomson ; Huang, Jenny
On 2018/9/12 21:21, Ard Biesheuvel wrote:
When enumerating option ROM images, take into account whether an emulator
exists that would allow dispatch of PE/COFF images built for foreign
architectures.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
Mde
On 2018/9/12 21:21, Ard Biesheuvel wrote:
When encountering PE/COFF images that cannot be supported natively,
attempt to locate an instance of the PE/COFF image emulator protocol,
and if it supports the image, proceed with loading it and register it
with the emulator.
Contributed-under: TianoCor
On 2018/9/12 21:21, Ard Biesheuvel wrote:
Introduce a protocol that can be invoked by the image loading services
to execute foreign architecture PE/COFF images via an emulator.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Include/Proto
nted.
I just sent another patch for it at
https://lists.01.org/pipermail/edk2-devel/2018-September/029636.html.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday, September 13, 2018 1:29 PM
To: Ni, Ruiyu ; Zeng, Star ;
edk2-devel@lists.01.org
Cc: Chang, Tomson ; Huan
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, September 10, 2018 3:12 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Ni, Ruiyu ; Zeng,
Star
Subject: [patch 3/3] MdeModulePkg: Avoid key notification called more than once
From: Dandan Bi
REF: https
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, September 10, 2018 6:05 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Kinney, Michael D
; Zeng, Star
Subject: [PATCH] MdeModulePkg/ConPlatform: Support short-form USB device path
Today's implementation do
s,
Star
-Original Message-
From: Wang, Jian J
Sent: Monday, September 10, 2018 11:22 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; You, Benjamin ;
Dong, Eric ; Laszlo Ersek
Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: add message for S3 config error
BZ#: https://bugzilla.tianoc
Reviewed-by: Star Zeng
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, September 6, 2018 9:45 PM
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel ; Zeng, Star
; Wang, Jian J ; Kinney, Michael D
; Gao, Liming ; Zhang, Chao B
; Yao, Jiewen
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, September 6, 2018 9:45 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Yao, Jiewen ;
Zeng, Star ; Kinney, Michael D
; Laszlo Ersek ; Zhang
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, September 5, 2018 10:18 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2] MdeModulePkg PeiCore: Always use PeiImageRead()
function to load
Thanks for the quick following up. :)
Reviewed-by: Star Zeng
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, September 6, 2018 3:45 AM
To: edk2-devel-01
Cc: Ni, Ruiyu ; Zeng, Star
Subject: [edk2] [PATCH
Hi Liming,
The code removed is about copying PeiImageReadForShadow, but not PeiImageRead.
How about updating the title and commit log a little?
And I suggest eliminating GetImageReadFunction() further in this patch and move
" ImageContext->ImageRead = PeiImageRead; " into LoadAndRelocatePeCoffIm
To: Yao, Jiewen ; Zeng, Star ;
Kinney, Michael D
Cc: edk2-devel@lists.01.org; Younas khan ; Gao,
Liming
Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new
EfiFindAcpiTableBySignature() API
I prefer S2.
Single interface is more easy for consumer to remember how to use.
Thanks/Ray
: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, September 4, 2018 6:38 PM
To: Zeng, Star ; edk2-devel-01
Cc: Gerd Hoffmann ; Wang, Jian J ;
Ni, Ruiyu ; Shi, Steven
Subject: Re: [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition
in BindingStart
On 09/04/18 03:27, Zeng, Star
, September 3, 2018 7:46 PM
To: Zeng, Star ; edk2-devel-01
Cc: Gerd Hoffmann ; Wang, Jian J ;
Ni, Ruiyu ; Shi, Steven
Subject: Re: [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition
in BindingStart
Hi Star,
On 09/03/18 10:35, Zeng, Star wrote:
> Good finding.
>
> There i
10:04 PM
To: edk2-devel-01
Cc: Gerd Hoffmann ; Wang, Jian J ;
Ni, Ruiyu ; Zeng, Star ; Shi, Steven
Subject: [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in
BindingStart
Commit 09943f5ecc0f ("MdeModulePkg: Skip to manage usb debug port in EDKII EHCI
driver if it'
-Original Message-
From: Ni, Ruiyu
Sent: Monday, September 3, 2018 1:09 PM
To: Zeng, Star ; Yao, Jiewen ;
Kinney, Michael D
Cc: edk2-devel@lists.01.org; Younas khan ; Gao,
Liming
Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new
EfiFindAcpiTableBySignature() API
That's fine to
Thanks Laszlo. :)
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, September 1, 2018 4:34 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric ; Younas
khan ; Gao, Liming ; Yao,
Jiewen ; Kinney, Michael D
Subject: Re: [edk2
,
Star
-Original Message-
From: Yao, Jiewen
Sent: Saturday, September 1, 2018 7:04 AM
To: Ni, Ruiyu
Cc: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
D ; Younas khan ; Gao,
Liming
Subject: RE: [edk2] [PATCH 1/6] MdePkg UefiLib: Add new
EfiFindAcpiTableBySignature() API
Good
Please mention 8f2613628acf601a2a17bb64bb49ef73f85cfe2c (which updated the PCDs
in dec) in commit log.
Reviewed that, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wang, Jian J
Sent: Friday, August 31, 2018 9:22 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Oh, yes, agree. I should update description.
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Thursday, August 30, 2018 5:55 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: RE: [PATCH 2/2] MdeModulePkg DxeCore: Handle multiple FV images in one
FV file
Star
Dandan, thanks.
Reviewed-by: Star Zeng
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Wednesday, August 29, 2018 4:53 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Ni, Ruiyu ;
Zeng, Star
Subject: [edk2] [patch V3
ts.01.org] On Behalf Of Dandan Bi
Sent: Tuesday, August 28, 2018 2:27 PM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Ni, Ruiyu ;
Zeng, Star
Subject: [edk2] [V2 patch] ShellPkg/SmbiosView: Update SmbiosView for
SMBIOS3.2.0
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1099
Update Smbios
Shenglei,
The library Pcdlib is not linked， so "#include "
is deleted.
There is massy code, please correct it before it can be pushed.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Tuesday, August 28, 2018 11:43 AM
To: edk2-devel@lists.01.org
Cc: Zeng, S
Pushed the patch at 5ec70b030eb623f0e5dfc66eeabbae513235d238.
Thanks very much.
Star
-Original Message-
From: Zeng, Star
Sent: Friday, August 24, 2018 5:16 PM
To: Laszlo Ersek ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Andrew Fish
; Leif Lindholm ; Bi, Dandan
; Zeng, Star
Agree and thanks.
Star
-Original Message-
From: Bi, Dandan
Sent: Monday, August 27, 2018 9:00 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Gao, Liming ; Kinney, Michael D
Subject: RE: [PATCH V2 1/2] MdePkg SmBios.h: Add SMBIOS 3.2.0 definitions
Hi Star,
One minor comment:
How
Thanks. Agree and I will follow your preference to push it next week if no
concern from others. :)
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, August 24, 2018 3:10 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Andrew Fish
On 2018/8/23 10:53, Ruiyu Ni wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1109
Today's restriction of VGA device is to have only one VGA device
enabled per PCI segment. It's not correct because several segments
may share one IO / MMIO address space.
We should restrict to have one V
On 2018/8/23 10:53, Ruiyu Ni wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1109
The patch doesn't change any behavior of this function.
It just renames the function to LocateVgaDevice() and renames
some parameters and local variables.
Contributed-under: TianoCore Contribution Agreem
I tried both at
https://github.com/lzeng14/tianocore/wiki/EDK-II-Release-Planning.
In fact, I am ok with either one. :)
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 23, 2018 7:20 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc
It is changing EhciPei but not UhciPei, please update the title.
Reviewed-by: Star Zeng with the title updated.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 22, 2018 9:50 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Tuesday, August 21, 2018 4:57 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zeng, Star
Subject: [patch] MdeModulePkg/SmmCorePerfLib: Add DxeServicesLib library class
in INF
REF: https://bugzilla.tianocore.org
ou double check the normal functionality (SMM AllocatePages + FreePages)
with the patch?
Thanks,
Star
-Original Message-
From: Dong, Eric
Sent: Tuesday, August 21, 2018 2:46 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [Patch] MdeModulePkg/PiSmmCore: Check valid memo
21, 2018 9:36 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Laszlo
Ersek
Subject: [PATCH v2 3/7] MdeModulePkg: Remove unused PCDs
The PCDs below are unused, so they have been removed from inf.
gEfiMdeModulePkgTokenSpaceGuid.Pcd
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chasel,
Chiu
Sent: Tuesday, August 21, 2018 9:44 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH] IntelFsp2WrapperPkg: Add EFIAPI to AsmExecute32BitCode
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 15, 2018 9:46 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH v2 07/27] MdeModulePkg SdMmcPciHcDxe: Remove redundant functions
The functions that are never called have
-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH v2 26/27] MdeModulePkg SetupBrowserDxe: Remove a redundant
function
The function IsDevicePathExist that is never called has been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 15, 2018 9:46 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH v2 27/27] MdeModulePkg UiApp: Remove a redundant function and a
variable
1.After the cleanup at
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Friday, August 17, 2018 10:36 PM
To: edk2-devel-01
Cc: Dong, Eric
Subject: [edk2] [PATCH 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: clear exec file mode
bits on "Pi
Hi Shenglei,
BaseLib is not belong to MdeModulePkg, please spit it into separated patch.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 16, 2018 1:32 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 1/5] MdeModulePkg: Remove
You may try report the FVMAIN_COMPACT with the way like below. Then PeiCore's
FvInfo notification will decompress the FVMAIN_COMPACT and build FV HOB for
decompressed FVMAIN for DXE phase. FvInfo is the standard way, FvHob is produce
for DXE phase. PeiCore only processes FvHob when
PcdFramework
On 2018/8/14 13:28, Zeng, Star wrote:
On 2018/8/14 13:18, shenglei wrote:
Some redundant library classes and GUIDs
have been removed in inf, .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1044
https://bugzilla.tianocore.org/show_bug.cgi?id=1045
https://bugzilla.tianocore.org
On 2018/8/14 13:18, shenglei wrote:
Some redundant library classes and GUIDs
have been removed in inf, .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1044
https://bugzilla.tianocore.org/show_bug.cgi?id=1045
https://bugzilla.tianocore.org/show_bug.cgi?id=1047
https://bugzilla.tian
On 2018/8/14 10:27, shenglei wrote:
Some redundant library classes and GUIDs
have been removed in inf, .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1044
https://bugzilla.tianocore.org/show_bug.cgi?id=1045
https://bugzilla.tianocore.org/show_bug.cgi?id=1047
https://bugzilla.tian
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of shenglei
Sent: Tuesday, August 14, 2018 10:18 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH v2] SignedCapsulePkg: Remove redundant things in inf, .h
a
I agree with Hao.
And there is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Don
I agree with Hao.
And there is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Don
There is a typo in commit log. 'calld' should be 'called'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
S
Sorry, I meant 'called'.
-Original Message-----
From: Zeng, Star
Sent: Thursday, August 9, 2018 6:25 PM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function
There is a typo in
Sorry, I meant 'called'.
-Original Message-----
From: Zeng, Star
Sent: Thursday, August 9, 2018 6:24 PM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: Remove a redundant
function
There is a typo
Sorry, I meant 'called'.
-Original Message-----
From: Zeng, Star
Sent: Thursday, August 9, 2018 6:10 PM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function
There is a typo in
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 17/26] MdeModulePkg PiSmmCore: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 14/26] MdeModulePkg UsbBusDxe: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 13/26] MdeModulePkg UsbBotPei: Remove redundant functions
The functions that are never called have been
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 12/26] MdeModulePkg UfsPassThruDxe: Remove redundant functions
The functions that are never called have been
I agree with Hao. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, August 10, 2018 10:58 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [edk2] [PATCH 11/26] MdeModulePkg UfsBlockIoPei: Remove redundant
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions
The functions that are never called have been removed
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions
The functions that are never called have been removed
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 08/26] MdeModulePkg UhciPei: Remove redundant functions
The functions that are never called have been removed
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions
The functions that are never called have been
I suggest merging this patch to thread
https://lists.01.org/pipermail/edk2-devel/2018-August/028167.html.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Friday, August 10, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg
I suggest merging this patch to thread
https://lists.01.org/pipermail/edk2-devel/2018-August/028167.html.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 9, 2018 2:54 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg
rsday, August 9, 2018 4:40 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: [edk2] [PATCH] MdeModulePkg: Remove redundant things in inf and .h
files
A redundant GUID and some library classes are removed
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc:
Hi Shenglei,
I know PrintLib is used by ParseConfigProfile.c that is included by
SystemFirmwareUpdateDxe.inf.
But could you evaluate whether DxeServicesLib could be removed from
SystemFirmwareUpdateDxe.inf or not?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
D Kinney
Sent: Friday, August 10, 2018 5:20 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] Maintainers.txt: Add FmpDevicePkg maintainers
This patch adds maint
There is a typo in commit log. 'calld' should be 'callled'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
S
There is a typo in commit log. 'calld' should be 'callled'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
S
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 26/26] MdeModulePkg SetupBrowserDxe: Remove a redundant function
The function IsDevicePathExist that is never
Cc Siyuan and Jiaxin.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 25/26] MdeModulePkg Tcp4Dxe: Remove redundant functions
The functions that are never called have
Cc Siyuan and Jiaxin.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 24/26] MdeModulePkg IScsiDxe: Remove a redundant function
The function IScsiFindTcbByITT that is
Cc Siyuan and Jiaxin.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 23/26] MdeModulePkg Ip4Dxe: Remove a redundant function
The function Ip4Config2OnDhcp4Event that
Reviewed-by: Star Zeng
Cc Hao.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 05/26] MdeModulePkg NvmExpressDxe: Remove redundant functions
The functions that are
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions
The functions that are never called have been removed
: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH 03/26] MdeModulePkg AtaAtapiPassThru: Remove
redundant functions
On 08/08/18 10:46, shenglei wrote:
> The functions that are never called have been removed.
> They are AhciCheckDeviceStatus and AhciPortReset.
There's mor
There is a typo in commit log. 'calld' should be 'callled'.
With the typo fixed, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Wednesday, August 8, 2018 4:47 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
S
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 9, 2018 1:21 AM
To: Carsey, Jaben ; Leif Lindholm
; Zhang, Shenglei
Cc: edk2-devel@lists.01.org; Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH 00/26] MdeModulePkg Remove redundant functions
On 08/08/18 18:05, Carsey, Jaben
: Zhang, Shenglei
Cc: edk2-devel@lists.01.org; Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH 00/26] MdeModulePkg Remove redundant functions
Eric, Star,
On Wed, Aug 08, 2018 at 04:46:46PM +0800, shenglei wrote:
> A lot of redundant functions which are never calld have been remove
I agree with Laszlo. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 9, 2018 2:07 AM
To: Zhang, Shenglei ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] [PATCH 02/26] MdeModulePkg
not aligned.
gEfiAcpiTableProtocolGuid ## CONSUMES
+ gEfiFirmwareVolume2ProtocolGuid ## CONSUMES
With that handled, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Friday, August 3, 2018 4:19 PM
To: edk2-devel@lists.01.org
C
201 - 300 of 1395 matches
Mail list logo
