Re: [edk2] [Patch] Maintainers.txt: Update maintainers for MdeModulePkg

2017-05-02 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, May 3, 2017 10:33 AM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: RE: [Patch] Maintainers.txt: Update maintainers for MdeModulePkg Reviewed-by: Star Zeng Thanks

Re: [edk2] [PATCH] UefiCpuPkg: Move ProgramVirtualWireMode() to MpInitLib

2017-04-25 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Friday, April 21, 2017 1:30 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg: Move ProgramVirtualWireMode() to MpInitLib In PEI phase, BSP did not program vitural wired mode

Re: [edk2] [PATCH v2] UefiCpuPkg/MpLib.c: Set AP state after X2APIC mode enabled

2017-04-25 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Tuesday, April 25, 2017 2:54 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH v2] UefiCpuPkg/MpLib.c: Set AP state after X2APIC mode enabled After X2APIC mode is enabled, APs need to be

Re: [edk2] [PATCH 0/2] Borrow the space below 1MB for AP reset vector

2017-04-24 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, April 21, 2017 2:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH 0/2] Borrow the space below 1MB for AP reset vector Current, CpuMpPei will find the available

Re: [edk2] [PATCH 0/2] MdeModulePkg/Ufs: Wait fDeviceInit be cleared by devices during init

2017-04-19 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Wednesday, March 22, 2017 9:28 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH 0/2] MdeModulePkg/Ufs: Wait fDeviceInit be cleared by devices during init The series changes the UFS host to wait

Re: [edk2] NvmExpressDxe async application crash with UDK debugger

2017-04-11 Thread Tian, Feng
Arka, Could you please share us your test code? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka Sharma Sent: Wednesday, April 12, 2017 12:59 PM To: edk2-devel@lists.01.org Subject: [edk2] NvmExpressDxe async application crash wi

Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

2017-04-11 Thread Tian, Feng
PS: lt's a typo on pkg name: IntelFWMdlPkg/IdeBusDxe: Fix undefined behavior in signed left shift -Original Message- From: Tian, Feng Sent: Wednesday, April 12, 2017 9:53 AM To: Wu, Hao A ; edk2-devel@lists.01.org; guoh...@huawei.com Cc: Tian, Feng Subject: RE: [PATCH v3 0/5

Re: [edk2] [PATCH v3 0/5] Fix undefined behavior in signed left shift

2017-04-11 Thread Tian, Feng
Series reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Wednesday, April 12, 2017 9:52 AM To: edk2-devel@lists.01.org; guoh...@huawei.com Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH v3 0/5] Fix undefined behavior in signed left shift After searching the whole code base

Re: [edk2] [PATCH 3/3] UefiCpuPkg: Error Level is not used correctly

2017-04-11 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Monday, April 10, 2017 2:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Yao, Jiewen Subject: [PATCH 3/3] UefiCpuPkg: Error Level is not used correctly Cc: Feng Tian Cc: Jiewen Yao Contributed-under: TianoCore

Re: [edk2] [PATCH 1/3] MdeModulePkg: Error Level is not used correctly

2017-04-11 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Monday, April 10, 2017 2:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH 1/3] MdeModulePkg: Error Level is not used correctly Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

2017-04-10 Thread Tian, Feng
ource UEFI driver for use. Thanks Feng -Original Message- From: Vladimir Olovyannikov [mailto:vladimir.olovyanni...@broadcom.com] Sent: Tuesday, April 11, 2017 12:14 AM To: Tian, Feng ; edk2-devel@lists.01.org Subject: RE: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform Hi Fe

Re: [edk2] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed left shift

2017-04-10 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Tuesday, April 11, 2017 9:30 AM To: edk2-devel@lists.01.org; ler...@redhat.com; guoh...@huawei.com Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH v2] MdeModulePkg/ScsiDiskDxe: Fix undefined behavior in signed

Re: [edk2] Using USB-Ethernet adapter in UEFI on an arm64 platform

2017-04-09 Thread Tian, Feng
Hi, Vladimir, Which usb2lan driver you are using for AX88772 adpater? The one in OptionRomPkg\Bus\Usb\UsbNetworking has bug on the polling performance. The one in OptionRomPkg\Bus\Usb\UsbNetworking\Ax88772b is better but if there is no data received, the polling operation still wastes some time

Re: [edk2] NvmExpressDxe TimerEvent frequency

2017-04-09 Thread Tian, Feng
Yes. For example, old platforms usually use 50ms as timer interval. So at such platforms, even the code is programming to use 1 ms timer, the actual trigger time interval is 50ms. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Arka

Re: [edk2] [PATCH] UefiCpuPkg/CpuFeatures: Change CPU features name to follow IA32 SDM

2017-04-06 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Thursday, April 6, 2017 1:47 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Tian, Feng Subject: [edk2] [PATCH] UefiCpuPkg/CpuFeatures

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Enhance short-form expanding logic

2017-04-06 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, April 6, 2017 5:45 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Dong, Eric ; Fan, Jeff Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Enhance short-form expanding logic Old implementation

Re: [edk2] [PATCH] UefiCpuPkg/MpLib.c: Load microcode before mtrr sync per IA32 SDM

2017-04-04 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Wednesday, April 5, 2017 11:07 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Kinney, Michael D ; Tian, Feng Subject: [PATCH] UefiCpuPkg/MpLib.c: Load microcode before mtrr sync per IA32 SDM Ref: https

Re: [edk2] DisconnectController API not working.

2017-04-04 Thread Tian, Feng
Kumar, Do "map -r" at first please. PS: for the issue you encounter, are you trying to disconnect the usb controller in use? Please note at this time you are reading the file from usb key. It means the disconnect will never succeed. Thanks Feng -Original Message- From: edk2-devel [m

Re: [edk2] [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF

2017-03-30 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Gao, Liming Sent: Friday, March 31, 2017 1:04 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [Patch] MdeModulePkg: Remove unsupported PcdExpression usage in module INF https://bugzilla.tianocore.org

Re: [edk2] [PATCH 1/2] MdeModulePkg/Tcp4Dxe: Fix unconditional window shrinking

2017-03-28 Thread Tian, Feng
Adding network module owners for further review. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of ate...@kraftway.ru Sent: Tuesday, March 28, 2017 3:20 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 1/2] MdeModulePkg/Tcp4Dxe: Fi

Re: [edk2] [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue

2017-03-27 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Bi, Dandan Sent: Tuesday, March 28, 2017 9:02 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Tian, Feng Subject: [patch 1/2] MdeModulePkg/MemoryProtection: Fix coding style issue Cc: Ard Biesheuvel Cc: Feng Tian

Re: [edk2] [PATCH v2] UefiCpuPkg/MpLib.c: Add checking CR0 PG bit

2017-03-27 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Tuesday, March 28, 2017 8:57 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH v2] UefiCpuPkg/MpLib.c: Add checking CR0 PG bit If CR0 PG bit is not set, it means paging is not

Re: [edk2] [PATCH 0/2] [UefiCpuPkg] Support 64bit MMIO address in CPU Register Table

2017-03-26 Thread Tian, Feng
Series Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff Sent: Thursday, March 23, 2017 1:28 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] [UefiCpuPkg] Support 64bit MMIO address in CPU Reg

Re: [edk2] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Add ASSERT on allocated memory

2017-03-26 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff Sent: Thursday, March 23, 2017 3:21 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Tian, Feng Subject: [edk2] [PATCH] UefiCpuPkg

Re: [edk2] [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues.

2017-03-26 Thread Tian, Feng
Series Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 27, 2017 11:02 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues. Cc: Feng Tian Cc

Re: [edk2] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Set CpuFeatureEntry initial value

2017-03-22 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Thursday, March 23, 2017 9:45 AM To: edk2-de...@ml01.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Set CpuFeatureEntry initial value CpuFeatureEntry will be set before

Re: [edk2] [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix case write issue

2017-03-22 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Thursday, March 23, 2017 9:16 AM To: edk2-de...@ml01.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/CpuCommonFeaturesLib: Fix case write issue Cc: Feng Tian Cc: Michael Kinney Contributed-under

Re: [edk2] [PATCH v5 00/11] Add CPU features driver

2017-03-21 Thread Tian, Feng
Series Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 20, 2017 4:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH v5 00/11] Add CPU features driver This serial of patches will add CPU featuers

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

2017-03-19 Thread Tian, Feng
Ok to me as well. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Monday, March 20, 2017 10:16 AM To: Laszlo Ersek ; edk2-devel-01 Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star Subject: RE: [PATCH v2 03/12] MdeModulePkg

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Remove MSR_IA32_MISC_ENABLE check

2017-03-16 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, March 15, 2017 9:55 AM To: edk2-devel@lists.01.org Cc: Anthony PERARD ; Tian, Feng ; Yao, Jiewen Subject: [edk2] [PATCH] UefiCpuPkg

Re: [edk2] [PATCH] MdeModulePkg/LogoDxe: Add missing dependency gEfiHiiImageExProtocolGuid

2017-03-16 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, March 16, 2017 2:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Dong, Eric Subject: [edk2] [PATCH] MdeModulePkg/LogoDxe: Add missing

Re: [edk2] [PATCH] Nt32Pkg: Use Shell source code directly

2017-03-16 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Thursday, March 16, 2017 1:58 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH] Nt32Pkg: Use Shell source code directly Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by

Re: [edk2] Testing NVMe async commands

2017-03-15 Thread Tian, Feng
Hi, Sharma As far as I know, we have UEFI SCT test suite to cover NVME_PASS_THRU async test. But it's not complex as your case. As you have sent 210720 cmds, it's more like memory leak issue. Could you please only send 1 cmds and compare the memory map change before and after? If there is

Re: [edk2] [PATCH 3/3] MdeModulePkg BmPerf: Handle "/" separator in debug path for GCC build

2017-03-14 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, March 15, 2017 1:51 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming ; Ni, Ruiyu ; Tian, Feng Subject: [PATCH 3/3] MdeModulePkg BmPerf: Handle "/" separator in debug path for

Re: [edk2] [PATCH 0/3] Add Context in SmiHandlerProfileUnregister.

2017-03-12 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 13, 2017 10:06 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star ; Bret Barkelew Subject: RE: [PATCH 0/3] Add Context in SmiHandlerProfileUnregister. Reviewed-by: Jeff

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot description for NVME

2017-03-12 Thread Tian, Feng
There is no such library class/instance. It should be HPE-specific stuff. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, March 13, 2017 10:24 AM To: Wang, Sunny (HPS SW) ; edk2-devel@lists.01.org Cc: Tian, Feng ; Haskell, Darrell Subject: RE

Re: [edk2] [PATCH v3 02/12] MdeModulePkg: Refine casting expression result to bigger size

2017-03-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 1:12 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star Subject: [PATCH v3 02/12] MdeModulePkg: Refine casting expression result to bigger size There are

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: Refine type cast for pointer subtraction

2017-03-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Saturday, February 25, 2017 12:05 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star Subject: [PATCH v3 1/6] MdeModulePkg: Refine type cast for pointer subtraction For pointer subtraction

Re: [edk2] [Patch] MdeModulePkg: use LShiftU64() instead of "<<" to avoid IA32 build error.

2017-02-28 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, March 1, 2017 12:13 PM To: Fu, Siyuan ; edk2-devel@lists.01.org Cc: Tian, Feng ; Ard Biesheuvel ; Zeng, Star Subject: RE: [Patch] MdeModulePkg: use LShiftU64() instead of "<<" to a

Re: [edk2] [PATCH v3 1/6] MdeModulePkg: Add DxeBmDmaLib (BmDmaLib class) library

2017-02-28 Thread Tian, Feng
A minor comment: > + LIBRARY_CLASS = BmDmaLib|DXE_DRIVER Shouldn't this lib support UEFI driver? Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Wednesday, March 1, 2017 10:39 AM To: Leo Duran ; edk2-de...@ml01.01.org Cc: Tian, Feng ; Zeng, Star Sub

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove used SetCacheability()

2017-02-26 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, February 27, 2017 1:31 PM To: edk2-devel@lists.01.org Cc: Leo Duran ; Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove used SetCacheability() No one uses the internal

Re: [edk2] Should Path Name in File Path Media Device Path node be NULL terminated?

2017-02-23 Thread Tian, Feng
UEFI spec clearly say: "Path Name" is A NULL-terminated Path string including directory and file names. The length of this string n can be determined by subtracting 4 from the Length entry. A device path may contain one or more of these nodes. Each node can optionally add a "\" separator to the

Re: [edk2] [PATCH v3 2/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro

2017-02-23 Thread Tian, Feng
Linton, Could you let me know where the +#define EFI_SCSI_REQUEST_SENSE_ERROR (0x70) comes from? According to SCSI SPC5r08 spec, the first byte of sense data is the RESPONSE CODE field. And 0x70 means a) the result of an error, exception condition, or protocol specific failure that is asso

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

2017-02-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, February 24, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Zeng, Star ; Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

Re: [edk2] [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure

2017-02-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Friday, February 24, 2017 9:56 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng ; Yao, Jiewen Subject: [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure Cc: Feng Tian Cc: Jiewen

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Replace EFI_D_xxx with DEBUG_xxx in DEBUG()

2017-02-21 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Wednesday, February 22, 2017 3:56 PM To: edk2-de...@ml01.01.org Cc: Laszlo Ersek ; Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/CpuDxe: Replace EFI_D_xxx with DEBUG_xxx in DEBUG() Cc: Laszlo

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix hard code actual TimerPeriod value

2017-02-21 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Monday, February 20, 2017 4:38 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix hard code actual TimerPeriod value Current CpuGetTimerValue() implementation return

Re: [edk2] [PATCH] MdeModulePkg/SdMmc: Avoid assigning 0 to the BlockSize of Trb

2017-02-19 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Monday, February 20, 2017 11:06 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH] MdeModulePkg/SdMmc: Avoid assigning 0 to the BlockSize of Trb Refine code to avoid potential divide

Re: [edk2] [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic

2017-02-08 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, February 9, 2017 3:05 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [edk2] [PATCH v2] MdeModulePkg PiSmmIpl

Re: [edk2] [PATCH v2 1/6] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of PCI_BAR_ALL

2017-02-07 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, February 6, 2017 2:01 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH v2 1/6] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of PCI_BAR_ALL When BarIndex equals to 0xFF, default

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Tian, Feng
MdeModulePkg reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, February 8, 2017 9:45 AM To: Rebecca Cran ; edk2-devel@lists.01.org Cc: Tian, Feng ; Fu, Siyuan ; Wu, Jiaxin ; Gao, Liming ; Zeng, Star Subject: RE: [PATCH] Fix some typos of

Re: [edk2] [PATCH v2 2/6] MdeModulePkg/PciBus: Accept Spec values as BarIndex and Alignment

2017-02-06 Thread Tian, Feng
2/3/4 looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, February 6, 2017 2:01 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff ; Tian, Feng Subject: [PATCH v2 2/6] MdeModulePkg/PciBus: Accept Spec values as BarIndex and Alignment PI

Re: [edk2] [PATCH 3/3] MdeModulePkg/DxeCore: Add UEFI image protection.

2017-02-05 Thread Tian, Feng
Jiewen, So where will you add such limitation statements? In this commit log or other places? Thanks Feng From: Gao, Liming Sent: Saturday, February 4, 2017 11:40 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Tian, Feng ; Zeng, Star Subject: RE: [edk2] [PATCH 3/3

Re: [edk2] [PATCH 1/2] MdeModulePkg/AcpiTableDxe: condense whitespace around FADT.{DSDT, X_DSDT}

2017-02-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 2, 2017 1:57 AM To: edk2-devel-01 Cc: Al Stone ; Ard Biesheuvel ; Tian, Feng ; Igor Mammedov ; Leo Duran ; Michael Tsirkin ; Phil Dennis-Jordan ; Zeng, Star

Re: [edk2] [Patch] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic

2017-02-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Gao, Liming Sent: Friday, February 3, 2017 9:35 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [Patch] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic Cc: Star Zeng Cc: Feng

Re: [edk2] [PATCH 2/3] MdeModulePkg: Update PcdSmbiosDocRev to 0x1 for SMBIOS spec 3.1.1

2017-01-23 Thread Tian, Feng
reviewed-by: Feng Tian -Original Message- From: Zeng, Star Sent: Sunday, January 22, 2017 4:18 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng ; Gao, Liming Subject: [PATCH 2/3] MdeModulePkg: Update PcdSmbiosDocRev to 0x1 for SMBIOS spec 3.1.1 REF: https

Re: [edk2] [PATCH 1/3] MdeModulePkg/FrameBufferBltLib: Refine ConfigurePixelBitMaskFormat

2017-01-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, January 23, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH 1/3] MdeModulePkg/FrameBufferBltLib: Refine ConfigurePixelBitMaskFormat https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2] [PATCH 2/3] MdeModulePkg/FrameBufferBltLib: Use dynamic allocated line buffer

2017-01-23 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, January 23, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH 2/3] MdeModulePkg/FrameBufferBltLib: Use dynamic allocated line buffer https://bugzilla.tianocore.org/show_bug.cgi

Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public

2017-01-19 Thread Tian, Feng
MdeModulePkg reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, January 19, 2017 6:30 PM To: Zeng, Star ; edk2-devel@lists.01.org ; Kinney, Michael D ; Fan, Jeff ; Tian, Feng ; Ni, Ruiyu ; Ma

Re: [edk2] Why is USB_BOOT_IO_BLOCKS set to 128?

2017-01-18 Thread Tian, Feng
please tell me the device model/serial no, then we can modify this value accordingly. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Wednesday, January 18, 2017 2:41 PM To: Tian, Feng ; edk2-devel@lists.01.org Cc: Zeng

Re: [edk2] [PATCH 0/3] Add SMBIOS spec 3.1.0 support

2017-01-16 Thread Tian, Feng
MdeModulePkg reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Tuesday, January 17, 2017 11:25 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming ; Kinney, Michael D ; Tian, Feng ; Ni, Ruiyu ; Carsey, Jaben Subject: [PATCH 0/3] Add SMBIOS spec

Re: [edk2] [PATCH v2 5/5] MdeModulePkg/UfsBlockIoPei: fix initialize OCS value to 0x0F

2017-01-16 Thread Tian, Feng
, January 17, 2017 12:03 AM To: Haojian Zhuang Cc: Tian, Feng ; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Subject: Re: [PATCH v2 5/5] MdeModulePkg/UfsBlockIoPei: fix initialize OCS value to 0x0F On Mon, Jan 16, 2017 at 08:22:58PM +0800, Haojian Zhuang wrote: > The OCS value should

Re: [edk2] [PATCH 1/8] MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types

2017-01-10 Thread Tian, Feng
Series reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Tuesday, January 10, 2017 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [PATCH 1/8] MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types Contributed-under

Re: [edk2] [PATCH] MdeModulePkg/Stall: Refine to compare 2 values with the same type

2017-01-10 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, January 6, 2017 4:52 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star ; Kinney, Michael D Subject: [PATCH] MdeModulePkg/Stall: Refine to compare 2 values with the same type Cc

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

2017-01-10 Thread Tian, Feng
: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Tian, Feng Subject: Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register Hi Feng, What’s the commit number of the old EDKII UFS driver? Best Regards Haojian From: Tian, Feng

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

2017-01-09 Thread Tian, Feng
--Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of haojian.zhu...@linaro.org Sent: Tuesday, January 10, 2017 2:09 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Tian, Feng Subject: Re: [edk2] [PATCH 4/9] U

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

2017-01-08 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Monday, January 9, 2017 1:06 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages Reviewed-by: Star Zeng

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

2017-01-08 Thread Tian, Feng
this, your fix also disobeys the UFS spec, which requests the UTRLBA is 1KB align. [cid:image003.jpg@01D26A5A.4655E180] Thanks Feng From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, January 6, 2017 5:06 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org

Re: [edk2] [PATCH 6/9] Ufs: add PhyInit

2017-01-06 Thread Tian, Feng
Yes, I am thinking moving UFS HC enable to lower layer, this way should be able to eliminate interface change... Thanks Feng -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, January 6, 2017 4:22 PM To: Tian, Feng Cc: leif.lindh...@linaro.org

Re: [edk2] [PATCH 8/9] Ufs: fix to add cache operation

2017-01-06 Thread Tian, Feng
: Friday, January 6, 2017 2:52 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang Subject: [PATCH 8/9] Ufs: fix to add cache operation Since command UPIU is initialized with virtual address that CPU accesses, need to add cache

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

2017-01-06 Thread Tian, Feng
Hi, Haojian If the UTRLBA & UTRLBAU gets changed like below, the doorbell location also should be updated. So I don't suggest to update them. Thanks Feng -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Friday, January 6, 2017 2:52 PM To: T

Re: [edk2] [PATCH 9/9] ScsiDisk: retry if device detected power failure

2017-01-06 Thread Tian, Feng
2:52 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang Subject: [PATCH 9/9] ScsiDisk: retry if device detected power failure If device detected power failure, just retry. This operation is common in linux kernel. Contributed-under:

Re: [edk2] [PATCH 6/9] Ufs: add PhyInit

2017-01-05 Thread Tian, Feng
Could this be done at lower layer rather than changing existing interface? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu

Re: [edk2] [PATCH 7/9] Ufs: fix initialize OCS value to 0x0F

2017-01-05 Thread Tian, Feng
Same with previous patches, could you please fix Ufs PEI driver as well? Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng ; leif.lindh

Re: [edk2] [PATCH 3/9] Ufs: fix the bit in UFS_HC_UTRLDBR_OFFSET register

2017-01-05 Thread Tian, Feng
Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang Subject: [edk2] [PATCH 3/9] Ufs: fix the bit in UFS_HC_UTRLDBR_OFFSET register When UPIU packet is sent, (BIT0 << Slot) sho

Re: [edk2] [PATCH 2/9] Ufs: fix to identify 32 bits address mode

2017-01-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Friday, January 6, 2017 2:52 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian

Re: [edk2] [PATCH 1/9] Ufs: fix data direction checking

2017-01-05 Thread Tian, Feng
Friday, January 6, 2017 2:52 PM To: Tian, Feng ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel@lists.01.org Cc: Haojian Zhuang Subject: [edk2] [PATCH 1/9] Ufs: fix data direction checking BIT6 is used in read operation, and BIT5 is used in write operation. Contributed-u

Re: [edk2] [patch] MdeModulePkg/StaControllerDxe: Fix coding style issue

2017-01-04 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Bi, Dandan Sent: Thursday, January 5, 2017 1:22 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [patch] MdeModulePkg/StaControllerDxe: Fix coding style issue Remove the empty line. Cc: Feng Tian Contributed-under

Re: [edk2] [PATCH 0/6] Support source debugging on DXE AP function

2016-12-27 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, December 26, 2016 7:21 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney; Kinney, Michael D ; Ni, Ruiyu Subject: [PATCH 0/6] Support source debugging on DXE AP function The current

Re: [edk2] [PATCH 0/2] Handle NULL capsule name in record.

2016-12-22 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, December 22, 2016 1:48 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/2] Handle NULL capsule name in record. According to UEF

Re: [edk2] [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check.

2016-12-22 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, December 22, 2016 11:45 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [edk2] [PATCH] MdeModulePkg/CapsuleLib

Re: [edk2] [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue

2016-12-19 Thread Tian, Feng
To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf | 2 +- 1 file

Re: [edk2] [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration

2016-12-19 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Bi, Dandan Sent: Monday, December 19, 2016 3:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration Cc: Feng Tian Contributed-under: TianoCore

Re: [edk2] [patch 5/8] MdeModulePkg/EmmcDxe: Avoid Non-Boolean type used as Boolean

2016-12-18 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, December 19, 2016 3:20 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [edk2] [patch 5/8] MdeModulePkg/EmmcDxe: Avoid Non-Boolean

Re: [edk2] [patch] MdeModulePkg: Fix assert in iSCSI.

2016-12-06 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, December 1, 2016 2:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [edk2] [patch] MdeModulePkg: Fix assert in iS

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Always initialze PSD

2016-12-05 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Kinney, Michael D Sent: Tuesday, December 6, 2016 11:57 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Fan, Jeff ; Tian, Feng Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Always initialze PSD The following commit moved the

Re: [edk2] [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name.

2016-12-01 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Yao, Jiewen Sent: Thursday, December 1, 2016 4:51 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Fan, Jeff Subject: [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name. To prevent potential build failure. Cc

Re: [edk2] [PATCH 0/3] mReservedVectors is not set

2016-11-30 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, November 30, 2016 3:23 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/3] mReservedVectors is not set mReservedVectors is used b

Re: [edk2] [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD

2016-11-30 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Thursday, December 1, 2016 12:58 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Tian, Feng Subject: RE: [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD Reviewed-by: Jeff Fan on

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-30 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 30, 2016 4:48 PM To: Fan, Jeff ; edk2-de...@ml01.01.org Cc: Kinney, Michael D ; Tian, Feng ; Yao, Jiewen Subject: Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Replace deprecated debug level macros

2016-11-29 Thread Tian, Feng
Reviewed-by: Feng Tian I will help push it into EDKII trunk. Thanks Feng -Original Message- From: Marcin Wojtas [mailto:m...@semihalf.com] Sent: Tuesday, November 29, 2016 9:52 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D ; Gao, Liming ; leif.lindh...@linaro.org

Re: [edk2] [PATCH v2] MdeModulePkg/AtaAtapiPassThru: Ensure GHC.AE bit is always set in Ahci

2016-11-24 Thread Tian, Feng
Reviewed-by: Feng Tian Do you want me to push it into EDKII trunk? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marcin Wojtas Sent: Thursday, November 24, 2016 3:55 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; ard.biesheu

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: Set GHC.AE bit unconditionally for Ahci

2016-11-23 Thread Tian, Feng
PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Gao, Liming ; Kinney, Michael D Subject: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: Set GHC.AE bit unconditionally for Ahci According to AHCI Spec 1.3 GHC.AE bit description: "The impleme

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

2016-11-18 Thread Tian, Feng
nks Feng -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, November 18, 2016 2:57 PM To: Tian, Feng Cc: Ni, Ruiyu ; Kinney, Michael D ; edk2-devel@lists.01.org; Gao, Liming ; af...@apple.com; Leif Lindholm Subject: Re: [edk2] [PATCH v3

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

2016-11-17 Thread Tian, Feng
Ard, I have another question. Is it the only way to specify device type in below enum? Looks like it will be changed often. Is it possible to make use of DevicePath node? Of course, I have no good idea to handle AMBA controller... +// +// Data Types +// +typedef enum { + NonDiscoverableDevice

Re: [edk2] [PATCH 0/6] UefiCpuPkg/MpInitLib: Program AP stack in fixed address

2016-11-16 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, November 14, 2016 11:47 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Wu, Hao A ; Kinney, Michael D Subject: [PATCH 0/6] UefiCpuPkg/MpInitLib: Program AP stack in fixed address Currently, MpInitLib

Re: [edk2] USB hub port reset

2016-11-15 Thread Tian, Feng
To: Tian, Feng ; edk2-devel@lists.01.org Subject: Re: [edk2] USB hub port reset Feng, Below change solves the problem with a device behind the hub. Do we still need the 10ms delay in UsbHubResetPort function for manual port reset in case of XHCI? Thanks, Baranee -Original Message- From

Re: [edk2] [PATCH] UefiCpuPkg/SecCore: Use %x to print stack information

2016-11-15 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Tuesday, November 15, 2016 4:32 PM To: edk2-de...@ml01.01.org Cc: Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/SecCore: Use %x to print stack information SecCoreData->StackBase is VOID * t

Re: [edk2] USB hub port reset

2016-11-14 Thread Tian, Feng
ontext[SlotId].InputContext, sizeof (INPUT_CONTEXT_64)); CmdTrbAddr.PtrLo= XHC_LOW_32BIT (PhyAddr); Could you please have a try to see if it solves your problem? Thanks Feng -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Monday, November 14, 2016 9:46 PM

Re: [edk2] USB hub port reset

2016-11-13 Thread Tian, Feng
ection 9.4 respectively) after the reset recovery time 10 ms (TRSTRCY) after the reset is removed." Thanks Feng -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Monday, November 14, 2016 11:33 AM To: Tian, Feng ; edk2-devel@lists.01.org Subject: R

  1   2   3   4   5   >