Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-18 Thread Laszlo Ersek
On 02/17/16 21:25, Leif Lindholm wrote: > On Tue, Feb 16, 2016 at 06:51:45PM +0100, Laszlo Ersek wrote: >> On 02/16/16 17:36, Jeremy Linton wrote: >>> |Not wishing to influence the discussion, just out of curiosity: Jeremy >>> |mentions "numerous other BlockIo protocol providers in edk2 bounce IO

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-17 Thread Leif Lindholm
On Tue, Feb 16, 2016 at 06:51:45PM +0100, Laszlo Ersek wrote: > On 02/16/16 17:36, Jeremy Linton wrote: > > |Not wishing to influence the discussion, just out of curiosity: Jeremy > > |mentions "numerous other BlockIo protocol providers in edk2 bounce IO > > |operations rather than simply allowing

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-16 Thread Laszlo Ersek
On 02/16/16 17:36, Jeremy Linton wrote: > > (trimming) > > |Not wishing to influence the discussion, just out of curiosity: Jeremy > |mentions "numerous other BlockIo protocol providers in edk2 bounce IO > |operations rather than simply allowing them to fail" -- can we see some > |examples? I

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-16 Thread Jeremy Linton
(trimming) |Not wishing to influence the discussion, just out of curiosity: Jeremy |mentions "numerous other BlockIo protocol providers in edk2 bounce IO |operations rather than simply allowing them to fail" -- can we see some |examples? I wonder if, upon seeing that code, we could use "git

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-15 Thread Tian, Feng
: edk2-devel@lists.01.org; Leif Lindholm Subject: Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned On 02/15/16 03:18, Tian, Feng wrote: > Hi, Jeremy > > Sorry for missing this mail. > > I would *REJECT* this patch as it should be grub2's bug in

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-15 Thread Laszlo Ersek
21:23 > To: Jeremy Linton > Cc: edk2-devel@lists.01.org; Leif Lindholm > Subject: Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO > operations if unaligned > > Hi Jeremy, > > On 15 January 2016 at 15:20, Jeremy Linton <jeremy.lin...@arm.com> wrote: >&

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-14 Thread Tian, Feng
Of Ryan Harkin Sent: Tuesday, February 09, 2016 21:23 To: Jeremy Linton Cc: edk2-devel@lists.01.org; Leif Lindholm Subject: Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned Hi Jeremy, On 15 January 2016 at 15:20, Jeremy Linton <jeremy.lin...@arm.com> wrote:

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-09 Thread Ryan Harkin
Hi Jeremy, On 15 January 2016 at 15:20, Jeremy Linton wrote: > BlockIo Protocol devices specify a buffer alignment requirement in > their media descriptors. This should be honored by users of the protocol. > In cases where the user of the protocol (grub2 in this case) fail

[edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-01-15 Thread Jeremy Linton
BlockIo Protocol devices specify a buffer alignment requirement in their media descriptors. This should be honored by users of the protocol. In cases where the user of the protocol (grub2 in this case) fail to correctly align their buffers, IO failures occur. Apparently this has been known for a