Re: [edk2] [Patch] BaseTool: Add cache for the result of SkipAutogen.

2018-07-02 Thread Gao, Liming
OK. Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Monday, July 02, 2018 11:13 AM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Feng, Bob C >Subject: RE: [Patch] BaseTool: Add cache for the result of SkipAutogen. > >Hi Liming, > >Based on my testing, a module

Re: [edk2] [Patch] BaseTool: Add cache for the result of SkipAutogen.

2018-07-01 Thread Feng, Bob C
Hi Liming, Based on my testing, a module will enter the CanSkip() multiple times even after CanSkip() return True. In this patch, I cache the module after CanSkip() return True to save the cost of later CanSkip() evaluation. I think the CanSkip() will always return True after it return True at

Re: [edk2] [Patch] BaseTool: Add cache for the result of SkipAutogen.

2018-07-01 Thread Gao, Liming
Bob: When will this cache take effective? Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Monday, July 02, 2018 9:16 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTool: Add cache for the result of SkipAutogen. > >Add a cache for the

[edk2] [Patch] BaseTool: Add cache for the result of SkipAutogen.

2018-07-01 Thread BobCF
Add a cache for the value of skip ModuleAutoGen process flag. This cache can improve build performance. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4