hi Andrew,
On Thu, 2014-09-11 at 06:59 -0700, Andrew Fish wrote:
On Sep 11, 2014, at 2:43 AM, Chen, Fan chen.fan.f...@cn.fujitsu.com
wrote:
Why did you get rid of sending IPI to wake up APs? Do you
encounter any issue with it?
From your patch, I don't know why StarupThisAP
Thank You all for your inputs.
On Mon, Sep 15, 2014 at 10:24 PM, Andrew Fish af...@apple.com wrote:
On Sep 15, 2014, at 8:57 AM, Deric Cole deric_c...@phoenix.com wrote:
You can use AsciiValueToString from PrintLib.
I think that is the opposite endian to the example. 0x43313031 would
Hi Olivier, Jaben,
The check in r15180 caused the shell always return EFI_ABORTED no matter what
exit-code user specifies for exit command. It's a critical bug for shell user
who does different things upon different exit-codes.
The issue is because the error status was returned in the ExitData.
Mike/others,
Further info...
I've cloned https://github.com/tianocore/edk2,
Downloaded the Linaro toolchain binaries, 'wget
http://releases.linaro.org/13.07/components/toolchain/binaries/gcc-linaro-aarch64-linux-gnu-4.8-2013.07-1_linux.tar.xz'
Unpacked them ' tar xf
Bruce Cran [mailto:bruce.c...@gmail.com] wrote:
] An excellent idea. I just tried it and it works great. I did the test
] building on Windows 7 X64. I built several projects for IA32 and X64.
] They all build without and compiler warning adjustments. One thing
] DDK3790 has that DDK7600 lacks is
The rollback looks good to me.
I did not doing any testing of it.
-Jaben
From: Ni, Ruiyu
Sent: Wednesday, September 17, 2014 2:54 AM
To: Olivier Martin; Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg: Return correct exit-code in exit command to
caller
Reviewed-by: Erik Bjorge erik.c.bjo...@intel.com
From: Leahy, Leroy P
Sent: Friday, September 12, 2014 4:34 PM
To: Bjorge, Erik C; Carsey, Jaben; Kinney, Michael D; Mudusuru, Giri P
Cc: edk2-devel@lists.sourceforge.net
Subject: EDK2: Remove trailing spaces
Attestation:
I have made the following
On Sep 16, 2014, at 11:42 PM, Chen, Fan chen.fan.f...@cn.fujitsu.com wrote:
hi Andrew,
On Thu, 2014-09-11 at 06:59 -0700, Andrew Fish wrote:
On Sep 11, 2014, at 2:43 AM, Chen, Fan chen.fan.f...@cn.fujitsu.com
wrote:
Why did you get rid of sending IPI to wake up APs? Do you
Joe Thomas,
THANK YOU! I was pointing to the wrong toolchain.
I think I got confused with all of the different Env vars.
This solves my problem with cross development.
I did have to fix a lot of 'set but not used' errors.
Regards,
Mike
-Original Message-
From: Joe Thomas
Sorry for the delay.
Reviewed-by: Chris Phillips chr...@hp.commailto:chr...@hp.com
From: Qiu, Shumin [mailto:shumin@intel.com]
Sent: Sunday, September 14, 2014 9:24 PM
To: Phillips, Chris J (Plano, TX); Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] ShellPkg:
When you compile BaseTools with clang you get 100’s of warnings for VfrCompile.
The attached patch fixes these warnings.
It is probably possible to do the same thing for GCC, but some one would need
to test that out. If the flag list ends up being different it should be easy to
add the GCC
Jaben or Erik: Could you please review the attached patches.
These are all 1-line changes, except for StdLib.inc, which is a 2-line change.
StdLib: Produce DevMedia as a library class alternative to DevShell.
AppPkg: Replace existing DevShell dependencies with DevMedia.
These patches will NOT
BaseTools maintainers, any feedback on this one?
If no one comment on this change by the next Wednesday (September 25th) I will
commit it.
From: Olivier Martin [olivier.mar...@arm.com]
Sent: 13 August 2014 11:30
To: edk2-devel@lists.sourceforge.net
Hi Jaben,
Could you help to review the patch? Refine code style to avoid potential
uninitialized local variable.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin shumin@intel.commailto:shumin@intel.com
Thanks,
Shumin
ShellPkg.patch
Description:
All APs use the same common stack to initialization. after
initialization, APs should switch to the stack of its own.
the sequences are:
1. BSP detects AP count
2. BSP allocates AP stack spaces
3. AP grabs a lock
4. AP SwitchStack
5. AP releases lock
Contributed-under: TianoCore
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuDxe.inf | 1 +
UefiCpuPkg/CpuDxe/CpuMp.c| 174 ++-
UefiCpuPkg/CpuDxe/CpuMp.h| 50 +
when Ap graps a lock and call CpuMp.c:ApEntryPointInC,
it should switch to stack of its' own and release the
lock to let others Ap call CpuMp.c:ApEntryPointInC
sequential. and StartCode should be not freed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan
This series patchset try to implement Mp Service protocol in UefiCpuPkg,
Jordan had implemented the startup APs code, and I try to add more
initialization code to let all APs work up, this Mp Service protocol's
implementation used EmulatorPkg/MpService for reference.
this patches works on my
From: Jordan Justen jordan.l.jus...@intel.com
This is the function the AP assembly code will expect to call after
getting a lock and setting up the stack.
Only one AP will enter this routine at a time.
If ApEntryPointInC exits, then the assembly code will loop around to
grab the lock, setup the
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 127 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 73 ++
2 files changed, 199 insertions(+), 1
From: Jordan Justen jordan.l.jus...@intel.com
This sequence should happen:
* CpuMp.c: Allocate a stack for the APs
* ApStartup.c: Send Start IPI to wake APs in 16-bit real mode
* MpAsm.S: AP enters CpuDxe driver code without stack
- AP grabs a lock
- AP sets up stack
- AP calls
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 56 ++-
UefiCpuPkg/CpuDxe/CpuMp.h | 35 +
2 files changed, 90 insertions(+), 1
From: Jordan Justen jordan.l.jus...@intel.com
This routine starts the APs and directs them to run the specified
code.
The specified code is entered without a stack being available.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
From: Jordan Justen jordan.l.jus...@intel.com
TODO: Port to MASM
TODO: Remove unused GNU Assembler
The AP startup code simply jumps into this code with the CpuDxe driver
without setting up a stack for the processor.
Therefore, this code must setup the stack before calling into C code.
This is
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 64 +++
UefiCpuPkg/CpuDxe/CpuMp.h | 31 +++
2 files changed, 85 insertions(+), 10
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 465 +-
UefiCpuPkg/CpuDxe/CpuMp.h | 161
2 files changed, 625 insertions(+), 1 deletion(-)
NOTE: this patches is for testing temporary.
So it should be ignore when adding to main tree.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuDxe.c| 2 ++
UefiCpuPkg/CpuDxe/CpuDxe.inf | 1 +
we used the AcquireSpinLock()/ReleaseSpinLock() in SynchronizationLib
to synchronize data. maybe it is not MP safe.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 330
by now, SwitchBSP() always return UNSUPPORTED
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
UefiCpuPkg/CpuDxe/CpuMp.c | 47 ++-
UefiCpuPkg/CpuDxe/CpuMp.h | 43
there were some bugs in function StartupAllAPs(), we need
fix them.
Chen Fan (4):
EmulatorPkg/MpService: Fix a NULL reference
EmulatorPkg/MpService: use simple pointer access
EmulatorPkg/MpService: Check Processor State when Set Procedure
EmulatorPkg/MpService: remove redundant
we had set the AP procedure in StartupAllAPs(), so do not need
to set AP procedure twice.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
EmulatorPkg/CpuRuntimeDxe/MpService.c | 4
1 file changed, 4 deletions(-)
diff --git
31 matches
Mail list logo
