Re: [edk2] Question on DSC double includes

Hi Folks, Unfortunately, we are just getting ready to put updates to the DSC and FDF specs out on the web. The next revision of the specs probably won’t come out until the end of the year. Until that time, we can use this e-mail. I will update statements in the specs from “may not” to “should no

Re: [edk2] [Basetool][Upt][patch]Update help message of UPT

Reviewed-by: lhauch Cheers, Larry From: Chen, Hesheng Sent: Thursday, June 11, 2015 6:31 PM To: Hauch, Larry; edk2-devel@lists.sourceforge.net Subject: [edk2][Basetool][Upt][patch]Update help message of UPT Hello Larry and all, Could you help review this patch? Thank you [Description] Update

Re: [edk2] [Basetool][Upt][patch]Update error message of installation failure

Reviewed-by: lhauch Cheers, Larry From: Chen, Hesheng Sent: Wednesday, June 17, 2015 12:20 AM To: Hauch, Larry; edk2-devel@lists.sourceforge.net Subject: [edk2][Basetool][Upt][patch]Update error message of installation failure Hello Larry and all, Could you help review this patch? Thank you

[edk2] [PATCH] BaseTools\Source\Python\Makefile

The attached patch adds new files to the Makefile for testing changed sources. The files were added April 9th, revision 17158, but the Makefile was not updated. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lhauch mailto:larry.ha...@intel.com>> Reviewed-by: Joe Peterso

Re: [edk2] [PATCH v2] BaseTools/Conf: Don't support upper case nasm extensions

Hi Jordan, So if we remove .Nasm and .NASM and someone accidentally uses these in an INF file, should the build break? Cheers, Larry -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Thursday, May 28, 2015 8:14 AM To: edk2-devel@lists.sourceforge.net Subject

[edk2] EDK II BaseTools Binaries VS2013

Hi Folks, We have updated automated build of the EDK II BaseTools Win32 binaries to be built using Microsoft* Visual Studio 2013. Refer to e-mail from Liming Gao of April 23, 2015, that states: "new binary BaseTools will not work in the old windows OS (XP and Server 2003). This is a known issue

Re: [edk2] [Patch] MdePkg/Include: Add support for flexible array members

Hi Mike, Looks good! Reviewed-by: lhauch Cheers, Larry From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, May 05, 2015 6:59 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] MdePkg/Include: Add support for flexible array members Use pragma to disable warni

Re: [edk2] Edk2Setup.bat doesn't inherit %PATH% from calling shell

-Original Message- From: Bruce Cran [mailto:bruce.c...@gmail.com] Sent: Thursday, October 30, 2014 8:22 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Edk2Setup.bat doesn't inherit %PATH% from calling shell On 10/27/2014 11:27 AM, Hauch, Larry wrote: > Actually, ORIGINAL

[edk2] [Patch] Update edksetup.bat to support VS2013

Here's a patch to update edksetup.bat to support Microsoft Visual Studio 2013 when building the Nt32Pkg emulation platform (enabled using the --nt32 flag). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lhauch Cheers, Larry Hauch Intel Corporation SSG, STO, Platform Soft

Re: [edk2] Edk2Setup.bat doesn't inherit %PATH% from calling shell

Hi, Actually, ORIGINAL_PATH is not a local variable, but is used as a flag so that when Edk2Setup (or edksetup) is run multiple times in the same command prompt window, the EDK II BaseTools path does not get added more than one time, along with other changes to the PATH. The design allowed for u

Re: [edk2] [RFC] Update INF specification

2:10 PM, Hauch, Larry wrote: > > In order to facilitate validation of INF files, we will also like to > create a new tool that can be used for content (not format) validation > of INF and DEC files. This tool would take two files as arguments, > either DEC or INF files, and

[edk2] [RFC] Update INF specification

The Intel(R) UEFI Packaging Tool, UPT.exe that is included in the BaseTools will create DEC and INF files when installing a UEFI Distribution Package (UDP). Both the INF and DEC files may have sections and content within a section that is reordered when installing a UDP. INF Spec Change When the

Re: [edk2] [Patch] Update the BaseTools/Source/Python/Makefile to check for dependent files

Larry: I find some file are still missing in build tool dependency. I update Makefile again. Please help review this patch. Thanks Liming From: Hauch, Larry [mailto:larry.ha...@intel.com] Sent: Friday, September 12, 2014 4:18 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-de

[edk2] [Patch] Update the BaseTools/Source/Python/Makefile to check for dependent files

Hi Folks, Please review the attached patch for the BaseTools\Source\Python\Makefile. The current Makefile only checks the primary python file, such as build.py and does not check other files in tool's directory tree. This modification adds all of the other files within the tool's directory tree

Re: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros in FDF files

Cheers, Larry From: Hauch, Larry [mailto:larry.ha...@intel.com] Sent: Thursday, August 28, 2014 7:29 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros in FDF files Hi Samer, I would like more information from you about your

Re: [edk2] [PATCH] BaseTools: Add support for ${s_*} and ${d_*} macros in FDF files

Hi Samer, I would like more information from you about your proposal. The rules in the EDK II FDF/DSC and Build Specs say that Macros must be defined in either the DSC or FDF files before they can be used. Are you requesting a change to this behavior or are you requesting the ability to set the

[edk2] [RFC] BaseTools/Bin/Win32/Readme.txt update with additional content

Hi Folks, I would like to update the Readme.txt file that generated by the Build Server when we update the BaseTools Win32 binaries. Please provide feedback so that I will be able to update the Build server scripts that generate the updated content on Tuesday, Sept. 2. Liming, Please review by

[edk2] [Patch RFC] Fix formatting of four more c-based tool's --version option

Liming, Please review the attached patch. Updated GenBootSector, GenCrc32 and GenPage to remove duplicate "Build" word in the version output, updated the minor number and copyright as needed. Updated the VolInfo version output to remove the tool description from the --version output string. Co

[edk2] [RFC][BaseTools build] Binary File List

Hi Folks, In order for the nightly build to automatically pickup any binary or supporting file in the BaseTools\Bin\Win32 directory, I would like to propose that we add the attached file in the BaseTools\Source directory. This allows a developer to add a new tool in either the C or Python trees,

Re: [edk2] [Patch RFC] Update Versions Strings for 3 C-based tools

Updated patch based on feedback. Cheers, Larry From: Hauch, Larry [mailto:larry.ha...@intel.com] Sent: Friday, August 22, 2014 1:44 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch RFC] Update Versions Strings for 3 C-based tools Dennis, Liming, Please review that attached patch

[edk2] [Patch RFC] Update Versions Strings for 3 C-based tools

Dennis, Liming, Please review that attached patch. BootSectImage.exe, EfiLdrImage.exe and Split.exe tools have incorrect output from the --version option. This patch fixes the --version option output and corrects the description displayed. Contributed-under: TianoCore Contribution Agreement 1.

[edk2] Proposed replacement scripts for edksetup.bat

Hi Folks, I have added a new script, Edk2Setup.bat, to the edk2 trunk and three new scripts in the BaseTools\Scripts directory, r15867. The plan is to allow people to test this script through the end of September. If there are no issues at that time, we can replace the existing edksetup.bat with

[edk2] About Patching UNI files

Hi Folks, After the recent change of the mime-type property on the UNI files in the EDK II trunk, it has been pointed out that some patch tools will not correctly handle patching the UTF-16LE Unicode files. The change in the format does have some other benefits such as allowing TortoiseSVN diff

Re: [edk2] [RFC] EDK II UNI Unicode File Specification

d length nor well-delimited. Consider what would happen if someone wanted to add \bolder to the grammar. This would make older strings suspect, since it could be interpreted as "\bold" and "er" or "\bolder" I mentioned this long ago. Tim From: Hauch, Lar

[edk2] [RFC] EDK II UNI Unicode File Specification

Hi Folks, Here are the proposed changes to the EDK II UNI Unicode File Specification. Hopefully, HTML format for the chapters will be easier to review and respond with feedback. Please provide feedback by the end of this week (22 Aug. 2014). Updates: · Updated EBNF to follow syntax s

Re: [edk2] [Patch][BaseTools] Fix --version in Rsa2048Sha256 tools

Hi Mike, Looks Good. Reviewed-by: lhauch Cheers, Larry From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, August 14, 2014 11:59 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch][BaseTools] Fix --version in Rsa2048Sha256 tools Larry, Can you please review

[edk2] [Patch 1] Change svn:mime-type property on Unicode files

Hi Folks, I agree that we should modify the svn property although it still does not fix the issue with code reviews for the files. I have attached the proposed patch; please review and let me know if there are any issues. Change svn:mime-type property on all Unicode files (extension .uni) in edk

Re: [edk2] EDK II UNI Unicode File Specification Update

to hold content that is not required by UEFI PI Distribution Package, but may be useful for User Interface tools. The following identifier may be used in the UnicodeLines' Token element to pass along the User Interface name of the package. L"STR_PRORPERTIES_MODULE_NAME" Other content may be provided

Re: [edk2] EDK II UNI Unicode File Specification Update

ry - I would recommend that these sort of changes not be added to the grammar, but rather in the specification text related to the [UserDefined] or DEFINES section of the .inf or .dec specification. Tim From: Hauch, Larry [mailto:larry.ha...@intel.com] Sent: Monday, August 11, 2014 10:

[edk2] EDK II UNI Unicode File Specification Update

Hi Folks, The following is content we would like to add to the EDK II UNI Unicode File Specification to support the changes we have proposed for supporting localization in EDK II that can be consumed by the packaging to when creating a UEFI PI Distribution Package (and when installing a UEFI PI

Re: [edk2] INF/DEC file updates to EDK II packages

2 | Reserved bits must be set to zero. # Modified EBNF in: 3.4 [Defines] Section Prototype ::= "[Defines]" "DEC_SPECIFICATION" "PACKAGE_NAME" "PACKAGE_GUID" "PACKAGE_VERSION" [ "PACKAGE_UNI_FILE" ] *

Re: [edk2] INF/DEC file updates to EDK II packages

Hi Folks, Here are the proposed changes to the INF and DEC specifications. . Added content highlighted and italic, deleted content strike-through and highlighted. Please see below. Cheers Larry ### INF Specification changes: Revision table Updates: * Change revision numb

Re: [edk2] Redundant Base tools

Hi Sergey, Use svn help checkout and you will see the --ignore-externals option. This option is also available to the update command. If you are using a GUI application for these operations, they may also have a way to do the same thing (although the tool may not use the exact same wording. For

Re: [edk2] [edk2-buildtools] [PATCH] Merge sources from edk2-buildtools sub-project to EDK II BaseTools trunk

Reviewed-by: lhauch Cheers, Larry From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Friday, July 25, 2014 10:39 AM To: edk2-devel@lists.sourceforge.net Cc: edk2-buildtools-de...@lists.sourceforge.net Subject: [edk2-buildtools] [edk2][PATCH] Merge sources from edk2-buildtools sub

[edk2] [PATCH] Update VS2010 and VS2012 RC.exe locations

CodeModule: BaseTools - tools_def.txt VS2010, VS2010x86, VS2012 and VS2012x86 update locations for rc.exe tool This change will point to the correct location of the rc.exe tool. RC.exe is used for building UEFI compliant drivers that must have a UEFI_HII_RESOURCE_SECTION generated as part of th

[edk2] [RFC] Proposed changes to edksetup.bat

Hi Folks, The following help content shows proposed changes to the edksetup.bat script in the edk2 project. While these changes currently focus on the Windows build environment, the *NIX edksetup.sh scripts can also be modified in the future to provide similar functionality with most of the sam

Re: [edk2] [Review][Patch] Remove BaseTools\Bin\Win32 and replace with external

need to be moved out of this tree into a new BaseTools/Bin/Arm directory tree.) Also, I forgot to include the following: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lhauch Cheers, Larry From: Hauch, Larry Sent: Wednesday, July 23, 2014 1:33 PM To: edk2-buildtools-de

[edk2] [Review][Patch] Remove BaseTools\Bin\Win32 and replace with external

Hi Folks, I have attached two patches for review that will complete task item 3 from the "Proposal to retire edk2-buildtools subproject". 3) Delete Win32 binaries from EDK II BaseTools and replace with an SVN extern. a. Default will continue to pull Win32 binaries

Re: [edk2] [edk2-buildtools] binary-only modules and [depex] sections

readable dependency expression. Removing the python code I mentioned in my original message (ignoring [Depex] sections when only [Binaries] sections are present) allows a dependency section to be generated on the fly. An appropriate FDF statement will include the correct section. - Justin From: Hauc

Re: [edk2] [edk2-buildtools] binary-only modules and [depex] sections

Hi Justin, The EDK II tools should support a binary INF file that has both the drive and the compiled depex file in the [Binaries] section. Using the PcAtChipsetPkg/PcatRealTimeClockRuntimeDex.inf as an example, a valid INF for the binary would looks like: [Defines] INF_VERSION

Re: [edk2] Proposed Syntax for .idf (Image Definition File) format.

Hi Tim, I agree with your assessment. I would like to follow up by asking if anyone would object to removing the alternate control characters and just redefine the UNI file format to use just the “#” symbol as the ‘control character’ and stating that “//” is used to indicate a comment that termi