Hello all,
Could you help review this patch?
This patch is going to:
1. Skip the content defined in USER EXTENSION section without raising an
error.
2. Wrap os.utime to use two arguments.
3. Add GenFdsCommand for PlatformAutoGen
Contributed-under: TianoCore Contribution Agre
Hess:
The patch is good.
Reviewed-by: Gao, Liming
Thanks
Liming
From: Chen, Hesheng [mailto:hesheng.c...@intel.com]
Sent: Thursday, August 21, 2014 3:13 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools]Skip the content defined in USER EXTENSION section
without raising an error
This patch looks good.
Thank you.
On Thu, 2014-08-21 at 00:46 +, Gao, Liming wrote:
> Hi, I meet with the same issue. I verify it in my ubutu 12.04. GCC46, Nasm
> 2.09. I meet with the build failure.
> 1) 0x10 is not power of two.
> 2) invalid combination of opcode and operands
>
> I prov
Yes, it's a tradeoff:-).
Putting it to MdeModulePkg will need carefully review its
modularity/interface/layer design. Putting it to a new package could enable
this feature quickly.
That's why I am asking UDF device path related question if Paulo want to put
into MdeModulePkg:-). I saw the code
This patch adds the HfsPlus driver it's licensed under the GPL so i'm curious
what the procedure here would be.
--
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
__
Great to hear this.
Today the two new file system driver are proposed:)
I would stick to introduce a new FileSystemPkg to contain it.
For procedure, I am not sure if GPL license is allowed in EDKII open source
repo. Maybe legal expert can answer this.
Thanks
Feng
-Original Message-
F
Oliver:
I see your commit patch still includes FixedPcdGet() usage in library. Does
it pass build? If not, how about remove PCD first.
And, another issue that new introduced PCD
gEfiMdePkgTokenSpaceGuid.PcdBaseStackCanary token number is same to
gEfiMdePkgTokenSpaceGuid.PcdValidateOrderedC
Sorry, I committed the v3 patch without taking attention of its content.
The FixedPcdGet() works well in the NULL library because the library is
linked to a module. So the FixedPcdGet behaves correctly in this case.
But the library cannot be built by itself with FixedPcdGet().
I think it was bette
Looks good to me, with another Ide patch it to fix slave devices I have
attached the two logs. One with Idebus and IdeController and the other with
AtaBus AtaAtapiPassthru and SataController.
On 17/08/14 01:32, Laszlo Ersek wrote:
> On 08/16/14 20:34, Reza Jelveh wrote:
> > On 16/08/14 14:51, Las
From: Reza Jelveh
The SataController is moved to PcAtChipsetPkg where the IdeController
resides. The SataController is also enabled for OVMF.
Certain controllers such as Marvel 9230 controller use a D2H FIS instead
of PIO Setup FIS to denote the end of a PIO data-in command.
Some dependency on
From: Reza Jelveh
SataController reads host capabalities when the module is first loaded.
SataControllerStart is called before AhciMode.c resets the bus and
enables AE. If SataControllerStart would do this itself, it would break
AhciMode.
The Initialize method should only install the protocol.
From: Reza Jelveh
Removed:
- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
(provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
- PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
(provides gEfiIdeControllerInitProtocolGuid)
Added:
- MdeModulePkg/Bus/Ata/AtaBusDxe/At
From: Reza Jelveh
Some AHCI controllers such as the Marvel 9230 controllers do not send
PIO Setup FIS when the PIO data-in command is completed. Instead they
just send a D2H FIS.
To accomodate for this possibility the status code of the D2H FIS is
checked.
Contributed-under: TianoCore Contribut
From: Reza Jelveh
GetChannelInfo is called to initialize the SataController when
enumerating ports.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 16
1 file changed, 16 insertions(+)
d
From: Reza Jelveh
The slave or master device must be selected before sending the
diagnostics command, otherwise reading the Ide registers yields invalid
results.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode
From: Reza Jelveh
SataController is moved to PcAtChipsetPkg for use in other packages such
as OVMF.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
DuetPkg/DuetPkg.fdf|2 +-
DuetPkg/DuetPkgIa32.dsc
From: Reza Jelveh
Apple's bootloader requires the ConsoleControl protocol to be
implemented. By adding the Foundation path to the package description
the ConsoleProtocol can be used in Ovmf without the need of copying it
to Include/Protocol of MdePkg like other protocols did.
The gEfiConsoleCont
From: Reza Jelveh
Apple's boot.efi checks if the ConsoleControl protocol returns
EFI_SUCCESS in both GetMode and SetMode.
Apple uses a kernel extension to make parts of the DataHub protocol
available to the xnu kernel. The xnu kernel then checks for FSB
frequency and if it's not found fails with
From: Reza Jelveh
This patch adds apple boot support to Ovmf. It readds the ConsoleControl
protocol and adds firmware and datahub settings apple needs for
successful osx boot
Reza Jelveh (4):
EdkCompatibilityPkg: allow ConsoleControl protocol to be used
OvmfPkg: add apple boot support to Ovm
From: Reza Jelveh
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
--
The hfs module can currently be found at:
https://github.com/fishman/edk2-hfsplus
Signed-off-by: Reza Jelveh
---
OvmfPkg/OvmfPkgIa32.dsc| 7 +++
OvmfPkg/OvmfPkgIa32.fdf| 2 ++
From: Reza Jelveh
Initialize apple specific boot support in PlatformBdsPolicyBehavior
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 5 +
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h | 1 +
Ovm
Dear FatPkg maintainers,
Please find the attached patch that adds stack protection to ARM
architectures.
BaseStackCheckLib is now required to build on ARM architectures.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
Regards,
Olivier
stack-prote
From: Ronald Cron
Update RVCT compile options for the CryptoPkg to compile.
Add support for stack protector with BaseStackCheckLib to link.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron
Reviewed-By: Olivier Martin
---
CryptoPkg/CryptoPkg.dsc
From: Ronald Cron
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron
Reviewed-By: Olivier Martin
---
CryptoPkg/CryptoPkg.dsc| 7 ---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 5 -
CryptoPkg/Library/BaseCryptLib/Runt
This patchset adds support for ARM and AARCH64 GCC.
And it also fixes ARM RVCT support.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron
Reviewed-By: Olivier Martin
Ronald Cron (3):
Update CryptoPkg build with RVCT
CryptoPkg: Add support to build with ARM G
From: Ronald Cron
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron
Reviewed-By: Olivier Martin
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
b/CryptoPkg/Librar
Dear ShellPkg maintainer,
Please find the attached patch that adds the CompilerIntrinsics for AARCH64.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Harry Liebel
Reviewed-By: Olivier Martin
Regards,
Olivier
---
Dear MdePkg maintainer,
Please find the attached patch that ensures the .type directive is used to
mark them as function symbols
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin
Regards,
Olivier
... with the attached patch.
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 21 August 2014 12:02
To: Kinney, Michael D; Gao, Liming
Cc: edk2-devel@lists.sourceforge.net
Subject: [PATCH] MdePkg: use GCC_ASM_EXPORT to export functions
Dear MdePkg maintainer,
Please find the a
... with the patch
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: 21 August 2014 12:01
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net; Harry Liebel
Subject: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics library
Dear ShellPkg maintainer,
Please find the attache
Hi,
Does OSX boot depend on ConsoleControl protocol? If yes, I think you can copy
its definition into OvmfPkg, not use the one in EdkCompatibilityPkg, because
ECP package is designed for old EDK driver. We don't want EDKII platform depend
on ECP package.
Thanks
Liming
-Original Message-
Hi everyone.
I'm having some problems with an application, but these issues just happen
when CSM is enabled.
I've tried to find some protocol that I can use to detect is a system has
CSM enabled, but didn't find anything.
Does anyone know some protocol that I can use to have this kind of
informat
You can try to locate gEfiLegacyBiosProtocolGuid instance of
EFI_LEGACY_BIOS_PLATFORM_PROTOCOL installed.
On Thu, 2014-08-21 at 11:10 -0300, Rafael Machado wrote:
> Hi everyone.
>
>
> I'm having some problems with an application, but these issues just
> happen when CSM is enabled.
>
>
> I've t
Dell - Internal Use - Confidential
I ran the suggested command
dh -p SerialIo
and got Protocol ID 'SerialIo' could not be identified.
However running
dh -p SerialIO
competed without error but dumped nothing to the screen.
From: Li, Elvin [mailto:elvin...@intel.com]
Sent: Tue
Jaben, Erik, Lee. Could you please review the attached changes.
StdLib/LibC/gdtoa: Initialize variables before use, update the Kmax definition.
gdtoaimp.h: update the Kmax definition.
strtodg.c: initialize variables before use.
general: Remove conditional sections for VAX and IBM mainframe. Re
The current DriverSampleDxe has the following item for the orderedlist:
option text = STRING_TOKEN(0x006F), value = 2, flags =
RESET_REQUIRED;
option text = STRING_TOKEN(0x006E), value = 1, flags =
RESET_REQUIRED;
option text = STRING_TOKEN(0x0070)
In DriverSampleDxe, the boot order item is listed in storage as:
UINT16 BootOrder[8];
And here is the ordered list which manipulates this item:
orderedlist
varid = MyIfrNVData.BootOrder,
prompt = STRING_TOKEN(0x006D),
help
The following statement appears in DriverSampleDxe for a checkbox:
checkbox varid = MyIfrNVData.ChooseToActivateNuclearWeaponry,
prompt = STRING_TOKEN(0x0029),
help = STRING_TOKEN(0x002A),
flags= CHECKBOX_DEFAULT | CHECKBOX
Hi Folks,
I have added a new script, Edk2Setup.bat, to the edk2 trunk and three new
scripts in the BaseTools\Scripts directory, r15867.
The plan is to allow people to test this script through the end of September.
If there are no issues at that time, we can replace the existing edksetup.bat
with
Hi,
On Wed, August 20, 2014 11:31 pm, Tian, Feng wrote:
> Thanks for the great job!
Thank you! It was a lot of fun, though.
> My personal thought likes the idea to add a new package to place your UDF
> driver, but let's see if there is different opinion.
>
> And I am not sure if we can split it
Hi Thomas,
On Thu, August 21, 2014 1:07 am, Thomas Rognon wrote:
> My perspective may not be complete, but I vote for putting it in
> MdeModulePkg/Universal/Disk/.
> The reason I say this is there is already some parts of edk2 that are
> getting fragmented and I think that's not a good trend. For
Hello Dennis,
It looks like the memory location you ask about (400h) is first cleared by line
40 of LegacyBda.c:
ZeroMem (Bda, 0x100);
Then it is set to 3F8h by line 1945 of LegacyBootSupport.c:
Bda->Com1 = SioPtr->Serial[0].Address;
Maybe some breakpoints or debug prints in
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Thursday, August 21, 2014 10:13 AM
To: Bjorge, Erik C; Phillips, Chris J (BCS CFE) (chr...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Add cross file system moving to MV command
Erik or Chris,
Can you review t
Hi,
On Thu, August 21, 2014 4:33 am, Tian, Feng wrote:
> Yes, it's a tradeoff:-).
>
> Putting it to MdeModulePkg will need carefully review its
> modularity/interface/layer design. Putting it to a new package could
> enable this feature quickly.
>
> That's why I am asking UDF device path related q
On Thu, Aug 21, 2014 at 10:09 AM, Paulo Alcantara wrote:
> Hi,
>
> On Wed, August 20, 2014 11:31 pm, Tian, Feng wrote:
>> Thanks for the great job!
>
> Thank you! It was a lot of fun, though.
>
>> My personal thought likes the idea to add a new package to place your UDF
>> driver, but let's see if
Hi,
On Thu, August 21, 2014 3:46 pm, Jordan Justen wrote:
> I looked a little at the spec, but I couldn't find this. Can you point
> out what you are referring to?
"12.3 File System Format, 12.3.2 Partition Discovery, et al."
I only can see FAT and ISO-9660 filesystem in there. The point is that
Jaben,
Looks like the .uni file needs some of the recent updates.
I will try to test it today, but I don't see PostDelete ever getting set to
TRUE.
I also don't see CreateDirectory() getting called. Is it really needed?
Thanks,
Chris
From: Bjorge, Erik C [mailto:erik.c.bjo...@intel.com]
Sent:
Reviewed-by: Erik Bjorge
From: Mcdaniel, Daryl
Sent: Thursday, August 21, 2014 9:24 AM
To: edk2-devel@lists.sourceforge.net
Cc: Carsey, Jaben; Bjorge, Erik C; Rosenbaum, Lee G
Subject: [PATCH] Review request: StdLib/LibC/gdtoa/{gdtoaimp.h, strtodg.c}
Jaben, Erik, Lee. Could you please review th
I will merge the UNI in, not replace it.
I agree that I seemed to have lost something in this patch. I will fix it and
resend it.
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Thursday, August 21, 2014 12:27 PM
To: Bjorge, Erik C; Carsey, Jaben
Cc: edk2-devel@lists.sourceforg
Yes, looks like something is missing. The shell build fails because it can't
find CopySingleFile() and CascadeDelete(). Looks like these are in Cp.c and
Rm.c.
Chris
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, August 21, 2014 2:39 PM
To: Phillips, Chris J (Plano, TX); B
Yep. I noticed that I forgot to include the .h change to make those functions
accessible.
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Thursday, August 21, 2014 12:42 PM
To: Carsey, Jaben; Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: ShellPkg: Add cross fi
On Aug 21, 2014, at 9:13 AM, Paulo Alcantara wrote:
> Hi,
>
> On Thu, August 21, 2014 3:46 pm, Jordan Justen wrote:
>> I looked a little at the spec, but I couldn't find this. Can you point
>> out what you are referring to?
>
> "12.3 File System Format, 12.3.2 Partition Discovery, et al."
>
>
Reviewed-by: Jaben carsey
From: Mcdaniel, Daryl
Sent: Thursday, August 21, 2014 9:24 AM
To: edk2-devel@lists.sourceforge.net
Cc: Carsey, Jaben; Bjorge, Erik C; Rosenbaum, Lee G
Subject: [PATCH] Review request: StdLib/LibC/gdtoa/{gdtoaimp.h, strtodg.c}
Jaben, Erik, Lee. Could you please review t
Reviewed-by: Jaben Carsey
15869
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Wednesday, August 20, 2014 10:08 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: Fix 'ls -sfo' and 'map -sfo' output format to match UEFI
Shell 2.1 spec
Importance: High
Chris,
The SFO output change actually accidentally messed up the non-SFO output per
the spec. In Non-SFO mode, the Y/N are not used and X and - are used for
present and non-present. The N and Y characters in the table are much bigger
and at a glance the - and X is easier to tell apart.
Could
Reviewed-by: Jaben Carsey
15870
p.s. long term I would like to convert the #define to a PCD.
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Wednesday, August 20, 2014 1:01 PM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: Fixes and updates for the 'driv
Reviewed-by: Jaben Carsey
15871
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Wednesday, August 20, 2014 2:11 PM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: Add support for UEFI Shell 2.1 spec command line comments
Importance: High
Please review th
On 08/20/14 22:30, Matt Fleming wrote:
> [ Pulling in EDK2 folks for help ]
>
> On Wed, 20 Aug, at 08:53:45PM, Michael Brown wrote:
>> On 20/08/14 20:05, Mantas Mikulėnas wrote:
>>>
>>> I experimented with some things (like setting chunk size to a few kB
>>> to see if it hangs earlier or only at t
Reviewed-by: Jaben Carsey
15872
I notice that neither the old non-SFO summary table nor this one is actually
the same as the spec example. The old summary had more info than that and the
new one has even more, but it has the same as the SFO more, which makes sense.
Just something to think o
Reviewed-by: Jaben Carsey
15873
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Wednesday, August 20, 2014 3:00 PM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: Fixes and updates for the 'parse' command
Importance: High
Please review the attached patch
This appears identical to the change made in 2011 by Andrew fish. Am I missing
something? I see that line in the DSC already.
The library under it (AArch64Lib.inf) does not appear in the tip though... not
sure what happened.
-Jaben
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: T
On Thu, August 21, 2014 4:49 pm, Andrew Fish wrote:
> The spec is defining what is required to be implement. It does not limit
> what could be implemented. Thus you would probably want to add a PCD
> feature flag to turn on/off UDF support in the partition driver, and just
> default it to off.
OK
Erik or Tapan,
Can you review this patch?
This makes sure that quotes are left around parameters when they are passed to
commands or apps so prevent them from being interpreted as a flag.
ShellPkg: leave quotes around params
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by
Erik,
Can you check this?
ShellPkg: Refactor string manipulation
This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy
through some other means.
This patch replaces StrCat with StrnCat or refactors out the usage of StrCat
through some other means.
Contributed-under: T
I guess you are missing AArch64. You are mixing with ARM.
The patch does:
[LibraryClasses.AARCH64]
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf
From: Carsey, Jaben [jaben.car
Il 13/08/2014 09:02, A. Sava ha scritto:
> Sounds like situation with Marvell is similar to Qemu.
>
> As I wrote earlier in this thread, Qemu also doesn't use PIO Setup FIS,
> it puts only D2H FIS at the end of a PIO command. That's why Reza
> checked if there are other controllers that behave sim
On Thu, Aug 21, 2014 at 1:37 PM, Paulo Alcantara wrote:
> On Thu, August 21, 2014 4:49 pm, Andrew Fish wrote:
>> The spec is defining what is required to be implement. It does not limit
>> what could be implemented. Thus you would probably want to add a PCD
>> feature flag to turn on/off UDF suppo
Jordan --
Yes, we want to disable anything non-spec (and in some cases, even those). Size
sensitive applications are always trying to take out the pieces that they don't
absolutely need. Adding a simple PCD allows us to make that choice without
having to branch the code.
Tim
-Original Mes
On Aug 21, 2014, at 11:43 AM, Jordan Justen wrote:
> On Thu, Aug 21, 2014 at 1:37 PM, Paulo Alcantara wrote:
>> On Thu, August 21, 2014 4:49 pm, Andrew Fish wrote:
>>> The spec is defining what is required to be implement. It does not limit
>>> what could be implemented. Thus you would probably
I think you have an off by one error. Should be +1 instead of +2. Please test
to make sure I am not insane. Otherwise I am fine with the change.
Reviewed-by: Erik Bjorge
Thanks,
-Erik
From: Carsey, Jaben
Sent: Thursday, August 21, 2014 1:42 PM
To: Bjorge, Erik C; Shah, Tapan (tapands...@hp.
But your patch does not include adding the [AARCH64] section, just the line
within that section.
> -Original Message-
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: Thursday, August 21, 2014 1:55 PM
> To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
> Cc: Harry Liebel
On 8/21/2014 12:38 AM, Dong, Eric wrote:
> As well as I understand that HII was introduced in EFI 2.1 specification
> revision. So how should the cases be handled when the driver is loaded in
> revisions of EFI that are lower then 2.1?
> [[[Eric]]] in this case, I suggest you do driver build with
On Aug 21, 2014, at 12:12 PM, Bruce Cran wrote:
> On 8/21/2014 12:38 AM, Dong, Eric wrote:
>> As well as I understand that HII was introduced in EFI 2.1 specification
>> revision. So how should the cases be handled when the driver is loaded in
>> revisions of EFI that are lower then 2.1?
>> [[
*Goal*
I need a UEFI PXE and Legacy PXE compatible boot image that will:
- Determine if the drive is bootable or not (find MBR or GPT and add
sector option(s) to boot menu)
- Query a server to determine default boot option for given MAC (this
part is currently written as a CGI script i
Reviewed-by: Erik Bjorge
From: Carsey, Jaben
Sent: Thursday, August 21, 2014 1:55 PM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Refactor string manipulation
Erik,
Can you check this?
ShellPkg: Refactor string manipulation
This patch replaces Str
Jordan:
Another question. Why you put some nop opcode in Thunk16.nasm code? 32bit
Thunk16.nasm has one nop. 64bit Thunk16.nasm have two nop.
Thanks
Liming
-Original Message-
From: Jordan Justen [mailto:jljus...@gmail.com]
Sent: Thursday, August 21, 2014 9:13 AM
To: edk2-devel@lists.sou
It looks like gEfiSerialIoProtocolGuid is not generated on your platform,
SerMode depends on this protocol. You could write a simple EFI application to
locate gEfiSerialIoProtocolGuid protocol to confirm. If not found, SerMode will
not work and no serial device exist.
Elvin
From: Scott Duplicha
On Thu, Aug 21, 2014 at 5:09 PM, Gao, Liming wrote:
> Jordan:
> Another question. Why you put some nop opcode in Thunk16.nasm code?
> 32bit Thunk16.nasm has one nop. 64bit Thunk16.nasm have two nop.
In MdePkg/Library/BaseLib/X64/Thunk16.asm, see:
@64BitCode:
db 090h
db 048h, 0
Lee, Please review the attached patch. It is blocking building with GCC for
IA32 target architectures.
StdLib/BsdSocketLib: Correct format arguments and types to have a consistent
size on all architectures and platforms.
The capital 'L' size specifier may not be used for integer types; it deno
Hi All,
I am trying to PXE boot Linux kernel and I can get GRUB to load and run and get
to grub prompt. How is GRUB supposed to get the boot menu from the tftp server
?If it is using UEFI network driver to talk to tftp server, does that mean the
UEFI network driver needs to be a UEFI runtime dri
Tcp4->Transmit() queues outgoing data into the transmit queue. In current
implementation, the notify function will be signaled as soon as the data is
queued, before TCP4->Transmit() finishes all its responsibilities.
Best Regards,
Ye Ting
From: Thomas Rognon [mailto:tcrog...@gmail.com]
Sent: Th
Jordan:
I want to keep the same behavior with current Thunkt16.asm, because they have
been verified for long time.
So, I suggest to remove nop from 32bit Thunk16.nasm, and keep nop for x64bit
Thunk16.nasm.
Thanks
Liming
-Original Message-
From: Jordan Justen [mailto:jljus...@gmail.c
Hi, Chris
The UEFI network driver doesn't need to be a runtime driver. The typical PXE
boot process is as below: first, GRUB will use UEFI stack to download the
required files to boot at least a minimum OS kernel, then load it. The OS
kernel continues to use UEFI stack to download until it get
Hi Siyuan,
I can get to Grub prompt but I don't see it trying to load any more files, like
the boot menu. Does GRUB V2.02 support PXE boot by default or does it need some
configuration option ?How does Grub know that it is in network boot mode and
not booting from some disk ?How does it know the
Jaben,
This change was made on purpose so SFO and non-SFO use the same characters.
When I was creating ECRs last year Mike said the example output for shell
commands in the spec are just examples. Implementations can decide what and
how to display.
The SFO output is specified and for the 'de
Hi Tim,
The flags definition in VFR spec is used to compatible with framework code, but
VfrCompile is generate code base on the UEFI spec, which means if the flag
value belongs to question, it will set it to the question's flag filed. Example
shows below, the RESET_REQUIRED flag is saved in the
Jaben,
Thanks for all the reviews.
Similar to my response for the 'devices' change. The 'memmap' example output
in the shell spec is just an example. Implementations can decide what and how
to display.
For servers with large amounts of memory, we found that there needed to be
additional out
On 21/08/14 23:20, Paolo Bonzini wrote:
> There is a patch in QEMU now that makes it report the PIO Setup FIS
> correctly. However QEMU will still report a D2H FIS later, even if
> there's no error. Is this incorrect?
Yeah, I saw that. In theory, for PIO Data-In it should not report a d2h fis
unl
If this is implementation behavior and not spec, maybe consider signaling
the notify function after Tcp4->Transmit() finishes its responsibilities?
It would be very useful for asynchronous network operations to be able to
use the socket again in the notify function. The only way I can have
backgrou
From: Reza Jelveh
Apple's bootloader requires the ConsoleControl protocol to be
implemented.
The gEfiConsoleControlProtocolGuid is added to the dec file for O to
consume.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/Include/Protocol/ConsoleCon
From: Reza Jelveh
This patch adds apple boot support to Ovmf. It readds the ConsoleControl
protocol and adds firmware and datahub settings apple needs for
successful osx boot.
This version fixes a few typos throughout the last version and moves the
ConsoleControl protocol from EdkCompat to OvmfP
From: Reza Jelveh
Initialize apple specific boot support in PlatformBdsPolicyBehavior
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 5 +
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h | 1 +
Ovm
From: Reza Jelveh
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
--
The hfs module can currently be found at:
https://github.com/fishman/edk2-hfsplus
Signed-off-by: Reza Jelveh
---
OvmfPkg/OvmfPkgIa32.dsc| 7 +++
OvmfPkg/OvmfPkgIa32.fdf| 2 ++
From: Reza Jelveh
Apple's boot.efi checks if the ConsoleControl protocol returns
EFI_SUCCESS in both GetMode and SetMode.
Apple uses a kernel extension to make parts of the DataHub protocol
available to the xnu kernel. The xnu kernel then checks for FSB
frequency and if it's not found fails with
Thanks for the suggestion. We will evaluate the impact for this change.
Best Regards,
Ye Ting
From: Thomas Rognon [mailto:tcrog...@gmail.com]
Sent: Friday, August 22, 2014 1:03 PM
To: edk2-devel
Subject: Re: [edk2] Asynchronous TCP issue
If this is implementation behavior and not spec, maybe con
Looks good for me:-).
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Friday, August 22, 2014 04:38
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH RFC 0/4] UDF filesystem driver
On Thu, August 21, 2014 4:49 pm, Andrew Fish wrote:
> The spec is de
Hi Tim,
Thanks for your advice, I will follow up to refine the code in DriverSampleDxe
and VfrCompile.
Thanks,
Eric
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Friday, August 22, 2014 12:46 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] HII CHECKBOX
The following statement appe
Hi, Reza
ATA spec said the Diagnostics cmd doesn't care DEV bit. Where did you meet such
issue?
Thanks
Feng
-Original Message-
From: reza.jel...@tuhh.de [mailto:reza.jel...@tuhh.de]
Sent: Thursday, August 21, 2014 17:56
To: edk2-devel@lists.sourceforge.net
Cc: ag...@suse.de
Subject: [e
Good to me.
Reviewed-by: Feng Tian
-Original Message-
From: reza.jel...@tuhh.de [mailto:reza.jel...@tuhh.de]
Sent: Thursday, August 21, 2014 17:56
To: edk2-devel@lists.sourceforge.net
Cc: ag...@suse.de
Subject: [edk2] [PATCH v2 1/6] MdeModulePkg: Check D2H register status in
AhciPioTra
Hi, Reza
If no this patch, is there any real impact? I ever mentioned, AhciMode.c will
use PortImplement register to know which port should be enumerated.
Thanks
Feng
-Original Message-
From: reza.jel...@tuhh.de [mailto:reza.jel...@tuhh.de]
Sent: Thursday, August 21, 2014 17:56
To: edk
1 - 100 of 101 matches
Mail list logo
