[edk2] How to debug UEFI (UDK2014) Shell application Using Visual Studio

2014-09-05 Thread partha sarathi swain
Hi All, I have downloaded EDK (UEDK2014) from taniacore site and I have successfully build UEFI application in Debug mode using following command C:\UDK2014.Complete.MyWorkSpace\UDK2014.MyWorkSpace\MyWorkSpace> build -t VS2012x86 -b DEBUG As it is in Debug mode it will create a .pdb file (Sec

Re: [edk2] How to debug UEFI (UDK2014) Shell application Using Visual Studio

2014-09-05 Thread Neeraj Ladkani
you can include SourceLevelDebugPkg for this purpose. refer to documentation for the same. Are you running from device or OVMF? Neeraj On Fri, Sep 5, 2014 at 12:37 PM, partha sarathi swain < partha161.sili...@gmail.com> wrote: > Hi All, > > I have downloaded EDK (UEDK2014) from taniacore sit

[edk2] [Patch]ShellPkg: Replace assignment statement with 'StrnCpy' to append terminal NULL character in a string

2014-09-05 Thread Qiu, Shumin
Hi Jaben, Can you help to review the patch? The assignment statement do not check the terminal NULL character in a string, so we use 'StrnCpy' to replace it to avoid buffer overflow. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

Re: [edk2] Xcode 5 and Ovmf.

2014-09-05 Thread Sergey Isakov
I made disassembler of the program and found the follow: This routine -- UINTN EFIAPI AsciiPrint ( IN CONST CHAR8 *Format, ... ) { VA_LIST Marker; UINTN Return; ASSERT (Format != NULL); VA_START (Marker, Format); Return = AsciiInternalPrint( Format, gST->ConOut, Marker)

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-09-05 Thread Laszlo Ersek
On 08/26/14 02:12, Jordan Justen wrote: > On Mon, Aug 25, 2014 at 4:27 PM, Laszlo Ersek wrote: >> On 08/26/14 00:24, Jordan Justen wrote: >>> On Fri, Aug 8, 2014 at 7:08 PM, Laszlo Ersek wrote: Recent changes in the QEMU ACPI table generator have shown that our limited client for that i

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-09-05 Thread Laszlo Ersek
On 09/05/14 10:52, Laszlo Ersek wrote: > On 08/26/14 02:12, Jordan Justen wrote: >> On Mon, Aug 25, 2014 at 4:27 PM, Laszlo Ersek wrote: >>> On 08/26/14 00:24, Jordan Justen wrote: On Fri, Aug 8, 2014 at 7:08 PM, Laszlo Ersek wrote: > Recent changes in the QEMU ACPI table generator have

Re: [edk2] [PATCH 0/9] first round of proposed fixups for "add support for AArch64 QEMU/KVM v6"

2014-09-05 Thread Ard Biesheuvel
On 4 September 2014 10:39, Laszlo Ersek wrote: > On 09/04/14 08:32, Ard Biesheuvel wrote: >> On 4 September 2014 04:09, Laszlo Ersek wrote: >>> Hi Ard, >>> >>> I started to review your v6 patchset in reverse order -- I first created >>> a map between your v5 and v6 patches (as much as it was poss

Re: [edk2] Xcode 5 and Ovmf.

2014-09-05 Thread Sergey Isakov
Resolved! It was an argument -DNO_BUILTIN_VA_FUNCS that must be excluded from Clang compilation. Sorry for disturbing! On 05.09.2014, at 12:44, Sergey Isakov wrote: > I made disassembler of the program and found the follow: > This routine > -- > UINTN > EFIAPI > AsciiPrint ( > IN CONST

Re: [edk2] [PATCH 0/9] first round of proposed fixups for "add support for AArch64 QEMU/KVM v6"

2014-09-05 Thread Laszlo Ersek
On 09/05/14 11:36, Ard Biesheuvel wrote: > On 4 September 2014 10:39, Laszlo Ersek wrote: >> On 09/04/14 08:32, Ard Biesheuvel wrote: >>> On 4 September 2014 04:09, Laszlo Ersek wrote: Hi Ard, I started to review your v6 patchset in reverse order -- I first created a map betwe

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-09-05 Thread Paolo Bonzini
> So the idea is, look at the target area, > - determine if the remaining size in that blob (the pointed-to blob) > could still contain an ACPI table header, > - if so, check the presumed "length" field in that header, and see if > it's self-consistent (ie. >= sizeof(header), and <= remaining

Re: [edk2] How to debug UEFI (UDK2014) Shell application Using Visual Studio

2014-09-05 Thread partha sarathi swain
I am using Windows 7 with a shell Emulator. I want to debug a shell application with Visual Studio 2010. Thanks & Regards Partha Sarathi Swain ASD Dept. LSI India Research and Development Center, Bangalore-560103. --

[edk2] [PATCH v7 22/24] ArmVirtualizationPkg: add PlatformPeiLib library

2014-09-05 Thread Ard Biesheuvel
This is a fork of the ARM PlatformPeiLib for virtual machines. The main purpose of having this specific implementation is that it allows us to preserve the device tree blob if it was passed to us in system DRAM. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Sig

[edk2] [PATCH v7 23/24] ArmVirtualizationPkg: add driver for QEMU's NOR flash

2014-09-05 Thread Ard Biesheuvel
This adds an implementation of NorFlashPlatformLib that exposes the two 64 MB NOR flash banks that are provided by QEMU's mach-virt emulation both in 32-bit and 64-bit mode. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- .../L

[edk2] [PATCH v7 16/24] ArmVirtualizationPkg: introduce gEarlyPL011BaseAddressGuid

2014-09-05 Thread Ard Biesheuvel
From: Laszlo Ersek This GUID will identify a customized HOB that carries the base address of the PL011 serial port, for clients that cannot access PCDs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- .../ArmVirtualizationPkg/ArmVirtualizationPkg.dec |

[edk2] [PATCH v7 19/24] ArmVirtualizationPkg: add VirtFdtDxe driver

2014-09-05 Thread Ard Biesheuvel
This driver enumerates the device nodes in the device tree located at the base address passed in gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, and installs drivers for devices it cares about (GIC interrupt controller, RTC, architected timer interrupt) Contributed-under: TianoCore Contribution Agree

[edk2] [PATCH v7 05/24] ArmPkg: rename ArmArchTimerLib.h to ArmArchTimer.h

2014-09-05 Thread Ard Biesheuvel
The ArmArchTimerLib.h include file is not directly related to the TimerLib instance ArmArchTimerLib, so the name is confusing. Rename to ArmArchTimer.h instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmC

[edk2] [PATCH v7 03/24] ArmPkg: add ArmHvcLib

2014-09-05 Thread Ard Biesheuvel
This is a utility library closely modeled after ArmSmcLib, that allows hypervisor call (HVC) instructions to be issued from C code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/Library/ArmHvcLib.h| 42 +++

[edk2] [PATCH v7 07/24] ArmPkg: add ArmGenericTimerCounterLib implementation using physical timer

2014-09-05 Thread Ard Biesheuvel
This adds an implementation of ArmGenericTimerCounterLib using the physical architected generic timer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmGenericTimerPhyCounterLib.c | 139 + .../ArmGenericTimerPhyC

[edk2] [PATCH v7 13/24] EmbeddedPkg: split off FDT loading functionality from FdtLib

2014-09-05 Thread Ard Biesheuvel
Split off the recently added functionality to load device tree images and install them as configuration tables, as it introduces a dependency on UefiBootServicesTableLib, preventing FdtLib from being used during SEC and PEI phases. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

[edk2] [PATCH v7 02/24] ArmPkg: allow dynamic GIC base addresses

2014-09-05 Thread Ard Biesheuvel
Allow the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase to be redeclared as PcdsDynamic by the platform, so virtual machines can set these properties during boot. As the PcdGet32() calls now call into the PCD database, cache the values that are re

[edk2] [PATCH v7 20/24] ArmVirtualizationPkg: add ArmVirtualizationPlatformLib library

2014-09-05 Thread Ard Biesheuvel
This is an implementation of ArmPlatformLib that discovers the size of system DRAM from a device tree blob located at the address passed in gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, which should equal the value in gArmTokenSpaceGuid.PcdSystemMemoryBase. As the device tree blob is passed in syst

[edk2] [PATCH v7 15/24] ArmVirtualizationPkg: add Include/ArmPlatform.h

2014-09-05 Thread Ard Biesheuvel
This include file contains platform specific defines, and is shared by various modules. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPkg/Include/ArmPlatform.h | 33 ++ 1 file changed

[edk2] [PATCH v7 04/24] ArmPkg: add ArmPsciResetSystemLib

2014-09-05 Thread Ard Biesheuvel
This implementation of EfiResetSystemLib uses ARM PSCI calls to perform reboot and poweroff, using either HVC or SMC calls. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec | 8 ++ .../ArmPsciResetSyste

[edk2] [PATCH v7 01/24] ArmPkg: allow dynamically discovered timer interrupts

2014-09-05 Thread Ard Biesheuvel
To support booting on virtual machines whose interrupt routing is discovered from the device tree, allow the interrupt numbers to be redeclared as PcdsDynamic by the platform .dsc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec | 2 ++

[edk2] [PATCH v7 21/24] ArmVirtualizationPkg: add ArmVirtualizationPlatformSysConfigLib library

2014-09-05 Thread Ard Biesheuvel
This introduces an implementation of ArmPlatformSysConfigLib for virtual machines. This is currently a stub, but some peripheral drivers (such as the PL031 RTC driver) rely on one to be available. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Casadevall Acked-by:

[edk2] [PATCH v7 09/24] ArmPkg/TimerDxe: respect layering of ARM timer libraries

2014-09-05 Thread Ard Biesheuvel
Replace direct calls to the physical timer system registers with calls into ArmArchTimer.h functions so we can swap in the virtual timer later. Also, register the virt and hyp timer interrupts at init time. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v7 00/24] add support for AArch64 QEMU/KVM

2014-09-05 Thread Ard Biesheuvel
This is v7 of the series that adds a platform config to support QEMU based virtual machines, either in TCG or KVM mode. These virtual machines declare their platform configuration by passing a device tree which needs to be parsed by Tianocore, rather than relying on hardcoded peripherals. This v7

[edk2] [PATCH v7 10/24] ArmPkg: move TimerDxe and ArmArchTimerLib to new ArmGenericTimerCounterLib

2014-09-05 Thread Ard Biesheuvel
Move TimerDxe and ArmArchTimerLib to ArmGenericTimerCounterLib, and update all platforms to select the physical counter instance they have been using implicitly all along. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/TimerDxe/TimerDxe.c

[edk2] [PATCH v7 06/24] ArmPkg: add ArmGenericTimerCounterLib interface

2014-09-05 Thread Ard Biesheuvel
This introduces ArmGenericTimerCounterLib by adding the include file ArmPkg/Include/Library/ArmGenericTimerCounterLib.h. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/Library/ArmGenericTimerCounterLib.h | 85 ++ 1 fil

[edk2] [PATCH v7 12/24] ArmPlatformPkg: separate PlatformPei and PlatformPeiLib

2014-09-05 Thread Ard Biesheuvel
This separates PlatformPei and PlatformPeiLib so the latter can be overridden by a specific platform. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PlatformPei/PlatformPeim.inf | 2 +- 1 file changed, 1 inserti

[edk2] [PATCH v7 14/24] ArmVirtualizationPkg: introduce PCDs for device tree base address

2014-09-05 Thread Ard Biesheuvel
Introduce gArmVirtualizationTokenSpaceGuid.PcdDeviceTreeBaseAddress and PcdDeviceTreeInitialBaseAddress, which will be used by virtual machine ports that discover the system configuration from a flattened device tree DTB image. The latter is FixedPcd only, and should contain the initial offset of

[edk2] [PATCH v7 11/24] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-09-05 Thread Ard Biesheuvel
This changes the definition and a bunch of references to gArmTokenSpaceGuid.PcdSystemMemoryBase and gArmTokenSpaceGuid.PcdSystemMemorySize so they can be declared as dynamic PCDs by the platform. Also, move the non-SEC call to ArmPlatformInitializeSystemMemory() earlier, so a platform has a chance

[edk2] [PATCH v7 08/24] ArmPkg: add ArmGenericTimerCounterLib implementation using virtual timer

2014-09-05 Thread Ard Biesheuvel
This adds an implementation of ArmGenericTimerCounterLib using the virtual architected generic timer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../ArmGenericTimerVirtCounterLib.c| 150 + .../ArmGenericTimerVirtC

[edk2] [PATCH v7 24/24] ArmVirtualizationPkg: add ArmVirtualizationQemu platform

2014-09-05 Thread Ard Biesheuvel
This adds support for executing UEFI in a QEMU/mach-virt emulated environment. The following assumptions are made about the target: - DRAM base at 0x4000_, containing the device tree blob - DRAM size at least 1 MB - device tree uses 64-bit physical base addresses and sizes - ARM architected tim

[edk2] [PATCH v7 17/24] ArmVirtualizationPkg: add private HobLib implementation for DXE phase

2014-09-05 Thread Ard Biesheuvel
To allow a dynamically discovered UART base address, we parse the device tree early and store the base address in a HOB. To prevent circular constructor dependencies from bringing up the serial port using this dynamic base address, use our own private HobLib with no dependencies on DebugLib either

[edk2] [PATCH v7 18/24] ArmVirtualizationPkg: add device tree based PL011 SerialPortLib

2014-09-05 Thread Ard Biesheuvel
This adds 2 implementations of SerialPortLib for device tree based platforms using a PL011 UART: - an 'early' one which is completely stateless and uses only fixed PCDs - a normal one which takes its base address from a HOB containing the base address discovered in the PEI phase A NULL SerialPor

Re: [edk2] How to debug UEFI (UDK2014) Shell application Using Visual Studio

2014-09-05 Thread Neeraj Ladkani
You can refer http://uefidk.com/sites/default/files/UDK_Debugger_Tool_User_Manual-SR1_v1_10.pdf On Fri, Sep 5, 2014 at 4:57 PM, partha sarathi swain < partha161.sili...@gmail.com> wrote: > I am using Windows 7 with a shell Emulator. I want to debug a shell > application with Visual Studio 2010.

Re: [edk2] [PATCH v2 00/18] Introducing Xen PV block driver to OVMF

2014-09-05 Thread Anthony PERARD
On Thu, Sep 04, 2014 at 08:01:07PM +0200, Laszlo Ersek wrote: > On 09/04/14 18:50, Anthony PERARD wrote: > > Hi all, > > > > This patch series is implementing the necessary in order to access a PV > > block > > device. For that, one need a XenStore client, a XenBus client, and the PV > > block >

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Shah, Tapan
Looks like patch is missing new files from ShellPkg/Library/UefiBcfgCommandLib/ directory. UefiShellInstall1CommandsLib.h and .uni files are removed from its .inf file in the patch, but don't see those files deleted in the patch. ShellPkg.dsc change: BcfgCommandLib|ShellPkg/Library/UefiBcfgCo

Re: [edk2] [patch] MdeModulePkg Fix XCODE Link Issue in DxeCore

2014-09-05 Thread Andrew Fish
Liming, Looks good. Reviewed-by: Andrew Fish On Sep 4, 2014, at 7:28 PM, Gao, Liming wrote: > Andrew: > Could you help review this patch? > > MdeModulePkg: Fix XCODE Link Issue in DxeCore > > In XCODE tool chain, the 64-bit bit wise and operation is causing the > compiler to emit an __

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Carsey, Jaben
All the new files were added in the first patch. This second patch removes the old code and moves the functionality to the added new library. I can certainly rename the library. I didn't think about the name much. I see the files removed from install around lines 3021 and 3111 in the patch 1/

Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command

2014-09-05 Thread Phillips, Chris J (Plano, TX)
Jaben, In the patch I see: - Duplicates of Library/UefiBcfgCommandLib/UefiBcfgCommandLib.c, .inf, and .uni - Some comments need updates, EX: BcfgLibraryRegisterBcfgCommand header comment in .h and .c is too generic. It isn't the constructor for all level 1 commands -

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-09-05 Thread Jordan Justen
On Fri, Sep 5, 2014 at 2:03 AM, Laszlo Ersek wrote: > On 09/05/14 10:52, Laszlo Ersek wrote: >> On 08/26/14 02:12, Jordan Justen wrote: >>> On Mon, Aug 25, 2014 at 4:27 PM, Laszlo Ersek wrote: On 08/26/14 00:24, Jordan Justen wrote: > On Fri, Aug 8, 2014 at 7:08 PM, Laszlo Ersek wrote:

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Shah, Tapan
UefiBcfgCommandLib.uni file can't be patched due to missing diff in patch. It's mime-type should be changed to "text/plain;encoding=UTF-16LE" From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 10:28 AM To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Carsey, Jaben
I have corrected that encoding. Here is the UNI file itself. I am now renaming the library and fixing some comments that chris pointed out. -Jaben From: Shah, Tapan [mailto:tapands...@hp.com] Sent: Friday, September 05, 2014 8:42 AM To: Carsey, Jaben; Phillips, Chris J (Plano, TX); Bjorge, Erik

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Shah, Tapan
Few lines were going beyond 80 characters in bcfg help output. So I have fixed them in attached .uni file. From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 10:48 AM To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.

[edk2] [PATCH v2] OvmfPkg: AcpiTimerLib: Access power mgmt regs based on host bridge type

2014-09-05 Thread Gabriel L. Somlo
Pick the appropriate bus:dev.fn for accessing ACPI power management registers (00:01.3 on PIIX4 vs. 00:1f.0 on Q35) based on the device ID of the host bridge (assumed always present at 00:00.0). With this patch, OVMF can boot QEMU's "-machine q35" x86 machine type. Contributed-under: TianoCore Co

Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command

2014-09-05 Thread Carsey, Jaben
Erik, Chris, and Tapan, Here is an updated patch with the rename and comment fixed per Tapan and Chris. I fixed the encoding on the UNI also. Note: the code and UNI content here is copied and pasted from the hopefully-soon-to-be-removed code except for the Register and Unregister functions.

[edk2] svn problem

2014-09-05 Thread Sergey Isakov
Hi sirs, what is it? ——— Skipped 'MdePkg/Library/BaseLib/X64/Thunk16.nasm' -- Node remains in conflict Skipped 'MdePkg/Library/BaseLib/Ia32/Thunk16.nasm' -- Node remains in conflict Fetching external item into 'BaseTools/Bin/Win32': External at revision 23. At revision 16063. ——— Sergey-

Re: [edk2] svn problem

2014-09-05 Thread Jordan Justen
On Fri, Sep 5, 2014 at 9:46 AM, Sergey Isakov wrote: > Hi sirs, > what is it? > ——— > Skipped 'MdePkg/Library/BaseLib/X64/Thunk16.nasm' -- Node remains in > conflict > Skipped 'MdePkg/Library/BaseLib/Ia32/Thunk16.nasm' -- Node remains in > conflict I just tried checking out BaseLib just before th

Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command

2014-09-05 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Friday, September 05, 2014 9:05 AM To: Shah, Tapan (tapands...@hp.com); Phillips, Chris J (BCS CFE) (chr...@hp.com); Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE: [PATCH 0/1] ShellPkg: Add a new library for "bcf

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Friday, September 05, 2014 9:12 AM To: Shah, Tapan (tapands...@hp.com); Phillips, Chris J (BCS CFE) (chr...@hp.com); Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE: [PATCH 1/1] ShellPkg: Use the new library for "b

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Phillips, Chris J (Plano, TX)
Please also update Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni to remove BCFG related strings. From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 11:12 AM To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C Cc: edk2-devel@lists.s

Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command

2014-09-05 Thread Phillips, Chris J (Plano, TX)
The UefiShellBcfgCommandLib.c code looks good. Fairly close to original with a couple other fixes. From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 11:05 AM To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Ca

Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command

2014-09-05 Thread Phillips, Chris J (Plano, TX)
Reviewed-by: Chris Phillips mailto:chr...@hp.com>> From: Phillips, Chris J (Plano, TX) Sent: Friday, September 05, 2014 12:52 PM To: Carsey, Jaben; Shah, Tapan; Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command The

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Phillips, Chris J (Plano, TX)
Reviewed-by: Chris Phillips mailto:chr...@hp.com>> From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 12:53 PM To: Phillips, Chris J (Plano, TX); Shah, Tapan; Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE: [PATCH 1/1] ShellPkg: Us

Re: [edk2] [PATCH 0/1] ShellPkg: Add a new library for "bcfg" command

2014-09-05 Thread Shah, Tapan
Reviewed by: Tapan Shah mailto:tapands...@hp.com>> From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 11:05 AM To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE: [PATCH 0/1] ShellPkg: Add

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

2014-09-05 Thread Shah, Tapan
Reviewed by: Tapan Shah mailto:tapands...@hp.com>> From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, September 05, 2014 12:53 PM To: Phillips, Chris J (Plano, TX); Shah, Tapan; Bjorge, Erik C Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE: [PATCH 1/1] ShellPkg: Us

Re: [edk2] VS2013 build failures: unresolved external symbol __dtoui3

2014-09-05 Thread Mcdaniel, Daryl
Scott, Thank you for reporting this. I have added it to the list of issues to be resolved for StdLib. Regrettably, I haven't done any testing with VS2013. While one is free to use the SSEx and MMX registers and instructions in their own code, it isn't a supported feature of EDK II. A compila

Re: [edk2] svn problem

2014-09-05 Thread Sergey Isakov
I made full edk2 checkout and now it is OK. I have svn 1.7.10 But removing only BaseLib and svn up was not help. On 05 сент. 2014 г., at 21:36, Jordan Justen wrote: > On Fri, Sep 5, 2014 at 9:46 AM, Sergey Isakov wrote: >> Hi sirs, >> what is it? >> ——— >> Skipped 'MdePkg/Library/BaseLib/X64/Th

Re: [edk2] VS2013 build failures: unresolved external symbol __dtoui3

2014-09-05 Thread Tim Lewis
Daryl -- I would note that for 64-bit x86 (2.3.4.2) it explicitly describes the usage of XMM registers. These are non-int usages but the preservation rules are listed. The registers Rax, Rcx Rdx R8, R9, R10, R11, and XMM0-XMM5 are volatile and are, therefore, destroyed on function calls. The re

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-09-05 Thread Laszlo Ersek
On 09/05/14 17:42, Jordan Justen wrote: > On Fri, Sep 5, 2014 at 2:03 AM, Laszlo Ersek wrote: >> On 09/05/14 10:52, Laszlo Ersek wrote: >>> On 08/26/14 02:12, Jordan Justen wrote: On Mon, Aug 25, 2014 at 4:27 PM, Laszlo Ersek wrote: > On 08/26/14 00:24, Jordan Justen wrote: >> On Fri

Re: [edk2] [Xen-devel] [PATCH v2 00/18] Introducing Xen PV block driver to OVMF

2014-09-05 Thread Jordan Justen
On Fri, Sep 5, 2014 at 6:34 AM, Anthony PERARD wrote: > On Thu, Sep 04, 2014 at 08:01:07PM +0200, Laszlo Ersek wrote: >> On 09/04/14 18:50, Anthony PERARD wrote: >> > Hi all, >> > >> > This patch series is implementing the necessary in order to access a PV >> > block >> > device. For that, one ne

Re: [edk2] VS2013 build failures: unresolved external symbol __dtoui3

2014-09-05 Thread Scott Duplichan
Here is a patch that fixes the VS2013-IA32 AppPkg build failure. It is tested using 32-bit Duet to boot a shell and then run Enquire.efi. The Enquire output (attached) matches that of the X64 build, except for the expected data size differences. -- StdLib: Fix VS2013-IA32 link failure caused by

[edk2] [PATCH v2 2/4] OvmfPkg: AcpiPlatformDxe: actualize QemuLoader.h comments

2014-09-05 Thread Laszlo Ersek
We used to state in this header file that we only cared about the Allocate command. This is no longer the case; update the comments accordingly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/AcpiPlatformDxe/QemuLoader.h | 6 +- 1 file changed

[edk2] [PATCH v2 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-09-05 Thread Laszlo Ersek
Recent changes in the QEMU ACPI table generator have shown that our limited client for that interface is insufficient and/or brittle. Implement the full interface utilizing OrderedCollectionLib for addressing fw_cfg blobs by name. In order to stay compatible with EFI_ACPI_TABLE_PROTOCOL, we don't

[edk2] [PATCH v2 3/4] OvmfPkg: AcpiPlatformDxe: remove current ACPI table loader

2014-09-05 Thread Laszlo Ersek
In the next patch we rewrite the client code for QEMU's fw_cfg ACPI table loader interface. In order to avoid randomly intermixed hunks in that patch, first remove the old code cleanly. We remove the InstallQemuLinkedTables() function and empty the InstallAllQemuLinkedTables() function. We also re

[edk2] [PATCH v2 0/4] OvmfPkg: complete client for QEMU's ACPI loader interface

2014-09-05 Thread Laszlo Ersek
Version 2 of . The main goal of this version to use EFI_ACPI_TABLE_PROTOCOL to install tables, while complying with the QEMU linker/loader interface as much as possible. Patches #1 and #2 are identical to their respective v1 counterpart

[edk2] [PATCH v2 1/4] OvmfPkg: resolve OrderedCollectionLib with base red-black tree instance

2014-09-05 Thread Laszlo Ersek
The "complete" QEMU fw_cfg ACPI loader will need to look up downloaded blobs by name, in order to implement the AddPointer and AddChecksum commands. Introduce OrderedCollectionLib to support such indexing. BaseOrderedCollectionRedBlackTreeLib is a BASE module, hence add the OrderedCollectionLib re

Re: [edk2] [PATCH v2 00/18] Introducing Xen PV block driver to OVMF

2014-09-05 Thread Laszlo Ersek
On 09/05/14 15:34, Anthony PERARD wrote: > I'm not sure what you are asking for. So, what more is needed? Just the three things I listed at the end of my previous email (investigating 32-bit, adding the protocol disclaimer, and a tally of licenses). I mentioned documentation (eg. a TechNotes.tx

Re: [edk2] [PATCH v2 0/4] OvmfPkg: complete client for QEMU's ACPI loader interface

2014-09-05 Thread Laszlo Ersek
On 09/05/14 23:15, Laszlo Ersek wrote: > Version 2 of > . The main > goal of this version to use EFI_ACPI_TABLE_PROTOCOL to install tables, > while complying with the QEMU linker/loader interface as much as > possible. > > Patches #1 an

Re: [edk2] [PATCH v7 24/24] ArmVirtualizationPkg: add ArmVirtualizationQemu platform

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This adds support for executing UEFI in a QEMU/mach-virt emulated environment. > The following assumptions are made about the target: > - DRAM base at 0x4000_, containing the device tree blob > - DRAM size at least 1 MB > - device tree uses 64-bit phys

Re: [edk2] [PATCH v7 22/24] ArmVirtualizationPkg: add PlatformPeiLib library

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This is a fork of the ARM PlatformPeiLib for virtual machines. The main > purpose of having this specific implementation is that it allows us to > preserve the device tree blob if it was passed to us in system DRAM. > > Contributed-under: TianoCore Contri

Re: [edk2] [PATCH v7 23/24] ArmVirtualizationPkg: add driver for QEMU's NOR flash

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This adds an implementation of NorFlashPlatformLib that exposes the > two 64 MB NOR flash banks that are provided by QEMU's mach-virt > emulation both in 32-bit and 64-bit mode. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Reviewed-by: La

Re: [edk2] [PATCH v7 21/24] ArmVirtualizationPkg: add ArmVirtualizationPlatformSysConfigLib library

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This introduces an implementation of ArmPlatformSysConfigLib for virtual > machines. This is currently a stub, but some peripheral drivers (such as > the PL031 RTC driver) rely on one to be available. > > Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [PATCH v7 20/24] ArmVirtualizationPkg: add ArmVirtualizationPlatformLib library

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This is an implementation of ArmPlatformLib that discovers the size of system > DRAM from a device tree blob located at the address passed in > gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, which should equal the value in > gArmTokenSpaceGuid.PcdSystemMemor

Re: [edk2] [PATCH v7 19/24] ArmVirtualizationPkg: add VirtFdtDxe driver

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This driver enumerates the device nodes in the device tree located at the > base address passed in gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, and > installs drivers for devices it cares about (GIC interrupt controller, RTC, > architected timer interrupt)

Re: [edk2] [PATCH v7 15/24] ArmVirtualizationPkg: add Include/ArmPlatform.h

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This include file contains platform specific defines, and is shared by > various modules. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Acked-by: Laszlo Ersek > Signed-off-by: Ard Biesheuvel > --- > .../ArmVirtualizationPkg/Include/ArmP

Re: [edk2] [PATCH v7 12/24] ArmPlatformPkg: separate PlatformPei and PlatformPeiLib

2014-09-05 Thread Laszlo Ersek
On 09/05/14 13:56, Ard Biesheuvel wrote: > This separates PlatformPei and PlatformPeiLib so the latter can be > overridden by a specific platform. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Reviewed-by: Laszlo Ersek > Signed-off-by: Ard Biesheuvel > --- > ArmPlatformPkg/Platf

Re: [edk2] [PATCH v7 19/24] ArmVirtualizationPkg: add VirtFdtDxe driver

2014-09-05 Thread Ard Biesheuvel
On 6 September 2014 02:24, Laszlo Ersek wrote: > On 09/05/14 13:56, Ard Biesheuvel wrote: >> This driver enumerates the device nodes in the device tree located at the >> base address passed in gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, and >> installs drivers for devices it cares about (GIC inte