Laszlo,
The reason I wanted to use the four APIs instead of only one BltLibGopBlt is if
user just wants to fill video, he can supply less parameters.
I am glad you have no concern to the refine proposal.
Jordan,
Any thought?
Thanks,
Ray
-Original Message-
From: Laszlo Ersek
I suggest to update the comments below The last chunk has been parsed, then
need to decide last message is Trailer or CRLF, in order to make it easier for
user to understand the code logic. Other parts are good to me.
Reviewed-by: Ye Ting ting...@intel.com
-Original Message-
From:
Got your opinion, I will modify it later, thanks
-Original Message-
From: Ye, Ting
Sent: Tuesday, August 11, 2015 1:33 PM
To: Zhang, Lubo; edk2-devel@lists.01.org
Cc: Wu, Jiaxin
Subject: RE: [patch] MdeModulePkg: HttpLib BodyParseComplete Event should
indicate the end of message body
On 10 August 2015 at 16:43, Daryl McDaniel edk2-li...@mc2research.org wrote:
Ard,
Thank you for the patch. I'll get it applied today.
Hello Daryl,
Thanks, but perhaps I could have your ack instead, and apply
everything when the various maintainers have acked each patch? You are
the first to
On Aug 8, 2015, at 2:59 PM, Benjamin Herrenschmidt b...@kernel.crashing.org
wrote:
On Sat, 2015-08-08 at 08:56 -0700, Andrew Fish wrote:
If you really need to punch holes in the memory map, then you can use
resource descriptors.
Yes, I do need to punch holes in there, Laszlo
On 07/31/2015 02:32 PM, Simpson, Gary wrote:
Is anyone from AMD on this list? If you know the right person, could
you please forward?
[Gary Simpson] Hi, Lee. My name is Gary Simpson (Firmware Architect
at AMD). Your post was forwarded to me.
(Thanks to both people who did so.) If desired,
Ard,
Thank you for the patch. I'll get it applied today.
Daryl
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Monday, August 10, 2015 6:08 AM
To: edk2-devel@lists.01.org; leif.lindh...@linaro.org;
yingke.d@intel.com
Cc: jordan.l.jus...@intel.com;
Hi.
Let's do an OVMF BoF at this year's KVM Forum too.
Paolo will present
Securing secure boot: system management mode in KVM and Tiano Core
on Thursday, August 20, in the 5:00pm - 5:30pm time slot.
Right after that, the BoF section starts at 5:30pm:
On Mon, 2015-08-10 at 20:14 +0200, Laszlo Ersek wrote:
On 08/10/15 18:46, Andrew Fish wrote:
Essentially, I am on a platform/architecture which feeds a flat
device-tree to EDK and I need to honor the input reserved regions
as they cover bits of memory either already used by the HW for
On Aug 10, 2015, at 1:51 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
On Mon, 2015-08-10 at 20:14 +0200, Laszlo Ersek wrote:
On 08/10/15 18:46, Andrew Fish wrote:
Essentially, I am on a platform/architecture which feeds a flat
device-tree to EDK and I need to honor the
On Tue, 2015-08-11 at 08:08 +1000, Benjamin Herrenschmidt wrote:
.../...
That means that if I want to reserve memory elsewhere in the system, I
need to either:
- Make sure that chunk of memory is not covered by a memory resource
descriptor HOB, or at least one that isn't marked somewhat
On Aug 10, 2015, at 4:01 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
On Tue, 2015-08-11 at 08:08 +1000, Benjamin Herrenschmidt wrote:
.../...
That means that if I want to reserve memory elsewhere in the system, I
need to either:
- Make sure that chunk of memory is
Replace the unsafe string functions with the safe one in UiApp.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi dandan...@intel.com
---
.../Application/UiApp/BootMaint/BootOption.c | 30 ++
.../Application/UiApp/BootMaint/FormGuid.h
On Aug 10, 2015, at 7:33 PM, Shubha Ramani shubharam...@yahoo.com wrote:
I know people were attempting to port acpidump from https://www.acpica.org/
to EDK2. Any success ? I need it desperately.
If you look at the mailing list history jonathan.d.sm...@intel.com
Yes thank you Tian. I rea the EDK2 Module Writer's Guide and figured it out.
Shubha Shubha D. ramanishubharam...@gmail.com
shubharam...@yahoo.com
On Tuesday, August 4, 2015 5:49 PM, Tian, Feng feng.t...@intel.com
wrote:
Why do you need to do the copy operation?
EDKII Build system
I know people were attempting to port acpidump from https://www.acpica.org/
to EDK2. Any success ? I need it desperately.
Thanks,
Shubha Shubha D. ramanishubharam...@gmail.com
shubharam...@yahoo.com
___
edk2-devel mailing list
edk2-devel@lists.01.org
Looks good to me.
Reviewed-by: Ye Ting ting...@intel.com
-Original Message-
From: Wu, Jiaxin
Sent: Friday, August 07, 2015 2:28 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting
Subject: [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP
DORA process
DHCP
Hi Bill
That is good question. In first version of TrEE, we do measure it at same
place. But later, we realize it might cause issue on Win8. I added comments in
code.
//
// We need measure Separator(7) here, because this event must be between
SecureBootPolicy (Configure)
// and
On 08/10/15 08:50, 闪耀 wrote:
when i used ovmf.fd in qemu manager,
then occurcs this tips:
Boot Failed. EFI DVD/CDROM
Boot Failed. EFI Floopy
i don't know what does this mean?
Your QEMU boot order specification (-boot ... option, or -device
...,bootindex=N properties) are incompatible
The ARMGCC toolchain will be removed, and so will the build rule family
by the same name. So remove the BuildOptions specific to ARMGCC.
Cc: Daryl McDaniel edk2-li...@mc2research.org
Cc: Jaben Carsey jaben.car...@intel.com
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard
We are going to remove the ARMGCC toolchains, so replace any references
to it with its replacement GCC48.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org
---
EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.c | 4 ++--
Add one, remove two ...
After adding the CLANG35 toolchain today, I noticed there is quite an
abundance of toolchains supported in EDK2, and in the ARM case, there
is some overlap between ARMGCC/ARMLINUXGCC and the GCC4x toolchains
that are defined for all architectures.
Since the recent changes
The ARM and ARMLINUXGCC toolchains will be removed, so replace any
mention of them with their replacement GCC48.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org
---
BeagleBoardPkg/ba.bat | 5 +++--
BeagleBoardPkg/build.sh | 7
Remove the ARMGCC and ARMLINUXGCC from comments in the respective
Makefiles of ArmPlatformPkg and ArmJunoPkg and from the [ancient]
Versatile Express instructions.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org
---
Ard:
This patch introduces GCC4X_ for common GCC option. It may be common for
GCC5, GCC6... So, how about use GCC_ prefix for all GCC common option?
Thanks
Liming
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Friday,
Refine the code in LegacyBootMaintUiLib to prevent the potential risk.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi dandan...@intel.com
---
.../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c| 13 +
1 file changed, 9 insertions(+), 4
On 10 August 2015 at 10:00, Gao, Liming liming@intel.com wrote:
Ard:
This patch introduces GCC4X_ for common GCC option. It may be common for
GCC5, GCC6... So, how about use GCC_ prefix for all GCC common option?
Yes, I agree that would be better. I will change it.
Thanks,
Ard.
Ard:
I am not familiar with ARM arch. Those changes are only for AArch64. I have
no comments for them. You can add review-by me.
Thanks
Liming
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Friday, August 7, 2015 10:23 PM
To: edk2-devel@lists.01.org;
when i used ovmf.fd in qemu manager,
then occurcs this tips:
Boot Failed. EFI DVD/CDROM
Boot Failed. EFI Floopy
i don't know what does this mean?
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Liming Gao liming@intel.com
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Monday, August 10, 2015 3:41 PM
To: edk2-devel@lists.01.org; Liu, Yingke D; leif.lindh...@linaro.org
Cc: Justen, Jordan L; Gao, Liming; Ard Biesheuvel
Subject:
On 10 August 2015 at 09:49, Gao, Liming liming@intel.com wrote:
Reviewed-by: Liming Gao liming@intel.com
Thanks
Series committed as SVN r18192 ... r18198.
Regards,
Ard.
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Monday, August 10,
Just drew a picture to show the current library APIs, V1 and V2 APIs, to help
you understand my point.
[cid:image001.png@01D0D37C.E78C2030]
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu
Sent: Monday, August 10, 2015 11:10 AM
To:
The AArch64 small C model makes extensive use of ADRP/ADD and
ADRP/{LDR,STR} pairs to emit PC-relative symbol references with
a +/- 4 GB range. Since the relocation pair splits the relative
offset into a relative page offset and an absolute offset into
a 4 KB page, we need to take extra care to
This is v4 of the followup to the series 'small C model and LLVM/clang support
for AARCH64' that I sent out on July 17th. Now that the FFS/FV optimization
patches have been merged, this is what remains to allow the AARCH64 platforms to
be built using clang, combined with the GNU binutils
Use an explicit VOID* cast when passing a static char array into
a function taking a void pointer.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org
Reviewed-by: Leif Lindholm leif.lindh...@linaro.org
Tested-by: Leif Lindholm
No need to hardcode the TE alignment anymore, now that GenFw sets
the PE/COFF alignment according to the alignment requirements of
the ELF input sections.
Also enable FIXED FFS placement so that we can reclaim some of the
space wasted to padding when using clang with 4 KB section alignment.
The ACPI .aslc files contain a ReferenceAcpiTable() function whose
sole purpose is to ensure that the table itself does not get optimized
away. However, when using clang, these dummy functions result in a 4 KB
section alignment requirement, which is silly since everything except
the .data section
The GNU assembler extends the generic notation for IMPLEMENTATION
DEFINED system registers to support any system register, so that
system registers defined by newer versions of the architecture can
still be used by older versions of the toolchain.
Clang before v3.6 supports the generic notation,
Reviewed-by: Liming Gao liming@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Friday, August 7, 2015 11:05 PM
To: edk2-devel@lists.01.org; Justen, Jordan L; Liu, Yingke D
Cc: Ard Biesheuvel
Subject: [edk2] [RFC
When adding section VERSION in FDF file, for example:
FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
SECTION RAW = MdeModulePkg/Logo/Logo.bmp
SECTION UI = Logo
SECTION VERSION = 0001
}
GenFds will report the following error:
Traceback (most recent call
1. Refine parameter name to consistent with function headers.
2. To avoid potential bug BOOLEAN values should not use explicit comparisons to
TRUE or FALSE.
Cc: Ruiyu Ni ruiyu...@intel.com
Cc: Ronald Cron ronald.c...@arm.com
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
On 10 August 2015 at 08:11, Gao, Liming liming@intel.com wrote:
Reviewed-by: Liming Gao liming@intel.com
Thank you Liming.
Does that apply to all patches? Or just this 2/4 ?
--
Ard.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
between variable HOB and NV storage.
Variable HOB may be built by a system that supports and loads variable
default, the variables in the HOB will be flush to NV storage after
variable write search ready.
After that, if the variable's Attributes is changed by someone and
system reboots and tries
The AARCH64 GCC builds use the GCC large code model by default, simply
because it is the code model that requires the least amount of hacking
to produce code that supports the PE/COFF conversion applied by Tianocore.
However, it is suboptimal in more than one way:
- each symbol reference requires
The DEBUG build of the Shell exceeds 1 MB in size, which means that
it cannot be built using the tiny code model. So force the use of
the code model in this case.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org
---
The AARCH64 tiny code model produces more efficient code, since it
uses relative symbol references rather than absolute references, i.e.,
an emitted relative reference refers to the symbol directly rather
than a literal containing its 64-bit absolute address. This saves
space in the binary, and
The ARMGCC and ARMLINUXGCC toolchains are specific to the ARM and
AARCH64 architectures, and overlap with the toolchain configuration
that is provided by the GCC44 - GCC49 toolchains, which are defined
for all architectures.
To reduce the maintenance burden, and make it easier to keep these
On Mon, Aug 10, 2015 at 03:07:41PM +0200, Ard Biesheuvel wrote:
Remove the ARMGCC and ARMLINUXGCC from comments in the respective
Makefiles of ArmPlatformPkg and ArmJunoPkg and from the [ancient]
Versatile Express instructions.
Contributed-under: TianoCore Contribution Agreement 1.0
CLANG chokes on the value 0XEA1 since it expects the 0x prefix
to use a lower case x.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org
---
OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +-
1 file changed, 1 insertion(+), 1
The relocated immediate notation supported by GNU as (e.g., #:lo12:foo)
is not supported by clang. Since we are loading a constant value, they
were not entirely appropriate here anyway, so simply replace them with
assembler arithmetic expressions.
Contributed-under: TianoCore Contribution
The ArmVirtPrePiUniCoreRelocatable module comes with its own GNU
linker script to create a PIE executable that can relocate itself
at runtime. In order to be able to build this module using CLANG,
we need to adhere to the section alignment passed via to the linker
using -z commmon-page-size, so
These are some minor code changes to allow ArmVirtXen to be built using
CLANG. Since the commercial ARM compiler suite is based on clang, we try
and keep the EDK2 code clang-clean, hence these patches.
Ard Biesheuvel (3):
ArmVirtPkg: avoid relocated immediates in AARCH64 asm
ArmVirtPkg: use
52 matches
Mail list logo