Re: [edk2] [patch 2/2] UefiCpuPkg/PiSmmCpu: Always set WP in CR0.

On 11/25/15 22:56, Yao, Jiewen wrote: > Hi Mike > Thanks for the suggestion. > Previously, I just want to *ADD* without touch old logic. I will use your way > to do it. > > -Original Message- > From: Kinney, Michael D > Sent: Thursday, November 26, 2015 2:01 AM > To: Yao, Jiewen;

[edk2] please DO NOT commit unreviewed patches to subversion!

I notice that recently there have been patches committed to the subversion repository that had *never* been posted to the list, in the ultimately committed form. Examples: (1) Patches on the list: http://thread.gmane.org/gmane.comp.bios.edk2.devel/4770 [edk2] [patch 1/3]

[edk2] [PATCH v5 22/33] OvmfPkg: SmmCpuFeaturesLib: remove unnecessary bits

From: Paolo Bonzini SMRR, MTRR, and SMM Feature Control support is not needed on a virtual platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paolo Bonzini Acked-by: Laszlo Ersek [ler...@redhat.com:

[edk2] [PATCH v5 25/33] OvmfPkg: use relaxed AP SMM synchronization mode

From: Paolo Bonzini Port 0xb2 on QEMU only sends an SMI to the currently executing processor. The SMI handler, however, and in particular SmmWaitForApArrival, currently expects that SmmControl2DxeTrigger triggers an SMI IPI on all processors rather than just the BSP. Thus

Re: [edk2] [patch] UefiCpuPkg/CpuExceptionHandlerLib: Skip CR restore for SMM handler.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Thursday, November 26, 2015 8:34 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Fan, Jeff; Kinney, Michael D Subject: [patch] UefiCpuPkg/CpuExceptionHandlerLib: Skip CR restore for SMM handler. In

Re: [edk2] [patch 2/2] UefiCpuPkg/PiSmmCpu: Always set WP in CR0.

Hi Laszlo Comments below: -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, November 27, 2015 5:57 AM To: Yao, Jiewen; Kinney, Michael D; edk2-de...@ml01.01.org Cc: Paolo Bonzini; Fan, Jeff Subject: Re: [edk2] [patch 2/2]

Re: [edk2] [patch 2/2] UefiCpuPkg/PiSmmCpu: Always set WP in CR0.

On 11/27/15 02:14, Yao, Jiewen wrote: > Hi Laszlo > Comments below: > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Friday, November 27, 2015 5:57 AM > To: Yao, Jiewen; Kinney, Michael D; edk2-de...@ml01.01.org > Cc:

[edk2] [PATCH v5 21/33] OvmfPkg: import SmmCpuFeaturesLib from UefiCpuPkg

From: Paolo Bonzini The next patches will customize the implementation, but let's start from the common version to better show the changes. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paolo Bonzini [ler...@redhat.com: drop

[edk2] [PATCH v5 24/33] OvmfPkg: SmmCpuFeaturesLib: customize state save map format

From: Paolo Bonzini This adjusts the previously introduced state save map access functions, to account for QEMU and KVM's 64-bit state save map following the AMD spec rather than the Intel one. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paolo

[edk2] [PATCH v5 23/33] OvmfPkg: SmmCpuFeaturesLib: implement SMRAM state save map access

From: Paolo Bonzini This implementation copies SMRAM state save map access from the PiSmmCpuDxeSmm module. The most notable change is: - dropping support for EFI_SMM_SAVE_STATE_REGISTER_IO - changing the implementation of EFI_SMM_SAVE_STATE_REGISTER_LMA to use the SMM

[edk2] [PATCH v5 13/33] OvmfPkg: LockBoxLib: -D SMM_REQUIRE excludes our fake lockbox

When the user builds OVMF with -D SMM_REQUIRE, our LockBox implementation must not be used, since it doesn't actually protect data in the LockBox from the runtime guest OS. Add an according assert to LockBoxLibInitialize(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH v5 08/33] OvmfPkg: add DXE_DRIVER for providing TSEG-as-SMRAM during boot-time DXE

The SMM core depends on EFI_SMM_ACCESS2_PROTOCOL. This small driver (which is a thin wrapper around "OvmfPkg/SmmAccess/SmramInternal.c" that was added in the previous patch) provides that protocol. Notably, EFI_SMM_ACCESS2_PROTOCOL is for boot time only, therefore our MODULE_TYPE is not

[edk2] [PATCH v5 07/33] OvmfPkg: add PEIM for providing TSEG-as-SMRAM during PEI

"MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf" is the LockBoxLib instance with SMRAM access for the PEI phase. Said library instance must, and can, access the LockBox data in SMRAM directly if it is invoked before SMBASE relocation / SMI handler installation. In that case, it only

[edk2] [PATCH v5 15/33] OvmfPkg: LockBox: use SMM stack with -D SMM_REQUIRE

During DXE, drivers save data in the LockBox. A save operation is layered as follows: - The unprivileged driver wishing to store data in the LockBox links against the "MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf" library instance. The library allows the unprivileged driver to

[edk2] [PATCH v5 00/33] OvmfPkg: support SMM for better security

Public branch: . The big change in this version is that Mike has flattened, cleaned up, and incorporated CpuS3DataDxe from OvmfPkg/QuarkPort to UefiCpuPkg. (Huge kudos for that again!) The OvmfPkg/QuarkPort directory is therefore gone, as are any

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

On 11/26/15 17:17, Laszlo Ersek wrote: > On 11/25/15 22:29, Jordan Justen wrote: >> On 2015-11-25 10:06:03, Laszlo Ersek wrote: >>> On 11/25/15 18:46, Jordan Justen wrote: On 2015-11-03 13:01:17, Laszlo Ersek wrote: > + qemu-system-i386 -cpu coreduo,-nx \ Sometimes we put

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Move IDT table to C code is very good! I think EFIAPI is no longer required for InitializeIDTSmmStackGuard(). Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of jiewen yao Sent: Thursday, November 26,

[edk2] [PATCH v5 29/33] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: add DXE_SMM_DRIVER build

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf | 89

[edk2] [PATCH v5 09/33] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

The EFI_SMM_COMMUNICATION_PROTOCOL implementation that is provided by the SMM core depends on EFI_SMM_CONTROL2_PROTOCOL; see the mSmmControl2->Trigger() call in the SmmCommunicationCommunicate() function [MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c]. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v5 30/33] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: adhere to -D SMM_REQUIRE

When the user requires "security" by passing -D SMM_REQUIRE, and consequently by setting PcdSmmSmramRequire, enforce flash-based variables. Furthermore, add two ASSERT()s to catch if the wrong module were pulled into the build. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH v5 19/33] OvmfPkg: select LocalApicLib instance with x2apic support

Although neither LocalApicLib instance is suitable for runtime DXE drivers (because they access the APIC at the physical address retrieved from either MSR_IA32_APIC_BASE_ADDRESS or PcdCpuLocalApicBaseAddress), they are suitable for SMM drivers -- SMM drivers are not influenced by the runtime OS's

[edk2] [PATCH v5 18/33] OvmfPkg: resolve DebugAgentLib for DXE_SMM_DRIVER modules

From: Michael Kinney Add mappings to DebugAgentLib for SMM modules to prevent build breaks when SMM_REQUIRE and SOURCE_DEBUG_ENABLE are both set. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney

[edk2] [PATCH v5 31/33] OvmfPkg: consolidate variable driver stack in DSC and FDF files

The following modules constitute the variable driver stack: - QemuFlashFvbServicesRuntimeDxe and EmuVariableFvbRuntimeDxe, runtime alternatives for providing the Firmware Volume Block(2) Protocol, dependent on qemu pflash presence, - FaultTolerantWriteDxe, providing the Fault Tolerant Write

[edk2] [PATCH v5 01/33] OvmfPkg: introduce -D SMM_REQUIRE and PcdSmmSmramRequire

This build time flag and corresponding Feature PCD will control whether OVMF supports (and, equivalently, requires) SMM/SMRAM support from QEMU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen

[edk2] [PATCH v5 17/33] OvmfPkg: resolve CpuExceptionHandlerLib for DXE_SMM_DRIVER modules

UefiCpuPkg/PiSmmCpuDxeSmm depends on this library (the RegisterCpuInterruptHandler() function specifically) to set up its specialized page fault handler (SmiPFHandler() -> DumpModuleInfoByIp()). It doesn't hurt to resolve this library class for all DXE_SMM_DRIVER modules. Contributed-under:

[edk2] [PATCH v5 32/33] OvmfPkg: pull in SMM-based variable driver stack

When -D SMM_REQUIRE is given, replace both - OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf and - OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.inf with - OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesSmm.inf. The outermost (= runtime DXE driver) VariableSmmRuntimeDxe enters SMM, and

[edk2] [PATCH v5 26/33] OvmfPkg: any AP in SMM should not wait for the BSP for more than 100 ms

This patch complements the previous one, "OvmfPkg: use relaxed AP SMM synchronization mode". While that patch focuses on the case when the SMI is raised synchronously by the BSP, on the BSP: BSPHandler() [UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c] SmmWaitForApArrival()

[edk2] [PATCH v5 11/33] OvmfPkg: pull in CpuIo2Smm driver

This driver provides EFI_SMM_CPU_IO2_PROTOCOL, which the SMM core depends on in its gEfiDxeSmmReadyToLockProtocolGuid callback (SmmReadyToLockHandler(), "MdeModulePkg/Core/PiSmmCore/PiSmmCore.c"). Approached on a higher level, this driver provides the SmmIo member of the EFI_SMM_SYSTEM_TABLE2

[edk2] [PATCH v5 16/33] OvmfPkg: resolve ReportStatusCodeLib for DXE_SMM_DRIVER modules

PiSmmCpuDxeSmm depends on this library class, and it's okay to resolve it generally for all DXE_SMM_DRIVER modules. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen ---

[edk2] [PATCH v5 28/33] OvmfPkg: build PiSmmCpuDxeSmm for -D SMM_REQUIRE

At this point we can enable building PiSmmCpuDxeSmm. CPU specific features, like SMRR detection, and functions that are used to initialize SMM and process SMIs, are abstracted through the SmmCpuFeaturesLib class for the PiSmmCpuDxeSmm module. Resolve it to our own implementation under OvmfPkg --

Re: [edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

Thanks for the great work to add generic IPMI definition. Here is my thought: 1) It is good to split header file definition to some small .h. Can we add more description in each function header description, so that people can know where to find the data structure? For example: +++

[edk2] [patch] NetworkPkg: Fix a bug in HttpBootDriverBindingStop() when destroying child.

If Http Driver is being unloaded or DisconnectController() without invoke HttpBootStart(), this will cause an unexpected ASSERT. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Reviewed-by: Sriram Subramanian

[edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

Add Ipmi2.0 definitions head file based on Ipmi category: App, Storage and etc. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- MdePkg/Include/IndustryStandard/Ipmi.h | 26 +

[edk2] [PATCH v2] MdeModulePkg:Replace unsafe string function with safe one.

V2: Update the Copyright info. Use StrCpyS instead of StrCatS when copy str1 to str. Cc: Liming Gao Cc: Eric Dong Cc: Qiu Shumin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

The IDT in ASM is removed. We rely on C code to allocate IDT. We also move InitializeIDTSmmStackGuard() from ASM to C file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff" Cc: "Kinney, Michael D"

Re: [edk2] [patch] NetworkPkg: Fix a bug in HttpBootDriverBindingStop() when destroying child.

Looks good. Reviewed-by: Sriram Subramanian Thanks, Sriram. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Thursday, November 26, 2015 12:02 PM To: edk2-devel@lists.01.org Subject: [edk2] [patch] NetworkPkg:

[edk2] [PATCH 03/23] BeagleBoardPkg: remove ArmPlatformGlobalVariableLib resolution

Remove the ArmPlatformGlobalVariableLib library class resolution now that BeagleBoardPkg no longer has a transitive dependency on it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BeagleBoardPkg/BeagleBoardPkg.dsc | 2 -- 1

[edk2] [PATCH 10/23] ArmVirtPkg/PrePi: remove global variable allocation from lowlevel init

Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePi init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 09/23] ArmPlatformPkg: remove all ArmPlatformGlobalVariableLib implementations

This removes the SEC, PEI and DXE variants of ArmPlatformGlobalVariableLib, which is no longer used, and should not be used since it violates the PI spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 11/23] ArmPlatformPkg/PrePi: remove global variable allocation from lowlevel init

Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePi init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 04/23] ArmVirtPkg/ArmVirtQemu: move to ArmPkg version of PeiServicesTablePointerLib

As pointed out by Eugene, the ArmPlatformPkg implementation of PeiServicesTablePointerLib violates the PI sec, since it uses ArmPlatformGlobalVariableLib to store the PEI services table pointer rather than the thread ID cpu registers as the spec requires. So instead, move to the ArmPkg version of

[edk2] [PATCH 01/23] ArmPlatformPkg/PrePiHobListPointerLib: use thread ID register

This updates the PrePiHobListPointerLib implementation in ArmPlatformPkg to move away from ArmPlatformGlobalVariableLib and instead use the thread ID CPU registers (TPIDRURW and TPIDR_EL0 for v7 and v8, respectively) for storing the HobList pointer. Since PrePiHobListPointerLib is specific to

[edk2] [PATCH 08/23] ArmPlatformPkg: remove PeiServicesTablePointerLib implementation

This removes the PeiServicesTablePointerLib implementation under ArmPlatformPkg that violates the PI spec, and hence should not be used. Instead, the implementation that resides under ArmPkg should be used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 07/23] ArmPlatformPkg: drop ArmPlatformGlobalVariableLib resolutions

We can remove all mention of ArmPlatformGlobalVariableLib now that there are no remaining [transitive] dependencies on it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc

[edk2] [PATCH 12/23] ArmPlatformPkg/PlatformPeim: remove ArmGlobalVariable lowlevel init

Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to query the ArmGlobalVariable PPI and install the ArmGlobalVariable HOB. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 13/23] ArmPlatformPkg/PrePeiCore: remove global variable allocation from lowlevel init

Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePeiCore init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 20/23] ArmPlatformPkg/EblCmdLib: drop bogus ArmGlobalVariableHob.h include

EblCmdLib does not use anything that is declared by ArmGlobalVariableHob.h, so remove the include. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Library/EblCmdLib/EblCmdFdt.c | 1 - 1 file changed, 1

[edk2] [PATCH 18/23] ArmPlatformPkg/ArmJunoDxe: drop bogus gArmGlobalVariableGuid dependency

ArmJunoDxe does not use gArmGlobalVariableGuid so drop the declaration from the .inf. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - 1 file changed, 1

[edk2] [PATCH 06/23] ArmPlatformPkg: move to ArmPkg version of PeiServicesTablePointerLib

As pointed out by Eugene, the ArmPlatformPkg implementation of PeiServicesTablePointerLib violates the PI sec, since it uses ArmPlatformGlobalVariableLib to store the PEI services table pointer rather than the thread ID cpu registers as the spec requires. So instead, move to the ArmPkg version of

[edk2] [PATCH 15/23] EmbeddedPkg/AndroidFastboot: drop bogus gArmGlobalVariableGuid dependency

This application lists gArmGlobalVariableGuid as a dependency, but does not actually need it. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf | 3

[edk2] [PATCH 19/23] ArmPlatformPkg/ArmVExpressFastBootDxe: drop bogus gArmGlobalVariableGuid dep

ArmVExpressFastBootDxe does not use gArmGlobalVariableGuid so drop the declaration from the .inf. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressFastBootDxe/ArmVExpressFastBootDxe.inf

[edk2] [PATCH 16/23] ArmPkg/BdsLib: drop bogus gArmGlobalVariableGuid dependency

The BdsLib implementation under ArmPkg never references gArmGlobalVariableGuid so it should not list it as a dependency. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/BdsLib/BdsLib.inf | 1 - 1 file changed, 1

[edk2] [PATCH 02/23] ArmPkg: remove ArmPlatformGlobalVariableLib resolution from ArmPkg.dsc

ArmPkg does not depend on ArmPlatformGlobalVariableLib, and this library is about to be removed, so remove all mention of it from ArmPkg.dsc. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dsc | 3 --- 1 file

[edk2] [PATCH 14/23] ArmPlatformPkg/Sec: remove global variable allocation from lowlevel init

Now that we dropped all ArmPlatformGlobalVariableLib dependencies, there is no longer a need to allocate and clear out the global variable region in the PrePi init code. So remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 22/23] ArmPlatformPkg: remove ArmGlobalVariable PCD, GUID and PPI definitions

Now that we removed all references to the ArmGlobalVariable definitions in the various lowlevel PrePi and PrePeiCore init routines, and removed the PPI and HOB references from PlatformPeim, it is time to say goodbye to ArmGlobalVariable. So remove the includes and the .DEC declarations.

[edk2] [PATCH 05/23] ArmVirtPkg: drop ArmPlatformGlobalVariableLib dependency

Now that all PeiServicesTablePointerLib and PrePiHobListPointerLib library dependencies in both ArmVirtQemu and ArmVirtXen are satisfied by implemenations that do not depend on ArmPlatformGlobalVariableLib, we can remove all mention of it from the various .dsc files. Contributed-under: TianoCore

[edk2] [PATCH 21/23] ArmPlatformPkg/PlatformIntelBdsLib: drop bogus gArmGlobalVariableGuid dep

PlatformIntelBdsLib does not use gArmGlobalVariableGuid so drop the declaration from the .inf. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 1 - 1 file

[edk2] [PATCH 17/23] ArmPlatformPkg/Bds: drop bogus ArmGlobalVariable dependencies

Remove the GUID references to gArmGlobalVariableGuid and includes of ArmGlobalVariableHob.h since they are not used by the ARM BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Bds/Bds.inf | 1 -

[edk2] [PATCH 23/23] ArmPkg: remove SetPrimaryStack and InitializePrimaryStack macros

The SetPrimaryStack and InitializePrimaryStack macros are no longer used now that we removed support for ArmPlatformGlobalVariableLib. So remove the various versions of them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [patch] UefiCpuPkg/CpuExceptionHandlerLib: Skip CR restore for SMM handler.

In SMM, we skip CR restore. The CR should always be right and should no be touched. mDoFarReturnFlag is changed to mSmmFlag to indicate all difference between normal mode and SMM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan,

[edk2] [Patch] BaseTools: Add a VPD report subsection of FLASH to the Report

Build Spec already added a VPD report subsection of FLASH to the Report chapter, it provide a simple way for user to determine where the VPD region and VPD PCDs are located in the fd file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

On 20 November 2015 at 13:46, Mark Rutland wrote: > On Fri, Nov 20, 2015 at 01:39:26PM +0100, Ard Biesheuvel wrote: >> The PrePeiCore vector table for AArch64 mode is only half populated. >> However unlikely, if exceptions from lower exception levels are ever >> taken, they

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

On Thu, Nov 26, 2015 at 04:06:40PM +0100, Ard Biesheuvel wrote: > On 20 November 2015 at 13:46, Mark Rutland wrote: > > On Fri, Nov 20, 2015 at 01:39:26PM +0100, Ard Biesheuvel wrote: > >> The PrePeiCore vector table for AArch64 mode is only half populated. > >> However

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

On 26 November 2015 at 16:09, Mark Rutland wrote: > On Thu, Nov 26, 2015 at 04:06:40PM +0100, Ard Biesheuvel wrote: >> On 20 November 2015 at 13:46, Mark Rutland wrote: >> > On Fri, Nov 20, 2015 at 01:39:26PM +0100, Ard Biesheuvel wrote: >> >> The

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

On 11/25/15 22:29, Jordan Justen wrote: > On 2015-11-25 10:06:03, Laszlo Ersek wrote: >> On 11/25/15 18:46, Jordan Justen wrote: >>> On 2015-11-03 13:01:17, Laszlo Ersek wrote: >>> + qemu-system-i386 -cpu coreduo,-nx \ >>> >>> Sometimes we put '$' before a command prompt. I know there is no

Re: [edk2] [PATCH] ArmPlatformPkg/PrePeiCore: add missing entries to AArch64 vector table

On Thu, Nov 26, 2015 at 04:20:00PM +0100, Ard Biesheuvel wrote: > On 26 November 2015 at 16:09, Mark Rutland wrote: > > On Thu, Nov 26, 2015 at 04:06:40PM +0100, Ard Biesheuvel wrote: > >> On 20 November 2015 at 13:46, Mark Rutland wrote: > >> > On

Re: [edk2] [PATCH 04/23] ArmVirtPkg/ArmVirtQemu: move to ArmPkg version of PeiServicesTablePointerLib

On 11/26/15 13:10, Ard Biesheuvel wrote: > As pointed out by Eugene, the ArmPlatformPkg implementation of > PeiServicesTablePointerLib violates the PI sec, since it uses > ArmPlatformGlobalVariableLib to store the PEI services table pointer > rather than the thread ID cpu registers as the spec

Re: [edk2] [PATCH 05/23] ArmVirtPkg: drop ArmPlatformGlobalVariableLib dependency

On 11/26/15 13:10, Ard Biesheuvel wrote: > Now that all PeiServicesTablePointerLib and PrePiHobListPointerLib > library dependencies in both ArmVirtQemu and ArmVirtXen are satisfied > by implemenations that do not depend on ArmPlatformGlobalVariableLib, > we can remove all mention of it from the

Re: [edk2] [PATCH 04/23] ArmVirtPkg/ArmVirtQemu: move to ArmPkg version of PeiServicesTablePointerLib

On 26 November 2015 at 17:45, Laszlo Ersek wrote: > On 11/26/15 13:10, Ard Biesheuvel wrote: >> As pointed out by Eugene, the ArmPlatformPkg implementation of >> PeiServicesTablePointerLib violates the PI sec, since it uses >> ArmPlatformGlobalVariableLib to store the PEI

Re: [edk2] [PATCH 10/23] ArmVirtPkg/PrePi: remove global variable allocation from lowlevel init

On 11/26/15 13:10, Ard Biesheuvel wrote: > Now that we dropped all ArmPlatformGlobalVariableLib dependencies, > there is no longer a need to allocate and clear out the global > variable region in the PrePi init code. So remove it. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] EDK python script

On 11/26/15 04:45, Lu, James wrote: > > Hi, > > I'm trying to build EDK BIOS with python script on Linux but got below error. > > [16:50:59]W: [Step 2/5] Build environment: > Linux-3.2.0-69-generic-x86_64-with-Ubuntu-12.04-precise > [16:50:59]W: [Step 2/5] Build start time: 16:50:59,

Re: [edk2] [PATCH V4 07/13] CorebootPayloadPkg: Use SerialDxe in MdeModulePkg

Hi Star, On 11/25/15 02:33, Star Zeng wrote: > 1. Update fdf and dsc to use SerialDxe in MdeModulePkg. > 2. Separate the code that gets SerialRegBase and SerialRegAccessType >by CbParseLib from CorebootPayloadPkg/Library/SerialPortLib to >PlatformHookLib, and then leverage