Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 15:57, Yao, Jiewen wrote: > Yes, that is weird. > Do you see the same issue in February 24 image? Or is this a new issue? > This is a different platform than I was using at the time to validate this code, so I cannot really compare them directly. > > It

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

That is enough. Thanks! I suggest you use this way as temp work-around. As final solution, I think we can construct table after all ReadyToBoot events are processed, which need more update in DxeCore. Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel

Re: [edk2] [PATCH] ArmPlatformPkg: Initialize the UART Debug Port

On 4 March 2016 at 19:37, wrote: > From: Sami Mujawar > > The Operating system debugger relies on the firmware to configure and > initialize the UART debug port. > > This patch initializes the PL011 UART to be used as a Debug Port. > > Code at: >

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 16:07, Yao, Jiewen wrote: > That is enough. Thanks! > > I suggest you use this way as temp work-around. > > As final solution, I think we can construct table after all ReadyToBoot > events are processed, which need more update in DxeCore. > For now, the

Re: [edk2] [Patch] NetworkPkg: Add RAM disk boot support to HTTP Boot driver.

The application/efi type is "temporarily approved". It is still waiting for final approval from IANA internal technical review. I do not think there are any issues, but it is just a matter of time. I am fine keeping the definition private in HttpBootDxe until IANA approves the type and

Re: [edk2] [PATCH 1/2] MdePkg: Add ARM Serial Port Subtype definitions

Sorry for late response. This serial is ok to me. Reviewed-by: Liming Gao liming@intel.com Thanks Liming From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, April 1, 2016 10:17 PM To: Yao, Jiewen Cc: evan.ll...@arm.com;

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 1 April 2016 at 16:17, Laszlo Ersek wrote: > On 04/01/16 16:13, Ard Biesheuvel wrote: >> On 29 March 2016 at 22:08, Ard Biesheuvel wrote: >>> On 29 March 2016 at 19:51, Laszlo Ersek wrote: Edk2 commit 8a45f80edad4

Re: [edk2] [PATCH 3/3] ArmPkg: Correct typos in ArmArchTimerLib.c.

On 3 March 2016 at 12:55, wrote: > From: Evan Lloyd > > SOme minor typographical problems were noticed during previous commits. > This change corrects those, and contains no functional modifications. > The changes are in comments, and one diagnostic

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 29 March 2016 at 22:08, Ard Biesheuvel wrote: > On 29 March 2016 at 19:51, Laszlo Ersek wrote: >> Edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII configuration settings >> available to OS runtime") implements the optional UEFI feature described

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Friday, April 1, 2016 12:16 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Wu Jiaxin Subject:

Re: [edk2] [PATCH 1/2] MdePkg: Add ARM Serial Port Subtype definitions

@Liming, Michael: do you have any objections to this patch? Thanks, Ard. On 5 March 2016 at 00:45, Yao, Jiewen wrote: > Reviewed by: jiewen@intel.com > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

Re: [edk2] [PATCH 2/2] MdePkg: Add ARM Serial Port Subtypes to DBG2

@Liming, Michael: any objections? On 5 March 2016 at 00:41, Yao, Jiewen wrote: > Reviewed by: jiewen@intel.com > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > evan.ll...@arm.com > Sent: Saturday, March 05, 2016

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 04/01/16 16:13, Ard Biesheuvel wrote: > On 29 March 2016 at 22:08, Ard Biesheuvel wrote: >> On 29 March 2016 at 19:51, Laszlo Ersek wrote: >>> Edk2 commit 8a45f80edad4 ("MdeModulePkg: Make HII configuration settings >>> available to OS runtime")

Re: [edk2] [PATCH] ArmPlatformPkg: Add PCD for Pl011 UART Interrupt

On 4 March 2016 at 19:26, wrote: > From: Sami Mujawar > > This patch adds a PCD for the PL011 UART Interrupt as this is needed by > the Serial Port Console Redirection Table. > > Code at: >

Re: [edk2] [PATCH] EmbeddedPkg: Fix SBSA Generic Watchdog helper

On 4 March 2016 at 14:46, wrote: > From: Sami Mujawar > > The Reserved field in the SBSA Generic Watchdog Structure is 1 byte in > length. Refer Table 5-123 in the ACPI 5.1 Specification Errata A. > > The

Re: [edk2] [PATCH 0/2] MdePkg: Add ARM Serial Port definitions

On 4 March 2016 at 18:24, wrote: > Second stab at Serial port id updates, responding to request from > Jiewen Yao > > [PATCH 1/2] MdePkg: Add ARM Serial Port Subtype definitions > [PATCH 2/2] MdePkg: Add ARM Serial Port Subtypes to DBG2 Thanks

Re: [edk2] [PATCH 2/2] ArmVirtPkg: disable PcdHiiOsRuntimeSupport

On 1 April 2016 at 16:32, Laszlo Ersek wrote: > On 04/01/16 16:20, Ard Biesheuvel wrote: >> On 1 April 2016 at 16:17, Laszlo Ersek wrote: >>> On 04/01/16 16:13, Ard Biesheuvel wrote: On 29 March 2016 at 22:08, Ard Biesheuvel

Re: [edk2] [PATCH 1/2] ArmPlatformPkg: Add support to configure PL011 UART clock

On 3 March 2016 at 13:16, wrote: > From: Sami Mujawar > > On some platforms the UART clock is not the same for all the serial > ports. The PL011 driver should be reentrant and capable of handling > serial ports with different clock rates. > > This patch

Re: [edk2] Using multiple SNP drivers on Shell

On 04/01/2016 06:48 AM, Bhupesh Sharma wrote: Hello, Any suggestions for this issue? Is this a known issue? Hi Bhupesh, The ping command allows you to specify the interface you would like to use with the -s flag, e.g. ping -s eth0 192.168.1.1 or ping -s eth1 192.168.1.1 The options

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 31/03/16 14:37, Michael Brown wrote: In a nutshell, I think iPXE should: - reflect the GUID / NAME / PATH triplet from the input to the output verbatim, - for each config knob requested, respond with =. (See also: "if a ConfigHdr is passed in with no request elements, all of the settings

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 31/03/16 14:06, Dong, Eric wrote: 1. Enhance the Results string for ExtractConfig function like below: Request = “GUID===&…” Results = “GUIDValue1=Value2=Value3…” PS: Red string you can get from the input Request string. Blue string is the true value for each knob in your driver.

Re: [edk2] HII incompatibility between edk2 and iPXE?

On 04/01/16 18:49, Michael Brown wrote: > On 31/03/16 14:37, Michael Brown wrote: >>> In a nutshell, I think iPXE should: >>> - reflect the GUID / NAME / PATH triplet from the input to the output >>> verbatim, >>> - for each config knob requested, respond with >>> =. >>> >>> (See also: "if a

Re: [edk2] [Patch] NetworkPkg: Check pointer for NULL before use.

Looks good to me. Reviewed-by: Ye Ting > From: Fu, Siyuan Sent: Friday, April 01, 2016 1:22 PM To: Wu, Jiaxin ; edk2-devel@lists.01.org Cc: Ye, Ting Subject: RE: [Patch] NetworkPkg: Check pointer for NULL

[edk2] [Patch] BaseTools/GenFds: Fix the bug for wrong alignment generate for RAW file

When do the multiple raw file support feature, it cause the regression that the raw file section alignment value was wrongly overridden by the single raw file. this patch: 1) fix the wrong overridden bug. 2) remove the duplicate code for combine multiple raw file into one. Contributed-under:

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 31 March 2016 at 15:33, Ard Biesheuvel wrote: > On 31 March 2016 at 15:20, Yao, Jiewen wrote: >> Hi Ard >> Thanks for your log. Yes, it seems new issue, I have never encountered >> before. >> >> Here is what I found: >> >> 1)

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 09:24, Ard Biesheuvel wrote: > On 31 March 2016 at 15:33, Ard Biesheuvel wrote: >> On 31 March 2016 at 15:20, Yao, Jiewen wrote: >>> Hi Ard >>> Thanks for your log. Yes, it seems new issue, I have

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

Ard, I totally agree with your judgement:). PciIo.AllocateBuffer() is specific for allocating a common buffer which could be accessed by CPU and DMA simultaneously. Map() could be used to map the host/cpu address got from AllocateBuffer() to pci device address. These APIs are common for

Re: [edk2] [PATCH] MdeModulePkg: support AHCI controller using PCI emulation

On 31 March 2016 at 22:51, Leendert van Doorn wrote: > >> So what we may have here is either a bug in DmaLib on ARM, or a bug in the >> PCI emulation >> where it handles EfiPciIoOperationBusMasterCommonBuffer allocations >> incorrectly, since such >> buffers need to be

Re: [edk2] [Patch v2 3/3] MdeModulePkg/Bds: Memory Bins don't count the memory used by RAM Disk

Hi Ray, For the code block below in BmSetMemoryTypeInformationVariable() in the BmMisc.c, +if (CurrentMemoryTypeInformation[Index1].Type == EfiReservedMemoryType) { + CurrentMemoryTypeInformation[Index1].NumberOfPages -= RamDiskSizeInPages; +} Since NumberOfPages is UINT32 but

Re: [edk2] [Patch v3 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

Hi Ray, For this patch, I just have a suggestion below. Others look good to me. For the memory allocation code block below, It looks better to add a ZeroMem() call right after it like the following so that we can avoid running into some problems caused by remaining garbage data in memory.

Re: [edk2] [Patch v3 2/3] MdeModulePkg/Bds: Free resources after ram disk boot finishes

Hi Ray, For this patch, I just found a minor issue and also have a suggestion below. Others look good to me. Minor issue: The following newly created functions' parameter lack IN and/or OUT modifiers: 1. BmGetLoadFileRamDisk 2. BmGetRamDiskMemoryInfo 3. BmDestroyRamDisk Suggestion: It looks

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: BmGetActiveConsoleIn code cleanup

Reviewed-by: Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Palmer, Thomas Sent: Thursday, March 31, 2016 1:17 AM To: edk2-devel@lists.01.org Cc: ruiyu...@intel.com; feng.t...@intel.com; star.z...@intel.com

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

On 1 April 2016 at 14:16, Ard Biesheuvel wrote: > On 1 April 2016 at 09:25, Ard Biesheuvel wrote: >> On 1 April 2016 at 09:24, Ard Biesheuvel wrote: >>> On 31 March 2016 at 15:33, Ard Biesheuvel

Re: [edk2] Recommend platforms for doing Intel UEFI driver development

On 03/31/16 23:10, Mahan, Patrick wrote: > Laszlo, > > What is FLR, I must admit my ignorance to that acronym. Function Level Reset. https://en.wikipedia.org/wiki/X86_virtualization#FLR > I'm not fully up on using a VM as s development environment. Does the NIC > need to have it's linux

[edk2] [PATCHv2 0/2] Bds: Correct the total RAM calculation

v2: This version updates the ram shift constants with RShiftU64. it also applies similar changes to the MdeModulePkg/UiApp which has a duplicate version of the UpdateFrontPageStrings function with some additional checks/error handling. In the latter case the changes are identical but I don't have

[edk2] [PATCH 2/2] MdeModulePkg/UiApp: Correct the total RAM calculation

This change mirrors the change in InteFrameworkModulePkg. We now account for all TYPE19 memory regions found in the smbios data, as well as handling records with Extended Addresses. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton ---

[edk2] [PATCH 1/2] IntelFrameworkModulePkg/Bds: Correct the total RAM calculation

Update the BDS frontpage to pull the RAM ranges from the smbios extended size fields when applicable. The RAM calculation also needs to take into account all the RAM ranges being provided as many machines have multiple physical address ranges. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 1/3] ArmPkg: Add GetTimeInNanoSecond() to ArmArchTimerLib

On 3 March 2016 at 17:26, Ryan Harkin wrote: > On 3 March 2016 at 15:28, wrote: >> From: Sami Mujawar >> >> FirmwarePerformanceDxe.c utilizes the Timer Library function >> GetTimeInNanoSecond() which was not implemented by the

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

Yes, that is weird. Do you see the same issue in February 24 image? Or is this a new issue? It seems some other module allocates RuntimeServicesData region in ReadyToBootEvent handler. I am not sure if it is introduced by recent HiiDatabaseDxe change. Would you please try to set

Re: [edk2] Using multiple SNP drivers on Shell

Hello, Any suggestions for this issue? Is this a known issue? Regards, Bhupesh > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Bhupesh Sharma > Sent: Thursday, March 31, 2016 5:18 PM > To: edk2-devel@lists.01.org > Subject: [edk2] Using