Re: [edk2] [Help] UEFI boot KVM4T vm hang On TianoCore

Hi, sorry about the delayed response. CC'ing Igor, and commenting below: On 10/31/17 15:29, Hangaohuai wrote: > Hi, Laszlo Ersek; > > I have tested the uefi booting KVM vm with the configuration(xml); but > start hang. > Enable the memoryhotplug, with usb3.0 config. The config as Config1 >

[edk2] [PATCH v2 3/3] ArmPlatformPkg/PL031RealTimeClockLib: ignore DST setting when timezone is set

According to the UEFI spec, the timezone setting which the platform needs to record in addition to the actual date and time already reflects the current DST setting. In other words, moving the clock from standard time to daylight saving time also involves adding or subtracting 60 minutes from the

[edk2] [PATCH v2 0/3] ArmPlatformPkg EmbeddedPkg: consolidate shared RTC functionality

This moves input validation and recording of the DST and timezone settings (which cannot usually be done by the hardware) into the core RTC driver in EmbeddedPkg, and removes it from one of the RealTimeClockLib implementations, the one for the ARM PL031. v2: split PL031 into two reinstate

[edk2] [PATCH v2 2/3] ArmPlatformPkg/PL031RealTimeClockLib: remove validation and DST handling

This library, which is intended to encapsulate the hardware specifics of the ARM PL031 RTC, also implements its own input validation routines and record the timezone and DST settings in its own set of EFI variables. This functionality has recently been added to the core driver, so let's remove it

[edk2] [PATCH v2 1/3] EmbeddedPkg/RealTimeClockRuntimeDxe: move common functionality into core

RealTimeClockRuntimeDxe defers the hardware/platform specific handling of reading/setting the hardware clock to RealTimeClockLib, but for unknown reasons, it also defers common functionality such as input validation and recording the timezone and DST settings (which are informational only and not

Re: [edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: call SdMmcFreeTrb() to complete sync operation

Except the typo "incorrecnt" needs to be "incorrect" in commit log, others are good to me. With typo fixed, Reviewed-by: Star Zeng -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Sunday, November 5, 2017 5:31 PM To:

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

I am ok to this code approach. Acknowledged-by: Star Zeng Besides, I think except GCD services, DxeCore should not call gCpu->SetMemoryAttributes() directly, for example ApplyMemoryProtectionPolicy(), it should have no assumption of the CPU code (to set capabilities),

Re: [edk2] Build error in StdLib with VS 2015 compiler

What do you say... Thanks, Karunakar -Original Message- From: Karunakar P Sent: Thursday, November 02, 2017 8:17 PM To: 'Gao, Liming'; 'Tim Lewis'; edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: RE: [edk2] Build error in StdLib with VS 2015 compiler Then it

Re: [edk2] [PATCH v3] MdeModulePkg/VarCheckHii: Enhance VarCheckHiiLib to support bit check

Reviewed-by: Star Zeng -Original Message- From: Bi, Dandan Sent: Monday, November 6, 2017 3:47 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Gao, Liming Subject: [PATCH v3]

Re: [edk2] [PATCH] MdeModulePkg SerialDxe: Handle Timeout change more robustly

Star, On 11/02/17 02:41, Star Zeng wrote: > https://lists.01.org/pipermail/edk2-devel/2017-October/016479.html > reported "Xen Console input very slow in recent UEFI" that appears > after 4cf3f37c87ba1f9d58072444bd735e40e4779e70 "MdeModulePkg > SerialDxe: Process timeout consistently in

Re: [edk2] [RFC PATCH edk2-platforms 1/3] Silicon/NXP: add RTC support library for PCF8563 I2C IP

Thanks Ard. This will allow to use PCF8563 on any platform not limiting to targeted platform. Few comments are inline. Regards Udit > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Friday, November 03, 2017 3:47 PM

[edk2] [Patch 0/2] Add missed Depex Protocol/Ppi.

The Protocol/Ppi used in the drivers but the it not add them in the dependence section, it may cause driver assert. This patch series add the missed Protocol/Ppi. Eric Dong (2): UefiCpuPkg/CpuFeaturesDxe.inf: Add missed Depex protocol. UefiCpuPkg/CpuFeaturesPei.inf: Add missed Depex Ppi.

[edk2] [Patch 2/2] UefiCpuPkg/CpuFeaturesPei.inf: Add missed Depex Ppi.

The gEfiPeiMpServicesPpiGuid Ppi is used by CpuFeaturesPei.inf during feature detection. Should be included in the [DepEx] section but actually not. This patch add it. Cc: Liming Gao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [Patch 1/2] UefiCpuPkg/CpuFeaturesDxe.inf: Add missed Depex protocol.

The gEfiMpServiceProtocolGuid protocol is used by CpuFeaturesDxe.inf during feature detection. Should be included in the [DepEx] section but actually not. This patch add it. Cc: Liming Gao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution

Re: [edk2] [RFC PATCH edk2-platforms 1/3] Silicon/NXP: add RTC support library for PCF8563 I2C IP

On 6 November 2017 at 11:09, Udit Kumar wrote: > Thanks Ard. > This will allow to use PCF8563 on any platform not limiting to targeted > platform. Yes, that was the intention. > Few comments are inline. > Thanks. > >> -Original Message- >> From: edk2-devel

[edk2] [PATCH] MdeModulePkg VarCheckHiiLib: Fix typo "0x02%x" to be "0x%02x"

Cc: Dandan Bi Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiGen.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

Hi Ray, On 11/03/17 09:28, Ruiyu Ni wrote: > The original code enables some BITs in PCI attributes in Start(), > but wrongly to disable these BITs in Stop(). > > The correct behavior is to save the original PCI attributes before > enables some BITs in Start(), and restore to original value > in

[edk2] Riding the UEFI shell / enabling the platform for C developers

Hi Tim, With the disappearance of MSDOS as a simple, single threaded, unprotected operating system with full hardware access to user programs on upcoming personal computer models the UEFI shell was intended to be the successor of MSDOS. please try

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Thanks for the review. And I agree that GCD.SetMemoryAttributes should be used all the time in DxeCore. Let's fix it in another patch. > -Original Message- > From: Zeng, Star > Sent: Monday, November 06, 2017 5:16 PM > To: Wang, Jian J ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

Laszlo, Sure I will add the Bugzilla url in the commit message. Steven, Could you please check whether this patch can fix your "reconnect -r" hang? Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 7, 2017 7:23 AM > To: Ni, Ruiyu

Re: [edk2] [PATCH v2 2/3] ShellPkg: Fix misuses of AllocateCopyPool

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wang, Jian J > Sent: Tuesday, November 7, 2017 1:11 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu ; > Bi, Dandan >

[edk2] [PATCH 14/14] UefiCpuPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

Re: [edk2] [Help] UEFI boot KVM4T vm hang On TianoCore

Hi, Laszlo Ersek; Thanks for your reply. I have trying to shoot this trouble: 1. edk get the MtrrValidBitsMask by "AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, , NULL, NULL, NULL); "(0x8008) 2. Cpuid(0x8008) is held in kvm struct (>arch.cpuid_entries[i]) 3. (0x8008) is set by qemu; Part1:

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Change ReadMe format

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- ReadMe.MD | 63 --- 1 file changed, 36 insertions(+), 27 deletions(-) diff --git a/ReadMe.MD b/ReadMe.MD index f5cbc7c..a42260e

[edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] Riding the UEFI shell / enabling the platform for C developers

Hi Tim, With the disappearance of MSDOS as a simple, single threaded, unprotected operating system with full hardware access to user programs on upcoming personal computer models the UEFI shell was intended to be the successor of MSDOS. please try

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Sorry, let me clarify, if we believe C4255 can help catch more problem, and we fixed all problem, why not enable it in BaseTool directly. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Tuesday, November 7, 2017 1:44

Re: [edk2] [PATCH v2] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

Jiewen, Any comments? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, November 1, 2017 12:49 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Michael Turner >

Re: [edk2] [RFC PATCH edk2-platforms 1/3] Silicon/NXP: add RTC support library for PCF8563 I2C IP

Thanks Ard, Your another patch set is addressing my concern Regards Udit > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, November 06, 2017 4:41 PM > To: Udit Kumar > Cc: edk2-devel@lists.01.org;

Re: [edk2] [PATCH v2] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

Looks good. Reviewed-by: jiewen@intel.com > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 7, 2017 10:40 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Michael Turner >

Re: [edk2] [PATCH 1/2] CryptoPkg/BaseCryptLib: Add C-structure to matching certificate stack

It is good to document this data structure. Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Long, > Qin > Sent: Tuesday, November 7, 2017 10:31 AM > To: Chen, Chen A ;

[edk2] [PATCH 10/14] SecurityPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 08/14] NetworkPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 11/14] ShellPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 09/14] PcAtChipsetPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 06/14] MdeModulePkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 04/14] IntelFsp2Pkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 01/14] FatPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 02/14] IntelFrameworkModulePkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 03/14] IntelFrameworkPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 00/14] Enable MSFT C4255 warning

Enable MSFT C4255 warning. >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 07/14] MdePkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 12/14] SignedCapsulePkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

[edk2] [PATCH 13/14] SourceLevelDebugPkg: Enable MSFT C4255 warning

Enable MSFT C4255 warning >From MSDN: Compiler Warning (level 4) C4255 function' : no function prototype given: converting '()' to '(void)' The compiler did not find an explicit list of arguments to a function. This warning is for the C compiler only. Cc: Liming Gao

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Jiewen: We plan to enable this option in new VS tool chain VS2017. So, we can keep DSC without the change, and enable this option after VS2017 tool chain is added. Thanks Liming >-Original Message- >From: Yao, Jiewen >Sent: Tuesday, November 07, 2017 2:00 PM >To: Yao, Jiewen

Re: [edk2] [PATCH 1/2] CryptoPkg/BaseCryptLib: Add C-structure to matching certificate stack

Reviewed-by: Long Qin One minor comment: please leave one space before the structure name: +} EFI_CERT_DATA; and +} EFI_CERT_STACK; Best Regards & Thanks, LONG, Qin -Original Message- From: Chen, Chen A Sent: Tuesday, November 7, 2017 9:05 AM To:

Re: [edk2] [PATCH 2/2] SecurityPkg/AuthVariableLib: Use EFI_CERT_DATA to parse certificate

Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of chenc2 Sent: Tuesday, November 7, 2017 9:05 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B ;

Re: [edk2] [PATCH 12/14] SignedCapsulePkg: Enable MSFT C4255 warning

Hi I suggest we fix the problem. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Song, > BinX > Sent: Tuesday, November 7, 2017 1:35 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 12/14]

Re: [edk2] [PATCH 04/14] IntelFsp2Pkg: Enable MSFT C4255 warning

Hi I suggest we fix the problem. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Song, > BinX > Sent: Tuesday, November 7, 2017 1:35 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 04/14]

[edk2] [PATCH v2 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool

> v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during

[edk2] [PATCH v2 2/3] ShellPkg: Fix misuses of AllocateCopyPool

> v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during

[edk2] [PATCH v2 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool

>v2: > a. Use ReallocatePool to replace AllocateCopyPool wherever applicable. AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during copy.

[edk2] [PATCH v2 0/3] Fix misuses of AllocateCopyPool

> v2: > a. Use ReallocatePool instead of allocating then copying wherever applicable AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Hi Jiewen, Do you mean we fix the problem after enable MSFT C4255 warning? If yes, I have fix them in related patch, such as MdeModulePkg. Best Regards, Bell Song > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 7, 2017 1:39 PM > To: Song, BinX ;

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Yes, I suggest we fix it. > -Original Message- > From: Song, BinX > Sent: Tuesday, November 7, 2017 1:43 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255

Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning

Hi I suggest we fix the problem. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Song, > BinX > Sent: Tuesday, November 7, 2017 1:35 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 05/14]

[edk2] [PATCH 1/2] CryptoPkg/BaseCryptLib: Add C-structure to matching certificate stack

The parameter CertStack of Pkcs7GetSigners will return all embedded X.509 certificate in one given PKCS7 signature. The format is: // // UINT8 CertNumber; // UINT32 Cert1Length; // UINT8 Cert1[]; // UINT32 Cert2Length; // UINT8 Cert2[]; // ... // UINT32 CertnLength; // UINT8 Certn[]; // Add

[edk2] [PATCH 2/2] SecurityPkg/AuthVariableLib: Use EFI_CERT_DATA to parse certificate

The function Pkcs7GetSigners return certificate stack as binary buffer. Use EFI_CERT_DATA to parsing certificate stack more clearly, and access certificate by the field of EFI_CERT_DATA structure. Cc: Long Qin Cc: Zhang Chao Contributed-under:

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Hi, Do you have further concern to this patch and have a RB? If no, I am happy to help push this patch with my AB. Thanks, Star -Original Message- From: Wang, Jian J Sent: Tuesday, November 7, 2017 8:55 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Laszlo Ersek

[edk2] [PATCH V2] MdeModulePkg SerialDxe: Handle Timeout change more robustly

https://lists.01.org/pipermail/edk2-devel/2017-October/016479.html reported "Xen Console input very slow in recent UEFI" that appears after 4cf3f37c87ba1f9d58072444bd735e40e4779e70 "MdeModulePkg SerialDxe: Process timeout consistently in SerialRead". Julien did more debugging and find out the

Re: [edk2] [PATCH] MdeModulePkg SerialDxe: Handle Timeout change more robustly

Laszlo, I agree it could be more rigorous to compare against the original parameters. Please check the V2 patch at https://lists.01.org/pipermail/edk2-devel/2017-November/016968.html. Julien, Please help take the test on your case with the V2 patch. Thanks, Star -Original Message-

Re: [edk2] UEFI Image Attribute

Thanks for the reply Igor. Yes, I was referring to the AttributesSetting of the EFI_FIRMWARE_IMAGE_DESCRIPTOR which is read as part of the GetImageInfo service of the FMP on a device. So,if the device sets this attributes, does it mean that its UEFI driver's FMP implementation can ONLY support

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Update ReadMe.MD

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- ReadMe.MD | 114 -- 1 file changed, 74 insertions(+), 40 deletions(-) diff --git a/ReadMe.MD b/ReadMe.MD index ae1556b..f5cbc7c

Re: [edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: call SdMmcFreeTrb() to complete sync operation

On 6 November 2017 at 08:56, Zeng, Star wrote: > Except the typo "incorrecnt" needs to be "incorrect" in commit log, others > are good to me. > > With typo fixed, Reviewed-by: Star Zeng > Thanks Pushed as 6743455e34d1b313d644d9f7ca726b9932effb1f >

Re: [edk2] Build error in StdLib with VS 2015 compiler

For VS2015, don't define it. The change is like below. #ifndef __STDC_HOSTED__ #if !defined(_MSC_VER) || _MSC_VER != 1900 #define __STDC_HOSTED__ 1 #endif #endif > -Original Message- > From: Karunakar P [mailto:karunak...@amiindia.co.in] > Sent: Monday, November 6, 2017 5:32 PM > To:

Re: [edk2] [PATCH] MdeModulePkg VarCheckHiiLib: Fix typo "0x02%x" to be "0x%02x"

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Monday, November 6, 2017 8:51 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Yao, Jiewen Subject: [PATCH]